active_record_doctor 1.4.1 → 1.7.2

Sign up to get free protection for your applications and to get access to all the features.
Files changed (84) hide show
  1. checksums.yaml +5 -5
  2. data/README.md +140 -10
  3. data/lib/active_record_doctor.rb +15 -1
  4. data/lib/active_record_doctor/printers/io_printer.rb +63 -7
  5. data/lib/active_record_doctor/railtie.rb +1 -1
  6. data/lib/active_record_doctor/tasks.rb +6 -0
  7. data/lib/active_record_doctor/tasks/base.rb +86 -0
  8. data/lib/active_record_doctor/tasks/extraneous_indexes.rb +5 -26
  9. data/lib/active_record_doctor/tasks/incorrect_boolean_presence_validation.rb +37 -0
  10. data/lib/active_record_doctor/tasks/missing_foreign_keys.rb +7 -28
  11. data/lib/active_record_doctor/tasks/missing_non_null_constraint.rb +56 -0
  12. data/lib/active_record_doctor/tasks/missing_presence_validation.rb +75 -0
  13. data/lib/active_record_doctor/tasks/missing_unique_indexes.rb +57 -0
  14. data/lib/active_record_doctor/tasks/undefined_table_references.rb +22 -21
  15. data/lib/active_record_doctor/tasks/unindexed_deleted_at.rb +23 -0
  16. data/lib/active_record_doctor/tasks/unindexed_foreign_keys.rb +7 -28
  17. data/lib/active_record_doctor/version.rb +1 -1
  18. data/lib/tasks/active_record_doctor.rake +33 -0
  19. data/test/active_record_doctor/printers/io_printer_test.rb +15 -7
  20. data/test/active_record_doctor/tasks/extraneous_indexes_test.rb +69 -19
  21. data/test/active_record_doctor/tasks/incorrect_boolean_presence_validation_test.rb +38 -0
  22. data/test/active_record_doctor/tasks/missing_foreign_keys_test.rb +17 -13
  23. data/test/active_record_doctor/tasks/missing_non_null_constraint_test.rb +113 -0
  24. data/test/active_record_doctor/tasks/missing_presence_validation_test.rb +115 -0
  25. data/test/active_record_doctor/tasks/missing_unique_indexes_test.rb +126 -0
  26. data/test/active_record_doctor/tasks/undefined_table_references_test.rb +39 -11
  27. data/test/active_record_doctor/tasks/unindexed_deleted_at_test.rb +59 -0
  28. data/test/active_record_doctor/tasks/unindexed_foreign_keys_test.rb +17 -13
  29. data/test/setup.rb +97 -0
  30. metadata +58 -117
  31. data/Rakefile +0 -28
  32. data/lib/active_record_doctor/compatibility.rb +0 -11
  33. data/lib/tasks/active_record_doctor_tasks.rake +0 -22
  34. data/test/dummy/README.rdoc +0 -28
  35. data/test/dummy/Rakefile +0 -6
  36. data/test/dummy/app/assets/javascripts/application.js +0 -13
  37. data/test/dummy/app/assets/stylesheets/application.css +0 -15
  38. data/test/dummy/app/controllers/application_controller.rb +0 -5
  39. data/test/dummy/app/helpers/application_helper.rb +0 -2
  40. data/test/dummy/app/models/application_record.rb +0 -3
  41. data/test/dummy/app/models/comment.rb +0 -3
  42. data/test/dummy/app/models/contract.rb +0 -3
  43. data/test/dummy/app/models/employer.rb +0 -2
  44. data/test/dummy/app/models/profile.rb +0 -2
  45. data/test/dummy/app/models/user.rb +0 -3
  46. data/test/dummy/app/views/layouts/application.html.erb +0 -14
  47. data/test/dummy/bin/bundle +0 -3
  48. data/test/dummy/bin/rails +0 -4
  49. data/test/dummy/bin/rake +0 -4
  50. data/test/dummy/bin/setup +0 -29
  51. data/test/dummy/config.ru +0 -4
  52. data/test/dummy/config/application.rb +0 -23
  53. data/test/dummy/config/boot.rb +0 -5
  54. data/test/dummy/config/database.yml +0 -19
  55. data/test/dummy/config/database.yml.travis +0 -5
  56. data/test/dummy/config/environment.rb +0 -5
  57. data/test/dummy/config/environments/development.rb +0 -41
  58. data/test/dummy/config/environments/production.rb +0 -79
  59. data/test/dummy/config/environments/test.rb +0 -47
  60. data/test/dummy/config/initializers/assets.rb +0 -11
  61. data/test/dummy/config/initializers/backtrace_silencers.rb +0 -7
  62. data/test/dummy/config/initializers/cookies_serializer.rb +0 -3
  63. data/test/dummy/config/initializers/filter_parameter_logging.rb +0 -4
  64. data/test/dummy/config/initializers/inflections.rb +0 -16
  65. data/test/dummy/config/initializers/mime_types.rb +0 -4
  66. data/test/dummy/config/initializers/session_store.rb +0 -3
  67. data/test/dummy/config/initializers/wrap_parameters.rb +0 -14
  68. data/test/dummy/config/locales/en.yml +0 -23
  69. data/test/dummy/config/routes.rb +0 -56
  70. data/test/dummy/config/secrets.yml +0 -22
  71. data/test/dummy/db/migrate/20160213101213_create_employers.rb +0 -13
  72. data/test/dummy/db/migrate/20160213101221_create_users.rb +0 -23
  73. data/test/dummy/db/migrate/20160213101232_create_profiles.rb +0 -12
  74. data/test/dummy/db/migrate/20160604081452_create_comments.rb +0 -11
  75. data/test/dummy/db/migrate/base_migration.rb +0 -5
  76. data/test/dummy/db/schema.rb +0 -63
  77. data/test/dummy/log/development.log +0 -136
  78. data/test/dummy/log/test.log +0 -1720
  79. data/test/dummy/public/404.html +0 -67
  80. data/test/dummy/public/422.html +0 -67
  81. data/test/dummy/public/500.html +0 -66
  82. data/test/dummy/public/favicon.ico +0 -0
  83. data/test/support/spy_printer.rb +0 -43
  84. data/test/test_helper.rb +0 -20
data/Rakefile DELETED
@@ -1,28 +0,0 @@
1
- begin
2
- require 'bundler/setup'
3
- rescue LoadError
4
- puts 'You must `gem install bundler` and `bundle install` to run rake tasks'
5
- end
6
-
7
- require 'rdoc/task'
8
-
9
- RDoc::Task.new(:rdoc) do |rdoc|
10
- rdoc.rdoc_dir = 'rdoc'
11
- rdoc.title = 'ActiveRecordDoctor'
12
- rdoc.options << '--line-numbers'
13
- rdoc.rdoc_files.include('README.rdoc')
14
- rdoc.rdoc_files.include('lib/**/*.rb')
15
- end
16
-
17
- Bundler::GemHelper.install_tasks
18
-
19
- require 'rake/testtask'
20
-
21
- Rake::TestTask.new(:test) do |t|
22
- t.libs << 'lib'
23
- t.libs << 'test'
24
- t.pattern = 'test/**/*_test.rb'
25
- t.verbose = false
26
- end
27
-
28
- task default: :test
@@ -1,11 +0,0 @@
1
- module ActiveRecordDoctor
2
- module Compatibility
3
- def connection_tables
4
- if Rails::VERSION::MAJOR == 5
5
- connection.data_sources
6
- else
7
- connection.tables
8
- end
9
- end
10
- end
11
- end
@@ -1,22 +0,0 @@
1
- require "active_record_doctor/tasks/unindexed_foreign_keys"
2
- require "active_record_doctor/tasks/extraneous_indexes"
3
- require "active_record_doctor/tasks/missing_foreign_keys"
4
- require "active_record_doctor/tasks/undefined_table_references"
5
-
6
- namespace :active_record_doctor do
7
- task :unindexed_foreign_keys => :environment do
8
- ActiveRecordDoctor::Tasks::UnindexedForeignKeys.run
9
- end
10
-
11
- task :extraneous_indexes => :environment do
12
- ActiveRecordDoctor::Tasks::ExtraneousIndexes.run
13
- end
14
-
15
- task :missing_foreign_keys => :environment do
16
- ActiveRecordDoctor::Tasks::MissingForeignKeys.run
17
- end
18
-
19
- task :undefined_table_references => :environment do
20
- exit(ActiveRecordDoctor::Tasks::UndefinedTableReferences.run)
21
- end
22
- end
@@ -1,28 +0,0 @@
1
- == README
2
-
3
- This README would normally document whatever steps are necessary to get the
4
- application up and running.
5
-
6
- Things you may want to cover:
7
-
8
- * Ruby version
9
-
10
- * System dependencies
11
-
12
- * Configuration
13
-
14
- * Database creation
15
-
16
- * Database initialization
17
-
18
- * How to run the test suite
19
-
20
- * Services (job queues, cache servers, search engines, etc.)
21
-
22
- * Deployment instructions
23
-
24
- * ...
25
-
26
-
27
- Please feel free to use a different markup language if you do not plan to run
28
- <tt>rake doc:app</tt>.
data/test/dummy/Rakefile DELETED
@@ -1,6 +0,0 @@
1
- # Add your own tasks in files placed in lib/tasks ending in .rake,
2
- # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
3
-
4
- require File.expand_path('../config/application', __FILE__)
5
-
6
- Rails.application.load_tasks
@@ -1,13 +0,0 @@
1
- // This is a manifest file that'll be compiled into application.js, which will include all the files
2
- // listed below.
3
- //
4
- // Any JavaScript/Coffee file within this directory, lib/assets/javascripts, vendor/assets/javascripts,
5
- // or any plugin's vendor/assets/javascripts directory can be referenced here using a relative path.
6
- //
7
- // It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the
8
- // compiled file.
9
- //
10
- // Read Sprockets README (https://github.com/rails/sprockets#sprockets-directives) for details
11
- // about supported directives.
12
- //
13
- //= require_tree .
@@ -1,15 +0,0 @@
1
- /*
2
- * This is a manifest file that'll be compiled into application.css, which will include all the files
3
- * listed below.
4
- *
5
- * Any CSS and SCSS file within this directory, lib/assets/stylesheets, vendor/assets/stylesheets,
6
- * or any plugin's vendor/assets/stylesheets directory can be referenced here using a relative path.
7
- *
8
- * You're free to add application-wide styles to this file and they'll appear at the bottom of the
9
- * compiled file so the styles you add here take precedence over styles defined in any styles
10
- * defined in the other CSS/SCSS files in this directory. It is generally better to create a new
11
- * file per style scope.
12
- *
13
- *= require_tree .
14
- *= require_self
15
- */
@@ -1,5 +0,0 @@
1
- class ApplicationController < ActionController::Base
2
- # Prevent CSRF attacks by raising an exception.
3
- # For APIs, you may want to use :null_session instead.
4
- protect_from_forgery with: :exception
5
- end
@@ -1,2 +0,0 @@
1
- module ApplicationHelper
2
- end
@@ -1,3 +0,0 @@
1
- class ApplicationRecord < ActiveRecord::Base
2
- self.table_name = nil
3
- end
@@ -1,3 +0,0 @@
1
- class Comment < ActiveRecord::Base
2
- belongs_to :commentable, polymorphic: true
3
- end
@@ -1,3 +0,0 @@
1
- class Contract < ApplicationRecord
2
- self.table_name = 'contract_records'
3
- end
@@ -1,2 +0,0 @@
1
- class Employer < ActiveRecord::Base
2
- end
@@ -1,2 +0,0 @@
1
- class Profile < ActiveRecord::Base
2
- end
@@ -1,3 +0,0 @@
1
- class User < ActiveRecord::Base
2
- belongs_to :profile
3
- end
@@ -1,14 +0,0 @@
1
- <!DOCTYPE html>
2
- <html>
3
- <head>
4
- <title>Dummy</title>
5
- <%= stylesheet_link_tag 'application', media: 'all', 'data-turbolinks-track' => true %>
6
- <%= javascript_include_tag 'application', 'data-turbolinks-track' => true %>
7
- <%= csrf_meta_tags %>
8
- </head>
9
- <body>
10
-
11
- <%= yield %>
12
-
13
- </body>
14
- </html>
@@ -1,3 +0,0 @@
1
- #!/usr/bin/env ruby
2
- ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
3
- load Gem.bin_path('bundler', 'bundle')
data/test/dummy/bin/rails DELETED
@@ -1,4 +0,0 @@
1
- #!/usr/bin/env ruby
2
- APP_PATH = File.expand_path('../../config/application', __FILE__)
3
- require_relative '../config/boot'
4
- require 'rails/commands'
data/test/dummy/bin/rake DELETED
@@ -1,4 +0,0 @@
1
- #!/usr/bin/env ruby
2
- require_relative '../config/boot'
3
- require 'rake'
4
- Rake.application.run
data/test/dummy/bin/setup DELETED
@@ -1,29 +0,0 @@
1
- #!/usr/bin/env ruby
2
- require 'pathname'
3
-
4
- # path to your application root.
5
- APP_ROOT = Pathname.new File.expand_path('../../', __FILE__)
6
-
7
- Dir.chdir APP_ROOT do
8
- # This script is a starting point to setup your application.
9
- # Add necessary setup steps to this file:
10
-
11
- puts "== Installing dependencies =="
12
- system "gem install bundler --conservative"
13
- system "bundle check || bundle install"
14
-
15
- # puts "\n== Copying sample files =="
16
- # unless File.exist?("config/database.yml")
17
- # system "cp config/database.yml.sample config/database.yml"
18
- # end
19
-
20
- puts "\n== Preparing database =="
21
- system "bin/rake db:setup"
22
-
23
- puts "\n== Removing old logs and tempfiles =="
24
- system "rm -f log/*"
25
- system "rm -rf tmp/cache"
26
-
27
- puts "\n== Restarting application server =="
28
- system "touch tmp/restart.txt"
29
- end
data/test/dummy/config.ru DELETED
@@ -1,4 +0,0 @@
1
- # This file is used by Rack-based servers to start the application.
2
-
3
- require ::File.expand_path('../config/environment', __FILE__)
4
- run Rails.application
@@ -1,23 +0,0 @@
1
- require File.expand_path('../boot', __FILE__)
2
-
3
- require 'rails/all'
4
-
5
- Bundler.require(*Rails.groups)
6
- require "active_record_doctor"
7
-
8
- module Dummy
9
- class Application < Rails::Application
10
- # Settings in config/environments/* take precedence over those specified here.
11
- # Application configuration should go into files in config/initializers
12
- # -- all .rb files in that directory are automatically loaded.
13
-
14
- # Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
15
- # Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
16
- # config.time_zone = 'Central Time (US & Canada)'
17
-
18
- # The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded.
19
- # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]
20
- # config.i18n.default_locale = :de
21
- end
22
- end
23
-
@@ -1,5 +0,0 @@
1
- # Set up gems listed in the Gemfile.
2
- ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../../../Gemfile', __FILE__)
3
-
4
- require 'bundler/setup' if File.exist?(ENV['BUNDLE_GEMFILE'])
5
- $LOAD_PATH.unshift File.expand_path('../../../../lib', __FILE__)
@@ -1,19 +0,0 @@
1
- default: &default
2
- adapter: postgresql
3
- encoding: unicode
4
- pool: 5
5
-
6
- development:
7
- <<: *default
8
- database: active_record_doctor_development
9
-
10
- # Warning: The database defined as "test" will be erased and
11
- # re-generated from your development database when you run "rake".
12
- # Do not set this db to the same as development or production.
13
- test:
14
- <<: *default
15
- database: active_record_doctor_test
16
-
17
- production:
18
- <<: *default
19
- database: active_record_doctor_production
@@ -1,5 +0,0 @@
1
- test:
2
- adapter: postgresql
3
- user: postgres
4
- password:
5
- database: active_record_doctor_test
@@ -1,5 +0,0 @@
1
- # Load the Rails application.
2
- require File.expand_path('../application', __FILE__)
3
-
4
- # Initialize the Rails application.
5
- Rails.application.initialize!
@@ -1,41 +0,0 @@
1
- Rails.application.configure do
2
- # Settings specified here will take precedence over those in config/application.rb.
3
-
4
- # In the development environment your application's code is reloaded on
5
- # every request. This slows down response time but is perfect for development
6
- # since you don't have to restart the web server when you make code changes.
7
- config.cache_classes = false
8
-
9
- # Do not eager load code on boot.
10
- config.eager_load = false
11
-
12
- # Show full error reports and disable caching.
13
- config.consider_all_requests_local = true
14
- config.action_controller.perform_caching = false
15
-
16
- # Don't care if the mailer can't send.
17
- config.action_mailer.raise_delivery_errors = false
18
-
19
- # Print deprecation notices to the Rails logger.
20
- config.active_support.deprecation = :log
21
-
22
- # Raise an error on page load if there are pending migrations.
23
- config.active_record.migration_error = :page_load
24
-
25
- # Debug mode disables concatenation and preprocessing of assets.
26
- # This option may cause significant delays in view rendering with a large
27
- # number of complex assets.
28
- config.assets.debug = true
29
-
30
- # Asset digests allow you to set far-future HTTP expiration dates on all assets,
31
- # yet still be able to expire them through the digest params.
32
- config.assets.digest = true
33
-
34
- # Adds additional error checking when serving assets at runtime.
35
- # Checks for improperly declared sprockets dependencies.
36
- # Raises helpful error messages.
37
- config.assets.raise_runtime_errors = true
38
-
39
- # Raises error for missing translations
40
- # config.action_view.raise_on_missing_translations = true
41
- end
@@ -1,79 +0,0 @@
1
- Rails.application.configure do
2
- # Settings specified here will take precedence over those in config/application.rb.
3
-
4
- # Code is not reloaded between requests.
5
- config.cache_classes = true
6
-
7
- # Eager load code on boot. This eager loads most of Rails and
8
- # your application in memory, allowing both threaded web servers
9
- # and those relying on copy on write to perform better.
10
- # Rake tasks automatically ignore this option for performance.
11
- config.eager_load = true
12
-
13
- # Full error reports are disabled and caching is turned on.
14
- config.consider_all_requests_local = false
15
- config.action_controller.perform_caching = true
16
-
17
- # Enable Rack::Cache to put a simple HTTP cache in front of your application
18
- # Add `rack-cache` to your Gemfile before enabling this.
19
- # For large-scale production use, consider using a caching reverse proxy like
20
- # NGINX, varnish or squid.
21
- # config.action_dispatch.rack_cache = true
22
-
23
- # Disable serving static files from the `/public` folder by default since
24
- # Apache or NGINX already handles this.
25
- config.serve_static_files = ENV['RAILS_SERVE_STATIC_FILES'].present?
26
-
27
- # Compress JavaScripts and CSS.
28
- config.assets.js_compressor = :uglifier
29
- # config.assets.css_compressor = :sass
30
-
31
- # Do not fallback to assets pipeline if a precompiled asset is missed.
32
- config.assets.compile = false
33
-
34
- # Asset digests allow you to set far-future HTTP expiration dates on all assets,
35
- # yet still be able to expire them through the digest params.
36
- config.assets.digest = true
37
-
38
- # `config.assets.precompile` and `config.assets.version` have moved to config/initializers/assets.rb
39
-
40
- # Specifies the header that your server uses for sending files.
41
- # config.action_dispatch.x_sendfile_header = 'X-Sendfile' # for Apache
42
- # config.action_dispatch.x_sendfile_header = 'X-Accel-Redirect' # for NGINX
43
-
44
- # Force all access to the app over SSL, use Strict-Transport-Security, and use secure cookies.
45
- # config.force_ssl = true
46
-
47
- # Use the lowest log level to ensure availability of diagnostic information
48
- # when problems arise.
49
- config.log_level = :debug
50
-
51
- # Prepend all log lines with the following tags.
52
- # config.log_tags = [ :subdomain, :uuid ]
53
-
54
- # Use a different logger for distributed setups.
55
- # config.logger = ActiveSupport::TaggedLogging.new(SyslogLogger.new)
56
-
57
- # Use a different cache store in production.
58
- # config.cache_store = :mem_cache_store
59
-
60
- # Enable serving of images, stylesheets, and JavaScripts from an asset server.
61
- # config.action_controller.asset_host = 'http://assets.example.com'
62
-
63
- # Ignore bad email addresses and do not raise email delivery errors.
64
- # Set this to true and configure the email server for immediate delivery to raise delivery errors.
65
- # config.action_mailer.raise_delivery_errors = false
66
-
67
- # Enable locale fallbacks for I18n (makes lookups for any locale fall back to
68
- # the I18n.default_locale when a translation cannot be found).
69
- config.i18n.fallbacks = true
70
-
71
- # Send deprecation notices to registered listeners.
72
- config.active_support.deprecation = :notify
73
-
74
- # Use default logging formatter so that PID and timestamp are not suppressed.
75
- config.log_formatter = ::Logger::Formatter.new
76
-
77
- # Do not dump schema after migrations.
78
- config.active_record.dump_schema_after_migration = false
79
- end
@@ -1,47 +0,0 @@
1
- Rails.application.configure do
2
- # Settings specified here will take precedence over those in config/application.rb.
3
-
4
- # The test environment is used exclusively to run your application's
5
- # test suite. You never need to work with it otherwise. Remember that
6
- # your test database is "scratch space" for the test suite and is wiped
7
- # and recreated between test runs. Don't rely on the data there!
8
- config.cache_classes = true
9
-
10
- # Do not eager load code on boot. This avoids loading your whole application
11
- # just for the purpose of running a single test. If you are using a tool that
12
- # preloads Rails for running tests, you may have to set it to true.
13
- config.eager_load = false
14
-
15
- # Configure static file server for tests with Cache-Control for performance.
16
- if Rails::VERSION::MAJOR == 5
17
- config.public_file_server.enabled = true
18
- config.public_file_server.headers = { 'Cache-Control' => 'public, max-age=3600' }
19
- else
20
- config.serve_static_files = true
21
- config.static_cache_control = 'public, max-age=3600'
22
- end
23
-
24
- # Show full error reports and disable caching.
25
- config.consider_all_requests_local = true
26
- config.action_controller.perform_caching = false
27
-
28
- # Raise exceptions instead of rendering exception templates.
29
- config.action_dispatch.show_exceptions = false
30
-
31
- # Disable request forgery protection in test environment.
32
- config.action_controller.allow_forgery_protection = false
33
-
34
- # Tell Action Mailer not to deliver emails to the real world.
35
- # The :test delivery method accumulates sent emails in the
36
- # ActionMailer::Base.deliveries array.
37
- config.action_mailer.delivery_method = :test
38
-
39
- # Randomize the order test cases are executed.
40
- config.active_support.test_order = :random
41
-
42
- # Print deprecation notices to the stderr.
43
- config.active_support.deprecation = :stderr
44
-
45
- # Raises error for missing translations
46
- # config.action_view.raise_on_missing_translations = true
47
- end