active_record_compose 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2622aa32a886a2c21fcc7836254285cb92f1ce7745674297c3e7fe46bcbe556a
-  data.tar.gz: 747acd3e97cb78aba78b9d3f2c87ab4d9bd34b0727aaf2a1c94d9520ea9eaa08
+  metadata.gz: 810feb87760ff992aa21ca019081e6072ec43c99387ea0ee013f767d4d2c875c
+  data.tar.gz: 7077c4d5b79d12c6c5f5a0297d0d2837c3d3c79a3b8e74a13c12e05a3511c078
 SHA512:
-  metadata.gz: e6002732e8e6fa09269ccb4a7635af4ef683d06af14e829aa062846c6dbb90c2942d5b3cc2b4d715eeef2182498e732d33b5ae004836ff703f8d8235fec12c70
-  data.tar.gz: 18d3f9a635d3f4bf940eeb4020824fa7fc7d91cf27b0a99aa253af53e31fdca6bebd69d402537bea29749de26eba3f5a261e10a3ef2ebf079294e7fc3dbd5127
+  metadata.gz: 283b3beaab24fb19d30e134dbe543a25c730bf0d331bdd5114ae89747d0a247b8b572d7e6f2578c06d80f2f7cb4b8c6023f2640518c5b0dc21d335401e45ab5c
+  data.tar.gz: 6f55ebeb0bd4379d206f55b8dc8dc618beca9d281f0d425c0cc8d96078d60ed74fd26c67b92b2bb8c26f9cb6dd4634557ef1064990c4a7ca91bb15e99d6c381e

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 ## [Unreleased]
 
+## [1.2.1] - 2026-03-21
+
+* Improved clarity of error when accessing uninitialized attributes.
+  (https://github.com/hamajyotan/active_record_compose/pull/71)
+* doc: Minor document adjustments, etc.
+
 ## [1.2.0] - 2026-01-05
 
 * Avoid issuing multiple saves on the same object.

data/README.md

@@ -1,7 +1,7 @@
 # ActiveRecordCompose
 
 ActiveRecordCompose lets you build form objects that combine multiple ActiveRecord models into a single, unified interface.
-More than just a simple form object, it is designed as a **business-oriented composed model** that encapsulates complex operations-such as user registration spanning multiple tables-making them easier to write, validate, and maintain.
+More than a simple form object, ActiveRecordCompose is designed as a **business-oriented composed model** that encapsulates complex operations, such as user registration spanning multiple tables, making them easier to write, validate, and maintain.
 
 [![Gem Version](https://badge.fury.io/rb/active_record_compose.svg)](https://badge.fury.io/rb/active_record_compose)
 ![CI](https://github.com/hamajyotan/active_record_compose/workflows/CI/badge.svg)
@@ -29,15 +29,14 @@ More than just a simple form object, it is designed as a **business-oriented com
 
 ## Motivation
 
-In Rails, `ActiveRecord::Base` is responsible for persisting data to the database.
-By defining validations and callbacks, you can model use cases effectively.
+In Rails, `ActiveRecord::Base` is responsible for persisting data to the database and modeling application behavior through validations and callbacks.
 
 However, when a single model must serve multiple different use cases, you often end up with conditional validations (`on: :context`) or workarounds like `save(validate: false)`.
 This mixes unrelated concerns into one model, leading to unnecessary complexity.
 
-`ActiveModel::Model` helps here — it provides the familiar API (`attribute`, `errors`, validations, callbacks) without persistence, so you can isolate logic per use case.
+`ActiveModel::Model` helps address this by providing a familiar API (`attribute`, `errors`, validations, callbacks) without persistence, allowing you to isolate logic per use case.
 
-**ActiveRecordCompose** builds on `ActiveModel::Model` and is a powerful **business object** that acts as a first-class model within Rails.
+**ActiveRecordCompose** builds on `ActiveModel::Model` and provides a powerful **business object** that acts as a first-class model within Rails.
 - Transparently accesses attributes across multiple models
 - Saves all associated models atomically in a transaction
 - Collects and exposes error information consistently
@@ -106,7 +105,7 @@ class UserRegistration < ActiveRecordCompose::Model
 end
 ```
 
-Usage:
+Example usage:
 
 ```ruby
 # === Standalone script ===
@@ -174,7 +173,7 @@ registration.attributes
 
 ### Unified Error Handling
 
-Validation errors from inner models are collected into the composed model:
+Validation errors from the inner models are collected into the composed object:
 
 ```ruby
 user_registration = UserRegistration.new(
@@ -274,7 +273,7 @@ model.save
 
 ### Notes on adding models dynamically
 
-Avoid adding `models` to the models array **after validation has already run**
+Avoid adding models to the `models` array **after validation has already run**
 (for example, inside `after_validation` or `before_save` callbacks).
 
 ```ruby
@@ -323,5 +322,5 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 ## Code of Conduct
 
-Everyone interacting in the ActiveRecord::Compose project's codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/hamajyotan/active_record_compose/blob/main/CODE_OF_CONDUCT.md).
+Everyone interacting in the ActiveRecordCompose project's codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/hamajyotan/active_record_compose/blob/main/CODE_OF_CONDUCT.md).
 

data/lib/active_record_compose/attributes.rb

@@ -3,6 +3,7 @@
 require_relative "attributes/attribute_predicate"
 require_relative "attributes/delegation"
 require_relative "attributes/querying"
+require_relative "exceptions"
 
 module ActiveRecordCompose
   # Provides attribute-related functionality for use within ActiveRecordCompose::Model.
@@ -127,7 +128,11 @@ module ActiveRecordCompose
     #
     # @see #attributes
     # @return [Array<String>] array of attribute name.
-    def attribute_names = super + delegated_attributes.to_a.map { _1.attribute_name }
+    def attribute_names
+      _require_attributes_initialized do
+        super + delegated_attributes.to_a.map { _1.attribute_name }
+      end
+    end
 
     # Returns a hash with the attribute name as key and the attribute value as value.
     # Attributes declared with {.delegate_attribute} are also merged.
@@ -155,7 +160,24 @@ module ActiveRecordCompose
     #
     # @return [Hash<String, Object>] hash with the attribute name as key and the attribute value as value.
     def attributes
-      super.merge(*delegated_attributes.to_a.map { _1.attribute_hash(self) })
+      _require_attributes_initialized do
+        super.merge(*delegated_attributes.to_a.map { _1.attribute_hash(self) })
+      end
+    end
+
+    private
+
+    def _write_attribute(...) = _require_attributes_initialized { super } # steep:ignore
+
+    def attribute(...) = _require_attributes_initialized { super }
+
+    def _require_attributes_initialized
+      unless @attributes
+        raise ActiveRecordCompose::UninitializedAttribute,
+              "No attributes have been set. Is proper initialization performed, such as calling `super` in `initialize`?"
+      end
+
+      yield
     end
   end
 end

data/lib/active_record_compose/exceptions.rb

@@ -26,4 +26,19 @@ module ActiveRecordCompose
   #     outer.save  #=> raises ActiveRecordCompose::CircularReferenceDetected
   #
   class CircularReferenceDetected < StandardError; end
+
+  # Occurs when accessing Attributes without initializing it.
+  #
+  # @example
+  #     class Model < ActiveRecordCompose::Model
+  #       def initialize
+  #         # Intentionally not calling super...
+  #       end
+  #
+  #       attribute :foo
+  #     end
+  #     model = Model.new
+  #     model.foo = 1  #=> raises ActiveRecordCompose::UninitializedAttribute
+  #
+  class UninitializedAttribute < StandardError; end
 end

data/lib/active_record_compose/transaction_support.rb

@@ -113,7 +113,7 @@ module ActiveRecordCompose
           ensure_finalize = !connection.transaction_open?
 
           connection.transaction do
-            connection.add_transaction_record(self, ensure_finalize || has_transactional_callbacks?) # steep:ignore
+            connection.add_transaction_record(self, ensure_finalize || has_transactional_callbacks?)
 
             yield.tap { raise ActiveRecord::Rollback unless _1 }
           end || false

data/lib/active_record_compose/validations.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative "composed_collection"
+require_relative "exceptions"
 
 module ActiveRecordCompose
   using ComposedCollection::PackagePrivate
@@ -44,7 +45,7 @@ module ActiveRecordCompose
     #   Returns the `ActiveModel::Errors` object that holds all information about attribute error messages.
     #
     #   The `ActiveModel::Base` implementation itself,
-    #   but also aggregates error information for objects stored in {#models} when validation is performed.
+    #   but also aggregates error information for objects stored in {ActiveRecordCompose::Model#models} when validation is performed.
     #
     #       class Account < ActiveRecord::Base
     #         validates :name, :email, presence: true

data/lib/active_record_compose/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveRecordCompose
-  VERSION = "1.2.0"
+  VERSION = "1.2.1"
 end

data/sig/_internal/package_private.rbs

@@ -11,6 +11,9 @@ module ActiveRecordCompose
 
     @attributes: untyped
 
+    private
+    def _require_attributes_initialized: [T] () { () -> T } -> T
+
     class AttributePredicate
       def initialize: (untyped value) -> void
       def call: -> bool

data/sig/active_record_compose.rbs

@@ -98,4 +98,7 @@ module ActiveRecordCompose
   class Railtie < Rails::Railtie
     extend Rails::Initializable::ClassMethods
   end
+
+  class UninitializedAttribute < StandardError
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_record_compose
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - hamajyotan