active_record_auto_validations 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d82df8dff2fe3dd3b03523499df936304e262721ea812792749059393602b662
-  data.tar.gz: 2f34c86ef85893c79c215c8227458ab42e0503c46cca848527ddef8f71dc1642
+  metadata.gz: fed3fd2ca11387161a5229a84c3a2830e75ecfccccb690f7e3df623d1b7860b0
+  data.tar.gz: cbce1703024f0281fd689a87f135b5ee3c197d4fa282ff8937790748e160823c
 SHA512:
-  metadata.gz: a3cee5f5a370c5c800efc0976eea8a350bb08d75bb9eab11d6fab4446d7ca2eab18096777daeff71f790bf51dd228c2a6c12e1d961c4eeda03541f1055f2be11
-  data.tar.gz: f2eb99db19909b63de9de904a86f0dc9b119117c6391b27d5595e8b0ca0ad5c4013b3bfa164a2314dafe393e315ca148db60206f2a99fb79d593da69c382608f
+  metadata.gz: 6f3f3022a614e737fd610d50ece642e8d8b5db811cb5e5a4a8c228935e3103b266480a16ad71f0ecce1591ef6614c1d7b258cfdc6af9a22720e7c1c1e238c5e4
+  data.tar.gz: 95f0eaf31a5ae94683bd686c0677ac783f02a6c36ef816a20fdfbe74c7c6a2ce673366d4fbed1df40c13aa7bd48dd2b494977085bc0079a6cf010f7c46d1d362

data/app/services/active_record_auto_validations/auto_validate_model_class.rb

@@ -1,11 +1,12 @@
 class ActiveRecordAutoValidations::AutoValidateModelClass
-  attr_reader :model_class
+  attr_reader :ignore_column_names, :model_class
 
-  def self.execute!(model_class:)
-    ActiveRecordAutoValidations::AutoValidateModelClass.new(model_class: model_class).perform
+  def self.execute!(...)
+    ActiveRecordAutoValidations::AutoValidateModelClass.new(...).perform
   end
 
-  def initialize(model_class:)
+  def initialize(model_class:, ignore_column_names: [])
+    @ignore_column_names = ignore_column_names
     @model_class = model_class
   end
 
@@ -18,7 +19,7 @@ class ActiveRecordAutoValidations::AutoValidateModelClass
       indexes
     rescue ActiveRecord::StatementInvalid => e
       # Database is probably not running - we need to ignore this to make stuff like db:migrate, db:schema:load work
-      Rails.logger.error { "AutoValidate: Ignoring error while loading columns, because database might not be initialized: #{e.message}" }
+      Rails.logger.info { "AutoValidate: Ignoring error while loading columns, because database might not be initialized: #{e.message}" }
       return
     end
 
@@ -40,13 +41,25 @@ class ActiveRecordAutoValidations::AutoValidateModelClass
     @columns ||= model_class.columns
   end
 
+  def ignore_column?(column_name)
+    return true if column_name == "id" || column_name == "created_at" || column_name == "updated_at"
+
+    ignore_column_names.include?(column_name)
+  end
+
+  def ignore_index?(index)
+    return true unless index.unique
+
+    index.columns.any? { |index_column_name| ignore_column?(index_column_name) }
+  end
+
   def indexes
     @indexes ||= model_class.connection.indexes(model_class.table_name)
   end
 
   def insert_active_record_auto_validations_from_columns!
     columns.each do |column|
-      next if column.name == "id" || column.name == "created_at" || column.name == "updated_at"
+      next if ignore_column?(column.name)
 
       auto_validate_pesence_on_column!(column) if auto_validate_presence_on_column?(column)
       auto_validate_max_length_on_column!(column) if auto_validate_max_length_on_column?(column)
@@ -55,11 +68,14 @@ class ActiveRecordAutoValidations::AutoValidateModelClass
 
   def insert_active_record_auto_validations_from_indexes!
     indexes.each do |index|
-      next unless index.unique
+      next if ignore_index?(index)
 
       # Dont add uniqueness validation to ActsAsList position columns
       if index.columns.include?("position") && model_class.respond_to?(:acts_as_list_top)
-        Rails.logger.info { "AutoValidate: Skipping unique validation on #{model_class.table_name}##{index.columns.join(",")} because it looks like ActsAsList" }
+        Rails.logger.info do
+          "AutoValidate: Skipping unique validation on #{model_class.table_name}##{index.columns.join(",")} because it looks like ActsAsList"
+        end
+
         next
       end
 
@@ -76,7 +92,7 @@ class ActiveRecordAutoValidations::AutoValidateModelClass
   end
 
   def auto_validate_presence_on_column?(column)
-    !column.null && !column.name.end_with?("_id") && column.default.nil? && !presence_validation_exists_on_column?(column)
+    !column.null && !column.name.end_with?("_id") && column.default.nil? && column.default_function.nil? && !presence_validation_exists_on_column?(column)
   end
 
   def auto_validate_pesence_on_column!(column)

data/lib/active_record_auto_validations/engine.rb

@@ -1,5 +1,5 @@
 module ActiveRecordAutoValidations; end
 
-class ActiveRecordAutoValidations::Engine < ::Rails::Engine
+class ActiveRecordAutoValidations::Engine < Rails::Engine
   isolate_namespace ActiveRecordAutoValidations
 end

data/lib/active_record_auto_validations/version.rb

@@ -1,3 +1,3 @@
 module ActiveRecordAutoValidations
-  VERSION = "0.0.3".freeze
+  VERSION = "0.0.4".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_record_auto_validations
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - kaspernj
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-10-28 00:00:00.000000000 Z
+date: 2024-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -24,104 +24,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 7.0.3
-- !ruby/object:Gem::Dependency
-  name: dotenv-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: mysql2
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop-performance
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Scans ActiveRecord models and adds automatic validations based on null,
   max length etc.
 email:
@@ -150,7 +52,7 @@ metadata:
   source_code_uri: https://github.com/kaspernj/active_record_auto_validations
   changelog_uri: https://github.com/kaspernj/active_record_auto_validations
   rubygems_mfa_required: 'true'
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -165,8 +67,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
-signing_key: 
+rubygems_version: 3.4.10
+signing_key:
 specification_version: 4
 summary: Scans ActiveRecord models and adds automatic validations based on null, max
   length etc.