active_record_api-rest 1.0.34 → 1.0.35

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ccd61a53e93831fa28204dbf344d7cf22139a4741ffcfcce0a5f9fce0bd297db
-  data.tar.gz: f7c809a93361dab541f2a38c9db03e673a3842f61fd3d8282714e0917fe5d257
+  metadata.gz: '0038b981a9593be11c659e1f598d06f44313a1042a7400344133be695289d504'
+  data.tar.gz: dd21d133133fa26d47929c8ec5653863630742a9a8ec6b6fd1632f5420e75a98
 SHA512:
-  metadata.gz: f886ec56717aa8b28d3187b0b7ccfd98896440b1edbf849d84401a783d1cb193ce1f1e94b629199d1dff0ccc6825d3b349619cafec855136ebc715e32f41450a
-  data.tar.gz: 6772fe1f3318871dc3605ec71982d4494faa859555157a2bcf38d58855e2db6540cffbd27ad43e60132e8ba0105d1122a32cd177e33036bd07933591b7d0c536
+  metadata.gz: 7f9bd2ebbdacfcc8202bf9e071cce13403651c7896504dc612b9b3937960964bc5f111bd41b50557ee2cd29ed326d4a160345d7d528021e295fdf8d791aa0a54
+  data.tar.gz: 6eebb310b5e62584d5a2a2c6c8457b1aba2e974b89b3f781184cb34ac56e3b9ba10eb78e1dbbc6ddabc2c1aa18fb3cd05c69235c71bf43f15ed365ccebb41a80

data/.gitlab-ci.yml

@@ -1,10 +1,11 @@
 stages:
   - build
   - deploy
+  - qa
 
 code_quality:
   retry: 2
-  stage: build
+  stage: deploy
   image: docker:stable
   variables:
     DOCKER_DRIVER: overlay2
@@ -21,7 +22,7 @@ code_quality:
     paths: [gl-code-quality-report.json]
     expire_in: 3 weeks
 
-rspec:
+.rspec:
   image: ruby:2.5.1
   stage: build
   variables:
@@ -45,7 +46,7 @@ rspec:
 
 codequality-verify:
   retry: 2
-  stage: deploy
+  stage: qa
   allow_failure: true
   image: ruby:2.5.1
   script:

data/lib/active_record_api/rest/controller.rb

@@ -34,13 +34,22 @@ module ActiveRecordApi
       end
 
       def destroy
-        model.destroy!
-        head :no_content
+        if model.destroy
+          render json: model
+        else
+          render json: model.errors, status: :unprocessable_entity
+        end
       end
 
       def destroy_by
-        authorized_models.where(queryable_params).destroy_all
-        head :no_content
+        found_model = authorized_models.find_by(queryable_params)
+        if !found_model
+          head :not_found
+        elsif found_model.destroy
+          render json: found_model
+        else
+          render json: found_model.errors, status: :unprocessable_entity
+        end
       end
 
       protected

data/lib/active_record_api/rest/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveRecordApi
   module Rest
-    VERSION = '1.0.34'.freeze
+    VERSION = '1.0.35'.freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_record_api-rest
 version: !ruby/object:Gem::Version
-  version: 1.0.34
+  version: 1.0.35
 platform: ruby
 authors:
 - Full Measure Education