active_record_api-rest 0.0.7 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dc6be5e661d2f86fc54c4f57906334b1edbfa98af328899dec021c6fba7473cf
-  data.tar.gz: 0afed262417beb1773c94857e633962908b24f3574027f141a6d1d9dfb199dc9
+  metadata.gz: 6fa1955af8c25e2210994802eb09bdbfbdb5a38c76092ee6bcbf202b5e5ef997
+  data.tar.gz: be2e65c8efcf3e9abf1d651f4cbd9c14dcdfca0745ff13ff8847bcc79de4e686
 SHA512:
-  metadata.gz: 1c15892f0cdcd3ece55399598704c8305f7c1f0b34a651089f505bcc82d81a043289b9d5cb96e05e4716a06773c02bd1df374de997cc4c4e2dad6463d6954949
-  data.tar.gz: fb1e43340815ee738411b7be1577d8f8f97e3e74e24a2f0311c983bbaa59b790e6947e7ea5fc6ad188b12c37c558200a3443d5b7c03bc949ab974c908d721696
+  metadata.gz: 4092ee83c28deb1f1356124a19767539782e12ef9d9e7e734c81661d39fcef30a23e046500be7465db37ce310cd4651bd3cdcdcaf5fa207d7d6a3b9ce9e3c3e2
+  data.tar.gz: aeb9066036e98a4fcba8ceb0d61da2d717ab030c6580ddc97457e6e9523d294e1359809ad3a17e25d88b9ff63fd2a702281088cd56bb0429bb34f6bf783d719b

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_record_api-rest (0.0.6)
+    active_record_api-rest (0.1.7)
       active_attr
       active_model_serializers
       cancancan

data/lib/active_record_api/rest/spec/rest_controller_shared_example.rb

@@ -18,15 +18,23 @@ shared_examples 'all::rest::actions' do
     end
   end
   let(:host) { ActiveRecordApi::Rest::RequestUrlGenerator.new(request: request).micro_service_url }
+  let(:create_new_attributes) { serializer.new(model).as_json.except(:id) }
+  let(:update_new_attributes) { serializer.new(model).as_json }
+  let(:update_invalid_attributes) { serializer.new(update_invalid_model).as_json.merge(id: model.id) }
   describe 'All rest actions' do
     let(:serializer) { ActiveModelSerializers::SerializableResource }
     let(:model_klass) { described_class.controller_name.classify.constantize }
     let(:model) { create factory_symbol }
-    include_examples 'get::show'
-    include_examples 'get::index'
-    include_examples 'put::update'
-    include_examples 'post::create'
-    include_examples 'delete::delete'
+    it_behaves_like 'get::show'
+    it_behaves_like 'get::index'
+    it_behaves_like 'put::update' do
+      let(:new_attributes) { update_new_attributes }
+      let(:invalid_attributes) { update_invalid_attributes }
+    end
+    it_behaves_like 'post::create' do
+      let(:new_attributes) { create_new_attributes }
+    end
+    it_behaves_like 'delete::delete'
   end
 end
 
@@ -115,7 +123,8 @@ shared_examples 'get::index' do
 end
 
 shared_examples 'put::update' do
-  let(:payload) { serializer.new(model).as_json }
+  let(:new_attributes) { serializer.new(model).as_json }
+  let(:invalid_attributes) { serializer.new(update_invalid_model).as_json.merge(id: model.id) }
   let(:relative_url) { Rails.application.routes.url_helpers.url_for(controller: base_model_klass.to_s.underscore.pluralize, action: 'show', id: model.id, only_path: true) }
   describe 'PUT update' do
     context 'when authorized' do
@@ -124,14 +133,14 @@ shared_examples 'put::update' do
       end
       context 'valid' do
         before(:each) do
-          put :update, params: payload
+          put :update, params: new_attributes
         end
         it { expect(response.status).to eq 303 }
         it { expect(response).to redirect_to "#{host}#{relative_url}" }
       end
       context 'when invalid param values provided' do
         before(:each) do
-          put :update, params: serializer.new(update_invalid_model).as_json.merge(id: model.id)
+          put :update, params: invalid_attributes
           expect(update_invalid_model.valid?).to be false
         end
         it { expect(response.status).to eq(422) }
@@ -139,7 +148,7 @@ shared_examples 'put::update' do
       end
       context 'when invalid param keys provided' do
         before(:each) do
-          put :update, params: payload.merge('foobars' => 'stuff')
+          put :update, params: new_attributes.merge('foobars' => 'stuff')
         end
         it { expect(response.status).to eq(422) }
         it { expect(response.body).to be_json_eql({ base: 'Extra parameters are not allow: foobars' }.to_json) }
@@ -148,7 +157,7 @@ shared_examples 'put::update' do
     context 'when not authorized' do
       before(:each) do
         unauthorize_update
-        get :show, params: payload
+        get :show, params: new_attributes
       end
       it { expect(response.status).to eq 403 }
       it { expect(JSON.parse(response.body)['base']).to include 'Access denied on show' }

data/lib/active_record_api/rest/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveRecordApi
   module Rest
-    VERSION = '0.0.7'.freeze
+    VERSION = '0.1.8'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_record_api-rest
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.1.8
 platform: ruby
 authors:
 - Full Measure Education
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-07-18 00:00:00.000000000 Z
+date: 2018-08-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler