active_record-when_change 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8221e6fff490d4b80ce3fb4fb3d66740e584b620
-  data.tar.gz: fe02eaadb35ea631179c8490c627d25c1271aa3d
+  metadata.gz: c7e017b6ca7ed73f70b7ac906edee79b39941931
+  data.tar.gz: e257700dc988e89ba3c638e3e374ff578f4ab0ab
 SHA512:
-  metadata.gz: fe4905219abcebff8bc4834670581004952ea82f6a50137b0a6a3638b8b0fa4ed3d79a7798ecb124996345a8bc53004ebf5a3425082faa9e19702ec9011ba953
-  data.tar.gz: 9619d747a2496343384c6c66c93f3ec3af6204612c996bc94e4b5e18e9a11e14d2ae110f20f7dc9c81bb35fae2c3de8c4d49377bce3dc25fea000d870b590dbc
+  metadata.gz: d9f804bae907a7c310ac4a5d7308f6cd21f02426a4240176cd4f6dfbf45c273cef8a3aa37c36a5121d8824c264fb3c17f4a7c63a0ec7301b0a1c12c841a9234f
+  data.tar.gz: 42f6e2a9dcfdd4c383cbee19aa6ac9358463b62b7fc3c9a0eaa1d0b763b4294cdd442e195cb8b26df13174563197c9411dac143bd2e1ed02ee51592d5614df43

data/lib/active_record/when_change.rb

@@ -13,15 +13,15 @@ module ActiveRecord
 
     def when_change attr, config={}, method = nil, &block
       # just return if config is blank or (method or block not given)
-      return if !@_new_record || config.blank? || (method == nil && !block_given? )
+      return if self.new_record? || config.blank? || (method == nil && !block_given? )
       config.keys.each{|key| logger.debug("#{key} is not valid options key for ArctiveRecordChanged") unless VALID_OPTIONS.include?(key)}
 
       new_attribute         = self.send(attr.to_sym)
       old_attribute         = self.send("#{attr}_was".to_sym)
       return if new_attribute == old_attribute
 
-      correct_form    = ( config[:from] and ( config[:from] != old_attribute ) ? false : true )
-      correct_to      = ( config[:to] and ( config[:to] != new_attribute ) ? false : true )
+      correct_form    = ( (config[:from] and ( config[:from] != old_attribute )) ? false : true )
+      correct_to      = ( (config[:to] and ( config[:to] != new_attribute )) ? false : true )
       correct_if      = ( (config[:if] and ( eval(config[:if]) != true ) ) ? false : true )
       correct_unless  = ( (config[:unless] and (eval(config[:unless]) == true) )? false : true )
 

data/lib/active_record/when_change/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module WhenChange
-    VERSION = "0.0.3"
+    VERSION = "0.0.4"
   end
 end

data/spec/lib/when_change_spec.rb

@@ -1,25 +1,22 @@
 require 'spec_helper'
 
 describe "when_change" do
+  before do
+    Post.send(:define_method,:notify_subsribers, ->{true})
+  end
+  after do
+    Post.reset_callbacks(:update)
+  end
   it "should be respond_to the model" do
     Post.should respond_to(:when_change)
     Post.new.should respond_to(:when_change)
   end
   context "when model defined some when_change event" do
-    after(:each) do
-      reset_all_constants
-    end
-
     context "whem its defined inside after_create" do
       before do
-        Post.class_eval do
-          after_create do
-            when_change :status, from: :draft, to: :publised do
-              notify_subsribers
-            end
-          end
-          def notify_subsribers
-            true
+        Post.after_create do
+          when_change :status, from: :draft, to: :publised do
+            notify_subsribers
           end
         end
       end
@@ -32,50 +29,37 @@ describe "when_change" do
 
     context "whem its defined inside after_update" do
       before do
-        Post.class_eval do
-          after_update do
-            when_change :status, from: :draft, to: :publised do
-              notify_subsribers
-            end
-          end
-          def notify_subsribers
-            true
+        Post.after_update do
+          when_change :status, from: 'draft', to: 'published' do
+            notify_subsribers
           end
         end
       end
-      let(:post){Post.create(status: :draft)}
-      it_behaves_like "callback triggered" do
-        let(:method){:notify_subsribers}
-        let(:attributes){{status: :publised}}
+      let(:post){Post.create(status: 'draft')}
+      it "should triggered the calback" do
+        mock(post).notify_subsribers.times(1)
+        post.update_attributes(status: 'published')
       end
-    end
-    context "when if" do
-      context "when true" do
-        before do
-          reset_all_constants
-          Post.class_eval do
-            after_update do
+      context "when if" do
+        context "when true" do
+          before do
+            Post.after_update do
               when_change :status, if: 'true' do
                 notify_subsribers
               end
             end
-            def notify_subsribers
-              true
-            end
+          end
+          let(:post){Post.create(status: :draft)}
+          it_behaves_like "callback triggered" do
+            let(:method){:notify_subsribers}
+            let(:attributes){{status: :publised}}
           end
         end
-        let(:post){Post.create(status: :draft)}
-        it_behaves_like "callback triggered" do
-          let(:method){:notify_subsribers}
-          let(:attributes){{status: :publised}}
+        context "when false" do
         end
       end
-      context "when false" do
-      end
     end
-  end
-  it "should reset constant" do
-    Post.new.should_not respond_to(:notify_subsribers)
+
   end
 
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_record-when_change
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Zidni Mubarock
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-28 00:00:00.000000000 Z
+date: 2014-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord