active_record-when_change 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b5ce12661dc8bab7a2a4aae116b02d0988972a05
-  data.tar.gz: 3c52309cdb0a9fc770292dd56e2487edb9981e0e
+  metadata.gz: 8221e6fff490d4b80ce3fb4fb3d66740e584b620
+  data.tar.gz: fe02eaadb35ea631179c8490c627d25c1271aa3d
 SHA512:
-  metadata.gz: 43c519621680512d0dd992d196a2c9f925907290562a2a13a2d3fa3dd104c70ac73ed43293512ccd83450149c47763a23a1e245057ac73170a4636b61b702058
-  data.tar.gz: 09b9b554b2474666d601646147d5b047f72abb5a4f7a62645c2d8c690bcc1eaf656f3bb3adbfffe8ddfc2f6e6a1dfa68953b4212bc5dee3c64be9208f01d4ff8
+  metadata.gz: fe4905219abcebff8bc4834670581004952ea82f6a50137b0a6a3638b8b0fa4ed3d79a7798ecb124996345a8bc53004ebf5a3425082faa9e19702ec9011ba953
+  data.tar.gz: 9619d747a2496343384c6c66c93f3ec3af6204612c996bc94e4b5e18e9a11e14d2ae110f20f7dc9c81bb35fae2c3de8c4d49377bce3dc25fea000d870b590dbc

data/active_record-when_change.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.email         = ["zidmubarock@gmail.com"]
   spec.summary       = %q{Simple DSL to control callback attribute changed in ActiveRecord model}
   spec.description   = %q{Simple DSL to control callback attribute changed in ActiveRecord model}
-  spec.homepage      = "http://barock.github.io/active_record-when_change"
+  spec.homepage      = "https://github.com/barock19/active_record-when_change"
   spec.license       = "MIT"
 
   spec.files         = `git ls-files -z`.split("\x0")

data/lib/active_record/when_change.rb

@@ -6,11 +6,14 @@ module ActiveRecord
     VALID_OPTIONS = [:from, :to, :if, :unless]
     def self.included(base)
       base.extend ClassMethods
+      base.after_initialize do
+        @_new_record = self.new_record?
+      end
     end
 
     def when_change attr, config={}, method = nil, &block
       # just return if config is blank or (method or block not given)
-      return if self.send("id_was".to_sym).nil? || config.blank? || (method == nil && !block_given? )
+      return if !@_new_record || config.blank? || (method == nil && !block_given? )
       config.keys.each{|key| logger.debug("#{key} is not valid options key for ArctiveRecordChanged") unless VALID_OPTIONS.include?(key)}
 
       new_attribute         = self.send(attr.to_sym)
@@ -39,36 +42,6 @@ module ActiveRecord
       def when_change
       end
     end
-
-    class ChangedAttributes
-      attr_reader :attr, :old_attr, :current
-      def initialize attr, old_attr, current
-        @attr = attr
-        @old_attr = old_attr
-        @current = current
-      end
-
-      def inspect
-        old != value
-      end
-
-      def old
-        old_attr[attr]
-      end
-
-      def value
-        current.read_attribute attr
-      end
-
-      def old_value
-        old
-      end
-
-      def new_value
-        value
-      end
-
-    end
   end
 end
 

data/lib/active_record/when_change/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module WhenChange
-    VERSION = "0.0.2"
+    VERSION = "0.0.3"
   end
 end

data/spec/lib/when_change_spec.rb

@@ -6,7 +6,7 @@ describe "when_change" do
     Post.new.should respond_to(:when_change)
   end
   context "when model defined some when_change event" do
-    after do
+    after(:each) do
       reset_all_constants
     end
 
@@ -18,21 +18,15 @@ describe "when_change" do
               notify_subsribers
             end
           end
-          after_commit do
-            when_change :status, from: :draft, to: :publised do
-              notify_subsribers
-            end
-          end
           def notify_subsribers
             true
           end
         end
       end
       let(:post){Post.new(status: :draft)}
-      it "should not triggered the action" do
-        post.should respond_to(:notify_subsribers)
-        mock(post).notify_subsribers.times(0)
-        post.update_attributes status: :publised
+      it_behaves_like "callback not triggered" do
+        let(:method){:notify_subsribers}
+        let(:attributes){{status: :publised}}
       end
     end
 
@@ -50,10 +44,33 @@ describe "when_change" do
         end
       end
       let(:post){Post.create(status: :draft)}
-      it "should not triggered the action" do
-        post.should respond_to(:notify_subsribers)
-        mock(post).notify_subsribers.times(1)
-        post.update_attributes status: :publised
+      it_behaves_like "callback triggered" do
+        let(:method){:notify_subsribers}
+        let(:attributes){{status: :publised}}
+      end
+    end
+    context "when if" do
+      context "when true" do
+        before do
+          reset_all_constants
+          Post.class_eval do
+            after_update do
+              when_change :status, if: 'true' do
+                notify_subsribers
+              end
+            end
+            def notify_subsribers
+              true
+            end
+          end
+        end
+        let(:post){Post.create(status: :draft)}
+        it_behaves_like "callback triggered" do
+          let(:method){:notify_subsribers}
+          let(:attributes){{status: :publised}}
+        end
+      end
+      context "when false" do
       end
     end
   end

data/spec/spec_helper.rb

@@ -37,4 +37,5 @@ RSpec.configure do |config|
   # the seed, which is printed after each run.
   #     --seed 1234
   config.order = 'random'
-end
+end
+load File.dirname(__FILE__) + '/support/shared_example.rb'

data/spec/support/shared_example.rb

@@ -0,0 +1,12 @@
+shared_examples "callback triggered" do
+  it "should triggered the calback" do
+    mock(post, method).times(1)
+    post.update_attributes(attributes)
+  end
+end
+shared_examples "callback not triggered" do
+  it "should triggered the calback" do
+    mock(post, method).times(0)
+    post.update_attributes(attributes)
+  end
+end

metadata

@@ -1,125 +1,125 @@
 --- !ruby/object:Gem::Specification
 name: active_record-when_change
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Zidni Mubarock
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-26 00:00:00.000000000 Z
+date: 2014-02-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 4.0.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 4.0.3
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
 - !ruby/object:Gem::Dependency
   name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.2.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.2.0
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rr
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Simple DSL to control callback attribute changed in ActiveRecord model
@@ -129,8 +129,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
+- ".gitignore"
+- ".rspec"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -143,7 +143,8 @@ files:
 - spec/support/constants_helper.rb
 - spec/support/post.rb
 - spec/support/schema.rb
-homepage: http://barock.github.io/active_record-when_change
+- spec/support/shared_example.rb
+homepage: https://github.com/barock19/active_record-when_change
 licenses:
 - MIT
 metadata: {}
@@ -153,12 +154,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
@@ -173,3 +174,4 @@ test_files:
 - spec/support/constants_helper.rb
 - spec/support/post.rb
 - spec/support/schema.rb
+- spec/support/shared_example.rb