active_record-sql_analyzer 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7987c2a8d140ea3c6dc2b13effcad2f810562171
-  data.tar.gz: b62f71e7563c8e92d11ee5baac0ad8722d669780
+  metadata.gz: cb06e648d1ffd4dea8993e522956e1f51e3a6c22
+  data.tar.gz: acfdcbbe3ee535851f8ae9ad7d7fbc93570733ce
 SHA512:
-  metadata.gz: df3a2c7ea88fbc0b86cc9fdcc9fe94c52c9727ff436ade3f6f06869932f842c24101c33cbefe6bae77e381275572dcb6d4e724741c3bb18cd1ac5888d99da971
-  data.tar.gz: 158608b3e248858f41a0084a6787432932e4860f41d48f876fd6cbbf58c9cad8a2eb7bbbb877eca8092fe50af1c7cc3d5aaf38518771111c6183de0b741b920b
+  metadata.gz: 5dc33540413a834ad211c77e473bf78de5dce8cb3fcf2221fe8c8d140249f2787d7bb6ed9961d106b5d123bb6bbb81eaec3cca02578ff29392ba80c67425c833
+  data.tar.gz: c15a89ef7b0e5ecd94d855dcde852554f34b2f08fea6fea924c9efc453c2c122ad6db32dce65f72f63a87e8e74603aaa860fb85d9bc7d3e33364aa51b3847807

data/lib/active_record/sql_analyzer/monkeypatches/query.rb

@@ -44,18 +44,11 @@ module ActiveRecord
                 QueryAnalyzerCall.new(call.sql.encode(Encoding::UTF_8, invalid: :replace, undef: :replace), call.caller)
               end
 
-              matching_calls = reencoded_calls.select do |call|
-                (call.sql =~ /^(UPDATE|INSERT|DELETE)/) || (call.sql =~ analyzer[:table_regex])
-              end
-
-              if matching_calls.any?
-                # Add back in the begin and commit statements, using the correct call stack references
-                if reencoded_calls.first.sql == 'BEGIN'
-                  matching_calls.unshift(reencoded_calls.first)
-                end
+              has_matching_calls = reencoded_calls.any? { |call| call.sql =~ analyzer[:table_regex] }
 
-                if ['COMMIT', 'ROLLBACK'].include? reencoded_calls.last.sql
-                  matching_calls << reencoded_calls.last
+              if has_matching_calls
+                matching_calls = reencoded_calls.select do |call|
+                  (call.sql =~ /^(BEGIN|COMMIT|ROLLBACK|UPDATE|INSERT|DELETE)/) || (call.sql =~ analyzer[:table_regex])
                 end
 
                 SqlAnalyzer.background_processor <<

data/lib/active_record/sql_analyzer/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module SqlAnalyzer
-    VERSION = '0.2.0'
+    VERSION = '0.2.1'
   end
 end

data/spec/active_record/sql_analyzer/end_to_end_spec.rb

@@ -241,6 +241,14 @@ RSpec.describe "End to End" do
     expect(log_def_hash.size).to eq(0)
   end
 
+  it "Does not log nonmatching-only insert transactions" do
+    transaction do
+      execute "INSERT INTO nonmatching_table (id) VALUES (1)"
+    end
+
+    expect(log_def_hash.size).to eq(0)
+  end
+
   context "Selectively sampling" do
     before do
       ActiveRecord::SqlAnalyzer.configure do |c|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_record-sql_analyzer
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Zachary Anker
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-16 00:00:00.000000000 Z
+date: 2016-08-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord