active_record-json_has_many 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1e8b17732f5551ec1211c1f72f1a4ef94028b6f5
-  data.tar.gz: 80f89023027d97ebf8c7efafc53f6798697e1a3f
+  metadata.gz: ae2083de42d457a0126dfae281028cf4160ec7b3
+  data.tar.gz: e9150e43a9833bbedacdc28303ad70e586fd107c
 SHA512:
-  metadata.gz: eb7946443e7a7df82b722d56b15518eef11db88f1c3852f3e4f722622c3eec84e3b9c6749e90f02cc91cbd90dcca18776dcc37e296c591d62596eebcf8af3feb
-  data.tar.gz: d1b993233a2f8709170c3520efbf4fc5c9d9b704cd06534e3b33394ea8f4f64f692e31475b6e267a48891362f9a2a045e83034c78e67809fe908b54bb8d48ae9
+  metadata.gz: fd9f6774aa2a44b6596db207a3b157dd457a71b0b21b6fc4ebe77c17f761b376e5bcd19636d70826c0e6b3e03cf282b25862865b29f379dba8b173eedbf5895b
+  data.tar.gz: 0fda3ea696b950060de99a9f2ef91d713653bcc8d72487a5f4fc64672f04dfeae14eeadfa080fe53275b4f0c9be0dd7d3a5f00e24227e10fdac500a0808b6236

data/.travis.yml

@@ -0,0 +1,5 @@
+language: ruby
+rvm:
+  - 2.0.0
+  - 2.1.0
+

data/README.md

@@ -1,6 +1,9 @@
 # ActiveRecord::JsonHasMany
 
-Instead of a many-to-many join table, serialize the ids into a JSON array.
+[![Build Status](https://travis-ci.org/botandrose/active_record-json_has_many.svg)](https://travis-ci.org/botandrose/active_record-json_has_many)
+[![Code Climate](https://codeclimate.com/github/botandrose/active_record-json_has_many/badges/gpa.svg)](https://codeclimate.com/github/botandrose/active_record-json_has_many)
+
+Instead of keeping the foreign keys on the children, or in a many-to-many join table, let's keep them in a JSON array on the parent.
 
 ## Installation
 
@@ -20,7 +23,7 @@ Or install it yourself as:
 
 ```ruby
 class Parent < ActiveRecord::Base
-  has_many_json :children, class_name: "Child"
+  json_has_many :children
 end
 ```
 
@@ -32,6 +35,10 @@ parent.child_ids #=> [1,2,3]
 parent.children => [<Child id=1>, <Child id=2>, Child id=3>]
 ```
 
+## Requirements
+
+* Ruby 2.0+
+
 ## Contributing
 
 1. Fork it ( https://github.com/[my-github-username]/active_record-json_has_many/fork )

data/Rakefile

@@ -1,2 +1,7 @@
 require "bundler/gem_tasks"
+require "rspec/core/rake_task"
+
+RSpec::Core::RakeTask.new(:spec)
+
+task :default => :spec
 

data/lib/active_record/json_has_many.rb

@@ -4,20 +4,28 @@ require "json"
 
 module ActiveRecord
   module JsonHasMany
-    def json_has_many(field, class_name: nil)
-      singularized_field = field.to_s.singularize.to_sym
-      class_name ||= singularized_field.to_s.classify
-      serialize :"#{singularized_field}_ids", JSON
-
-      class_eval <<-RUBY
-        def #{singularized_field}_ids
-          super || []
+    def json_has_many(many, class_name: nil)
+      one = many.to_s.singularize
+      one_ids = :"#{one}_ids"
+      class_name ||= one.classify
+
+      serialize one_ids, JSON
+
+      include instance_methods(one_ids, many, class_name)
+    end
+
+    private
+
+    def instance_methods one_ids, many, class_name
+      Module.new do
+        define_method one_ids do
+          super() || []
         end
 
-        def #{field}
-          #{class_name}.where(id: #{singularized_field}_ids)
+        define_method many do
+          class_name.constantize.where(id: send(one_ids))
         end
-      RUBY
+      end
     end
   end
 

data/lib/active_record/json_has_many/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module JsonHasMany
-    VERSION = "0.1.0"
+    VERSION = "0.2.0"
   end
 end

data/spec/json_has_many_spec.rb

@@ -1,4 +1,5 @@
 require "active_record/json_has_many"
+require "byebug"
 
 describe ActiveRecord::JsonHasMany do
   before do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_record-json_has_many
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Micah Geisel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-28 00:00:00.000000000 Z
+date: 2014-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -102,6 +102,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md