active_record-json_associations 0.13.0 → 0.13.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c6e92de811720d3a6f9ed242d374f6f4b6e604e09977476f619355918c22b6ea
-  data.tar.gz: 31e0f02c6b52dbc6994d3d4c2ae7016287a2d2488ad1371ddac6ba65bf9598d8
+  metadata.gz: 9d0210b855faca7f7e383b01be2e5e7fb6f78a24770fc5456f6fe6661e3862d2
+  data.tar.gz: 95abf57fc202bb226e8c3dd01c018c489c21ed47c3e00fbd1fc920b0df8f7856
 SHA512:
-  metadata.gz: 1773bd6dd9c36865e772b81c6e0c7ac9ece43028cdc1c5e254047dcc5349bb0cc4a8073b30de3cd114bed20be88ab30495b6f5b2f9a241caa78f9fd8c1a67908
-  data.tar.gz: 4312ec59acc30da426d32c53dea432bcdd2064a21fea69faa826f6dd1347887668e6fc7280be9a107973ad9ac6f19745e43df382c573831b71623ed3f8889a32
+  metadata.gz: d396317afb6cb24bccf06d8f7d9a773f8b76ca65e117d9194230c9378804eeb26f9eb608b26e7240fa0de45e5292f03b6170e544473bfb77621d695a7a0cc887
+  data.tar.gz: 72cc81817ebb6f46f4d82a446f1a17235d60ca701f43300aa23425d2bbd298d5119587ad407eaaf441c74dca0a68aa0d58483b42ef315e064eacb4fe869f8784

data/lib/active_record/json_associations/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module JsonAssociations
-    VERSION = "0.13.0"
+    VERSION = "0.13.1"
   end
 end

data/lib/active_record/json_associations.rb

@@ -79,7 +79,7 @@ module ActiveRecord
         end
 
         define_method one_ids_equals do |ids|
-          super Array(ids).select(&:present?).map(&:to_i)
+          super Array(ids).select(&:present?).map(&:to_i).uniq
         end
 
         define_method many do
@@ -137,7 +137,7 @@ module ActiveRecord
         end
 
         define_method one_ids_equals do |ids|
-          normalized_ids = Array(ids).select(&:present?).map(&:to_i)
+          normalized_ids = Array(ids).select(&:present?).map(&:to_i).uniq
           send many_equals, klass.find(normalized_ids)
         end
 

data/spec/{json_associations_spec.rb → belongs_to_many_spec.rb}

@@ -10,6 +10,7 @@ describe ActiveRecord::JsonAssociations do
           t.string :name
           t.text :child_ids
           t.text :fuzzy_ids
+          t.json :dependent_types_and_ids
           t.timestamps
         end
 
@@ -274,216 +275,4 @@ describe ActiveRecord::JsonAssociations do
       end
     end
   end
-
-  describe ".has_many :parents, json_foreign_key: true" do
-    subject { Child.create! }
-
-    let(:parents) { [Parent.create!, Parent.create!, Parent.create!] }
-
-    describe "#parent_ids" do
-      it "is empty by default" do
-        expect(subject.parent_ids).to eq []
-      end
-
-      it "is an accessor" do
-        subject.parent_ids = parents.map(&:id)
-        expect(subject.parent_ids).to eq parents.map(&:id)
-      end
-    end
-
-    describe "#parent_ids=" do
-      before { parents } # ensure parents exist
-
-      it "normalizes to integers" do
-        subject.parent_ids = ["1",2,"3"]
-        expect(subject.parent_ids).to eq [1,2,3]
-      end
-
-      it "ignores empty strings" do
-        subject.parent_ids = ["","1","2","3"]
-        expect(subject.parent_ids).to eq [1,2,3]
-      end
-    end
-
-    describe "#parents" do
-      it "returns an empty array when there are no parents" do
-        expect(subject.parents).to eq []
-      end
-
-      it "finds the children by id" do
-        subject.parent_ids = parents.map(&:id)
-        expect(subject.parents).to eq parents
-      end
-
-      it "is an accessor" do
-        subject.parents = parents
-        expect(subject.parents).to eq parents
-      end
-
-      context "finds records with the specified id" do
-        let(:child) { Child.create! }
-
-        it "as the whole json array" do
-          parent = Parent.create(children: [child])
-          expect(child.parents).to eq [parent]
-        end
-
-        it "at the beginning of the json array" do
-          parent = Parent.create(children: [child, Child.create!])
-          expect(child.parents).to eq [parent]
-        end
-
-        it "in the middle of the json array" do
-          parent = Parent.create(children: [Child.create!, child, Child.create!])
-          expect(child.parents).to eq [parent]
-        end
-
-        it "at the end of the json array" do
-          parent = Parent.create(children: [Child.create!, child])
-          expect(child.parents).to eq [parent]
-        end
-      end
-    end
-
-    describe "#parents?" do
-      it "returns false when there are no parents" do
-        expect(subject.parents?).to be_falsey
-      end
-
-      it "returns true when there are parents" do
-        subject.parents = parents
-        expect(subject.parents?).to be_truthy
-      end
-    end
-
-    describe "#build_parent" do
-      it "doesnt save the record" do
-        parent = subject.build_parent
-        expect(parent).to be_new_record
-      end
-
-      it "sets the foreign key column" do
-        parent = subject.build_parent
-        expect(parent.children).to eq([subject])
-      end
-
-      it "passes attributes through" do
-        parent = subject.build_parent(name: "Parent")
-        expect(parent.name).to eq("Parent")
-      end
-    end
-
-    describe "#create_parent" do
-      it "saves the record" do
-        parent = subject.create_parent
-        expect(parent).to be_persisted
-      end
-
-      it "sets the foreign key column" do
-        parent = subject.create_parent
-        expect(parent.children).to eq([subject])
-      end
-
-      it "passes attributes through" do
-        parent = subject.create_parent(name: "Parent")
-        expect(parent.name).to eq("Parent")
-      end
-
-      it "calls create on the model" do
-        expect(Parent).to receive(:create)
-        subject.create_parent
-      end
-    end
-
-    describe "#create_parent!" do
-      it "saves the record" do
-        parent = subject.create_parent!
-        expect(parent).to be_persisted
-      end
-
-      it "sets the foreign key column" do
-        parent = subject.create_parent!
-        expect(parent.children).to eq([subject])
-      end
-
-      it "passes attributes through" do
-        parent = subject.create_parent!(name: "Parent")
-        expect(parent.name).to eq("Parent")
-      end
-
-      it "calls create! on the model" do
-        expect(Parent).to receive(:create!)
-        subject.create_parent!
-      end
-    end
-  end
-
-  describe ".has_many :parents, json_foreign_key: :fuzzy_ids" do
-    subject { Pet.create! }
-
-    let(:parents) { [Parent.create!, Parent.create!, Parent.create!] }
-
-    describe "#parent_ids" do
-      it "is empty by default" do
-        expect(subject.parent_ids).to eq []
-      end
-
-      it "is an accessor" do
-        subject.parent_ids = parents.map(&:id)
-        expect(subject.parent_ids).to eq parents.map(&:id)
-      end
-    end
-
-    describe "#parents" do
-      it "returns an empty array when there are no parents" do
-        expect(subject.parents).to eq []
-      end
-
-      it "finds the parents by id" do
-        subject.parent_ids = parents.map(&:id)
-        expect(subject.parents).to eq parents
-      end
-
-      it "is an accessor" do
-        subject.parents = parents
-        expect(subject.parents).to eq parents
-      end
-
-      context "finds records with the specified id" do
-        let(:pet) { Pet.create! }
-
-        it "as the whole json array" do
-          parent = Parent.create(fuzzies: [pet])
-          expect(pet.parents).to eq [parent]
-        end
-
-        it "at the beginning of the json array" do
-          parent = Parent.create(fuzzies: [pet, Pet.create!])
-          expect(pet.parents).to eq [parent]
-        end
-
-        it "in the middle of the json array" do
-          parent = Parent.create(fuzzies: [Pet.create!, pet, Pet.create!])
-          expect(pet.parents).to eq [parent]
-        end
-
-        it "at the end of the json array" do
-          parent = Parent.create(fuzzies: [Pet.create!, pet])
-          expect(pet.parents).to eq [parent]
-        end
-      end
-    end
-
-    describe "#parents?" do
-      it "returns false when there are no parents" do
-        expect(subject.parents?).to be_falsey
-      end
-
-      it "returns true when there are parents" do
-        subject.parents = parents
-        expect(subject.parents?).to be_truthy
-      end
-    end
-  end
 end
-

data/spec/has_many_spec.rb

@@ -0,0 +1,255 @@
+require "active_record/json_associations"
+
+describe ActiveRecord::JsonAssociations do
+  before do
+    ActiveRecord::Base.establish_connection adapter: "sqlite3", database: ":memory:"
+
+    silence_stream(STDOUT) do
+      ActiveRecord::Schema.define do
+        create_table :parents do |t|
+          t.string :name
+          t.text :child_ids
+          t.text :fuzzy_ids
+          t.timestamps
+        end
+
+        create_table :children do |t|
+          t.timestamps
+        end
+
+        create_table :pets do |t|
+          t.timestamps
+        end
+      end
+    end
+
+    class Parent < ActiveRecord::Base
+      belongs_to_many :children, touch: true
+      belongs_to_many :fuzzies, class_name: "Pet"
+    end
+
+    class Child < ActiveRecord::Base
+      has_many :parents, json_foreign_key: true
+    end
+
+    class Pet < ActiveRecord::Base
+      has_many :parents, json_foreign_key: :fuzzy_ids
+
+      # ensure that regular .has_many invocations still work
+      has_many :fallback_parents
+      has_many :fallback_parents_with_options, class_name: "Pet"
+      has_many :fallback_parents_with_scope, -> { order(:id) }
+    end
+  end
+ 
+  describe ".has_many :parents, json_foreign_key: true" do
+    subject { Child.create! }
+
+    let(:parents) { [Parent.create!, Parent.create!, Parent.create!] }
+
+    describe "#parent_ids" do
+      it "is empty by default" do
+        expect(subject.parent_ids).to eq []
+      end
+
+      it "is an accessor" do
+        subject.parent_ids = parents.map(&:id)
+        expect(subject.parent_ids).to eq parents.map(&:id)
+      end
+    end
+
+    describe "#parent_ids=" do
+      before { parents } # ensure parents exist
+
+      it "normalizes to integers" do
+        subject.parent_ids = ["1",2,"3"]
+        expect(subject.parent_ids).to eq [1,2,3]
+      end
+
+      it "ignores empty strings" do
+        subject.parent_ids = ["","1","2","3"]
+        expect(subject.parent_ids).to eq [1,2,3]
+      end
+    end
+
+    describe "#parents" do
+      it "returns an empty array when there are no parents" do
+        expect(subject.parents).to eq []
+      end
+
+      it "finds the children by id" do
+        subject.parent_ids = parents.map(&:id)
+        expect(subject.parents).to eq parents
+      end
+
+      it "is an accessor" do
+        subject.parents = parents
+        expect(subject.parents).to eq parents
+      end
+
+      context "finds records with the specified id" do
+        let(:child) { Child.create! }
+
+        it "as the whole json array" do
+          parent = Parent.create(children: [child])
+          expect(child.parents).to eq [parent]
+        end
+
+        it "at the beginning of the json array" do
+          parent = Parent.create(children: [child, Child.create!])
+          expect(child.parents).to eq [parent]
+        end
+
+        it "in the middle of the json array" do
+          parent = Parent.create(children: [Child.create!, child, Child.create!])
+          expect(child.parents).to eq [parent]
+        end
+
+        it "at the end of the json array" do
+          parent = Parent.create(children: [Child.create!, child])
+          expect(child.parents).to eq [parent]
+        end
+      end
+    end
+
+    describe "#parents?" do
+      it "returns false when there are no parents" do
+        expect(subject.parents?).to be_falsey
+      end
+
+      it "returns true when there are parents" do
+        subject.parents = parents
+        expect(subject.parents?).to be_truthy
+      end
+    end
+
+    describe "#build_parent" do
+      it "doesnt save the record" do
+        parent = subject.build_parent
+        expect(parent).to be_new_record
+      end
+
+      it "sets the foreign key column" do
+        parent = subject.build_parent
+        expect(parent.children).to eq([subject])
+      end
+
+      it "passes attributes through" do
+        parent = subject.build_parent(name: "Parent")
+        expect(parent.name).to eq("Parent")
+      end
+    end
+
+    describe "#create_parent" do
+      it "saves the record" do
+        parent = subject.create_parent
+        expect(parent).to be_persisted
+      end
+
+      it "sets the foreign key column" do
+        parent = subject.create_parent
+        expect(parent.children).to eq([subject])
+      end
+
+      it "passes attributes through" do
+        parent = subject.create_parent(name: "Parent")
+        expect(parent.name).to eq("Parent")
+      end
+
+      it "calls create on the model" do
+        expect(Parent).to receive(:create)
+        subject.create_parent
+      end
+    end
+
+    describe "#create_parent!" do
+      it "saves the record" do
+        parent = subject.create_parent!
+        expect(parent).to be_persisted
+      end
+
+      it "sets the foreign key column" do
+        parent = subject.create_parent!
+        expect(parent.children).to eq([subject])
+      end
+
+      it "passes attributes through" do
+        parent = subject.create_parent!(name: "Parent")
+        expect(parent.name).to eq("Parent")
+      end
+
+      it "calls create! on the model" do
+        expect(Parent).to receive(:create!)
+        subject.create_parent!
+      end
+    end
+  end
+
+  describe ".has_many :parents, json_foreign_key: :fuzzy_ids" do
+    subject { Pet.create! }
+
+    let(:parents) { [Parent.create!, Parent.create!, Parent.create!] }
+
+    describe "#parent_ids" do
+      it "is empty by default" do
+        expect(subject.parent_ids).to eq []
+      end
+
+      it "is an accessor" do
+        subject.parent_ids = parents.map(&:id)
+        expect(subject.parent_ids).to eq parents.map(&:id)
+      end
+    end
+
+    describe "#parents" do
+      it "returns an empty array when there are no parents" do
+        expect(subject.parents).to eq []
+      end
+
+      it "finds the parents by id" do
+        subject.parent_ids = parents.map(&:id)
+        expect(subject.parents).to eq parents
+      end
+
+      it "is an accessor" do
+        subject.parents = parents
+        expect(subject.parents).to eq parents
+      end
+
+      context "finds records with the specified id" do
+        let(:pet) { Pet.create! }
+
+        it "as the whole json array" do
+          parent = Parent.create(fuzzies: [pet])
+          expect(pet.parents).to eq [parent]
+        end
+
+        it "at the beginning of the json array" do
+          parent = Parent.create(fuzzies: [pet, Pet.create!])
+          expect(pet.parents).to eq [parent]
+        end
+
+        it "in the middle of the json array" do
+          parent = Parent.create(fuzzies: [Pet.create!, pet, Pet.create!])
+          expect(pet.parents).to eq [parent]
+        end
+
+        it "at the end of the json array" do
+          parent = Parent.create(fuzzies: [Pet.create!, pet])
+          expect(pet.parents).to eq [parent]
+        end
+      end
+    end
+
+    describe "#parents?" do
+      it "returns false when there are no parents" do
+        expect(subject.parents?).to be_falsey
+      end
+
+      it "returns true when there are parents" do
+        subject.parents = parents
+        expect(subject.parents?).to be_truthy
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_record-json_associations
 version: !ruby/object:Gem::Version
-  version: 0.13.0
+  version: 0.13.1
 platform: ruby
 authors:
 - Micah Geisel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2025-01-21 00:00:00.000000000 Z
+date: 2025-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -145,7 +145,8 @@ files:
 - gemfiles/rails_7.2.gemfile
 - lib/active_record/json_associations.rb
 - lib/active_record/json_associations/version.rb
-- spec/json_associations_spec.rb
+- spec/belongs_to_many_spec.rb
+- spec/has_many_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/botandrose/active_record-json_associations
 licenses:
@@ -171,5 +172,6 @@ signing_key:
 specification_version: 4
 summary: Instead of a many-to-many join table, serialize the ids into a JSON array.
 test_files:
-- spec/json_associations_spec.rb
+- spec/belongs_to_many_spec.rb
+- spec/has_many_spec.rb
 - spec/spec_helper.rb