active_record-associated_object 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9b5e7079fe6ffefe707c65a2a88b92c20ff3c8b91601cdef75bd638adbb73166
-  data.tar.gz: 1e59dbc65c54baa19c8bac770ebd52a469aa95855c7758c020bfd8b72a51b3f0
+  metadata.gz: 20d91687ec83cbc70efb318377c15ce1e2e79b28d350322b0d91ad6618073cc2
+  data.tar.gz: 59f19eea143da23bd980f0d6bca5a96670e13c7859d0db860741bf314d949822
 SHA512:
-  metadata.gz: 7f2c7de0292ac2ce3ed011be69f6c887cf93873ab4b80c2288b4cd66ff22ec0780cb9872476656227eec164cf73ed9fc2e0ced1dcde154db6377343c408fbef5
-  data.tar.gz: 783ca5c727bb5718aa7436b0252b83b9f4c904f28829635cc117f83920a740d2361cce9708707b8ba2f084148b6a5968e6e6a6f8cca56d9b9526d4b30fa59a76
+  metadata.gz: a41fc155e625c0d04d01f39a55a6c80155b8e275abb1c9be9ef5fac6c927cd6c36b83a13a9f621c73c344b333b246bd86e76bb49773579b2605fb1d2ede636b3
+  data.tar.gz: 3de159d609ac4ab8eedbe03d681cd6d8295ca4831c7eb4430ca760f86dfa243906bd9c7d62cc2cd60cf44ba0aa271116114703bd59a784780260d4b961f3e725

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## [0.4.0] - 2022-09-25
+
+- Extract `performs` into the `active_job-performs` gem with some fixes and extra features, but include it as a dependency.
+
 ## [0.3.0] - 2022-09-25
 
 - Add `performs` to help cut down Active Job boilerplate.

data/Gemfile

@@ -15,3 +15,5 @@ gem "sqlite3"
 gem "kredis"
 gem "activejob"
 gem "railties"
+
+gem "minitest-sprint", "~> 1.2"

data/Gemfile.lock

@@ -1,7 +1,8 @@
 PATH
   remote: .
   specs:
-    active_record-associated_object (0.3.0)
+    active_record-associated_object (0.4.0)
+      active_job-performs
       activerecord (>= 6.1)
 
 GEM
@@ -20,6 +21,8 @@ GEM
       erubi (~> 1.4)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.1, >= 1.2.0)
+    active_job-performs (0.1.1)
+      activejob (>= 6.1)
     activejob (7.0.2.3)
       activesupport (= 7.0.2.3)
       globalid (>= 0.3.6)
@@ -55,10 +58,13 @@ GEM
       nokogiri (>= 1.5.9)
     method_source (1.0.0)
     minitest (5.15.0)
+    minitest-sprint (1.2.2)
+      path_expander (~> 1.1)
     nokogiri (1.13.4-arm64-darwin)
       racc (~> 1.4)
     nokogiri (1.13.4-x86_64-linux)
       racc (~> 1.4)
+    path_expander (1.1.1)
     racc (1.6.0)
     rack (2.2.3)
     rack-test (1.1.0)
@@ -95,6 +101,7 @@ DEPENDENCIES
   debug
   kredis
   minitest (~> 5.0)
+  minitest-sprint (~> 1.2)
   railties
   rake (~> 13.0)
   sqlite3

data/README.md

@@ -46,6 +46,8 @@ end
 
 ### How `performs` removes Active Job boilerplate
 
+`performs` comes from the `active_job-performs` gem and is automatically bundled with `ActiveRecord::AssociatedObject`.
+
 With an associated object like this:
 
 ```ruby

data/Rakefile

@@ -1,12 +1,3 @@
 # frozen_string_literal: true
 
 require "bundler/gem_tasks"
-require "rake/testtask"
-
-Rake::TestTask.new(:test) do |t|
-  t.libs << "test"
-  t.libs << "lib"
-  t.test_files = FileList["test/**/test_*.rb"]
-end
-
-task default: :test

data/active_record-associated_object.gemspec

@@ -24,12 +24,11 @@ Gem::Specification.new do |spec|
       (f == __FILE__) || f.match(%r{\A(?:(?:bin|test|spec|features)/|\.(?:git|travis|circleci)|appveyor)})
     end
   end
-  spec.bindir = "exe"
-  spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
   # Uncomment to register a new dependency of your gem
   spec.add_dependency "activerecord", ">= 6.1"
+  spec.add_dependency "active_job-performs"
 
   # For more information and examples about making a new gem, check out our
   # guide at: https://bundler.io/guides/creating_gem.html

data/lib/active_record/associated_object/railtie.rb

@@ -4,8 +4,8 @@ class ActiveRecord::AssociatedObject::Railtie < Rails::Railtie
     ActiveRecord::AssociatedObject.include GlobalID::Identification if defined?(GlobalID)
 
     ActiveSupport.on_load :active_job do
-      require "active_record/associated_object/performs"
-      ActiveRecord::AssociatedObject.extend ActiveRecord::AssociatedObject::Performs
+      require "active_job/performs"
+      ActiveRecord::AssociatedObject.extend ActiveJob::Performs
     end
   end
 

data/lib/active_record/associated_object/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveRecord
   class AssociatedObject
-    VERSION = "0.3.0"
+    VERSION = "0.4.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_record-associated_object
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Kasper Timm Hansen
 autorequire:
-bindir: exe
+bindir: bin
 cert_chain: []
-date: 2022-09-25 00:00:00.000000000 Z
+date: 2022-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '6.1'
+- !ruby/object:Gem::Dependency
+  name: active_job-performs
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description:
 email:
 - hey@kaspth.com
@@ -40,7 +54,6 @@ files:
 - active_record-associated_object.gemspec
 - lib/active_record/associated_object.rb
 - lib/active_record/associated_object/object_association.rb
-- lib/active_record/associated_object/performs.rb
 - lib/active_record/associated_object/railtie.rb
 - lib/active_record/associated_object/version.rb
 homepage: https://github.com/kaspth/active_record-associated_object

data/lib/active_record/associated_object/performs.rb

@@ -1,36 +0,0 @@
-module ActiveRecord::AssociatedObject::Performs
-  def performs(method = nil, **configs, &block)
-    @job ||= safe_define("Job") { ApplicationJob }
-
-    if method.nil?
-      apply_performs_to(@job, **configs, &block)
-    else
-      job = safe_define("#{method}_job".classify) { @job }
-      apply_performs_to(job, **configs, &block)
-
-      job.class_eval <<~RUBY, __FILE__, __LINE__ + 1 unless job.instance_method(:perform).owner == job
-        def perform(object, *arguments, **options)
-          object.#{method}(*arguments, **options)
-        end
-      RUBY
-
-      class_eval <<~RUBY, __FILE__, __LINE__ + 1
-        def #{method}_later(*arguments, **options)
-          #{job}.perform_later(self, *arguments, **options)
-        end
-      RUBY
-    end
-  end
-
-  private
-    def safe_define(name)
-      name.safe_constantize || const_set(name, Class.new(yield))
-    end
-
-    def apply_performs_to(job_class, **configs, &block)
-      job_class.class_eval do
-        configs.each { public_send(_1, _2) }
-        yield if block_given?
-      end
-    end
-end