active_record-acts_as 5.0.2 → 5.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 52d4f9697fffd355665d4fbfec8e95d3df7e4a7f079c1075ec02433003088028
-  data.tar.gz: 90991fdb687a92ea19ef8c3d1f86f8940079e8adc31a715b0c81a0c64cde8159
+  metadata.gz: ecd8cd75c441652a7719cc0b040d77a84a95f30b1ea8b19c02aa35fb6bdcd425
+  data.tar.gz: a94c71a0cc0dec6e7468cc3949260ee521320a15ab09d433a7c6323aa8b2114d
 SHA512:
-  metadata.gz: 7f387a9c486ad279c7c978bdd58136f34a0b74438d757be8d507c0817da2d7c51f95bfac00223f375942ae511124d63dcfc77970901481d6671d92559166dbfa
-  data.tar.gz: 17cb390291b18ca97a7778177407694f300dc45fb5717d76410b859018339bf71988fb88c430355aa21ad3910d726f97d5e9f19139c5f86aa8b039d1957876db
+  metadata.gz: ea6d3e0caa50e3a5e39543684bf372e4d64d5b8adfeb29686523b6674d7d1f4d42449b924f657814cd2c14894068a019d8a8796c45efcc1a76bc1c8cac0ea886
+  data.tar.gz: 9d12820c023f3c0f9d11594b17c904da1ece86fa4381a791cb84f086cde101078140ab9219dfee08185c7e90143d3ae1cffe7abe4f829e427fce002da72c8366

data/.travis.yml

@@ -10,3 +10,7 @@ gemfile:
   - gemfiles/rails_6.0.gemfile
   - gemfiles/rails_6.1.gemfile
   - gemfiles/rails_master.gemfile
+jobs:
+  exclude:
+    - rvm: 2.6
+      gemfile: gemfiles/rails_master.gemfile

data/CHANGELOG.md

@@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased] -
 
+## [5.0.2] - 2021-07-27
+
+### Fixed
+- Handle kwargs in ruby 3 in methods delegated to supermodel (@tindron)
+
 ## [5.0.1] - 2021-01-28
 
 ### Fixed

data/active_record-acts_as.gemspec

@@ -30,5 +30,6 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency "activesupport", ">= 6.0"
   spec.add_dependency "activerecord", ">= 6.0"
+  spec.add_dependency "ruby2_keywords"
 
 end

data/lib/active_record/acts_as.rb

@@ -1,3 +1,4 @@
+require 'ruby2_keywords'
 require 'active_support'
 require 'active_record'
 require 'active_record/acts_as/version'

data/lib/active_record/acts_as/class_methods.rb

@@ -23,7 +23,7 @@ module ActiveRecord
         acting_as_model.methods_callable_by_submodel.include?(method) || super
       end
 
-      def method_missing(method, *args, &block)
+      ruby2_keywords def method_missing(method, *args, &block)
         if acting_as_model.methods_callable_by_submodel.include?(method)
           result = acting_as_model.public_send(method, *args, &block)
           if result.is_a?(ActiveRecord::Relation)

data/lib/active_record/acts_as/instance_methods.rb

@@ -117,7 +117,7 @@ module ActiveRecord
         duplicate
       end
 
-      def method_missing(method, *args, &block)
+      ruby2_keywords def method_missing(method, *args, &block)
         if !self_respond_to?(method) && acting_as.respond_to?(method)
           acting_as.send(method, *args, &block)
         else

data/lib/active_record/acts_as/version.rb

@@ -1,6 +1,6 @@
 module ActiveRecord
   module ActsAs
-    VERSION = "5.0.2"
+    VERSION = "5.0.3"
   end
 end
 

data/spec/acts_as_spec.rb

@@ -157,6 +157,10 @@ RSpec.describe "ActiveRecord::Base model with #acts_as called" do
       expect(pen.present).to eq("pen - $0.8")
     end
 
+    it "responds to supermodel methods with keyword arguments" do
+      expect(pen.keyword_method(one: 3, two: 4)).to eq [3,4]
+    end
+
     it 'responds to serialized attribute' do
       expect(pen).to respond_to('option1')
       expect(isolated_pen).to respond_to('option2')
@@ -452,6 +456,10 @@ RSpec.describe "ActiveRecord::Base model with #acts_as called" do
         expect(Product.class_method_callable_by_submodel).to eq('class_method_callable_by_submodel')
         expect(Pen.class_method_callable_by_submodel).to eq('class_method_callable_by_submodel')
       end
+
+      it 'with keyword arguments can be called from the submodel' do
+        expect(Pen.class_keyword_method_callable_by_submodel(one: 3, two: 4)).to eq([3,4])
+      end
     end
 
     context 'when they are neither defined via `scope` nor made callable by submodel' do

data/spec/models.rb

@@ -16,6 +16,10 @@ class Product < ActiveRecord::Base
     'class_method'
   end
 
+  callable_by_submodel def self.class_keyword_method_callable_by_submodel(one: 1, two: 2)
+    [one, two]
+  end
+
   callable_by_submodel def self.class_method_callable_by_submodel
     'class_method_callable_by_submodel'
   end
@@ -27,6 +31,10 @@ class Product < ActiveRecord::Base
   def raise_error
     specific.non_existant_method
   end
+
+  def keyword_method(one: 1, two: 2)
+    [one, two]
+  end
 end
 
 class Payment < ActiveRecord::Base

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_record-acts_as
 version: !ruby/object:Gem::Version
-  version: 5.0.2
+  version: 5.0.3
 platform: ruby
 authors:
 - Hassan Zamani
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-02-09 00:00:00.000000000 Z
+date: 2021-07-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sqlite3
@@ -124,6 +124,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '6.0'
+- !ruby/object:Gem::Dependency
+  name: ruby2_keywords
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Simulate multi-table inheritance for activerecord models using a polymorphic
   association
 email: