active_record-acts_as 2.4.0 → 2.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 589ce7c704e9fbea72a54a837e5a6937a617abc7
-  data.tar.gz: ffd0002ce231c728cf4508c008c4b033c12ebdf9
+  metadata.gz: b0bbaf8a07eceb6c10fd9e9fea3ece8a641aef69
+  data.tar.gz: c5c9b6265ca7464402b6cf8955c28345deee417d
 SHA512:
-  metadata.gz: a4ddd42dca8305b4b6e10d6045455b54192834004e0289cb1a1073ed99f409342f075467b8c4a63dc812ace6e31b3cd09692ad3a4538cc08af683409833eeeff
-  data.tar.gz: 46701f3ca1f4f00783ef1e2a58763752e5a7ff5d67f20e33ea2ac78a20f170c92ec83750d62f57687e7c1dc6336739fb6083b64deb0e350ecddc88d25380b7ef
+  metadata.gz: 195e8c8b7c28634bb882fdcd693341a2eb8bdad0092c1a43fda14414a55da85dda79b2b04ad5d8bd651e622a7380bc5731a082f9d996aa156968bba316639e64
+  data.tar.gz: 5daea8a73f30a50e7471bbf521a00dbb9313576ec508ba518f24508c1a5262a28dfcae98acb6c389e05da2ed540dce7d5b091452f25444a8b687efae75c895e7

data/CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [2.4.1] - 2017-04-19
+### Fixed
+- Make ActiveRecord::Relation#where! work.
+
 ## [2.4.0] - 2017-04-16
 ### Changed
 - Don't make all supermodel class methods callable by submodel, only scopes. Add `callable_by_submodel` to supermodel so users can make their own class methods callable by submodels.
@@ -84,7 +88,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Fixed
 - Fixed `remove_actable` migration helper (https://github.com/hzamani/active_record-acts_as/pull/71, thanks to [nuclearpidgeon](https://github.com/nuclearpidgeon)!)
 
-[Unreleased]: https://github.com/krautcomputing/active_record-acts_as/compare/v2.4.0...HEAD
+[Unreleased]: https://github.com/krautcomputing/active_record-acts_as/compare/v2.4.1...HEAD
+[2.4.1]: https://github.com/krautcomputing/active_record-acts_as/compare/v2.4.0...v2.4.1
 [2.4.0]: https://github.com/krautcomputing/active_record-acts_as/compare/v2.3.1...v2.4.0
 [2.3.1]: https://github.com/krautcomputing/active_record-acts_as/compare/v2.3.0...v2.3.1
 [2.3.0]: https://github.com/krautcomputing/active_record-acts_as/compare/v2.2.1...v2.3.0

data/lib/active_record/acts_as/querying.rb

@@ -1,7 +1,7 @@
 module ActiveRecord
   module ActsAs
     module QueryMethods
-      def where(opts = :chain, *rest)
+      def where!(opts, *)
         if acting_as? && opts.is_a?(Hash)
           if table_name_opts = opts.delete(klass.table_name)
             opts = opts.merge(table_name_opts)

data/lib/active_record/acts_as/version.rb

@@ -1,6 +1,6 @@
 module ActiveRecord
   module ActsAs
-    VERSION = "2.4.0"
+    VERSION = "2.4.1"
   end
 end
 

data/spec/acts_as_spec.rb

@@ -443,22 +443,30 @@ RSpec.describe "ActiveRecord::Base model with #acts_as called" do
     before(:each) { clear_database }
 
     it "respects supermodel attributes in .where" do
-      red_pen = Pen.create(name: 'red pen', price: 0.8, color: 'red')
-      blue_pen = Pen.create(name: 'blue pen', price: 0.8, color: 'blue')
+      red_pen   = Pen.create(name: 'red pen',   price: 0.8, color: 'red')
+      blue_pen  = Pen.create(name: 'blue pen',  price: 0.8, color: 'blue')
       black_pen = Pen.create(name: 'black pen', price: 0.9, color: 'black')
 
-      expect{Pen.where(price: 0.8)}.to_not raise_error
-      expect(Pen.where(price: 0.8)).to include(red_pen, blue_pen)
-      expect(Pen.where(price: 0.8)).to_not include(black_pen)
+      expect(Pen.where(price: 0.8).to_a).to eq([red_pen, blue_pen])
+    end
+
+    it "respects supermodel attributes in .where!" do
+      red_pen   = Pen.create(name: 'red pen',   price: 0.8, color: 'red')
+      blue_pen  = Pen.create(name: 'blue pen',  price: 0.8, color: 'blue')
+      black_pen = Pen.create(name: 'black pen', price: 0.9, color: 'black')
+
+      relation = Pen.all
+      relation.where!(price: 0.8)
+      expect(relation.to_a).to eq([red_pen, blue_pen])
     end
 
     it "respects supermodel attributes in .find_by" do
-      red_pen = Pen.create(name: 'red pen', price: 0.8, color: 'red')
-      blue_pen = Pen.create(name: 'blue pen', price: 0.8, color: 'blue')
+      red_pen   = Pen.create(name: 'red pen',   price: 0.8, color: 'red')
+      blue_pen  = Pen.create(name: 'blue pen',  price: 0.8, color: 'blue')
       black_pen = Pen.create(name: 'black pen', price: 0.9, color: 'black')
 
-      expect(Pen.find_by(name: 'red pen')).to eq(red_pen)
-      expect(Pen.find_by(name: 'blue pen')).to eq(blue_pen)
+      expect(Pen.find_by(name: 'red pen')).to   eq(red_pen)
+      expect(Pen.find_by(name: 'blue pen')).to  eq(blue_pen)
       expect(Pen.find_by(name: 'black pen')).to eq(black_pen)
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_record-acts_as
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.4.1
 platform: ruby
 authors:
 - Hassan Zamani
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-16 00:00:00.000000000 Z
+date: 2017-04-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sqlite3