active_record-acts_as 2.0.5 → 2.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5f5963e720c4d133aec9bbcadb5d8034e805c5da
-  data.tar.gz: b72a5773b65e24a08baa22ef43ff420f25d24d29
+  metadata.gz: 9c9748df03b3540052a5ffdc565d4e7e1533c295
+  data.tar.gz: 6e9bd73f2ca3999edc268e6c40b12510bc76e46c
 SHA512:
-  metadata.gz: 6308fb4da307ca8d479ed40e6f6e1245dec31cbdc031ed28f6ebb4832dc1d282f28622235d074b296c9783ee1eb7c82e1aab6a93cc5fbf03f96918e824927a29
-  data.tar.gz: cb452a38e28515964324e1540cf562631cdb0c3e403fdb9f512682a36d5076a9ad0f31d4b989fffc2fe65da828fe46266a91ed3cd3991985088821bca482f016
+  metadata.gz: 5103fa9f9a3e0cc57ab76270ca05db23008938c7090aa0af4bb9c0fce2b9a4e947a804d512138f4560ceae982e1e15f63bb9073b8ad1d0b15533f1592a23b5ab
+  data.tar.gz: b00229a569085953c49aff5095fc6b1475916cd50979172e84c1cca6f9b790f1a005761aa498745bd14978d484f91a3885a81b841ca639e389d76c252bdb1e90

data/CHANGELOG.md

@@ -4,6 +4,15 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [2.0.6] - 2017-02-17
+### Added
+- Allow arguments to #touch and forward them to the supermodel
+
+## [2.0.5] - 2016-12-20
+### Fixed
+- Don't try to touch supermodel if it's not persisted
+- Call `#destroy`, not `#delete`, on the submodule by default to trigger callbacks
+
 ## [2.0.4] - 2016-12-07
 ### Fixed
 - Touch associated objects if supermodel is updated
@@ -32,7 +41,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Fixed
 - Fixed `remove_actable` migration helper (https://github.com/hzamani/active_record-acts_as/pull/71, thanks to [nuclearpidgeon](https://github.com/nuclearpidgeon)!)
 
-[Unreleased]: https://github.com/hzamani/active_record-acts_as/compare/v2.0.4...HEAD
+[Unreleased]: https://github.com/hzamani/active_record-acts_as/compare/v2.0.6...HEAD
+[2.0.6]: https://github.com/hzamani/active_record-acts_as/compare/v2.0.5...v2.0.6
+[2.0.5]: https://github.com/hzamani/active_record-acts_as/compare/v2.0.4...v2.0.5
 [2.0.4]: https://github.com/hzamani/active_record-acts_as/compare/v2.0.3...v2.0.4
 [2.0.3]: https://github.com/hzamani/active_record-acts_as/compare/v2.0.2...v2.0.3
 [2.0.2]: https://github.com/hzamani/active_record-acts_as/compare/v2.0.1...v2.0.2

data/lib/active_record/acts_as/instance_methods.rb

@@ -91,8 +91,8 @@ module ActiveRecord
         end
       end
 
-      def touch
-        acting_as.touch if acting_as.persisted?
+      def touch(*args)
+        acting_as.touch(*args) if acting_as.persisted?
       end
 
       def respond_to?(name, include_private = false, as_original_class = false)

data/lib/active_record/acts_as/version.rb

@@ -1,6 +1,6 @@
 module ActiveRecord
   module ActsAs
-    VERSION = "2.0.5"
+    VERSION = "2.0.6"
   end
 end
 

data/spec/acts_as_spec.rb

@@ -230,6 +230,12 @@ RSpec.describe "ActiveRecord::Base model with #acts_as called" do
     end
 
     context "touching" do
+      it "forwards arguments to #touch to the supermodel" do
+        pen.save!
+        expect(pen.product).to receive(:touch).with(:one, :two)
+        pen.touch(:one, :two)
+      end
+
       it "touches supermodel on save" do
         pen.save
         pen.reload
@@ -266,11 +272,22 @@ RSpec.describe "ActiveRecord::Base model with #acts_as called" do
       end
     end
 
+    context "polymorphic associations" do
+      it "handles them correctly" do
+        payment = Payment.new
+        pen.payment = payment
+        pen.save!
+        expect(pen.reload.payment).to       eq(payment)
+        expect(pen.payment.payable_type).to eq(pen.acting_as.class.to_s)
+        expect(pen.payment.payable_id).to   eq(pen.acting_as.id)
+      end
+    end
+
     it "raises NoMethodEror on unexisting method call" do
       expect { pen.unexisted_method }.to raise_error(NoMethodError)
     end
 
-    it "destroies Supermodel on destroy" do
+    it "destroys Supermodel on destroy" do
       pen.save
       product_id = pen.product.id
       pen.destroy

data/spec/models.rb

@@ -5,6 +5,7 @@ class Product < ActiveRecord::Base
   actable
   belongs_to :store, touch: true
   has_many :buyers, dependent: :destroy
+  has_one :payment, as: :payable
   validates_presence_of :name, :price
   store :settings, accessors: [:global_option]
 
@@ -17,6 +18,10 @@ class Product < ActiveRecord::Base
   end
 end
 
+class Payment < ActiveRecord::Base
+  belongs_to :payable, polymorphic: true
+end
+
 class PenCollection < ActiveRecord::Base
   has_many :pens
 end
@@ -90,6 +95,11 @@ def initialize_schema
       t.actable
     end
 
+    create_table :payments do |t|
+      t.references :payable, polymorphic: true
+      t.timestamps null: true
+    end
+
     create_table :stores do |t|
       t.string :name
       t.timestamps null: true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_record-acts_as
 version: !ruby/object:Gem::Version
-  version: 2.0.5
+  version: 2.0.6
 platform: ruby
 authors:
 - Hassan Zamani
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-20 00:00:00.000000000 Z
+date: 2017-02-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sqlite3
@@ -164,7 +164,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.6
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Simulate multi-table inheritance for activerecord models
@@ -177,4 +177,3 @@ test_files:
 - spec/models.rb
 - spec/rspec_matchers_spec.rb
 - spec/spec_helper.rb
-has_rdoc: