active_record-acts_as 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ecc2d344c7bbdff842f92553d2a7a028f5a7c34e
-  data.tar.gz: 87136997ae1fccbffb70958662dc476fbb8a636c
+  metadata.gz: 34fc19a0853dc464c318bb8da5d55542940a7428
+  data.tar.gz: 9343cbe6c7b873b2a55af6e937042dc2fca10554
 SHA512:
-  metadata.gz: 42685ddd2f09b51053c1547e76ba3a8470d308d34b2103d52c363b4a75bebcb529f878b7c1a25df5c3420f2454d6943a64af5845e5df510e7d9cb4badc986a8e
-  data.tar.gz: 18f01b95fb9602ca9e6f4c7fe1393094847ff8ae5f3441d4804b9c4eaf5409bd249d342821b68e794af2d4673e17a5f601c3282a0f4c7fa7b882bf191f1ac2f2
+  metadata.gz: fdedabb5d9cff8c513c70f799b2a35527e896d37c452ea4c99ef01cff726988542179c85465588d70c701275c51b598b54f0cb164f5de63f814a67f470a98205
+  data.tar.gz: 8df4505d0d20012f9675dba4acd8512ebfc2d8c6cb64a9088853ccff6125af156132ec7cedae895810f5ac019d6f0c15543169da77e3b4c2fbed8779a60580ae

data/README.md

@@ -47,7 +47,7 @@ class Product < ActiveRecord::Base
 
   validates_presence_of :name, :price
 
-  def display
+  def info
     "#{name} $#{price}"
   end
 end
@@ -66,7 +66,7 @@ end
 ```
 
 and add foreign key and type columns to products table as in a polymorphic relation.
-You may prefere using a migration:
+You may prefer using a migration:
 
 ```Ruby
 change_table :products do |t|
@@ -102,7 +102,7 @@ pen.valid?
   # => false
 pen.errors.full_messages
   # => ["Name can't be blank", "Price can't be blank", "Color can't be blank"]
-Pen.first.display
+Pen.first.info
   # => "Penie! $0.8"
 ```
 
@@ -141,7 +141,7 @@ end
 `acts_as` support all `has_one` options, where defaults are there:
 `as: :actable, dependent: :destroy, validate: false, autosave: true`
 
-Make sure you know what you are doing when overwriting `validate` or `autodave` options.
+Make sure you know what you are doing when overwriting `validate` or `autosave` options.
 
 You can pass scope to `acts_as` as in `has_one`:
 

data/active_record-acts_as.gemspec

@@ -26,5 +26,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake", "~> 10"
 
   spec.add_dependency "activesupport", "~> 4"
-  spec.add_dependency "activerecord", "~> 4.1.2"
+  spec.add_dependency "activerecord", "~> 4", ">= 4.1.2"
 end

data/lib/active_record/acts_as/instance_methods.rb

@@ -50,7 +50,9 @@ module ActiveRecord
       end
 
       def dup
-        super.acting_as = acting_as.dup
+        duplicate = super
+        duplicate.acting_as = acting_as.dup
+        duplicate
       end
 
       def method_missing(method, *args, &block)

data/lib/active_record/acts_as/relation.rb

@@ -13,7 +13,7 @@ module ActiveRecord
           default_scope -> { eager_load(name) }
           validate :actable_must_be_valid
 
-          cattr_reader(:acting_as_reflection) { reflections[name.to_sym] }
+          cattr_reader(:acting_as_reflection) { reflections.stringify_keys[name.to_s] }
           cattr_reader(:acting_as_name) { name.to_s }
           cattr_reader(:acting_as_model) { (options[:class_name] || name.to_s.camelize).constantize }
           class_eval "def acting_as() #{name} || build_#{name} end"
@@ -47,7 +47,7 @@ module ActiveRecord
 
           reflections = belongs_to name, {polymorphic: true, dependent: :delete, autosave: true}.merge(options)
 
-          cattr_reader(:actable_reflection) { reflections[name] }
+          cattr_reader(:actable_reflection) { reflections.stringify_keys[name.to_s] }
 
           alias_method :specific, name
         end

data/lib/active_record/acts_as/version.rb

@@ -1,6 +1,6 @@
 
 module ActiveRecord
   module ActsAs
-    VERSION = "1.0.2"
+    VERSION = "1.0.3"
   end
 end

data/spec/actable_spec.rb

@@ -23,6 +23,13 @@ RSpec.describe "ActiveRecord::Base subclass with #actable" do
     end
   end
 
+  describe "#actable_reflection" do
+    it "returns an activerecord assosiation reflection" do
+      expect(Product.actable_reflection).to_not be_nil
+      expect(Product.actable_reflection).to be_a(ActiveRecord::Reflection::AssociationReflection)
+    end
+  end
+
   describe ".specific" do
     it "return specific submodel" do
       pen.save

data/spec/acts_as_spec.rb

@@ -30,6 +30,13 @@ RSpec.describe "ActiveRecord::Base model with #acts_as called" do
     end
   end
 
+  describe "#acting_as_reflection" do
+    it "returns an activerecord assosiation reflection" do
+      expect(Pen.acting_as_reflection).to_not be_nil
+      expect(Pen.acting_as_reflection).to be_a(ActiveRecord::Reflection::AssociationReflection)
+    end
+  end
+
   describe ".acting_as?" do
     it "returns true for supermodel class and name" do
       expect(pen.acting_as? :product).to be true
@@ -85,6 +92,7 @@ RSpec.describe "ActiveRecord::Base model with #acts_as called" do
   describe "#dup" do
     it "duplicates actable model as well" do
       p = pen.dup
+      expect(p).to be_a Pen
       expect(p.name).to eq('pen')
       expect(p.price).to eq(0.8)
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_record-acts_as
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Hassan Zamani
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-17 00:00:00.000000000 Z
+date: 2015-01-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sqlite3
@@ -85,6 +85,9 @@ dependencies:
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 4.1.2
   type: :runtime
@@ -92,6 +95,9 @@ dependencies:
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 4.1.2
 description: Simulate multi-table inheritance for activerecord models using a plymorphic
@@ -143,7 +149,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.1
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Simulate multi-table inheritance for activerecord models