active_record-acts_as 1.0.0.rc → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c137b5172e254e835624861325efa82e6ca2e609
-  data.tar.gz: c1836efae6258976e635b8232d1c7654b3e33838
+  metadata.gz: 3d5548c95a54d8cbe26c5714273ec3ca3a3bf0ff
+  data.tar.gz: 70a127389d745b09cf38eba99f120cc9fa42e692
 SHA512:
-  metadata.gz: 17f92b735d3520d7a66da1f75b6e7455963df6d1721557faceaca82c98949fbaab4110588f8254b94268dbeb30ddba1d6f1226424f1cf5edfb3e9e8db61effe2
-  data.tar.gz: 14117fe50dfde347a40a607ac783eca19aedbc46fe3c1a4d66a1bbdb594deb26c4e185d584fa68200c39ad020e7be4af6cc3908fe77356ebe346510015a51815
+  metadata.gz: 18d8183369e11b5b136f76e2b94d3d4ffad186113f1266031a92f6960abea9a45577ab5e718a5130b4b609939ea62f49f4993e0df777cf646d669ac074f0795c
+  data.tar.gz: cf442a282239a0a618dbf78b10ff234286537ba38fb2a5c78b098d9b3754ec268591405e9d4fbf6ee8eb2f5a20c9068fce9d922c28596227138012afb8835f71

data/README.md

@@ -16,11 +16,11 @@ A product has common attributes (`name`, `price`, `image` ...),
 while each type of product has its own attributes:
 for example a `pen` has `color`, a `book` has `author` and `publisher` and so on.
 With multiple-table-inheritance you can have a `products` table with common columns and
-a seprate table for each product type, i.e. a `pens` table with `color` column.
+a separate table for each product type, i.e. a `pens` table with `color` column.
 
 ## Requirements
 
-`AciveRecord ~> 4`
+`AciveRecord ~> 4.1.2` or newest
 
 ## Installation
 
@@ -121,7 +121,7 @@ You can give a name to all methods in `:as` option:
 
 ```Ruby
 class Product < ActiveRecord::Base
-  actable as: producible
+  actable as: :producible
 end
 
 class Pen < ActiveRecord::Base
@@ -133,10 +133,10 @@ change_table :products do |t|
 end
 ```
 
-`acts_as` support all `has_one` options, where defauls are there:
+`acts_as` support all `has_one` options, where defaults are there:
 `as: :actable, dependent: :destroy, validate: false, autosave: true`
 
-Make sure you know what you are doing when ovrewriting `validate` or `autodave` options.
+Make sure you know what you are doing when overwriting `validate` or `autodave` options.
 
 You can pass scope to `acts_as` as in `has_one`:
 
@@ -147,7 +147,7 @@ acts_as :person, -> { includes(:friends) }
 `actable` support all `belongs_to` options, where defaults are these:
 `polymorphic: true, dependent: :delete, autosave: true`
 
-Make sure you know what you are doing when ovrewriting `polymorphic` option.
+Make sure you know what you are doing when overwriting `polymorphic` option.
 
 
 ## Migrating from acts_as_relation
@@ -160,7 +160,7 @@ Replace `acts_as_superclass` in models with `actable` and if you where using
 
 1. Fork it ( https://github.com/hzamani/active_record-acts_as/fork )
 2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Test changes don't breake anything (`rspec`)
+3. Test changes don't break anything (`rspec`)
 4. Add specs for your new feature
 5. Commit your changes (`git commit -am 'Add some feature'`)
 6. Push to the branch (`git push origin my-new-feature`)

data/active_record-acts_as.gemspec

@@ -26,5 +26,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake", "~> 10"
 
   spec.add_dependency "activesupport", "~> 4"
-  spec.add_dependency "activerecord", "~> 4"
+  spec.add_dependency "activerecord", "~> 4.1.2"
 end

data/lib/active_record/acts_as/relation.rb

@@ -15,7 +15,7 @@ module ActiveRecord
 
           cattr_reader(:acting_as_reflection) { reflections[name.to_sym] }
           cattr_reader(:acting_as_name) { name.to_s }
-          cattr_reader(:acting_as_model) { name.to_s.camelize.constantize }
+          cattr_reader(:acting_as_model) { (options[:class_name] || name.to_s.camelize).constantize }
           class_eval "def acting_as() #{name} || build_#{name} end"
           alias_method :acting_as=, "#{name}=".to_sym
 

data/lib/active_record/acts_as/version.rb

@@ -1,6 +1,6 @@
 
 module ActiveRecord
   module ActsAs
-    VERSION = "1.0.0.rc"
+    VERSION = "1.0.0"
   end
 end

data/spec/actable_spec.rb

@@ -30,6 +30,11 @@ RSpec.describe "ActiveRecord::Base subclass with #actable" do
     end
   end
 
+  it "raises NoMethodError for undefined methods on specific" do
+    pen.save
+    expect{ pen.product.raise_error }.to raise_error(NoMethodError, /undefined method `non_existant_method' for #<Pen/)
+  end
+
   it "deletes specific subclass on destroy" do
     pen.save
     pen.product.destroy

data/spec/acts_as_spec.rb

@@ -14,6 +14,10 @@ RSpec.describe "ActiveRecord::Base model with #acts_as called" do
     expect(association.options).to have_key(:as)
   end
 
+  it "has a cattr_reader for the acting_as_model" do
+    expect(subject.acting_as_model).to eq Product
+  end
+
   describe "#acting_as?" do
     it "returns true for supermodel class and name" do
       expect(Pen.acting_as? :product).to be true
@@ -180,4 +184,19 @@ RSpec.describe "ActiveRecord::Base model with #acts_as called" do
       expect(relation.scope_for_create[:name]).to eq('new name')
     end
   end
+
+  context 'Namespaces' do
+    subject { Inventory::PenLid }
+
+    it "has a has_one relation" do
+      association = subject.reflect_on_all_associations.find { |r| r.name == :product_feature }
+      expect(association).to_not be_nil
+      expect(association.macro).to eq(:has_one)
+      expect(association.options).to have_key(:as)
+    end
+
+    it "has a cattr_reader for the acting_as_model" do
+      expect(subject.acting_as_model).to eq Inventory::ProductFeature
+    end
+  end
 end

data/spec/models.rb

@@ -9,6 +9,10 @@ class Product < ActiveRecord::Base
   def present
     "#{name} - $#{price}"
   end
+
+  def raise_error
+    specific.non_existant_method
+  end
 end
 
 class Pen < ActiveRecord::Base
@@ -21,6 +25,25 @@ class Store < ActiveRecord::Base
   has_many :products
 end
 
+module Inventory
+  class ProductFeature < ActiveRecord::Base
+    self.table_name = 'inventory_product_features'
+    actable
+    validates_presence_of :name, :price
+
+    def present
+      "#{name} - $#{price}"
+    end
+  end
+
+  class PenLid < ActiveRecord::Base
+    self.table_name = 'inventory_pen_lids'
+    acts_as :product_feature, class_name: 'Inventory::ProductFeature'
+
+    validates_presence_of :color
+  end
+end
+
 initialize_database do
   create_table :pens do |t|
     t.string :color
@@ -36,4 +59,14 @@ initialize_database do
   create_table :stores do |t|
     t.string :name
   end
+
+  create_table :inventory_pen_lids do |t|
+    t.string :color
+  end
+
+  create_table :inventory_product_features do |t|
+    t.string :name
+    t.float :price
+    t.actable
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_record-acts_as
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc
+  version: 1.0.0
 platform: ruby
 authors:
 - Hassan Zamani
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-29 00:00:00.000000000 Z
+date: 2014-08-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sqlite3
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4'
+        version: 4.1.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4'
+        version: 4.1.2
 description: Simulate multi-table inheritance for activerecord models using a plymorphic
   association
 email:
@@ -138,9 +138,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '1.9'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.2.2