active_pubsub 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e22f01f9cf4b2f63a384b21e4aa28b9623ef20b0
-  data.tar.gz: 2376b5d7171510a5087cfb021c50d105f0d480f3
+  metadata.gz: 4c4e0a20248f5de90d821e8e07db538c76dd121c
+  data.tar.gz: c3e9ffbf7d9faef44bf37393f38b39cfd3bfd806
 SHA512:
-  metadata.gz: f4fd96f0626db35b97853c803f8af0ace6746cce0910159187f18b504ddb3e6dbd1462d8f7ab9468f5d07c3090b0056aa24e61c52f8b0600a2ee3e72a0d1a7df
-  data.tar.gz: bb359a492946e1c60ca0d6cac8c50498c03573a3f03bc712bcfead4792915b8395fc51c0f5670a5994142439fc37bc6f258bd1c19f1b54c19688169eec541cf9
+  metadata.gz: 56af865a31f3bc9939f079c800191f9976a04d5039556d3e7721d74a9a59cda5e9d9560f439ec91fbaec689e0c5ae2f2ad09f5002ccf1cc529c525e009d560fb
+  data.tar.gz: 0604dcb58eec116f71ae5c964d87f5a455c5aae35a2d1708ab5fdeae84aa36028efc45f2557dc2910e10dddc4a5547756f5b30be0aae13e8fe049d210ad63f4b

data/README.md

@@ -39,6 +39,24 @@ class PostSubscriber < ::ActivePubsub::Subscriber
 end
 ```
 
+### Subscribe to individual attribute changes
+
+``` ruby
+class PostSubscriber < ::ActivePubsub::Subscriber
+  include ::ActivePubsub::SubscribeToChanges
+
+  # Note: Do NOT define updated as an event, as on_change
+  # uses updated event so latter event will override former
+  observes "cms"
+  as "aggregator"
+
+  on_change :title do |new_value, old_value|
+    puts record.inspect
+    puts new_value
+  end
+end
+```
+
 ## Publishing events
 
 Just include ::ActivePubsub::Publishable module into an active record class whose events you want to publish.

data/lib/active_pubsub.rb

@@ -37,8 +37,12 @@ module ActivePubsub
   end
 
   def self.start_subscribers
-    puts "Starting subscriber"
+
     ::ActivePubsub::Subscriber.subclasses.each do |subscriber|
+      next if subscriber.started?
+
+      puts "Starting #{subscriber.name}"
+
       subscriber.bind_subscriptions!
       subscriber.print_subscriptions!
     end
@@ -55,6 +59,7 @@ require "active_pubsub/config"
 require "active_pubsub/event"
 require "active_pubsub/publisher"
 require "active_pubsub/publishable"
-require "active_pubsub/subscriber"
 require "active_pubsub/publish_with_serializer"
+require "active_pubsub/subscriber"
+require "active_pubsub/subscribe_to_changes"
 require 'active_pubsub/railtie' if defined?(Rails)

data/lib/active_pubsub/publish_with_serializer.rb

@@ -9,13 +9,16 @@ module ActivePubsub
     end
 
     def serialized_resource
-       serialized_resource_attributes.merge!(:changes => previous_changes) if previous_changes
+      serialized_resource_attributes.merge!(:changes => previous_changes) if previous_changes
 
       ::Marshal.dump(serialized_resource_attributes)
     end
 
     def serialized_resource_attributes
-       @serialized_resource_attributes ||= self.class.publish_serializer.new(self).attributes
+       @serialized_resource_attributes ||= self.class
+                                               .publish_serializer.new(self)
+                                               .attributes
+                                               .symbolize_keys!
     end
 
     module ClassMethods

data/lib/active_pubsub/publishable.rb

@@ -21,6 +21,7 @@ module ActivePubsub
     def attributes_hash
       hash = self.as_json
       hash.merge!(:changes => previous_changes) if previous_changes && hash
+      hash.symbolize_keys! if hash
       hash
     end
 

data/lib/active_pubsub/subscribe_to_changes.rb

@@ -0,0 +1,26 @@
+module ActivePubsub
+  module SubscribeToChanges
+    extend ActiveSupport::Concern
+
+    included do
+      class_attribute :attributes_to_watch_for_changes
+      self.attributes_to_watch_for_changes = {}
+
+      on :updated do |changed_record|
+        attributes_to_watch_for_changes.each_pair do |field, block|
+          if changed_record[:changes].with_indifferent_access.has_key?(field)
+            old_value = changed_record[:changes][field][0]
+            new_value = changed_record[:changes][field][1]
+            instance_exec(new_value, old_value, &block)
+          end
+        end
+      end
+    end
+
+    module ClassMethods
+      def on_change(attribute_name, &block)
+        attributes_to_watch_for_changes[attribute_name] = block
+      end
+    end
+  end
+end

data/lib/active_pubsub/subscriber.rb

@@ -8,11 +8,16 @@ module ActivePubsub
     class_attribute :exchange_name
     class_attribute :connection
     class_attribute :local_service_namespace
+    class_attribute :started
 
-    self.events = {}
     self.connection = ::ActivePubsub::Connection.new
+    self.started = false
 
     ### Class Methods ###
+    def self.as(service_namespace)
+      self.local_service_namespace = service_namespace
+    end
+
     def self.channel
       connection.channel
     end
@@ -21,8 +26,8 @@ module ActivePubsub
       channel.topic(exchange_name, :auto_delete => true)
     end
 
-    def self.as(service_namespace)
-      self.local_service_namespace = service_namespace
+    def self.inherited(klass)
+      klass.events = {}
     end
 
     def self.on(event_name, &block)
@@ -30,6 +35,8 @@ module ActivePubsub
     end
 
     def self.bind_subscriptions!
+      return if started?
+
       events.each_pair do |event_name, block|
         channel.queue(queue_for_event(event_name.to_s))
                .bind(exchange, :routing_key => routing_key_for_event(event_name))
@@ -41,6 +48,8 @@ module ActivePubsub
           subscriber_instance.instance_exec(deserialized_record, &block)
         end
       end
+
+      self.started = true
     end
 
     def self.deserialize_event(event)
@@ -74,6 +83,10 @@ module ActivePubsub
       puts message
     end
 
+    def self.started?
+      self.started
+    end
+
     ### Instance Methods ###
     attr_accessor :record
 

data/lib/active_pubsub/version.rb

@@ -1,3 +1,3 @@
 module ActivePubsub
-  VERSION = "0.0.6"
+  VERSION = "0.0.7"
 end

data/spec/active_pubsub/publishable_spec.rb

@@ -24,7 +24,7 @@ describe ::ActivePubsub::Publishable do
           let(:created_record) { ::Fake::Blog::Post.create!(:title => "Post about nothing") }
 
           it "should merge previous changes" do
-            expect(created_record.attributes_hash).to have_key("title")
+            expect(created_record.attributes_hash).to have_key(:title)
           end
         end
       end

data/spec/active_pubsub/subscribe_to_changes_spec.rb

@@ -0,0 +1,42 @@
+require 'spec_helper'
+require 'support/subscribers/author_subscriber'
+
+describe ::ActivePubsub::SubscribeToChanges do
+  before do
+    ::ActivePubsub.start_subscribers
+  end
+
+  subject { ::AuthorSubscriber }
+
+  let(:fake_author) { ::Fake::Blog::Author.create!(:first_name => "Bill", :last_name => "Lumberg") }
+  let(:fake_post) { ::Fake::Blog::Post.create!(:title => "Fake post by #{fake_author.first_name}", :author_id => fake_author.id) }
+
+  its(:attributes_to_watch_for_changes) {
+    should have_key(:first_name)
+  }
+
+  describe "#on_change" do
+    context "when author last name is changed" do
+      it "does not update titles" do
+        fake_post
+
+        fake_author.last_name = "Bolton"
+        fake_author.save
+
+        fake_author.posts.last.title.should eq "Fake post by Bill"
+      end
+    end
+
+    context "when author first name is changed" do
+      # ghetto, but since its async we need to sleep to see update
+      it "updates all titles with new author name" do
+        fake_post
+
+        fake_author.first_name = "Michael"
+        fake_author.save
+        sleep(0.5)
+        fake_author.posts.last.title.should eq "Fake post by Michael"
+      end
+    end
+  end
+end

data/spec/active_pubsub/subscriber_spec.rb

@@ -0,0 +1,51 @@
+require 'spec_helper'
+
+describe ActivePubsub::Subscriber do
+
+  subject { ::PostSubscriber }
+
+  its(:events) { should have_key(:created) }
+  its(:events) { should have_key(:destroyed) }
+  its(:events) { should have_key(:updated) }
+  its(:exchange_name) { should eq "test.post" }
+  its(:local_service_namespace) { should eq "test" }
+  its(:started) { should be true }
+  its(:connection) { should be_a(ActivePubsub::Connection) }
+
+  describe ".on" do
+    context ":created" do
+      let!(:fake_author) { ::Fake::Blog::Author.create!(:first_name => "Samir", :last_name => "Nyininejad") }
+      let!(:fake_post) { ::Fake::Blog::Post.create!(:title => "myblogpost", :author_id => fake_author.id) }
+
+      it "should increment post_count" do
+        sleep(0.1)
+        ::Fake::Blog::AuthorPostReport.find_by(:author_id => fake_author.id).post_count.should eq 1
+      end
+    end
+
+    context ":destroyed" do
+      let!(:fake_author) { ::Fake::Blog::Author.create!(:first_name => "Samir", :last_name => "Nyininejad") }
+      let!(:fake_post) { ::Fake::Blog::Post.create!(:title => "myblogpost", :author_id => fake_author.id) }
+
+      it "should destroy author post report" do
+        fake_post.destroy
+        sleep(0.1)
+        ::Fake::Blog::AuthorPostReport.where(:author_id => fake_author.id).first.should be_nil
+      end
+    end
+
+    context ":updated" do
+      let!(:fake_author) { ::Fake::Blog::Author.create!(:first_name => "Samir", :last_name => "Nyininejad") }
+      let!(:fake_post) { ::Fake::Blog::Post.create!(:title => "myblogpost", :author_id => fake_author.id) }
+
+      it "should update author last name with author_id" do
+        fake_post.title = "Asdfg"
+        fake_post.save
+
+        sleep(0.1)
+
+        fake_author.reload.last_name.should eq "author_#{fake_author.id}"
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -9,6 +9,9 @@ SimpleCov.start do
 end
 
 RSpec.configure do |config|
+  config.before(:suite) do
+    ::ActivePubsub.start_subscribers
+  end
 end
 
 Bundler.require(:default, :development, :test)

data/spec/support/db/setup.rb

@@ -14,16 +14,20 @@ ActiveRecord::Schema.define(:version => 1) do
     t.string :body
     t.string :title
     t.string :slug
-    t.integer :user_id
+    t.integer :author_id
 
     t.timestamps
   end
 
+  create_table :author_post_reports do |t|
+    t.integer :author_id
+    t.integer :post_count
+  end
+
   create_table :authors do |t|
     t.string :first_name
     t.string :last_name
     t.string :slug
-    t.integer :user_id
 
     t.timestamps
   end

data/spec/support/models/author.rb

@@ -9,6 +9,8 @@ module Fake
       serialize_publish_with ::AuthorSerializer
 
       publish_as "test"
+
+      has_many :posts, :class_name => "Fake::Blog::Post"
     end
   end
 end

data/spec/support/models/author_post_report.rb

@@ -0,0 +1,9 @@
+module Fake
+  module Blog
+    class AuthorPostReport < ::ActiveRecord::Base
+      # after_initialize do
+      #   self[:post_count] ||= 0
+      # end
+    end
+  end
+end

data/spec/support/models/post.rb

@@ -5,6 +5,8 @@ module Fake
       include ::ActivePubsub::Publishable
 
       publish_as "test"
+
+      belongs_to :author, :class_name => "Fake::Blog::Author"
     end
   end
 end

data/spec/support/subscribers/author_subscriber.rb

@@ -0,0 +1,16 @@
+class AuthorSubscriber < ::ActivePubsub::Subscriber
+  include ::ActivePubsub::SubscribeToChanges
+
+  observes "test.author"
+  as "test"
+
+  on_change :first_name do |new_value, old_value|
+    author.posts.update_all(:title => "Fake post by #{new_value}")
+  end
+
+  private
+
+  def author
+    @author ||= ::Fake::Blog::Author.find(record[:id])
+  end
+end

data/spec/support/subscribers/post_subscriber.rb

@@ -0,0 +1,30 @@
+class PostSubscriber < ::ActivePubsub::Subscriber
+
+  observes "test.post"
+  as "test"
+
+  # Pointless as examples, but being used for integration testing
+
+  on :created do
+    author_post_report.increment!(:post_count) if record.has_key?(:author_id)
+  end
+
+  on :updated do
+    author.last_name = "author_#{record[:author_id]}"
+    author.save
+  end
+
+  on :destroyed do
+    author_post_report.destroy
+  end
+
+  private
+
+  def author
+    @author ||= ::Fake::Blog::Author.find(record[:author_id])
+  end
+
+  def author_post_report
+    @author_post_report ||= ::Fake::Blog::AuthorPostReport.where(:author_id => record[:author_id]).first_or_create
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_pubsub
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Jason Ayre
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-20 00:00:00.000000000 Z
+date: 2014-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_attr
@@ -318,6 +318,7 @@ files:
 - lib/active_pubsub/publishable.rb
 - lib/active_pubsub/publisher.rb
 - lib/active_pubsub/railtie.rb
+- lib/active_pubsub/subscribe_to_changes.rb
 - lib/active_pubsub/subscriber.rb
 - lib/active_pubsub/version.rb
 - spec/active_pubsub/config_spec.rb
@@ -325,13 +326,16 @@ files:
 - spec/active_pubsub/publish_with_serializer_spec.rb
 - spec/active_pubsub/publishable_spec.rb
 - spec/active_pubsub/publisher_spec.rb
+- spec/active_pubsub/subscribe_to_changes_spec.rb
+- spec/active_pubsub/subscriber_spec.rb
 - spec/spec_helper.rb
 - spec/support/db/setup.rb
-- spec/support/models.rb
 - spec/support/models/author.rb
+- spec/support/models/author_post_report.rb
 - spec/support/models/post.rb
-- spec/support/serializers.rb
 - spec/support/serializers/author_serializer.rb
+- spec/support/subscribers/author_subscriber.rb
+- spec/support/subscribers/post_subscriber.rb
 - spec/test.db
 homepage: https://github.com/jasonayre/active_pubsub
 licenses:
@@ -364,11 +368,14 @@ test_files:
 - spec/active_pubsub/publish_with_serializer_spec.rb
 - spec/active_pubsub/publishable_spec.rb
 - spec/active_pubsub/publisher_spec.rb
+- spec/active_pubsub/subscribe_to_changes_spec.rb
+- spec/active_pubsub/subscriber_spec.rb
 - spec/spec_helper.rb
 - spec/support/db/setup.rb
-- spec/support/models.rb
 - spec/support/models/author.rb
+- spec/support/models/author_post_report.rb
 - spec/support/models/post.rb
-- spec/support/serializers.rb
 - spec/support/serializers/author_serializer.rb
+- spec/support/subscribers/author_subscriber.rb
+- spec/support/subscribers/post_subscriber.rb
 - spec/test.db

data/spec/support/models.rb

@@ -1 +0,0 @@
-require 'support/models/post'

data/spec/support/serializers.rb

@@ -1 +0,0 @@
-require 'support/serializers/author_serializer'