active_pubsub 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bcd064945fb467cc30fd67d30c752ef2a519dff0
-  data.tar.gz: e96a5f3b33bc9f1479f28b2633bf9e81c40e57d1
+  metadata.gz: e22f01f9cf4b2f63a384b21e4aa28b9623ef20b0
+  data.tar.gz: 2376b5d7171510a5087cfb021c50d105f0d480f3
 SHA512:
-  metadata.gz: bc686f2b420a0b8640bcc7a27fc49a28388541c4975bd0392aa4cbc62eb269bb303a35d4ef948b90daf467896239ec0f6fb803a2391d6520e20b195193f069ef
-  data.tar.gz: 131fc0cb89d24fae8ee7248a72c07dad38e642c7ec2f01666a4e7fb68fd2cc19703ac188d8a2141a929bbd971ad5e08f705907c2104f36b32b28ea23a071ddf9
+  metadata.gz: f4fd96f0626db35b97853c803f8af0ace6746cce0910159187f18b504ddb3e6dbd1462d8f7ab9468f5d07c3090b0056aa24e61c52f8b0600a2ee3e72a0d1a7df
+  data.tar.gz: bb359a492946e1c60ca0d6cac8c50498c03573a3f03bc712bcfead4792915b8395fc51c0f5670a5994142439fc37bc6f258bd1c19f1b54c19688169eec541cf9

data/active_pubsub.gemspec

@@ -38,5 +38,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'guard-bundler', '~> 2'
   spec.add_development_dependency 'rb-fsevent'
   spec.add_development_dependency 'terminal-notifier-guard'
+  spec.add_development_dependency "active_model_serializers"
 
 end

data/lib/active_pubsub/publish_with_serializer.rb

@@ -2,18 +2,22 @@ module ActivePubsub
   module PublishWithSerializer
     extend ActiveSupport::Concern
 
-    #todo: move this into separate gem
+    #todo: move this into separate gem?
 
     included do
       class_attribute :publish_serializer
     end
 
     def serialized_resource
-       serialized_resource_attributes = self.class.publish_serializer.new(self).attributes
-       serialized_resource_attributes.merge!("changes" => changes) if self.changed?
+       serialized_resource_attributes.merge!(:changes => previous_changes) if previous_changes
+
       ::Marshal.dump(serialized_resource_attributes)
     end
 
+    def serialized_resource_attributes
+       @serialized_resource_attributes ||= self.class.publish_serializer.new(self).attributes
+    end
+
     module ClassMethods
       def serialize_publish_with(klass)
         self.publish_serializer = klass

data/lib/active_pubsub/publishable.rb

@@ -17,8 +17,11 @@ module ActivePubsub
       ::ActivePubsub::Publisher.increment_publishable_model_count!
     end
 
+    ### todo: investigate why specs break if && hash is omitted
     def attributes_hash
-      attributes.merge!("changes" => changes)
+      hash = self.as_json
+      hash.merge!(:changes => previous_changes) if previous_changes && hash
+      hash
     end
 
     private

data/lib/active_pubsub/version.rb

@@ -1,3 +1,3 @@
 module ActivePubsub
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/spec/active_pubsub/publish_with_serializer_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+describe ::ActivePubsub::PublishWithSerializer do
+  subject { ::Fake::Blog::Author }
+  let(:publisher) { ::ActivePubsub.publisher }
+
+  context "ClassMethods" do
+    its(:publish_serializer) { should eq ::AuthorSerializer }
+  end
+
+  context "InstanceMethods" do
+    subject{ ::Fake::Blog::Author.new(:first_name => "whatever") }
+
+    its (:serialized_resource_attributes) { should have_key(:first_name) }
+
+    describe "#serialized_resource" do
+      it "should dump serialized resource attributes" do
+        Marshal.should_receive(:dump).with(subject.serialized_resource_attributes)
+
+        subject.serialized_resource
+      end
+    end
+  end
+end

data/spec/active_pubsub/publishable_spec.rb

@@ -11,6 +11,24 @@ describe ::ActivePubsub::Publishable do
     end
 
     context "Instance Methods" do
+      describe "#attributes_hash" do
+        #had to do some hackyness in attributes_hash method to get this to pass
+        #and not sure why, but as_json was coming back nil
+        it "should call as json" do
+          instance_subject.should_receive(:as_json)
+
+          instance_subject.attributes_hash
+        end
+
+        context "when attributes are changed" do
+          let(:created_record) { ::Fake::Blog::Post.create!(:title => "Post about nothing") }
+
+          it "should merge previous changes" do
+            expect(created_record.attributes_hash).to have_key("title")
+          end
+        end
+      end
+
       describe "#publish_updated_event" do
         let(:created_record) { ::Fake::Blog::Post.create!(:title => "Post about nothing") }
 

data/spec/support/db/setup.rb

@@ -18,4 +18,13 @@ ActiveRecord::Schema.define(:version => 1) do
 
     t.timestamps
   end
-end
+
+  create_table :authors do |t|
+    t.string :first_name
+    t.string :last_name
+    t.string :slug
+    t.integer :user_id
+
+    t.timestamps
+  end
+end

data/spec/support/models/author.rb

@@ -0,0 +1,14 @@
+require 'active_record'
+require_relative '../../support/serializers/author_serializer.rb'
+module Fake
+  module Blog
+    class Author < ::ActiveRecord::Base
+      include ::ActivePubsub::Publishable
+      include ::ActivePubsub::PublishWithSerializer
+
+      serialize_publish_with ::AuthorSerializer
+
+      publish_as "test"
+    end
+  end
+end

data/spec/support/serializers/author_serializer.rb

@@ -0,0 +1,3 @@
+class AuthorSerializer < ActiveModel::Serializer
+  attributes :id, :first_name
+end

data/spec/support/serializers.rb

@@ -0,0 +1 @@
+require 'support/serializers/author_serializer'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_pubsub
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Jason Ayre
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-16 00:00:00.000000000 Z
+date: 2014-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_attr
@@ -276,6 +276,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: active_model_serializers
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Uses RabbitMQ and ActiveRecord for publishing and consuming model events
   from any service
 email:
@@ -308,12 +322,16 @@ files:
 - lib/active_pubsub/version.rb
 - spec/active_pubsub/config_spec.rb
 - spec/active_pubsub/connection_spec.rb
+- spec/active_pubsub/publish_with_serializer_spec.rb
 - spec/active_pubsub/publishable_spec.rb
 - spec/active_pubsub/publisher_spec.rb
 - spec/spec_helper.rb
 - spec/support/db/setup.rb
 - spec/support/models.rb
+- spec/support/models/author.rb
 - spec/support/models/post.rb
+- spec/support/serializers.rb
+- spec/support/serializers/author_serializer.rb
 - spec/test.db
 homepage: https://github.com/jasonayre/active_pubsub
 licenses:
@@ -343,10 +361,14 @@ summary: Pubsub using RabbitMQ and ActiveRecord, observe model events from diffe
 test_files:
 - spec/active_pubsub/config_spec.rb
 - spec/active_pubsub/connection_spec.rb
+- spec/active_pubsub/publish_with_serializer_spec.rb
 - spec/active_pubsub/publishable_spec.rb
 - spec/active_pubsub/publisher_spec.rb
 - spec/spec_helper.rb
 - spec/support/db/setup.rb
 - spec/support/models.rb
+- spec/support/models/author.rb
 - spec/support/models/post.rb
+- spec/support/serializers.rb
+- spec/support/serializers/author_serializer.rb
 - spec/test.db