active_presenter 0.0.1 → 0.0.2

data/Rakefile

@@ -8,12 +8,3 @@ task :default => :test
 task :test do
   Dir['test/**/*_test.rb'].each { |l| require l }
 end
-
-desc 'Generate documentation for the ResourceController plugin.'
-Rake::RDocTask.new(:rdoc) do |rdoc|
-  rdoc.rdoc_dir = 'rdoc'
-  rdoc.title    = 'ActivePresenter'
-  rdoc.options << '--line-numbers' << '--inline-source'
-  rdoc.rdoc_files.include('README')
-  rdoc.rdoc_files.include('lib/**/*.rb')
-end

data/lib/active_presenter/base.rb

@@ -58,7 +58,7 @@ module ActivePresenter
     # Set the attributes of the presentable instances using the type_attribute form (i.e. user_login => 'james')
     #
     def attributes=(attrs)
-      attrs.each { |k,v| send("#{k}=", v) }
+      attrs.each { |k,v| send("#{k}=", v) unless attribute_protected?(k)}
     end
     
     # Makes sure that the presenter is accurate about responding to presentable's attributes, even though they are handled by method_missing.
@@ -145,7 +145,8 @@ module ActivePresenter
       end
     
       def presented_attribute?(method_name)
-        !presentable_for(method_name).nil?
+        p = presentable_for(method_name)
+        !p.nil? && send(p).respond_to?(flatten_attribute_name(method_name,p))
       end
       
       def flatten_attribute_name(name, type)
@@ -161,5 +162,11 @@ module ActivePresenter
           errors.add(attribute_prefix(type)+att, msg)
         end
       end
+      
+      def attribute_protected?(name)
+        presentable    = presentable_for(name)
+        flat_attribute = {flatten_attribute_name(name, presentable) => ''} #remove_att... normally takes a hash, so we use a ''
+        presentable.to_s.classify.constantize.new.send(:remove_attributes_protected_from_mass_assignment, flat_attribute).empty?
+      end
   end
 end

data/lib/active_presenter/version.rb

@@ -2,7 +2,7 @@ module ActivePresenter
   module VERSION
     MAJOR    = 0
     MINOR    = 0
-    TINY     = 1
+    TINY     = 2
     
     STRING   = [MAJOR, MINOR, TINY].join('.')
   end

data/lib/tasks/doc.rake

@@ -0,0 +1,19 @@
+desc 'Generate documentation for the ResourceController plugin.'
+Rake::RDocTask.new(:rdoc) do |rdoc|
+  rdoc.rdoc_dir = 'rdoc'
+  rdoc.title    = 'ActivePresenter'
+  rdoc.options << '--line-numbers' << '--inline-source'
+  rdoc.rdoc_files.include('README')
+  rdoc.rdoc_files.include('lib/**/*.rb')
+end
+
+task :upload_docs => :rdoc do
+  puts 'Deleting previous rdoc'
+  `ssh jamesgolick.com 'rm -Rf /home/apps/jamesgolick.com/public/active_presenter/rdoc'`
+  
+  puts "Uploading current rdoc"
+  `scp -r rdoc jamesgolick.com:/home/apps/jamesgolick.com/public/active_presenter/rdoc`
+  
+  puts "Deleting rdoc"
+  `rm -Rf rdoc`
+end

data/test/base_test.rb

@@ -17,6 +17,10 @@ Expectations do
     SignupPresenter.new(:user_login => 'james')
   end
   
+  # admin= should be protected from mass assignment
+  expect SignupPresenter.new.to.be.attribute_protected?(:user_admin)
+  expect SignupPresenter.new(:user_admin => true).user.not.to.be.admin?
+  
   expect 'mymockvalue' do
     User.any_instance.stubs(:login).returns('mymockvalue')
     SignupPresenter.new.user_login
@@ -101,6 +105,7 @@ Expectations do
   expect SignupPresenter.new(:user => User.new(hash_for_user)).to.be.save!
   
   expect SignupPresenter.new.to.be.respond_to?(:user_login)
+  expect SignupPresenter.new.to.be.respond_to?(:user_password_confirmation)
   expect SignupPresenter.new.to.be.respond_to?(:valid?) # just making sure i didn't break everything :)
   
   expect User.create!(hash_for_user).not.to.be.login_changed? do |user|

data/test/test_helper.rb

@@ -1,9 +1,13 @@
 require File.dirname(__FILE__)+'/../lib/active_presenter'
 require 'expectations'
+require 'logger'
 
 ActiveRecord::Base.configurations = {'sqlite3' => {:adapter => 'sqlite3', :database => ':memory:'}}
 ActiveRecord::Base.establish_connection('sqlite3')
 
+ActiveRecord::Base.logger = Logger.new(STDERR)
+ActiveRecord::Base.logger.level = Logger::WARN
+
 ActiveRecord::Schema.define(:version => 0) do
   create_table :users do |t|
     t.boolean :admin,    :default => false
@@ -19,6 +23,8 @@ end
 
 class User < ActiveRecord::Base
   validates_presence_of :login, :password
+  attr_accessible :login, :password
+  attr_accessor   :password_confirmation
 end
 class Account < ActiveRecord::Base; end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: active_presenter
 version: !ruby/object:Gem::Version 
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors: 
 - James Golick & Daniel Haran
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-07-27 00:00:00 -04:00
+date: 2008-07-28 00:00:00 -04:00
 default_executable: 
 dependencies: []
 
@@ -30,6 +30,7 @@ files:
 - lib/active_presenter/version.rb
 - lib/active_presenter.rb
 - lib/tasks
+- lib/tasks/doc.rake
 - lib/tasks/gem.rake
 - test/base_test.rb
 - test/test_helper.rb