active_poro 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b338750e482aee089da8aadb601c00da369e062f
-  data.tar.gz: fdf0737739226fec8f4c5b4fa5f62bbac77fefcf
+  metadata.gz: 3286adee5f545522ce345124881eef5115a971c7
+  data.tar.gz: ae3738aa15aa080e96b0007f7795d84078aafd07
 SHA512:
-  metadata.gz: eb82d3cf0f5fb6b78c66bfc64b664cdf39b0d0895116c58a9f138d373b640c4b5985ecf7bc8df9044bf28e7657ccc0e30ced3fa886bb6578e7dd4aa131b9b8d5
-  data.tar.gz: 6cc328b1058c513a0efab6c355611e3bc169f50301b69ac78328d1c4d94893e9f9ae7990b5adb091fd5bfb1cd7b43ad109a01b199a22edffc15c1329850367ae
+  metadata.gz: ec03afae6e91b65a42848405c2b65fb07a7e01b862b8131613f690f4eb67c7aa08c9c882c579f2cdcf99353f7afcb56b51c133902aa54f9e7a7a620f54b85915
+  data.tar.gz: fa60eedcaee6d2753a1ca749744cfbcb461808d97b3964ee2c90764d127a5dbf36175753143ff5389fc8c917734ad4858984622ea37e481d1c9c7beb6e313c62

data/README.md

@@ -82,6 +82,8 @@ another_dog.fleas
 #=> [flea_b] # simplified output, not actual output on the console
 ```
 
+This also works with has_one and belongs_to as expected.
+
 ## Contributing
 
 1. Fork it ( https://github.com/codescrum/active_poro/fork )

data/lib/active_poro/relations.rb

@@ -11,8 +11,12 @@ module ActivePoro
 
         # define setter method
         define_method "#{target_name}=" do |members|
+
+          # nil to empty
+          members ||= []
+
           # set the instance variable only if I am now the rightful owner
-          instance_variable_set("@#{target_name}", members || [])
+          instance_variable_set("@#{target_name}", members)
           reflected_association_name = self.class.name.underscore
           members.each do |member|
 
@@ -47,10 +51,10 @@ module ActivePoro
         # define setter method
         define_method "#{target_name}=" do |member|
           reflected_association_name = self.class.name.underscore
-          unless member.send(reflected_association_name) == self
+          if member.respond_to?(reflected_association_name) && member.send(reflected_association_name) != self
             member.send "#{reflected_association_name}=", self
           end
-          instance_variable_set("@#{target_name}", (member || nil))
+          instance_variable_set("@#{target_name}", member)
         end
       end
 
@@ -66,10 +70,8 @@ module ActivePoro
           instance_variable_set("@#{target_name}", member)
           reflected_association_name = self.class.name.underscore
           # add myself to reflected association
-          if member.respond_to? reflected_association_name
-            unless member.send(reflected_association_name) == self
-              member.send("#{reflected_association_name}=", self)
-            end
+          if member.respond_to?(reflected_association_name) && member.send(reflected_association_name) != self
+            member.send("#{reflected_association_name}=", self)
           elsif member.respond_to? reflected_association_name.pluralize
             reflected_members = member.send(reflected_association_name.pluralize)
             unless reflected_members.include? self

data/lib/active_poro/version.rb

@@ -1,3 +1,3 @@
 module ActivePoro
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/active_poro_spec.rb

@@ -37,6 +37,21 @@ describe 'ActivePoro' do
           expect(car.driver).to eq(driver)
         end
 
+        context 'when the car is transferred to another owner/driver' do
+          let(:another_driver){ Driver.new('Bob') }
+          it 'detaches the car from the previous owner' do
+            car.driver = driver
+            expect(driver.car).to eq(car)
+            expect(car.driver).to eq(driver)
+
+            # car changes owner
+            car.driver = another_driver
+            expect(driver.car).to be_nil
+            expect(car.driver).to eq(another_driver)
+            expect(another_driver.car).to eq(car)
+          end
+        end
+
       end
 
       context 'has_many + belongs_to' do

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
 require 'rubygems'
+require 'pry'
 
 ######################
 require 'active_poro'#

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_poro
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Miguel Diaz