active_notifier 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bd10b598192c1508228777489f96764cd880b15da9ab6978250abf8fa5ac19ca
-  data.tar.gz: 002bbc7be0c8a7cc89490a9b863978150d870ac3ce12afa4a641ca76bbeffbda
+  metadata.gz: 8919ed9bb7359c3c50bc1501c733507015b25f9b158f309dd522f38fc4058663
+  data.tar.gz: 6b7e4c32efce34c3b111a1b9a52ddcb6e119a8302c1053411f8132be02e0d37d
 SHA512:
-  metadata.gz: 14469a324d498c52244cb44053cf310e185f68053aeec83f8f286cffdf52ad2510ef9241fbef246354a9ba9cf597f19127eefa82cffa04b585c2521fbbc91c7c
-  data.tar.gz: 0aba370debb2b69d882165c7dbcc855ee1c6a5194facb0cd03007e0b23af4147996a3e18ef673a3f6f7d60d6d9f3397a1562652aadc1fefc984598c99eaa2bc3
+  metadata.gz: e943777261d19d6ac66da441ffbb899cee74a686b46a91aad7b0a871863b06cc8b7ea9ad5d255ee0a59644307a502fe6965b428d7a9c1bff28a05bad9f5542d9
+  data.tar.gz: 32a64dcc3fde456796fba803c42b1a347e33206b9170f490491c577b111e9c4a72d2a72124fa08bbfc03ae6a2f08f00d007a39af14cd398bc72b879b2f6e136c

data/.gitignore

@@ -9,3 +9,4 @@
 .byebug_history
 .DS_Store
 Gemfile.lock
+.ruby-version

data/.rubocop.yml

@@ -5,27 +5,19 @@ AllCops:
     - 'vendor/**/*'
 Metrics/LineLength:
   Max: 120
-Style/AsciiComments:
-  Enabled: false
-Style/FrozenStringLiteralComment:
-  Enabled: false
-Style/Documentation:
-  Enabled: false
-Style/BlockComments:
-  Enabled: false
 Metrics/MethodLength:
-  Max: 30
+  Max: 30 # default * 3
 Metrics/AbcSize:
-  Max: 30
-Style/StringLiterals:
-  Enabled: false
-Style/BlockDelimiters:
-  Enabled: false
+  Max: 50 # default * 2
 Metrics/ModuleLength:
   Exclude:
     - "**/*_spec.rb"
 Metrics/BlockLength:
   Exclude:
     - "**/*_spec.rb"
-Style/DoubleNegation:
-  Enabled: false
+Style/FrozenStringLiteralComment:
+  EnforcedStyle: never
+Style/StringLiterals:
+   EnforcedStyle: double_quotes
+Style/BlockDelimiters:
+  EnforcedStyle: braces_for_chaining

data/.travis.yml

@@ -1,5 +1,7 @@
 language: ruby
 rvm:
+  - 2.3.7
+  - 2.4.4
   - 2.5.1
 cache: bundler
 script:

data/README.md

@@ -103,7 +103,7 @@ Notifer.exec(...)
 
 * [More Examples](https://github.com/pinewong/active_notifier/blob/master/spec/active_notifier_spec.rb)
 * [RDoc](https://www.rubydoc.info/github/pinewong/active_notifier)
-* [Gem RDoc](http://www.rubydoc.info/gems/active_notifier/0.4.0)
+* [Gem RDoc](http://www.rubydoc.info/gems/active_notifier/0.4.1)
 
 ## Development
 

data/lib/active_notifier/configurable.rb

@@ -1,7 +1,9 @@
 module ActiveNotifier
+  # ActiveNotifier support for configuration
   module Configurable
     extend ActiveSupport::Concern
 
+    # Core functions for Configuration
     module ClassMethods
       # Configure for ActiveNotifier.
       #
@@ -22,6 +24,7 @@ module ActiveNotifier
       end
     end
 
+    # Store the configuration data
     class Configuration
       # Alias const for ActiveNotifier
       # @!attribute [r]

data/lib/active_notifier/core_ext/erb/result_with_hash.rb

@@ -0,0 +1,24 @@
+# Add #result_with_hash for version less than 2.5
+class ERB
+  if RUBY_VERSION < "2.5"
+    def result_with_hash(hash)
+      b = new_toplevel(hash.keys)
+      hash.each_pair do |key, value|
+        b.local_variable_set(key, value)
+      end
+      result(b)
+    end
+
+    private
+
+    # File lib/erb.rb, line 901
+    def new_toplevel(vars = nil)
+      b = TOPLEVEL_BINDING
+      if vars
+        vars = vars.select { |v| b.local_variable_defined?(v) }
+        return b.eval("tap {|;#{vars.join(',')}| break binding}") unless vars.empty?
+      end
+      b.dup
+    end
+  end
+end

data/lib/active_notifier/core_ext/net/http/post.rb

@@ -0,0 +1,12 @@
+module Net
+  # Add ::post for version less than 2.4 and change ::post for version 2.4
+  class HTTP
+    if RUBY_VERSION < "2.5"
+      def self.post(url, data, header = nil)
+        start(url.hostname, url.port, use_ssl: url.scheme == "https") do |http|
+          http.post(url, data, header)
+        end
+      end
+    end
+  end
+end

data/lib/active_notifier/notifiable.rb

@@ -1,7 +1,9 @@
 module ActiveNotifier
+  # The third notifier implement
   module Notifiable
     extend ActiveSupport::Concern
 
+    # Core functions for Notifiable
     module ClassMethods
       # Message execute.
       #

data/lib/active_notifier/notifier.rb

@@ -2,6 +2,7 @@ require "active_notifier/notifier_adapters/abstract"
 require "active_notifier/notifier_adapters/dingtalk"
 
 module ActiveNotifier
+  # The third adaptable notifier that need implement
   class Notifier < ActiveAdapter::Engine
   end
 end

data/lib/active_notifier/notifier_adapters/abstract.rb

@@ -1,5 +1,6 @@
 module ActiveNotifier
   module NotifierAdapters
+    # Define the interface for ActiveNotifier::Notifier adapter
     class Abstract < ActiveAdapter::Abstract
       # Notify message
       #

data/lib/active_notifier/notifier_adapters/dingtalk.rb

@@ -1,12 +1,13 @@
 module ActiveNotifier
   module NotifierAdapters
+    # Dingtalk implement for ActiveNotifier::Notifier adapter
     class Dingtalk < ActiveAdapter::Implement
       VALID_TYPES = %i[text markdown].freeze
 
       # (see NotifierAdapters::Abstract#notify)
-      # @param title [#to_s]
-      # @param at_mobiles [#to_a] ([])
-      # @param is_at_all [Boolean] (false)
+      # @option options [#to_s] :title
+      # @option options [#to_a] :at_mobiles
+      # @option options [Boolean] :is_at_all
       def notify(token, type, message, **options)
         webhook = "#{ActiveNotifier.config.adapters_with_base_url.fetch(:dingtalk)}#{token}"
         unless VALID_TYPES.include?(type)
@@ -17,26 +18,35 @@ module ActiveNotifier
           error_message = "Message of the Dingtalk adapter can't be blank, please check template file"
           raise ActiveNotifier::AdapterError, error_message
         end
-        at_mobiles = options[:at_mobiles].to_a
-        is_at_all = !!options[:is_at_all]
-
-        body = case type
-               when :text
-                 get_text_body(message, at_mobiles, is_at_all)
-               when :markdown
-                 title = options[:title].to_s
-                 raise ActiveNotifier::AdapterError, "Dingtalk adapter require other options: title" if title.empty?
-                 get_markdown_body(title, message, at_mobiles, is_at_all)
-               end
+        body = get_body(type, message, **options)
         headers = {
-          'Content-Type' => 'application/json',
-          'Accept' => 'application/json'
+          "Content-Type" => "application/json",
+          "Accept" => "application/json"
         }
         Net::HTTP.post(URI(webhook), body.to_json, headers)
       end
 
       private
 
+      # @param type [Symbol]
+      # @param message [String]
+      # @param options [Hash]
+      # @option options [#to_s] :title
+      # @option options [#to_a] :at_mobiles
+      # @option options [Boolean] :is_at_all
+      def get_body(type, message, **options)
+        at_mobiles = options[:at_mobiles].to_a
+        is_at_all = options[:is_at_all] ? true : false
+        case type
+        when :text
+          get_text_body(message, at_mobiles, is_at_all)
+        when :markdown
+          title = options[:title].to_s
+          raise ActiveNotifier::AdapterError, "Dingtalk adapter require other options: title" if title.empty?
+          get_markdown_body(title, message, at_mobiles, is_at_all)
+        end
+      end
+
       def get_text_body(content, at_mobiles, is_at_all)
         {
           msgtype: "text",

data/lib/active_notifier/version.rb

@@ -1,3 +1,3 @@
 module ActiveNotifier
-  VERSION = "0.4.0".freeze
+  VERSION = "0.4.1".freeze
 end

data/lib/active_notifier.rb

@@ -1,14 +1,16 @@
 require "net/http"
 require "active_support/all"
 require "active_adapter"
-require "active_notifier/version"
-require "active_notifier/notifier"
 
+Dir["#{File.expand_path(__dir__)}/active_notifier/core_ext/**/*.rb"].each { |file| require file }
+require "active_notifier/configurable"
+require "active_notifier/notifiable"
+
+# Notify message through webhooks
 module ActiveNotifier
   extend ActiveSupport::Autoload
 
-  autoload :Configurable
-  autoload :Notifiable
+  autoload :Notifier
 
   eager_autoload do
     autoload_at "active_notifier/errors" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_notifier
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Pine Wong
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-07-30 00:00:00.000000000 Z
+date: 2018-07-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_adapter
@@ -57,6 +57,8 @@ files:
 - bin/setup
 - lib/active_notifier.rb
 - lib/active_notifier/configurable.rb
+- lib/active_notifier/core_ext/erb/result_with_hash.rb
+- lib/active_notifier/core_ext/net/http/post.rb
 - lib/active_notifier/errors.rb
 - lib/active_notifier/notifiable.rb
 - lib/active_notifier/notifier.rb