active_model_serializers_pg 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 63d2090a2d7e9e33d8565156023d5c3dc75ea74c77baade84c5c0727d3ab917f
-  data.tar.gz: d1abc37c7a6dade9d9bacb7584b5e630f81652a87d28849dacc6bcbb5291c7d9
+  metadata.gz: 0fb040d4836aa84e29ba59590ac8bc4373528e31e5186cec1168538d52384fd0
+  data.tar.gz: a2ef8e881e358597aeb30145a73cbfdff5b7ed663d1c614ba5a40cbceba9d772
 SHA512:
-  metadata.gz: ec68d79eacdcbb257753fa6636236b406e2a57012aa68aba4d8f1ff564bd072653cfc6da4daa07ebe17bce5be0913d6e93da7cadccf6c4d637467d4026cdc21c
-  data.tar.gz: 0a7726480564582f54afcc91b8f7666ceb8416a772a8b34623b252723bb36b545a19491894b07b06372cbbfc5313473e8b12f80899e4c7d6705bdaef10ac8235
+  metadata.gz: 30889a0c217b98a0a79296379fd7c399b414b223a3568133e796ef605ae938d013957052c939c65bed5a75fed3e64d08025bc83729a92d620d3fdb905aca13dd
+  data.tar.gz: 7ff699ff57696cece4ed3f54a2f3d8583f1d2bd2089f65ab842972d9c22c9a2a86360c20e4bd0e043f2532db8f54c332804e3038c3d65f35c3af6be4f297a56e

data/lib/active_model_serializers/adapter/json_api_pg.rb

@@ -688,7 +688,7 @@ class JsonApiPgSql
     resource.serializer._attributes.select{|f|
       if ms.include? "include_#{f}?".to_sym
         ser = resource.serializer.new(nil, @options)
-        ser.send("include_#{f}?".to_sym) # TODO: call the method
+        ser.send("include_#{f}?".to_sym)
       else
         true
       end
@@ -702,7 +702,7 @@ class JsonApiPgSql
     resource.serializer._reflections.keys.select{|f|
       if ms.include? "include_#{f}?".to_sym
         ser = resource.serializer.new(nil, @options)
-        ser.send("include_#{f}?".to_sym) # TODO: call the method
+        ser.send("include_#{f}?".to_sym)
       else
         true
       end
@@ -735,6 +735,9 @@ class JsonApiPgSql
 
   def _attribute_fields_for(resource)
     attrs = Set.new(serializer_attributes(resource))
+    # JSON:API always excludes the `id`
+    # even if it's part of the serializer:
+    attrs = attrs - [resource.primary_key.to_sym]
     fields_for(resource).select { |f| attrs.include? f }.to_a
   end
 

data/lib/active_model_serializers_pg/version.rb

@@ -1,3 +1,3 @@
 module ActiveModelSerializersPg
-  VERSION = '0.0.4'
+  VERSION = '0.0.5'
 end

data/spec/serializer_spec.rb

@@ -25,7 +25,7 @@ describe 'ArraySerializer' do
           {
             id: @note.id.to_s,
             type: 'notes',
-            attributes: {id: @note.id, name: 'Title'},
+            attributes: {name: 'Title'},
             relationships: {tags: {data: [{id: @tag.id.to_s, type: 'tags'}]}},
           }
         ]
@@ -65,7 +65,7 @@ describe 'ArraySerializer' do
           {
             id: person.id.to_s,
             type: 'people',
-            attributes: { id: person.id, full_name: 'Test User', attendance_name: 'User, Test' },
+            attributes: { full_name: 'Test User', attendance_name: 'User, Test' },
           }
         ]
       }.to_json
@@ -80,7 +80,7 @@ describe 'ArraySerializer' do
           {
             id: person.id.to_s,
             type: 'people',
-            attributes: {id: person.id, full_name: 'Test User', attendance_name: 'ADMIN User, Test'}
+            attributes: {full_name: 'Test User', attendance_name: 'ADMIN User, Test'}
           }
         ]
       }.to_json
@@ -270,7 +270,7 @@ describe 'ArraySerializer' do
         data: {
           id: @note.id.to_s,
           type: 'notes',
-          attributes: { id: @note.id, name: 'Title' },
+          attributes: { name: 'Title' },
           relationships: { tags: { data: [{id: @tag.id.to_s, type: 'tags'}] } }
         }
       }.to_json
@@ -424,7 +424,7 @@ describe 'ArraySerializer' do
           {
             id: tag.id.to_s,
             type: 'tags',
-            attributes: { id: tag.id, name: 'My tag' },
+            attributes: { name: 'My tag' },
             relationships: { note: { data: { id: note.id.to_s, type: 'notes' } } },
           }
         ],
@@ -462,7 +462,7 @@ describe 'ArraySerializer' do
           {
             id: reviewer.id.to_s,
             type: 'users',
-            attributes: { id: reviewer.id, name: 'Peter' },
+            attributes: { name: 'Peter' },
             relationships: {
               offers: { data: [] },
               reviewed_offers: { data: [{id: offer.id.to_s, type: 'offers'}] },
@@ -471,7 +471,7 @@ describe 'ArraySerializer' do
           {
             id: user.id.to_s,
             type: 'users',
-            attributes: { id: user.id, name: 'John' },
+            attributes: { name: 'John' },
             relationships: {
               offers: { data: [{id: offer.id.to_s, type: 'offers'}] },
               reviewed_offers: { data: [] },
@@ -522,7 +522,7 @@ describe 'ArraySerializer' do
           {
             id: tag.id.to_s,
             type: 'tag_with_notes',
-            attributes: { id: tag.id, name: 'My tag' },
+            attributes: { name: 'My tag' },
             relationships: { note: { data: { id: note.id.to_s, type: 'notes' } } },
           }
         ]
@@ -581,7 +581,7 @@ describe 'ArraySerializer' do
           {
             id: @user.id.to_s,
             type: 'users',
-            attributes: {id: @user.id, name: 'John', mobile: '51111111'},
+            attributes: {name: 'John', mobile: '51111111'},
             relationships: {
               offers: {data: []},
               address: {data: {id: address.id.to_s, type: 'addresses'}},
@@ -601,7 +601,7 @@ describe 'ArraySerializer' do
           {
             id: @user.id.to_s,
             type: 'users',
-            attributes: {id: @user.id, name: 'John'},
+            attributes: {name: 'John'},
             relationships: {
               offers: {data: []},
               reviewed_offers: {data: []},
@@ -629,7 +629,7 @@ describe 'ArraySerializer' do
           {
             id: note.id.to_s,
             type: 'notes',
-            attributes: {id: note.id},
+            attributes: {},
             relationships: {
               sorted_tags: {
                 data: [
@@ -665,7 +665,7 @@ describe 'ArraySerializer' do
           {
             id: note.id.to_s,
             type: 'notes',
-            attributes: {id: note.id},
+            attributes: {},
             relationships: {
               custom_sorted_tags: {
                 data: [

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_model_serializers_pg
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Paul A. Jungwirth