active_model_serializers 0.9.12 → 0.9.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 61778c5b2b91da210dcc01075ef454249315c36600f82bea6996ed3290560003
-  data.tar.gz: 75e07b2aaf633ea4c5b785ea9d95a23bf9a240e8ee232c80a2c2a8bc9bca4666
+  metadata.gz: a8649ea9bfdefabb0215cc90a6a47a87d902573ecd0e2c73b6142c9cefe17825
+  data.tar.gz: 420e8afdc1ba7cbaaab42d7f8f36c3e10b702587cc7484e270428ded2eeccbdd
 SHA512:
-  metadata.gz: dd16f19a2585c7fb2fdb4b54990eb71e306def01fc6757d42c19b26820f43d3afb82d28c44efd6c228bffcac7a84324277e9d17facaa22935bf8f3a1cf4ee588
-  data.tar.gz: 06c780dffd320606869b1e377e08fdbc2b83f7ec2726ea100d3004e9ad7098f89d254ffb2b1b62477a08b0e6898b1a40ae0466bf137296559e3736c19ab7a760
+  metadata.gz: 237f372c6dd5e73cb7d5f944d90918a23e6acf0f7aa137f0e2972a275445a549a6cf4ffd9e410386c611e89e1dc0137d5451c6d61702d6c6381e43a41e3434ac
+  data.tar.gz: 5d009500e9e616e7d1a7f83adaf7874022f1f039594983e923ef82d4b8f6b8f6268259404b097545a27512b149ec22c8e113a8c0bb51effbef3c0fdd728d7973

data/CHANGELOG.md

@@ -1,6 +1,11 @@
 ## 0.09.x
 
-### [0-9-stable](https://github.com/rails-api/active_model_serializers/compare/v0.9.12...0-9-stable)
+### [0-9-stable](https://github.com/rails-api/active_model_serializers/compare/v0.9.13...0-9-stable)
+
+### [v0.9.13 (2024-09-17)](https://github.com/rails-api/active_model_serializers/compare/v0.9.12...v0.9.13)
+
+- Perf
+  - [#2471](https://github.com/rails-api/active_model_serializers/pull/2471) Generate better attribute accessors, that also don't trigger warnings when redefined. (@byroot)
 
 ### [v0.9.12 (2024-04-11)](https://github.com/rails-api/active_model_serializers/compare/v0.9.11...v0.9.12)
 

data/lib/active_model/serializer/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveModel
   class Serializer
-    VERSION = '0.9.12'
+    VERSION = '0.9.13'
   end
 end

data/lib/active_model/serializer.rb

@@ -90,15 +90,27 @@ end
       end
 
       def attributes(*attrs)
+        # Use `class_eval` rather than `define_method` for faster access
+        # and avoid retaining objects in the closure.
+        # Batch all methods in a single `class_eval` for efficiceny,
+        # and define all methods on the same line so the eventual backtrace
+        # properly maps to the `attributes` call.
+        source = ["# frozen_string_literal: true\n"]
         attrs.each do |attr|
           striped_attr = strip_attribute attr
 
           @_attributes << striped_attr
 
-          define_method striped_attr do
-            object.read_attribute_for_serialization attr
-          end unless method_defined?(attr)
+          unless method_defined?(attr)
+            source <<
+            "def #{striped_attr}" <<
+              "object.read_attribute_for_serialization(#{attr.inspect})" <<
+            "end" <<
+            "alias_method :#{striped_attr}, :#{striped_attr}" # suppress method redefinition warning
+          end
         end
+        caller = caller_locations(1, 1).first
+        class_eval(source.join(";"), caller.path, caller.lineno - 1)
       end
 
       def has_one(*attrs)

data/test/tmp/app/serializers/account_serializer.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
-class AccountSerializer < ActiveModel::Serializer
+class AccountSerializer < MySerializer
   attributes :id
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_model_serializers
 version: !ruby/object:Gem::Version
-  version: 0.9.12
+  version: 0.9.13
 platform: ruby
 authors:
 - José Valim
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-04-11 00:00:00.000000000 Z
+date: 2024-09-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -115,12 +115,7 @@ files:
 - test/integration/generators/serializer_generator_test.rb
 - test/test_app.rb
 - test/test_helper.rb
-- test/tmp/app/assets/javascripts/accounts.js
-- test/tmp/app/assets/stylesheets/accounts.css
-- test/tmp/app/controllers/accounts_controller.rb
-- test/tmp/app/helpers/accounts_helper.rb
 - test/tmp/app/serializers/account_serializer.rb
-- test/tmp/config/routes.rb
 - test/unit/active_model/array_serializer/except_test.rb
 - test/unit/active_model/array_serializer/key_format_test.rb
 - test/unit/active_model/array_serializer/meta_test.rb
@@ -198,12 +193,7 @@ test_files:
 - test/integration/generators/serializer_generator_test.rb
 - test/test_app.rb
 - test/test_helper.rb
-- test/tmp/app/assets/javascripts/accounts.js
-- test/tmp/app/assets/stylesheets/accounts.css
-- test/tmp/app/controllers/accounts_controller.rb
-- test/tmp/app/helpers/accounts_helper.rb
 - test/tmp/app/serializers/account_serializer.rb
-- test/tmp/config/routes.rb
 - test/unit/active_model/array_serializer/except_test.rb
 - test/unit/active_model/array_serializer/key_format_test.rb
 - test/unit/active_model/array_serializer/meta_test.rb

data/test/tmp/app/assets/javascripts/accounts.js

@@ -1,2 +0,0 @@
-// Place all the behaviors and hooks related to the matching controller here.
-// All this logic will automatically be available in application.js.

data/test/tmp/app/assets/stylesheets/accounts.css

@@ -1,4 +0,0 @@
-/*
-  Place all the styles related to the matching controller here.
-  They will automatically be included in application.css.
-*/

data/test/tmp/app/controllers/accounts_controller.rb

@@ -1,3 +0,0 @@
-# frozen_string_literal: true
-class AccountsController < ApplicationController
-end

data/test/tmp/app/helpers/accounts_helper.rb

@@ -1,3 +0,0 @@
-# frozen_string_literal: true
-module AccountsHelper
-end

data/test/tmp/config/routes.rb

@@ -1,2 +0,0 @@
-# frozen_string_literal: true
-Rails.application.routes.draw {}