active_model_listener 0.2.4 → 0.2.5

data/CHANGELOG

@@ -1,5 +1,6 @@
 2010-05-14
-  - fixed annoying 'activerecord' deprecation warning
+  - fixed annoying 'activerecord' deprecation warning (thanks to Todd Persen)
+  - ActiveModelListener.listeners << now takes a string to play well with Rails in development mode (Peter Jaros)
 
 2009-10-26
   - you no longer have to define all 3 callback methods in callback classes

data/README.md

@@ -4,13 +4,6 @@ Simple, global ActiveRecord event observers, using a middleware architecture, th
 
 ## Installation
 
-The gem is hosted at gemcutter.  You can either add gemcutter as a source, or you can make gemcutter your default source (recommended):
-
-    gem install gemcutter
-    gem tumble
-
-Then, install it like any other gem:
-
     gem install active_model_listener
 
 ## Usage
@@ -28,32 +21,28 @@ Add the listeners to the ActiveModelListener in an initializer:
     # config/initializers/active_model_listener.rb
     ActiveModelListener.listeners << ActivityFeedListener
 
-Then, create a listener class that defines methods for after_create, after_update and after_destroy:
+NOTE: you can also use a string or symbol version of the class.  The following are all equivalent:
+
+    ActiveModelListener.listeners << ActivityFeedListener
+    ActiveModelListener.listeners << "ActivityFeedListener"
+    ActiveModelListener.listeners << "activity_feed_listener"
+    ActiveModelListener.listeners << :activity_feed_listener
+
+Then, create a listener class that defines methods for after_create, after_update and/or after_destroy:
 
     class ActivityFeedListener
       class << self
         def after_create(record)
-          description = "#{record.class.name} was created"
-          publish_activity_feed_items record, description
+          # do stuff
         end
 
         def after_update(record)
-          description = "#{record.class.name} was updated"
-          publish_activity_feed_items record, description
+          # do stuff
         end
 
         def after_destroy(record)
-          description = "#{record.class.name} was deleted"
-          publish_activity_feed_items record, description
-        end
-
-        def publish_activity_feed_items(record, description)
-          record.activity_feed_item_subscribers.each do |subscriber|
-            ActivityFeedItem.create :user => subscriber, :description => description
-          end
+          # do stuff
         end
-
-        private :publish_activity_feed_items
       end
     end
 

data/Rakefile

@@ -8,7 +8,7 @@ begin
     gem.summary = %Q{Simple, global ActiveRecord event observers, using a middleware architecture, that can easily be turned on and off.  Designed for audit trails, activity feeds and other app-level event handlers}
     gem.email = "jeff@zilkey.com"
     gem.homepage = "http://github.com/zilkey/active_model_listener"
-    gem.authors = ["Jeff Dean"]
+    gem.authors = ["Jeff Dean", "Peter Jaros"]
     # gem is a Gem::Specification... see http://www.rubygems.org/read/chapter/20 for additional settings
   end
 

data/VERSION

@@ -1 +1 @@
-0.2.4
+0.2.5

data/active_model_listener.gemspec

@@ -5,10 +5,10 @@
 
 Gem::Specification.new do |s|
   s.name = %q{active_model_listener}
-  s.version = "0.2.4"
+  s.version = "0.2.5"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.authors = ["Jeff Dean"]
+  s.authors = ["Jeff Dean", "Peter Jaros"]
   s.date = %q{2010-05-14}
   s.email = %q{jeff@zilkey.com}
   s.extra_rdoc_files = [

data/lib/active_model_listener/active_model_listener.rb

@@ -13,7 +13,8 @@ class ActiveModelListener
       method_name = "after_#{action}"
       self.listeners.each do |listener|
         without_listeners do
-          listener.send method_name, object if listener.respond_to?(method_name)
+          listener_object = listener.to_s.classify.constantize
+          listener_object.send method_name, object if listener_object.respond_to?(method_name)
         end
       end
     end

data/spec/active_model_listener_spec.rb

@@ -4,8 +4,10 @@ class GenericListener
   def self.after_create(object)
     object.class.create
   end
+
   def self.after_update(object)
   end
+
   def self.after_destroy(object)
   end
 end
@@ -19,9 +21,6 @@ end
 class BarListener < GenericListener
 end
 
-class BazListener < GenericListener
-end
-
 describe ActiveModelListener do
   before do
     build_model :articles do
@@ -32,11 +31,14 @@ describe ActiveModelListener do
     end
 
     ActiveModelListener.listeners.clear
-    ActiveModelListener.listeners << FooListener
-    ActiveModelListener.listeners << BarListener
   end
 
   describe "with_listeners" do
+    before do
+      ActiveModelListener.listeners << FooListener
+      ActiveModelListener.listeners << BarListener
+    end
+
     it "only fires those listeners that are present" do
       FooListener.should_receive(:after_create)
       BarListener.should_not_receive(:after_create)
@@ -58,6 +60,11 @@ describe ActiveModelListener do
   end
 
   describe "without_listeners" do
+    before do
+      ActiveModelListener.listeners << FooListener
+      ActiveModelListener.listeners << BarListener
+    end
+
     it "fires no listeners" do
       FooListener.should_not_receive(:after_create)
       BarListener.should_not_receive(:after_create)
@@ -69,6 +76,11 @@ describe ActiveModelListener do
   end
 
   describe "callback methods" do
+    before do
+      ActiveModelListener.listeners << FooListener
+      ActiveModelListener.listeners << BarListener
+    end
+
     it "should turn off other listeners" do
       FooListener.should_receive(:after_create).once
       Article.create! :title => "foo"
@@ -81,7 +93,12 @@ describe ActiveModelListener do
   end
 
   describe "after create" do
-    it "should fire off all wired up events" do
+    before do
+      ActiveModelListener.listeners << FooListener
+      ActiveModelListener.listeners << BarListener
+    end
+
+    it "should fire all wired up events" do
       FooListener.should_receive(:after_create)
       BarListener.should_receive(:after_create)
       Article.create! :title => "foo"
@@ -89,7 +106,12 @@ describe ActiveModelListener do
   end
 
   describe "after update" do
-    it "should fire off all wired up events" do
+    before do
+      ActiveModelListener.listeners << FooListener
+      ActiveModelListener.listeners << BarListener
+    end
+
+    it "should fire all wired up events" do
       article = Article.create
       FooListener.should_receive(:after_update).with(article)
       BarListener.should_receive(:after_update).with(article)
@@ -98,7 +120,12 @@ describe ActiveModelListener do
   end
 
   describe "after destroy" do
-    it "should fire off all wired up events" do
+    before do
+      ActiveModelListener.listeners << FooListener
+      ActiveModelListener.listeners << BarListener
+    end
+
+    it "should fire all wired up events" do
       article = Article.create
       FooListener.should_receive(:after_destroy).with(article)
       BarListener.should_receive(:after_destroy).with(article)
@@ -108,11 +135,10 @@ describe ActiveModelListener do
 
   describe "a listener with missing methods" do
     before do
-      ActiveModelListener.listeners.clear
       ActiveModelListener.listeners << SimpleListener
     end
-      
-    it "should not fire off the missing methods" do
+
+    it "should not fire the missing methods" do
       article = Article.create
       proc do
         article.destroy
@@ -120,4 +146,25 @@ describe ActiveModelListener do
     end
   end
 
+  describe "a listener with missing methods" do
+    before do
+      ActiveModelListener.listeners << SimpleListener
+    end
+
+    it "should not fire the missing methods" do
+      article = Article.create
+      proc do
+        article.destroy
+      end.should_not raise_error
+    end
+  end
+
+  ["FooListener", :foo_listener, "foo_listener"].each do |name|
+    it "work when specifying with a format like #{name}" do
+      ActiveModelListener.listeners << name
+      FooListener.should_receive(:after_create)
+      Article.create
+    end
+  end
+
 end

metadata

@@ -5,11 +5,12 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 2
-  - 4
-  version: 0.2.4
+  - 5
+  version: 0.2.5
 platform: ruby
 authors: 
 - Jeff Dean
+- Peter Jaros
 autorequire: 
 bindir: bin
 cert_chain: []