active_model_listener 0.2.1 → 0.2.2

data/CHANGELOG

@@ -0,0 +1,3 @@
+2009-10-26
+  - you no longer have to define all 3 callback methods in callback classes
+  - callback methods are execute without listeners, to prevent recursion

data/README.md

@@ -2,6 +2,17 @@
 
 Simple, global ActiveRecord event observers, using a middleware architecture, that can easily be turned on and off.  Designed for audit trails, activity feeds and other application-level event handlers.
 
+## Installation
+
+The gem is hosted at gemcutter.  You can either add gemcutter as a source, or you can make gemcutter your default source (recommended):
+
+    gem install gemcutter
+    gem tumble
+
+Then, install it like any other gem:
+
+    gem install active_model_listener
+
 ## Usage
 
 First, require Active Model Listener above your rails initializer:
@@ -46,6 +57,8 @@ Then, create a listener class that defines methods for after_create, after_updat
       end
     end
 
+Inside the after_create, after_destroy and after_update methods all calls will be called _without_ listeners, to prevent recursion.  If you need listeners to be turned on during those blocks, you'll have to set them yourself within the blocks.
+
 ## Turning off listeners in specs
 
 When unit testing if your listeners are all firing your unit tests become integration tests.  To avoid this, you can easily turn off listeners for all specs all the time:

data/Rakefile

@@ -16,6 +16,8 @@ rescue LoadError
   puts "Jeweler (or a dependency) not available. Install it with: sudo gem install jeweler"
 end
 
+Jeweler::GemcutterTasks.new
+
 require 'spec/rake/spectask'
 Spec::Rake::SpecTask.new(:spec) do |spec|
   spec.libs << 'lib' << 'spec'

data/VERSION

@@ -1 +1 @@
-0.2.1
+0.2.2

data/active_model_listener.gemspec

@@ -1,12 +1,15 @@
+# Generated by jeweler
+# DO NOT EDIT THIS FILE DIRECTLY
+# Instead, edit Jeweler::Tasks in Rakefile, and run the gemspec command
 # -*- encoding: utf-8 -*-
 
 Gem::Specification.new do |s|
   s.name = %q{active_model_listener}
-  s.version = "0.2.1"
+  s.version = "0.2.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Jeff Dean"]
-  s.date = %q{2009-10-03}
+  s.date = %q{2009-10-26}
   s.email = %q{jeff@zilkey.com}
   s.extra_rdoc_files = [
     "LICENSE",
@@ -15,6 +18,7 @@ Gem::Specification.new do |s|
   s.files = [
     ".document",
      ".gitignore",
+     "CHANGELOG",
      "LICENSE",
      "README.md",
      "Rakefile",
@@ -45,3 +49,4 @@ Gem::Specification.new do |s|
   else
   end
 end
+

data/lib/active_model_listener/active_model_listener.rb

@@ -10,8 +10,11 @@ class ActiveModelListener
     end
 
     def dispatch(object, action)
+      method_name = "after_#{action}"
       self.listeners.each do |listener|
-        listener.send "after_#{action}", object
+        without_listeners do
+          listener.send method_name, object if listener.respond_to?(method_name)
+        end
       end
     end
 

data/spec/active_model_listener_spec.rb

@@ -2,6 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
 class GenericListener
   def self.after_create(object)
+    object.class.create
   end
   def self.after_update(object)
   end
@@ -9,6 +10,9 @@ class GenericListener
   end
 end
 
+class SimpleListener
+end
+
 class FooListener < GenericListener
 end
 
@@ -61,6 +65,13 @@ describe ActiveModelListener do
     end
   end
 
+  describe "callback methods" do
+    it "should turn off other listeners" do
+      FooListener.should_receive(:after_create).once
+      Article.create! :title => "foo"
+    end
+  end
+
   describe "after create" do
     it "should fire off all wired up events" do
       FooListener.should_receive(:after_create)
@@ -87,4 +98,18 @@ describe ActiveModelListener do
     end
   end
 
+  describe "a listener with missing methods" do
+    before do
+      ActiveModelListener.listeners.clear
+      ActiveModelListener.listeners << SimpleListener
+    end
+      
+    it "should not fire off the missing methods" do
+      article = Article.create
+      proc do
+        article.destroy
+      end.should_not raise_error
+    end
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: active_model_listener
 version: !ruby/object:Gem::Version 
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors: 
 - Jeff Dean
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-10-03 00:00:00 -04:00
+date: 2009-10-26 00:00:00 -04:00
 default_executable: 
 dependencies: []
 
@@ -25,6 +25,7 @@ extra_rdoc_files:
 files: 
 - .document
 - .gitignore
+- CHANGELOG
 - LICENSE
 - README.md
 - Rakefile