active_model-relation 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f0321b5b92acdc5dd26dae064782f042c36201d3f5f3a956497d0719e774aaee
-  data.tar.gz: f46553ea8591a73af03326c41c3ada13454f7ae9f508382bfeef1788bdbb178c
+  metadata.gz: 317f4bd9c497d254fabc65f125c743badd36fe4f91e41876bd40819f77703e01
+  data.tar.gz: 937df0db69de0e3983531fae564b0cefa8efbb3cc9d9aac499238a601d9e6503
 SHA512:
-  metadata.gz: ab15a40f58b9a295841a8740a9b4465c4a872db3d64a1d9e03b69ff6c018b5716af356cf65d64ed8b2e8d8037ee601f8eac4e5d9d33a911257a1f2db7e447152
-  data.tar.gz: 4f2fad7e6ed5b5f365aec277d438fb9d22c6bdce031adf3b42d22e36ee5c297eaee14d655f1c8c6fcdfda5746655838f51d4454261d146d654bc73e874e52db1
+  metadata.gz: f147ee5f25e5b5cd8570dae9d0117c4cbbf015491d8820ae07cf6cca831075d3c9a70f5cc0ec0bf7a15dd522bd691103fa12ee9b6e9b3dcc9a12484ca0761df3
+  data.tar.gz: d61a00b7833c030be0ca14d814f8aeb8e0f23d913e071dd068a09fac050106ca1f3c46cd80b8dea597c21632397fec4d0ccd276cfb7193b29e09b73d1b2ebe68

data/CHANGELOG.md

@@ -1,8 +1,12 @@
 ## [Unreleased]
 
+- Treat `ActiveModel::RecordNotFound` like `ActiveRecord::RecordNotFound` in `ActionDispatch`
+- Properly type cast values when they are defined as attribute
+- Ensure that there is always at least an empty array of records
+
 ## [0.2.0] - 2024-09-16
 
-- Rename `ActiveModel::Relation::ModelNotFound` to `ActiveModel::Relation::RecordNotFound`
+- Rename `ActiveModel::ModelNotFound` to `ActiveModel::RecordNotFound`
 - Allow creating a `ActiveModel::Relation` without passing a collection
 - Don't require a `.records` class method on model classes
 - Allow passing a block to `ActiveModel::Relation#find`

data/README.md

@@ -51,7 +51,7 @@ An `ActiveModel::Relation` can be queried almost exactly like an `ActiveRecord::
 
 #### `#find`
 
-You can look up a record by it's primary key, using the `find` method. If no record is found, it will raise a `ActiveModel::Relation::RecordNotFound` error.
+You can look up a record by it's primary key, using the `find` method. If no record is found, it will raise a `ActiveModel::RecordNotFound` error.
 
 ```ruby
 project = relation.find(1)
@@ -268,3 +268,11 @@ The gem is available as open source under the terms of the [MIT License](https:/
 ## Code of Conduct
 
 Everyone interacting in the ActiveModel::Relation project's codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/userlist/active_model-relation/blob/main/CODE_OF_CONDUCT.md).
+
+## What is Userlist?
+
+[![Userlist](https://userlist.com/images/external/userlist-logo-github.svg)](https://userlist.com/)
+
+[Userlist](https://userlist.com/) allows you to onboard and engage your SaaS users with targeted behavior-based campaigns using email or in-app messages.
+
+Userlist was started in 2017 as an alternative to bulky enterprise messaging tools. We believe that running SaaS products should be more enjoyable. Learn more [about us](https://userlist.com/about-us/).

data/lib/active_model/relation/railtie.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require 'rails'
+
+module ActiveModel
+  class Relation
+    class Railtie < Rails::Railtie # :nodoc:
+      config.action_dispatch.rescue_responses.merge!(
+        'ActiveModel::RecordNotFound' => :not_found
+      )
+    end
+  end
+end

data/lib/active_model/relation/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveModel
   class Relation
-    VERSION = '0.2.0'
+    VERSION = '0.2.1'
   end
 end

data/lib/active_model/relation.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'active_model'
+require_relative 'relation/railtie' if defined?(Rails::Railtie)
 
 module ActiveModel
   class RecordNotFound < StandardError
@@ -29,9 +30,9 @@ module ActiveModel
 
     delegate :each, :size, :last, to: :records
 
-    def initialize(model, records = model.try(:records) || [])
+    def initialize(model, records = model.try(:records))
       @model = model
-      @records = records
+      @records = records || []
       @where_clause = WhereClause.new
       @order_clause = OrderClause.new
       @offset_value = nil
@@ -49,7 +50,7 @@ module ActiveModel
     end
 
     def find_by(attributes = {})
-      where_clause = self.where_clause + WhereClause.from_hash(attributes)
+      where_clause = self.where_clause + WhereClause.from_hash(type_cast_values(attributes))
 
       records.find(&where_clause)
     end
@@ -61,7 +62,7 @@ module ActiveModel
     def where!(attributes = {}, &)
       return WhereChain.new(spawn) unless attributes.any? || block_given?
 
-      self.where_clause += WhereClause.build(attributes, &)
+      self.where_clause += WhereClause.build(type_cast_values(attributes), &)
       self
     end
 
@@ -180,5 +181,14 @@ module ActiveModel
         relation.limit_value = values[:limit]
       end
     end
+
+    def type_cast_values(attributes)
+      attributes.to_h do |key, value|
+        type = model.try(:type_for_attribute, key)
+        value = type.cast(value) if type
+
+        [key, value]
+      end
+    end
   end
 end

metadata

@@ -1,29 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: active_model-relation
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Benedikt Deicke
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-09-16 00:00:00.000000000 Z
+date: 2024-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '7.2'
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '8.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '7.2'
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '8.0'
 description: This library allows querying of collections of Ruby objects, with a similar
   interface to ActiveRecord::Relation.
 email:
@@ -43,6 +49,7 @@ files:
 - lib/active_model/relation/model.rb
 - lib/active_model/relation/order_clause.rb
 - lib/active_model/relation/querying.rb
+- lib/active_model/relation/railtie.rb
 - lib/active_model/relation/scoping.rb
 - lib/active_model/relation/version.rb
 - lib/active_model/relation/where_chain.rb