active_model-errors_details 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 26eafe0432507692d145a348879901aa097de958
-  data.tar.gz: a9a9b46faa6d0529ebfee0aa712c06ddfbecae1f
+  metadata.gz: 3dff9bf03484706f8055dba610aa63a39098c00f
+  data.tar.gz: c53ce253b6ea7f322f5e21f4308fe90e170b1a08
 SHA512:
-  metadata.gz: c6859c5e55f5637f6536c32f1ee8fc1367beb4940e6761a49e2398975c01578084de3b71bc0b62a499eedaa97613d2cf34c217f7f5e278de07a85d1ff7bf8177
-  data.tar.gz: 6ed6433f0a29093f243db25f1e8325fe3eead369121c968f158050136e4dc472fa0f9caf274113ce7401afed43e216a554afc1ccc3e14f2b42366aedd47b9bf2
+  metadata.gz: 6335f01847ac63a228d66373e1c06906291b377f1bc260ccd37c51489038cfa4f031a45d28d72a32820e6ddbcea622fa96bda832f289c47c1a4d43ce19a0ad00
+  data.tar.gz: 4ffc69ec8985f4247d0b9c108e681578d1eb52be5ea6cdf85394fd30252151a403e84f8ea6f26fd5bf6036d5b17564116495b9cf0467e9b645e41e80c2c80a2e

data/.travis.yml

@@ -6,3 +6,4 @@ notifications:
 rvm:
   - 2.0
   - 2.2
+  - 2.3

data/active_model-errors_details.gemspec

@@ -18,10 +18,12 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "activemodel", ">= 3.2.13", "< 5.0.0.alpha"
+  spec.add_dependency "activemodel", ">= 3.2.13", "< 5.0.0.beta1"
   spec.add_dependency "activesupport"
 
   spec.add_development_dependency "bundler", "~> 1.7"
-  spec.add_development_dependency "minitest", "~> 5.6"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "minitest", ">= 5.6"
+  spec.add_development_dependency "rake", ">= 10.0"
+  spec.add_development_dependency "activerecord", ">= 3.2.13", "< 5.0.0.beta1"
+  spec.add_development_dependency "sqlite3"
 end

data/lib/active_model/errors_details.rb

@@ -28,6 +28,41 @@ rescue LoadError
   end
 end
 
+if defined?(ActiveRecord)
+  require "active_record/autosave_association"
+
+  module ActiveRecord
+    module AutosaveAssociation
+      def association_valid?(reflection, record)
+        return true if record.destroyed? || (reflection.options[:autosave] && record.marked_for_destruction?)
+
+        validation_context = self.validation_context unless [:create, :update].include?(self.validation_context)
+        unless valid = record.valid?(validation_context)
+          if reflection.options[:autosave]
+            record.errors.each do |attribute, message|
+              attribute = "#{reflection.name}.#{attribute}"
+              errors[attribute] << message
+              errors[attribute].uniq!
+            end
+            # Monkey patch here
+            record.errors.details.each_key do |attribute|
+              reflection_attribute = "#{reflection.name}.#{attribute}"
+
+              record.errors.details[attribute].each do |error|
+                errors.details[reflection_attribute] << error
+                errors.details[reflection_attribute].uniq!
+              end
+            end
+          else
+            errors.add(reflection.name)
+          end
+        end
+        valid
+      end
+    end
+  end
+end
+
 module ActiveModel
   module ErrorsDetails
     MESSAGE_OPTIONS = [:message]

data/lib/active_model/errors_details/version.rb

@@ -1,5 +1,5 @@
 module ActiveModel
   module ErrorsDetails
-    VERSION = "1.2.0"
+    VERSION = "1.3.0"
   end
 end

data/test/test_ar_association.rb

@@ -0,0 +1,37 @@
+require "active_record"
+require "minitest_helper"
+
+ActiveRecord::Base.establish_connection(adapter: "sqlite3", database: ":memory:")
+
+ActiveRecord::Schema.define do
+  create_table :users, force: true  do |t|
+  end
+
+  create_table :comments, force: true  do |t|
+    t.integer :user_id
+    t.string :content
+  end
+end
+
+class TestArAssociation < MiniTest::Test
+  class User < ActiveRecord::Base
+    has_many :comments
+
+    accepts_nested_attributes_for :comments
+  end
+
+  class Comment < ActiveRecord::Base
+    belongs_to :user
+
+    validates :content, presence: true
+  end
+
+  def test_error_details_on_associated_model
+    user = User.new
+    user.comments.build
+    user.valid?
+
+    expected = {"comments.content" => [{error: :blank}]}
+    assert_equal user.errors.details, expected
+  end
+end

data/test/test_errors_details.rb

@@ -4,7 +4,7 @@ require "minitest_helper"
 require "active_support/core_ext/module/remove_method"
 require "active_model/naming"
 
-class TestErrorsDetails < MiniTest::Unit::TestCase
+class TestErrorsDetails < MiniTest::Test
   class Person
     extend ActiveModel::Naming
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_model-errors_details
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Wojciech Wnętrzak
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-25 00:00:00.000000000 Z
+date: 2015-12-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -19,7 +19,7 @@ dependencies:
         version: 3.2.13
     - - "<"
       - !ruby/object:Gem::Version
-        version: 5.0.0.alpha
+        version: 5.0.0.beta1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: 3.2.13
     - - "<"
       - !ruby/object:Gem::Version
-        version: 5.0.0.alpha
+        version: 5.0.0.beta1
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -62,30 +62,64 @@ dependencies:
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.6'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.2.13
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 5.0.0.beta1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.2.13
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 5.0.0.beta1
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Backported from Rails 5.0 to use with 4.x versions
 email:
 - w.wnetrzak@gmail.com
@@ -103,6 +137,7 @@ files:
 - lib/active_model/errors_details.rb
 - lib/active_model/errors_details/version.rb
 - test/minitest_helper.rb
+- test/test_ar_association.rb
 - test/test_errors_details.rb
 homepage: https://github.com/cowbell/active_model-errors_details
 licenses:
@@ -124,10 +159,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Adds ActiveModel::Errors#details to return type of used validator
 test_files:
 - test/minitest_helper.rb
+- test/test_ar_association.rb
 - test/test_errors_details.rb