active_model-attribute 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d95747a10423b764cf2bf709a6fd40ac575da3cf
-  data.tar.gz: 4f58b52e8e850770d93bbb6792394e0d488c45f9
+  metadata.gz: 1ed7ef5bddca113e053cd2edf3856bd665f37c52
+  data.tar.gz: de80657a0582837da4417a871004411323b2427f
 SHA512:
-  metadata.gz: 704fc0632f75dbf3c28c93ab0580e2b2e3f16bb8da6cfdba0d0171ec889b22865e72a78878cb214e89ce90f38768b2b984d03812f071075d416fd58aae7b63f7
-  data.tar.gz: b0d7700ceb94fb6ba6ba6cb0e81b23f3ea92032e80dfc693d3b3475b5cc97c3f0ac7b6fda2e3c0b2bc4302c7c7364ba9cc4fec8ed96851c60465bda5931fcc7b
+  metadata.gz: 1e632f92ade18c2728bdd8596c498e6aaae8beb01d61a5b0753288383e29ea8a8e71ef7b977e942a5839ad9cf8c611d9e0700e439f20b3a80db306d1a64d28d5
+  data.tar.gz: a74d10d8d2c23e61a5bd18406d21daff642accce9167cca61645a8157ed1f84a521b92d0fd1b12abbc8753d76aedc2642e813b7648cf36110921bfe6133f7b54

data/README.md

@@ -0,0 +1,57 @@
+# ActiveModel::Attribute [![Build Status](https://travis-ci.org/frodsan/active_model-attribute.svg)](https://travis-ci.org/frodsan/active_model-attribute)
+
+Declares attributes for Active Model objects.
+
+## Installation
+
+Add this line to your application's Gemfile:
+
+```ruby
+gem "active_model-attribute"
+```
+
+And then execute:
+
+    $ bundle
+
+Or install it yourself as:
+
+    $ gem install active_model-attribute
+
+## Usage
+
+```ruby
+class User
+  include ActiveModel::Attribute
+
+  attribute :name, :string
+  attribute :position, :string
+  attribute :age, :integer
+  attribute :active, :boolean
+
+  alias_attribute :full_name, :name
+end
+
+user = User.new(
+  name: 'Bob',
+  position: 'Developer',
+  age: '42',
+  active: false
+)
+
+user.age
+# => 42
+
+user.age.class
+# => Integer
+
+user.full_name
+# => 'Bob'
+
+user.active?
+# => false
+```
+
+## License
+
+The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).

data/lib/active_model/attribute.rb

@@ -1,8 +1,7 @@
 # frozen_string_literal: true
 
 require "active_support/concern"
-require "active_model/forbidden_attributes_protection"
-require "active_model/attribute_assignment"
+require "active_model"
 require "active_model/type"
 
 module ActiveModel
@@ -10,42 +9,35 @@ module ActiveModel
     extend ActiveSupport::Concern
 
     included do
+      include ActiveModel::AttributeMethods
       include ActiveModel::AttributeAssignment
-    end
 
-    class_methods do
-      def inherited(subclass)
-        subclass.attributes.replace(attributes)
-      end
+      class_attribute :attributes, :attribute_registry,
+                      instance_accessor: false,
+                      instance_predicate: false
 
-      def attributes
-        @attributes ||= []
-      end
+      self.attributes = []
+      self.attribute_registry = {}
 
-      def attribute(name, type, **options)
-        attributes << name unless attributes.include?(name)
+      attribute_method_suffix '='
+      attribute_method_suffix '?'
+    end
+
+    class_methods do
+      def attribute(name, type, options = {})
+        name = name.to_s
 
-        getter = name.to_sym
-        setter = :"#{name}="
+        self.attribute_registry = attribute_registry.merge(name => [type, options])
 
-        define_method(getter) do
-          @attributes[getter]
-        end
+        self.attributes = attribute_registry.keys
 
-        define_method(setter) do |value|
-          @attributes[getter] = ActiveModel::Type.lookup(type, **options).cast(value)
-        end
-      end
+        define_attribute_method(name)
 
-      def alias_attribute(new_name, old_name)
-        alias_method new_name, old_name
-        alias_method :"#{new_name}=", :"#{old_name}="
+        attr_reader(name)
       end
     end
 
     def initialize(attrs = {})
-      @attributes = {}
-
       assign_attributes(attrs) if attrs
 
       super()
@@ -60,5 +52,19 @@ module ActiveModel
         hash[name] = send(name)
       end
     end
+
+    private
+
+    def attribute=(attr, value)
+      type, options = self.class.attribute_registry[attr.to_s]
+
+      value = ActiveModel::Type.lookup(type, **options).cast(value)
+
+      instance_variable_set(:"@#{attr}", value)
+    end
+
+    def attribute?(attr)
+      send(attr).present?
+    end
   end
 end

data/test/active_model_attribute_test.rb

@@ -17,6 +17,8 @@ class User
   attribute :description, :text
   attribute :age, :integer
   attribute :active, :boolean
+
+  alias_attribute :full_name, :name
 end
 
 class Admin < User
@@ -25,31 +27,51 @@ end
 
 class ActiveModelAttributeTest < Minitest::Test
   def test_class_attributes
-    assert_equal User.attributes, [:name, :description, :age, :active]
+    assert_equal User.attributes, %w[name description age active]
   end
 
   def test_inheritance
-    assert_equal Admin.attributes, User.attributes + [:sudo]
+    assert_equal Admin.attributes, User.attributes + %w[sudo]
   end
 
   def test_casting
     user = User.new(
-      name: 'Francesco',
-      description: 'Developer',
-      age: '322',
-      active: 'true'
+      name: "Francesco",
+      description: "Developer",
+      age: "322",
+      active: "true"
     )
 
-    assert_equal 'Francesco', user.name
-    assert_equal 'Developer', user.description
+    assert_equal "Francesco", user.name
+    assert_equal "Developer", user.description
     assert_equal 322, user.age
     assert_equal true, user.active
   end
 
   def test_attributes
-    user = User.new(name: 'Francesco', description: 'Developer')
+    user = User.new(name: "Francesco", description: "Developer")
+
+    assert_equal "Francesco", user.attributes["name"]
+    assert_equal "Developer", user.attributes["description"]
+  end
+
+  def test_predicates
+    user = User.new(active: false)
+
+    refute user.active?
+    refute user.name?
+
+    user.name = "Francesco"
+    user.active = true
+
+    assert user.name?
+    assert user.active?
+  end
+
+  def test_alias
+    user = User.new(full_name: 'Francesco')
 
-    assert_equal 'Francesco', user.attributes[:name]
-    assert_equal 'Developer', user.attributes[:description]
+    assert user.full_name?
+    assert_equal user.full_name, user.name
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_model-attribute
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Francesco Rodríguez
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-14 00:00:00.000000000 Z
+date: 2017-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -109,7 +109,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Declares attribute for Active Model objects