active_metric 2.5.3 → 2.5.4

data/lib/active_metric/stat.rb

@@ -36,6 +36,10 @@ module ActiveMetric
       title.to_sym
     end
 
+    def self.approximation
+      nil
+    end
+
     #TODO Make custom classes namespaced to where they are being defined
     def self.create_custom_stat(name_of_stat, value_type, default, calculate_block)
       class_name = name_of_stat.to_s.camelcase

data/lib/active_metric/stat_definition.rb

@@ -4,8 +4,9 @@ module ActiveMetric
     attr_reader :name_of_stat, :klass, :access_name, :options
 
     def initialize(name_of_stat, klass, access_name, options)
-      @name_of_stat, @klass, @access_name, @options = name_of_stat, klass, access_name, options
+      @name_of_stat, @klass, @access_name, @options = name_of_stat, klass, access_name, options.clone
       @options[:axis] ||= 0
+      @options[:approximation] ||= klass.approximation
     end
 
     def create_stat

data/lib/active_metric/statistics/defaults.rb

@@ -5,6 +5,10 @@ module ActiveMetric
     def calculate(measurement)
       self.value = [self.value, measurement.send(self.property)].min
     end
+
+    def self.approximation
+      "low"
+    end
   end
 
   class Max < Stat
@@ -26,6 +30,10 @@ module ActiveMetric
       self.value = (self.sum.to_f / self.count)
       super
     end
+
+    def self.approximation
+      "average"
+    end
   end
 
   class Derivative < Stat

data/lib/active_metric/version.rb

@@ -1,3 +1,3 @@
 module ActiveMetric
-  VERSION = "2.5.3"
+  VERSION = "2.5.4"
 end

data/test/behavior_tests/graph_calculation_test.rb

@@ -87,5 +87,21 @@ module ActiveMetric
       assert_equal [[2,4],[7,9],[11,13],[14,14]], same_gvm.series_for("max_value").data
     end
 
+    test "graph view model gets created with approximation as defined in stat then sample class" do
+      default_min_approximation = "low"
+      default_mean_approximation = "average"
+      default_approximation = "high"
+      test_sample_defined_approximation = "open"
+      report = Report.create
+      subject = TestSubject.create :report => report
+
+      gvm = subject.graph_view_model
+
+      assert_equal default_min_approximation, gvm.series_for("min_value").approximation
+      assert_equal default_mean_approximation, gvm.series_for("mean_value").approximation
+      assert_equal default_approximation, gvm.series_for("max_value").approximation
+      assert_equal test_sample_defined_approximation, gvm.series_for("standard_deviation_value").approximation
+    end
+
   end
 end

data/test/test_helper.rb

@@ -29,7 +29,7 @@ module ActiveMetric
 
   class TestSample < Sample
     stat :value
-    stat :value, [:standard_deviation], axis: 1
+    stat :value, [:standard_deviation], axis: 1, approximation: "open"
     stat :value, [:delta], axis: 1
     stat :value, [:speed], axis: 1
     stat :value, [:bucket], axis: 2

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_metric
 version: !ruby/object:Gem::Version
-  version: 2.5.3
+  version: 2.5.4
   prerelease: 
 platform: ruby
 authors:
@@ -14,7 +14,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-16 00:00:00.000000000 Z
+date: 2014-02-07 00:00:00.000000000 Z
 dependencies: []
 description: ActiveMetric is a mongo based statistics calculator and persistance layer
 email: