active_metadata 0.4.2 → 0.5.0

data/app/controllers/active_metadata/attachments_controller.rb

@@ -24,7 +24,7 @@ module ActiveMetadata
 
     def update
       @document = eval(params[:model_name]).find params[:model_id]
-      @document.update_attachment_for(params[:field_name],params[:id],params[:file])
+      @document.update_attachment(params[:id],params[:file])
       
       #todo: if errors send back the correct answer
       respond_to do |format|
@@ -34,7 +34,7 @@ module ActiveMetadata
 
     def destroy
       @document = eval(params[:model_name]).find params[:model_id]
-      @document.delete_attachment_for(params[:field_name], params[:id])
+      @document.delete_attachment(params[:id])
       
       #todo: if errors send back the correct answer
       respond_to do |format|

data/app/controllers/active_metadata/notes_controller.rb

@@ -49,7 +49,7 @@ module ActiveMetadata
 
     def destroy
       @document = eval(params[:model_name]).find params[:model_id]
-      @document.delete_note_for(params[:field_name],params[:id])
+      @document.delete_note(params[:id])
       respond_to do |format|
         # TODO redirect to index
         format.js

data/config/routes.rb

@@ -6,11 +6,14 @@ Rails.application.routes.draw do
     #note
     match ':model_name/:model_id/:field_name/notes' => 'notes#index', :via => :get, :as => "notes", :path_prefix => mount_at 
     match ':model_name/:model_id/:field_name/notes' => 'notes#create', :via => :post, :as => "create_note", :path_prefix => mount_at 
-    match ':model_name/:model_id/:field_name/note/:id' => 'notes#destroy', :via => :delete, :as => "destroy_note", :path_prefix => mount_at 
-    match ':model_name/:model_id/:field_name/note/:id/edit' => 'notes#edit', :via => :get, :as => "edit_note", :path_prefix => mount_at 
-    match ':model_name/:model_id/:field_name/note/:id' => 'notes#update', :via => :put, :as => "update_note", :path_prefix => mount_at 
-    match ':model_name/:model_id/:field_name/note/:id' => 'notes#show', :via => :get, :as => "show_note", :path_prefix => mount_at 
-    
+    match ':model_name/:model_id/:field_name/notes/:id' => 'notes#destroy', :via => :delete, :as => "destroy_note", :path_prefix => mount_at
+    match ':model_name/:model_id/:field_name/notes/:id/edit' => 'notes#edit', :via => :get, :as => "edit_note", :path_prefix => mount_at
+    match ':model_name/:model_id/:field_name/notes/:id' => 'notes#update', :via => :put, :as => "update_note", :path_prefix => mount_at
+    match ':model_name/:model_id/:field_name/notes/:id' => 'notes#show', :via => :get, :as => "show_note", :path_prefix => mount_at
+    match ':model_name/:model_id/:field_name/notes/starred' => 'notes#starred', :via => :get, :as => "starred_notes", :path_prefix => mount_at
+    match ':model_name/:model_id/:field_name/notes/:id/star' => 'notes#star', :via => :put, :as => "star_note", :path_prefix => mount_at
+    match ':model_name/:model_id/:field_name/notes/:id/unstar' => 'notes#unstar', :via => :put, :as => "unstar_note", :path_prefix => mount_at
+
     #history
     match ':model_name/:model_id/:field_name/histories' => 'histories#index', :via => :get, :as => "histories", :path_prefix => mount_at 
 
@@ -19,7 +22,10 @@ Rails.application.routes.draw do
     match ':model_name/:model_id/:field_name/attachments' => 'attachments#create', :via => :post, :as => "create_attachment", :path_prefix => mount_at 
     match ':model_name/:model_id/:field_name/attachments/:id' => 'attachments#destroy', :via => :delete, :as => "destroy_attachment", :path_prefix => mount_at   
     match ':model_name/:model_id/:field_name/attachments/:id' => 'attachments#update', :via => :put, :as => "update_attachment", :path_prefix => mount_at   
-                                                                                              
+    match ':model_name/:model_id/:field_name/attachments/starred' => 'attachments#starred', :via => :get, :as => "starred_attachments", :path_prefix => mount_at
+    match ':model_name/:model_id/:field_name/attachments/:id/star' => 'attachments#star', :via => :put, :as => "star_attachments", :path_prefix => mount_at
+    match ':model_name/:model_id/:field_name/attachments/:id/unstar' => 'attachments#unstar', :via => :put, :as => "unstar_attachments", :path_prefix => mount_at
+
     #alerts
     get ':model_name/:model_id/:field_name/watchers' => 'watchers#index', :as => "watchers", :path_prefix => mount_at 
     post ':model_name/:model_id/:field_name/watchers/:user_id' => 'watchers#create',:as => "set_watcher", :path_prefix => mount_at 

data/db/migrate/02_active_metadata_migrations.rb

@@ -8,6 +8,7 @@ class ActiveMetadataMigrations < ActiveRecord::Migration
       t.integer :document_id
       t.integer :created_by
       t.integer :updated_by
+      t.boolean :starred
       t.timestamps
     end
 
@@ -41,6 +42,7 @@ class ActiveMetadataMigrations < ActiveRecord::Migration
       t.string :attach_content_type
       t.integer :attach_file_size
       t.datetime :attach_updated_at
+      t.boolean :starred
       t.timestamps
     end
 

data/lib/active_metadata/persistence/active_record/attachment.rb

@@ -6,8 +6,9 @@ module ActiveMetadata::Persistence::ActiveRecord::Attachment
 
   module InstanceMethods
 
-    def save_attachment_for(field, file)      
-      attachment = Attachment.create! :document_class => metadata_class, :document_id => metadata_id, :label => field, :attach => file, :created_by => current_user_id
+    def save_attachment_for(field, file, starred=false)
+      attachment = Attachment.create! :document_class => metadata_class, :document_id => metadata_id, :label => field, :attach => file,
+                                      :starred => starred, :created_by => current_user_id
       reload_attachments_cache_for field 
       self.send(:send_notification, field, "", attachment.attach.original_filename, :attachment_message, current_user_id)
     end
@@ -18,40 +19,61 @@ module ActiveMetadata::Persistence::ActiveRecord::Attachment
       end  
     end
 
-    def delete_attachment_for(field,id)
+    def delete_attachment(id)
       a = Attachment.find(id)
       filename = a.attach.original_filename
       a.destroy      
-      reload_attachments_cache_for field 
-      self.send(:send_notification, field, filename, "", :attachment_message)
+      reload_attachments_cache_for a.label
+      self.send(:send_notification, a.label, filename, "", :attachment_message)
     end
 
-    def update_attachment_for(field, id, newfile)
+    def update_attachment(id, newfile, starred=nil)
       a = Attachment.find(id)
       old_filename = a.attach.original_filename
       a.attach = newfile
       a.updated_by = current_user_id
-      a.save                                            
+      a.starred = starred if !starred.nil?
+      a.save
       new_filename = a.attach.original_filename
 
-      reload_attachments_cache_for field       
-      self.send(:send_notification, field, old_filename, new_filename, :attachment_message, current_user_id)
+      reload_attachments_cache_for a.label
+      self.send(:send_notification, a.label, old_filename, new_filename, :attachment_message, current_user_id)
     end
 
     def has_attachments_for field
       attachments_for(field).size == 0 ? false : true
     end
-    
+
+    def find_attachment_by_id(id)
+      Attachment.find(id)
+    end
+
+    # not cached
+    def starred_attachments_for(field)
+      fetch_attachments_for field,true
+    end
+
+    def star_attachment(id)
+      n = Attachment.find(id)
+      update_attachment id,n.attach,true
+    end
+
+    def unstar_attachment(id)
+      n = Attachment.find(id)
+      update_attachment id,n.attach,false
+    end
+
     private
     
     def reload_attachments_cache_for field
       Rails.cache.write(attachments_cache_key(field),fetch_attachments_for(field), :expires_in => ActiveMetadata::CONFIG['cache_expires_in'].minutes )     
     end  
     
-    def fetch_attachments_for field
-      Attachment.all(:conditions => {:document_class => metadata_class, :document_id => metadata_id,:label => field}, :order => "attach_updated_at DESC")
+    def fetch_attachments_for field, starred=nil
+      conditions = {:document_class => metadata_class, :document_id => metadata_id,:label => field}
+      conditions[:starred] = starred if !starred.nil?
+      Attachment.all(:conditions => conditions , :order => "attach_updated_at DESC")
     end  
-    
 
   end
 

data/lib/active_metadata/persistence/active_record/note.rb

@@ -6,16 +6,21 @@ module ActiveMetadata::Persistence::ActiveRecord::Note
 
   module InstanceMethods
     
-    def create_note_for(field, note)      
-      Note.create! :document_id => metadata_id, :document_class => metadata_class, :label => field.to_s,:note => note, :created_by => current_user_id
-      reload_notes_cache_for field 
+    def create_note_for(field, note, starred=false)
+      Note.create! :document_id => metadata_id, :document_class => metadata_class, :label => field.to_s,:note => note, :created_by => current_user_id, :starred => starred
+      reload_notes_cache_for field
       self.send(:send_notification, field, "", note, :note_message, current_user_id) 
     end
 
-    def update_note(id, note)
+    def update_note(id, note, starred=nil)
       n = Note.find(id)
       old_value = n.note
-      n.update_attributes! :note => note, :updated_by => current_user_id, :updated_at => Time.now.utc     
+      attributes =  {:note => note, :updated_by => current_user_id, :updated_at => Time.now.utc}
+      #mass assign starred inly if provided
+      unless starred.nil?
+        attributes[:starred] = starred
+      end
+      n.update_attributes! attributes
       reload_notes_cache_for n.label 
       self.send(:send_notification, n.label, old_value, note, :note_message, current_user_id)
     end
@@ -26,7 +31,7 @@ module ActiveMetadata::Persistence::ActiveRecord::Note
       end    
     end
 
-    def note_for(field,id)
+    def find_note_by_id(id)
       Note.find(id)
     end      
     
@@ -34,26 +39,45 @@ module ActiveMetadata::Persistence::ActiveRecord::Note
       notes.each { |note| create_note_for field, note }
     end
 
-    def delete_note_for(field,id)
+    def delete_note(id)
       n = Note.find(id)
       old_value = n.note
       n.destroy
-      reload_notes_cache_for field 
-      self.send(:send_notification, field, old_value, "", :note_message)
+      reload_notes_cache_for n.label
+      self.send(:send_notification, n.label, old_value, "", :note_message)
     end
     
     def has_notes_for field      
       notes_for(field).size == 0 ? false : true
     end
-    
+
+    # not cached
+    def starred_notes_for(field)
+      fetch_notes_for field,true
+    end
+
+    def star_note(id)
+      n = Note.find(id)
+      update_note id,n.note,true
+    end
+
+    def unstar_note(id)
+      n = Note.find(id)
+      update_note id,n.note,false
+    end
+
     private
     
     def reload_notes_cache_for field
       Rails.cache.write(notes_cache_key(field),fetch_notes_for(field), :expires_in => ActiveMetadata::CONFIG['cache_expires_in'].minutes )     
     end  
     
-    def fetch_notes_for field
-      Note.all(:conditions => {:label => field, :document_class => metadata_class, :document_id => metadata_id}, :order => "updated_at DESC" )
+    def fetch_notes_for(field, starred=nil)
+      conditions = {:label => field, :document_class => metadata_class, :document_id => metadata_id}
+      unless starred.nil?
+        conditions[:starred] = starred
+      end
+      Note.all(:conditions => conditions, :order => "updated_at DESC")
     end  
         
   end

data/lib/active_metadata/version.rb

@@ -1,3 +1,3 @@
 module ActiveMetadata
-  VERSION = "0.4.2"
+  VERSION = "0.5.0"
 end

data/spec/active_metadata_spec.rb

@@ -28,160 +28,6 @@ describe ActiveMetadata do
 
   end
 
-  context "saving and quering notes" do
-
-    before(:each) do
-      @document = Document.create! { |d| d.name = "John" }
-      @document.reload
-    end
-
-    it "should create a new note for a given field" do
-      @document.create_note_for(:name, "Very important note!")
-      @document.notes_for(:name).should have(1).record
-    end
-
-
-    it "should verify the content of a note created" do
-      @document.create_note_for(:name, "Very important note!")
-      @document.notes_for(:name).last.note.should eq "Very important note!"
-    end
-
-    it "should verify that notes are created for the correct model" do
-      @document.create_note_for(:name, "Very important note!")
-      @document.notes_for(:name).last.document_class.should eq(@document.class.to_s)
-    end
-
-    it "should verify the created_by of a note created" do
-      @document.create_note_for(:name, "Very important note!")
-      @document.notes_for(:name).last.created_by.should eq User.current.id
-    end
-
-    it "should verify that notes_for_name return only notes for the self Document" do
-      # fixtures
-      @another_doc = Document.create :name => "Andrea"
-      @another_doc.create_note_for(:name, "Very important note for doc2!")
-      @another_doc.reload
-      @document.create_note_for(:name, "Very important note!")
-
-        # expectations
-      @document.notes_for(:name).count.should eq(1)
-      @document.notes_for(:name).last.note.should eq "Very important note!"
-      @another_doc.notes_for(:name).last.note.should eq "Very important note for doc2!"
-
-    end
-
-    it "should update a note using update_note_for_name" do
-      @document.create_note_for(:name, "Very important note!")
-      id = @document.notes_for(:name).last.id
-      @document.update_note(id, "New note value!")
-      @document.notes_for(:name).last.note.should eq "New note value!"
-    end
-
-    it "should verify the content of a note created for a second attribute" do
-      @document.create_note_for(:name, "Very important note!")
-      @document.create_note_for(:surname, "Note on surname attribute!")
-
-      @document.notes_for(:name).last.note.should eq "Very important note!"
-      @document.notes_for(:surname).last.note.should eq "Note on surname attribute!"
-    end
-
-    it "should save multiple notes" do
-      notes = ["note number 1", "note number 2"]
-      @document.create_notes_for(:name, notes)
-      @document.notes_for(:name).should have(2).record
-    end
-
-    it "should save the updater id in metadata" do
-      @document.create_note_for(:name, "Very important note!")
-      id = @document.notes_for(:name).last.id
-      @document.update_note id, "new note value"
-      @document.notes_for(:name).last.updated_by.should eq User.current.id
-    end
-
-    it "should save the created_at datetime in metadata" do
-      @document.create_note_for(:name, "Very important note!")
-      @document.notes_for(:name).last.created_at.should be_a_kind_of Time
-    end
-
-    it "should save the updated_at datetime in metadata" do
-      @document.create_note_for(:name, "Very important note!")
-      @document.notes_for(:name).last.updated_at.should be_a_kind_of Time
-    end
-
-    it "should update the updated_at field when a note is updated" do
-      @document.create_note_for(:name, "Very important note!")
-      id = @document.notes_for(:name).last.id
-      sleep 1.seconds
-      @document.update_note id, "new note value"
-      note = @document.notes_for(:name).last
-      note.updated_at.should > note.created_at
-    end
-
-    it "should verify that note are saved with the correct model id if metadata_id_from is defined"  do
-      # fixtures
-      @document.create_note_for(:name, "Very important note!")
-      @section = @document.create_section :title => "new section"
-      @section.reload
-      @section.create_note_for(:title, "Very important note for section!")
-
-      # expectations
-      @document.notes_for(:name).last.document_id.should eq @document.id
-      @section.notes_for(:title).last.document_id.should eq @document.id
-    end
-
-    it "should delete a note id" do
-      #fixtures
-      2.times do |i|
-        @document.create_note_for(:name, "Note number #{i}")
-      end
-
-      #expectations
-      notes = @document.notes_for(:name)
-      notes.count.should eq 2
-      note_to_be_deleted = notes[0].note
-      
-      @document.delete_note_for(:name,notes[0].id)
-      
-      notes = @document.notes_for(:name)
-      notes.count.should eq 1
-      notes.first.note.should_not eq note_to_be_deleted
-
-    end
-
-    it "should verify that notes_for sort by updated_at descending" do
-      #fixtures
-      3.times do |i|
-        sleep 1.seconds
-        @document.create_note_for(:name, "Note number #{i}")
-      end
-
-      #expectations
-      @document.notes_for(:name).first.note.should eq "Note number 2"
-      @document.notes_for(:name).last.note.should eq "Note number 0"
-    end
-    
-    it "should find a note by id" do
-
-      3.times do |i|
-        @document.create_note_for(:name, "Note number #{i}")
-      end
-      
-      note = @document.notes_for(:name).last
-      id = note.id
-      
-      match_note = @document.note_for :name,id
-      match_note.id.should eq id 
-      
-    end
-
-    it "should has_notes_for verify if defined field has notes" do
-      @document.has_notes_for(:name).should be_false
-      @document.create_note_for(:name, "new note")
-      @document.has_notes_for(:name).should be_true      
-    end
-
-  end
-
   context "history" do
 
     before(:each) do
@@ -257,132 +103,7 @@ describe ActiveMetadata do
 
   end
 
-  context "attachments" do
-
-    before(:each) do
-      @document = Document.create! { |d| d.name = "John" }
-      @document.reload
-      doc = File.expand_path('../support/pdf_test.pdf',__FILE__)
-      @attachment = Rack::Test::UploadedFile.new(doc, "application/pdf")
-      doc2 = File.expand_path('../support/pdf_test_2.pdf',__FILE__)
-      @attachment2 = Rack::Test::UploadedFile.new(doc2, "application/pdf")
-    end
-
-    it "should save attachment for a given attribute" do
-      @document.save_attachment_for(:name,@attachment)
-      @document.attachments_for(:name).should have(1).record
-    end
-
-    it "should verify that the attachment metadata id refers to the correct self id" do
-      @document.save_attachment_for(:name,@attachment)
-      @document.attachments_for(:name).last.document_id.should eq @document.id
-    end
-
-    it "should verify that the attachment file name is correctly saved" do
-      @document.save_attachment_for(:name,@attachment)
-      @document.attachments_for(:name).last.attach.original_filename.should eq @attachment.original_filename
-    end
-
-    it "should verify that the attachment content type is correctly saved" do
-      @document.save_attachment_for(:name,@attachment)
-      @document.attachments_for(:name).last.attach.content_type.should eq @attachment.content_type
-    end
-
-    it "should verify that the attachment size is correctly saved" do
-      @document.save_attachment_for(:name,@attachment)
-      @document.attachments_for(:name).last.attach.size.should eq @attachment.size
-    end
-
-    it "should verify that the attachment updated_at is correctly saved"  do
-      @document.save_attachment_for(:name,@attachment)      
-      @document.attachments_for(:name).last.attach.instance_read(:updated_at).should be_a_kind_of Time
-    end
-
-    it "should verify that the document has been saved in the correct position on filesystem"  do
-      @document.save_attachment_for(:name,@attachment)
-      att = @document.attachments_for(:name).first
-      expected_path = File.expand_path "#{ActiveMetadata::CONFIG['attachment_base_path']}/#{att.document_class}/#{@document.id}/#{:name.to_s}/#{att.id}/#{@attachment.original_filename}"
-      File.exists?(expected_path).should be_true
-    end
-
-    it "should delete an attachment by id" do
-      #fixtures
-      2.times do |i|
-        @document.save_attachment_for(:name,@attachment)
-      end
-
-      #expectations
-      attachments = @document.attachments_for(:name)
-      attachments.count.should eq 2
-      attachment_path_to_be_deleted = attachments[0].attach.path
-      
-      @document.delete_attachment_for(:name,attachments[0].id)
-      
-      attachments = @document.attachments_for(:name)
-      attachments.count.should eq 1
-      attachments.first.attach.path.should_not eq attachment_path_to_be_deleted
-    end
-
-    it "should update an attachment" do
-      @document.save_attachment_for(:name,@attachment)
-      att = @document.attachments_for(:name).last
-      @document.update_attachment_for :name,att.id,@attachment2
-      att2 = @document.attachments_for(:name).last
-
-      File.exists?(att.attach.path).should be_false
-      File.exists?(att2.attach.path).should be_true
-    end
-
-    it "should verify that field attachment_updated_at is modified after an update" do
-      @document.save_attachment_for(:name,@attachment)
-      att = @document.attachments_for(:name).last
-
-      sleep 1.seconds
-
-      @document.update_attachment_for :name,att.id,@attachment2
-      att2 = @document.attachments_for(:name).last
-
-      att2.attach.instance_read(:updated_at).should be > att.attach.instance_read(:updated_at)
-    end
-    
-    it "should verify that is possible to upload 2 files with the same name for the same field" do
-      2.times do
-        @document.save_attachment_for(:name,@attachment)
-      end  
-      
-      #expectations
-      attachments = @document.attachments_for :name
-      attachments.count.should eq 2
-      File.exists?(attachments[0].attach.path).should be_true
-      attachments[0].attach.instance_read(:file_name).should eq "pdf_test.pdf"
-      File.exists?(attachments[1].attach.path).should be_true
-      attachments[1].attach.instance_read(:file_name).should eq "pdf_test.pdf"
-    end
-
-    it "should save the correct creator when an attachment is created" do
-      @document.save_attachment_for(:name,@attachment)
-      @document.attachments_for(:name).last.created_by.should eq User.current.id
-    end
-
-    it "should save the correct updater when anttachment is updated" do
-      @document.save_attachment_for(:name,@attachment)
-      att = @document.attachments_for(:name).last
-
-      @document.update_attachment_for :name,att.id,@attachment2
-      att2 = @document.attachments_for(:name).last
-      
-      @document.attachments_for(:name).last.updated_by.should eq User.current.id        
-    end
-
-    it "should has_notes_for verify if defined field has attachments" do
-      @document.has_attachments_for(:name).should be_false
-      @document.save_attachment_for(:name,@attachment)
-      @document.has_attachments_for(:name).should be_true      
-    end
-    
-  end
-          
-  context "watchers" do        
+  context "watchers" do
     before(:each) do
       @document = Document.create! { |d| d.name = "John" }
     end
@@ -434,4 +155,5 @@ describe ActiveMetadata do
     end
 
   end
+
 end

data/spec/attachments_spec.rb

@@ -0,0 +1,182 @@
+require "spec_helper"
+require "rack/test/uploaded_file"
+require "time"
+
+describe ActiveMetadata do
+
+  context "attachments" do
+
+    before(:each) do
+      @document = Document.create! { |d| d.name = "John" }
+      @document.reload
+      doc = File.expand_path('../support/pdf_test.pdf', __FILE__)
+      @attachment = Rack::Test::UploadedFile.new(doc, "application/pdf")
+      doc2 = File.expand_path('../support/pdf_test_2.pdf', __FILE__)
+      @attachment2 = Rack::Test::UploadedFile.new(doc2, "application/pdf")
+    end
+
+
+    context "saving and quering" do
+
+      it "should save attachment for a given attribute" do
+        @document.save_attachment_for(:name, @attachment)
+        @document.attachments_for(:name).should have(1).record
+      end
+
+      it "should verify that the attachment metadata id refers to the correct self id" do
+        @document.save_attachment_for(:name, @attachment)
+        @document.attachments_for(:name).last.document_id.should eq @document.id
+      end
+
+      it "should verify that the attachment file name is correctly saved" do
+        @document.save_attachment_for(:name, @attachment)
+        @document.attachments_for(:name).last.attach.original_filename.should eq @attachment.original_filename
+      end
+
+      it "should verify that the attachment content type is correctly saved" do
+        @document.save_attachment_for(:name, @attachment)
+        @document.attachments_for(:name).last.attach.content_type.should eq @attachment.content_type
+      end
+
+      it "should verify that the attachment size is correctly saved" do
+        @document.save_attachment_for(:name, @attachment)
+        @document.attachments_for(:name).last.attach.size.should eq @attachment.size
+      end
+
+      it "should verify that the attachment updated_at is correctly saved" do
+        @document.save_attachment_for(:name, @attachment)
+        @document.attachments_for(:name).last.attach.instance_read(:updated_at).should be_a_kind_of Time
+      end
+
+      it "should verify that the document has been saved in the correct position on filesystem" do
+        @document.save_attachment_for(:name, @attachment)
+        att = @document.attachments_for(:name).first
+        expected_path = File.expand_path "#{ActiveMetadata::CONFIG['attachment_base_path']}/#{att.document_class}/#{@document.id}/#{:name.to_s}/#{att.id}/#{@attachment.original_filename}"
+        File.exists?(expected_path).should be_true
+      end
+
+      it "should delete an attachment by id" do
+        #fixtures
+        2.times do |i|
+          @document.save_attachment_for(:name, @attachment)
+        end
+
+        #expectations
+        attachments = @document.attachments_for(:name)
+        attachments.count.should eq 2
+        attachment_path_to_be_deleted = attachments[0].attach.path
+
+        @document.delete_attachment(attachments[0].id)
+
+        attachments = @document.attachments_for(:name)
+        attachments.count.should eq 1
+        attachments.first.attach.path.should_not eq attachment_path_to_be_deleted
+      end
+
+      it "should update an attachment" do
+        @document.save_attachment_for(:name, @attachment)
+        att = @document.attachments_for(:name).last
+        @document.update_attachment att.id, @attachment2
+        att2 = @document.attachments_for(:name).last
+
+        File.exists?(att.attach.path).should be_false
+        File.exists?(att2.attach.path).should be_true
+      end
+
+      it "should verify that field attachment_updated_at is modified after an update" do
+        @document.save_attachment_for(:name, @attachment)
+        att = @document.attachments_for(:name).last
+
+        sleep 1.seconds
+
+        @document.update_attachment att.id, @attachment2
+        att2 = @document.attachments_for(:name).last
+
+        att2.attach.instance_read(:updated_at).should be > att.attach.instance_read(:updated_at)
+      end
+
+      it "should verify that is possible to upload 2 files with the same name for the same field" do
+        2.times do
+          @document.save_attachment_for(:name, @attachment)
+        end
+
+        #expectations
+        attachments = @document.attachments_for :name
+        attachments.count.should eq 2
+        File.exists?(attachments[0].attach.path).should be_true
+        attachments[0].attach.instance_read(:file_name).should eq "pdf_test.pdf"
+        File.exists?(attachments[1].attach.path).should be_true
+        attachments[1].attach.instance_read(:file_name).should eq "pdf_test.pdf"
+      end
+
+      it "should save the correct creator when an attachment is created" do
+        @document.save_attachment_for(:name, @attachment)
+        @document.attachments_for(:name).last.created_by.should eq User.current.id
+      end
+
+      it "should save the correct updater when anttachment is updated" do
+        @document.save_attachment_for(:name, @attachment)
+        att = @document.attachments_for(:name).last
+
+        @document.update_attachment att.id, @attachment2
+        att2 = @document.attachments_for(:name).last
+
+        @document.attachments_for(:name).last.updated_by.should eq User.current.id
+      end
+
+      it "should has_notes_for verify if defined field has attachments" do
+        @document.has_attachments_for(:name).should be_false
+        @document.save_attachment_for(:name, @attachment)
+        @document.has_attachments_for(:name).should be_true
+      end
+
+    end
+
+    describe "managing starred" do
+
+      it "should craete starred attachments" do
+        @document.save_attachment_for(:name, @attachment, true)
+        @document.attachments_for(:name).first.starred?.should be_true
+      end
+
+      it "should update an attachment as starred" do
+        @document.save_attachment_for(:name, @attachment)
+        attachment = @document.attachments_for(:name).first
+        @document.update_attachment(attachment.id, attachment.attach, true)
+        @document.attachments_for(:name).first.starred?.should be_true
+      end
+
+      it "should retrieve only starred attachments for a given label" do
+        @document.save_attachment_for(:name, @attachment, true)
+        @document.save_attachment_for(:name, @attachment2)
+
+        atts = @document.starred_attachments_for(:name)
+        atts.size.should eq 1
+      end
+
+      it "should set an attachment as starred using star method" do
+        @document.save_attachment_for(:name, @attachment2)
+        att = @document.attachments_for(:name).first
+
+        @document.star_attachment(att.id)
+
+        att = @document.find_attachment_by_id(att.id)
+        att.starred?.should be_true
+      end
+
+      it "should unstar" do
+        @document.save_attachment_for(:name, @attachment, true)
+        att = @document.starred_attachments_for(:name).first
+
+        @document.unstar_attachment(att.id)
+
+        att = @document.find_attachment_by_id(att.id)
+        att.starred?.should be_false
+      end
+
+    end
+
+
+  end
+
+end

data/spec/notes_spec.rb

@@ -0,0 +1,208 @@
+require "spec_helper"
+require "time"
+
+describe ActiveMetadata do
+
+  before(:each) do
+    @document = Document.create! { |d| d.name = "John" }
+    @document.reload
+  end
+
+  describe "notes" do
+
+    context "saving and quering" do
+
+      it "should create a new note for a given field" do
+        @document.create_note_for(:name, "Very important note!")
+        @document.notes_for(:name).should have(1).record
+      end
+
+
+      it "should verify the content of a note created" do
+        @document.create_note_for(:name, "Very important note!")
+        @document.notes_for(:name).last.note.should eq "Very important note!"
+      end
+
+      it "should verify that notes are created for the correct model" do
+        @document.create_note_for(:name, "Very important note!")
+        @document.notes_for(:name).last.document_class.should eq(@document.class.to_s)
+      end
+
+      it "should verify the created_by of a note created" do
+        @document.create_note_for(:name, "Very important note!")
+        @document.notes_for(:name).last.created_by.should eq User.current.id
+      end
+
+      it "should verify that notes_for_name return only notes for the self Document" do
+        # fixtures
+        @another_doc = Document.create :name => "Andrea"
+        @another_doc.create_note_for(:name, "Very important note for doc2!")
+        @another_doc.reload
+        @document.create_note_for(:name, "Very important note!")
+
+        # expectations
+        @document.notes_for(:name).count.should eq(1)
+        @document.notes_for(:name).last.note.should eq "Very important note!"
+        @another_doc.notes_for(:name).last.note.should eq "Very important note for doc2!"
+
+      end
+
+      it "should update a note using update_note_for_name" do
+        @document.create_note_for(:name, "Very important note!")
+        id = @document.notes_for(:name).last.id
+        @document.update_note(id, "New note value!")
+        @document.notes_for(:name).last.note.should eq "New note value!"
+      end
+
+      it "should verify the content of a note created for a second attribute" do
+        @document.create_note_for(:name, "Very important note!")
+        @document.create_note_for(:surname, "Note on surname attribute!")
+
+        @document.notes_for(:name).last.note.should eq "Very important note!"
+        @document.notes_for(:surname).last.note.should eq "Note on surname attribute!"
+      end
+
+      it "should save multiple notes" do
+        notes = ["note number 1", "note number 2"]
+        @document.create_notes_for(:name, notes)
+        @document.notes_for(:name).should have(2).record
+      end
+
+      it "should save the updater id in metadata" do
+        @document.create_note_for(:name, "Very important note!")
+        id = @document.notes_for(:name).last.id
+        @document.update_note id, "new note value"
+        @document.notes_for(:name).last.updated_by.should eq User.current.id
+      end
+
+      it "should save the created_at datetime in metadata" do
+        @document.create_note_for(:name, "Very important note!")
+        @document.notes_for(:name).last.created_at.should be_a_kind_of Time
+      end
+
+      it "should save the updated_at datetime in metadata" do
+        @document.create_note_for(:name, "Very important note!")
+        @document.notes_for(:name).last.updated_at.should be_a_kind_of Time
+      end
+
+      it "should update the updated_at field when a note is updated" do
+        @document.create_note_for(:name, "Very important note!")
+        id = @document.notes_for(:name).last.id
+        sleep 1.seconds
+        @document.update_note id, "new note value"
+        note = @document.notes_for(:name).last
+        note.updated_at.should > note.created_at
+      end
+
+      it "should verify that note are saved with the correct model id if metadata_id_from is defined" do
+        # fixtures
+        @document.create_note_for(:name, "Very important note!")
+        @section = @document.create_section :title => "new section"
+        @section.reload
+        @section.create_note_for(:title, "Very important note for section!")
+
+        # expectations
+        @document.notes_for(:name).last.document_id.should eq @document.id
+        @section.notes_for(:title).last.document_id.should eq @document.id
+      end
+
+      it "should delete a note id" do
+        #fixtures
+        2.times do |i|
+          @document.create_note_for(:name, "Note number #{i}")
+        end
+
+        #expectations
+        notes = @document.notes_for(:name)
+        notes.count.should eq 2
+        note_to_be_deleted = notes[0].note
+
+        @document.delete_note(notes[0].id)
+
+        notes = @document.notes_for(:name)
+        notes.count.should eq 1
+        notes.first.note.should_not eq note_to_be_deleted
+
+      end
+
+      it "should verify that notes_for sort by updated_at descending" do
+        #fixtures
+        3.times do |i|
+          sleep 1.seconds
+          @document.create_note_for(:name, "Note number #{i}")
+        end
+
+        #expectations
+        @document.notes_for(:name).first.note.should eq "Note number 2"
+        @document.notes_for(:name).last.note.should eq "Note number 0"
+      end
+
+      it "should find a note by id" do
+
+        3.times do |i|
+          @document.create_note_for(:name, "Note number #{i}")
+        end
+
+        note = @document.notes_for(:name).last
+        id = note.id
+
+        match_note = @document.find_note_by_id id
+        match_note.id.should eq id
+
+      end
+
+      it "should has_notes_for verify if defined field has notes" do
+        @document.has_notes_for(:name).should be_false
+        @document.create_note_for(:name, "new note")
+        @document.has_notes_for(:name).should be_true
+      end
+
+    end
+
+    describe "managing starred" do
+
+      it "should craete starred note" do
+        @document.create_note_for(:name, "nuova nota", true)
+        @document.notes_for(:name).first.starred?.should be_true
+      end
+
+      it "should update a note as starred" do
+        @document.create_note_for(:name, "nuova nota")
+        note = @document.notes_for(:name).first
+        @document.update_note(note.id, note.note, true)
+        @document.notes_for(:name).first.starred?.should be_true
+      end
+
+      it "should retrieve only starred notes for a given label" do
+        @document.create_note_for(:name, "starred note", true)
+        @document.create_note_for(:name, "nuova nota")
+
+        notes = @document.starred_notes_for(:name)
+        notes.size.should eq 1
+        notes.first.note.should eq "starred note"
+      end
+
+      it "should set a note as starred using star method" do
+        @document.create_note_for(:name, "nota 1")
+        nota = @document.notes_for(:name).first
+
+        @document.star_note(nota.id)
+
+        nota = @document.find_note_by_id(nota.id)
+        nota.starred?.should be_true
+      end
+
+      it "should unstar a note" do
+        @document.create_note_for(:name, "nota 1", true)
+        nota = @document.notes_for(:name).first
+
+        @document.unstar_note(nota.id)
+
+        nota = @document.find_note_by_id(nota.id)
+        nota.starred?.should be_false
+      end
+
+    end
+
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_metadata
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.5.0
   prerelease: 
 platform: ruby
 authors:
@@ -10,11 +10,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-11-14 00:00:00.000000000Z
+date: 2011-11-21 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec-rails
-  requirement: &2165112740 !ruby/object:Gem::Requirement
+  requirement: &70240621249380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -22,10 +22,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2165112740
+  version_requirements: *70240621249380
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &2165106080 !ruby/object:Gem::Requirement
+  requirement: &70240621248800 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -33,10 +33,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2165106080
+  version_requirements: *70240621248800
 - !ruby/object:Gem::Dependency
   name: sqlite3-ruby
-  requirement: &2165094420 !ruby/object:Gem::Requirement
+  requirement: &70240621247520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -44,10 +44,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2165094420
+  version_requirements: *70240621247520
 - !ruby/object:Gem::Dependency
   name: cucumber
-  requirement: &2165088920 !ruby/object:Gem::Requirement
+  requirement: &70240621247060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -55,10 +55,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2165088920
+  version_requirements: *70240621247060
 - !ruby/object:Gem::Dependency
   name: ci_reporter
-  requirement: &2165079800 !ruby/object:Gem::Requirement
+  requirement: &70240621246620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -66,10 +66,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2165079800
+  version_requirements: *70240621246620
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &2165077260 !ruby/object:Gem::Requirement
+  requirement: &70240621245860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - =
@@ -77,10 +77,10 @@ dependencies:
         version: 3.0.1
   type: :runtime
   prerelease: false
-  version_requirements: *2165077260
+  version_requirements: *70240621245860
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &2165073960 !ruby/object:Gem::Requirement
+  requirement: &70240621245240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - =
@@ -88,10 +88,10 @@ dependencies:
         version: 3.0.1
   type: :runtime
   prerelease: false
-  version_requirements: *2165073960
+  version_requirements: *70240621245240
 - !ruby/object:Gem::Dependency
   name: paperclip
-  requirement: &2165067820 !ruby/object:Gem::Requirement
+  requirement: &70240621236040 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -99,18 +99,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2165067820
-- !ruby/object:Gem::Dependency
-  name: to_xls
-  requirement: &2165056320 !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: *2165056320
+  version_requirements: *70240621236040
 description: First implementation will write metadata on mongodb
 email:
 - acampolonghi@gmail.com
@@ -175,9 +164,11 @@ files:
 - features/watchlist/add_a_user_to_a_watcher.feature
 - features/watchlist/trigger_alert_on_modify.feature
 - spec/active_metadata_spec.rb
+- spec/attachments_spec.rb
 - spec/benchmark_spec.rb
 - spec/concurrency_spec.rb
 - spec/controllers/metadata_controller_spec.rb
+- spec/notes_spec.rb
 - spec/spec_helper.rb
 - spec/support/document.rb
 - spec/support/pdf_test.pdf
@@ -199,7 +190,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1217831110724826394
+      hash: -4250317635104951696
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -208,10 +199,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1217831110724826394
+      hash: -4250317635104951696
 requirements: []
 rubyforge_project: active_metadata
-rubygems_version: 1.8.11
+rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
 summary: Add metadata to fields in an active record model
@@ -224,9 +215,11 @@ test_files:
 - features/watchlist/add_a_user_to_a_watcher.feature
 - features/watchlist/trigger_alert_on_modify.feature
 - spec/active_metadata_spec.rb
+- spec/attachments_spec.rb
 - spec/benchmark_spec.rb
 - spec/concurrency_spec.rb
 - spec/controllers/metadata_controller_spec.rb
+- spec/notes_spec.rb
 - spec/spec_helper.rb
 - spec/support/document.rb
 - spec/support/pdf_test.pdf