active_merchant_webpay 0.0.5 → 0.0.6

data/lib/active_merchant/billing/integrations/webpay/notification.rb

@@ -81,8 +81,9 @@ module ActiveMerchant #:nodoc:
             params['TBK_ORDEN_COMPRA']
           end
           
-          def fail!
+          def fail!(message=nil)
             @error = true
+            @message = message
           end
           
           def success?
@@ -94,7 +95,7 @@ module ActiveMerchant #:nodoc:
           end
           
           def message
-            RESPONSE_CODES[params['TBK_RESPUESTA']]
+            @message || RESPONSE_CODES[params['TBK_RESPUESTA']]
           end
 
           # Check the transaction's validity. This method has to be called after a new 
@@ -106,30 +107,23 @@ module ActiveMerchant #:nodoc:
           #     notify = Webpay::Notification.new(request.raw_post)
           # 
           #     if notify.valid? 
-          #       ... process order
+          #       if check order & ammount
+          #         # Process Order
+          #       else
+          #         notify.fail!
+          #       end
           #     else
           #       ... log possible hacking attempt ...
           #     end
           # 
           #     render :text => notify.acknowledge
           #   end
-          def valid?
-            return false if params['TBK_RESPUESTA'] != '0'
-            
-            if @valid.nil?
-              file = Tempfile.new 'webpay-mac-check'
-              file.write raw
-              file.close
-              executable = Webpay.cgis_root + '/tbk_check_mac.cgi'
-              @valid = ( `#{executable} #{file.path}`.strip == VALID_MAC_RESPONSE )
-              file.unlink
-            end
-            
-            @valid
+          def valid? 
+            valid_mac && params['TBK_RESPUESTA'] == '0'
           end
           
           def acknowledge
-            success? ? SUCCESS_RESPONSE : FAILURE_RESPONSE
+            @error ? FAILURE_RESPONSE : SUCCESS_RESPONSE
           end
           
           private
@@ -141,6 +135,21 @@ module ActiveMerchant #:nodoc:
                 params[key] = value
               end
             end
+            
+            def valid_mac
+              if @valid_mac.nil?
+                file = Tempfile.new 'webpay-mac-check'
+                file.write raw
+                file.close
+                executable = Webpay.cgis_root + '/tbk_check_mac.cgi'
+                @valid_mac = ( `#{executable} #{file.path}`.strip == VALID_MAC_RESPONSE )
+                file.unlink
+                
+                fail! 'Mac Invalido' unless @valid_mac
+              end
+              
+              @valid_mac
+            end
         end
       end
     end

data/lib/active_merchant/billing/integrations/webpay/version.rb

@@ -2,7 +2,7 @@ module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     module Integrations #:nodoc:
       module Webpay
-        VERSION = "0.0.5"
+        VERSION = "0.0.6"
       end
     end
   end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 0
-  - 5
-  version: 0.0.5
+  - 6
+  version: 0.0.6
 platform: ruby
 authors: 
 - "Sebasti\xC3\xA1n Gamboa"
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-02-11 00:00:00 -03:00
+date: 2011-02-16 00:00:00 -03:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency