active_merchant_ideal 0.1.6 → 0.1.7

data/.gitignore

@@ -0,0 +1,21 @@
+## MAC OS
+.DS_Store
+
+## TEXTMATE
+*.tmproj
+tmtags
+
+## EMACS
+*~
+\#*
+.\#*
+
+## VIM
+*.swp
+
+## PROJECT::GENERAL
+coverage
+rdoc
+pkg
+
+## PROJECT::SPECIFIC

data/Gemfile

@@ -0,0 +1,6 @@
+source "http://rubygems.org"
+
+gem 'activemerchant', '>= 1.5.1'
+gem 'rake'
+
+gemspec

data/Gemfile.lock

@@ -0,0 +1,42 @@
+PATH
+  remote: .
+  specs:
+    active_merchant_ideal (0.1.6)
+
+GEM
+  remote: http://rubygems.org/
+  specs:
+    active_utils (1.0.1)
+      activesupport (>= 2.3.11)
+      i18n
+    activemerchant (1.20.0)
+      active_utils (>= 1.0.1)
+      activesupport (>= 2.3.11)
+      braintree (>= 2.0.0)
+      builder (>= 2.0.0)
+      i18n
+      json (>= 1.5.1)
+      money (<= 3.7.1)
+    activesupport (3.1.3)
+      multi_json (~> 1.0)
+    braintree (2.13.1)
+      builder (>= 2.0.0)
+    builder (3.0.0)
+    i18n (0.6.0)
+    json (1.6.3)
+    metaclass (0.0.1)
+    mocha (0.10.0)
+      metaclass (~> 0.0.1)
+    money (3.7.1)
+      i18n (~> 0.4)
+    multi_json (1.0.4)
+    rake (0.9.2.2)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  active_merchant_ideal!
+  activemerchant (>= 1.5.1)
+  mocha
+  rake

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2010 Frank Oxener - Agile Dovadi B.V.
+Copyright (c) 2011 Frank Oxener - Agile Dovadi B.V.
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.textile

@@ -1,5 +1,14 @@
 h1. Active_merchant_ideal
 
+h2. ATTENTION: transition period with a new certificate (ING only)
+
+Recently ING issued a new iDEAL certificate, which should be in production before May 23 2011. See "Wijzigen van een acquiring certificaat in
+iDEAL Advanced":http://www.ing.nl/Images/Wijzigen_van_een_acquiring_certificaat_in_iDEAL_Advanced_internet_tcm7-82882.pdf. However ING is not able to say exactly when this migration will take place. This means there will be a transition period in which it's uncertain which iDEAL certificate is needed.
+
+Luckily Roel van Dijk (Voormedia BV) has written a gem/patch, so you can use the old and the new certificate during this transition period.
+
+See "active_merchant_ideal_multicert":https://github.com/rdvdijk/active_merchant_ideal_multicert
+
 h2. Description:
 
 "iDEAL":http://www.ideal.nl payment gateway for "ActiveMerchant":http://www.activemerchant.org.
@@ -32,10 +41,10 @@ As a gem:
 sudo gem install active_merchant_ideal 
 </pre>
 
-Add the following to your environment.rb:
+Add the following to your Gemfile:
 
 <pre>
-config.gem 'active_merchant_ideal'
+gem 'active_merchant_ideal'
 </pre>
 
 As a plugin:
@@ -69,18 +78,19 @@ h3. Test the gem
 You can run the tests from this gem with (inside the active_merchant_ideal directory):
 
 <pre>
-rake test
+ bundle install
+ bundle exec rake test
 </pre>
 
-h3. Run the remote tests (For ING BANK only)
+h3. Run the remote tests (For ING BANK and Rabobank only)
 
 * Create .active_merchant directory in your own home directory
 * Copy test/fixtures.yml to the .active_merchant directory
 * Fill in your own merchant id, passphrase and the correct locations to your private key and certificates.
-* For running the *seven prescribed remote test transactions* (ING bank) which are needed to activate the iDEAL account use 
+* For running the *seven prescribed remote test transactions* (ING bank and Rabobank) which are needed to activate the iDEAL account use 
 
 <pre>
-rake test:remote
+ bundle exec rake test:remote
 </pre>
 
 h3. Compatibility
@@ -94,14 +104,14 @@ h3. First configure the gateway
 Put the following code in, for instance, an initializer:
 
 <pre>
-IdealGateway.acquirer = :ing # Other banks preloaded are :abnamro and :rabobank
-IdealGateway.merchant_id = '00123456789'
-IdealGateway.passphrase = 'the_private_key_passphrase'
+ActiveMerchant::Billing::IdealGateway.acquirer = :ing # Other banks preloaded are :abnamro and :rabobank
+ActiveMerchant::Billing::IdealGateway.merchant_id = '00123456789'
+ActiveMerchant::Billing::IdealGateway.passphrase = 'the_private_key_passphrase'
 
 # CERTIFICATE_ROOT points to a directory where the key and certificates are located
-IdealGateway.private_key_file = File.join(CERTIFICATE_ROOT, 'private_key.pem')
-IdealGateway.private_certificate_file = File.join(CERTIFICATE_ROOT, 'private_certificate.cer')
-IdealGateway.ideal_certificate_file = File.join(CERTIFICATE_ROOT, 'ideal.cer')
+ActiveMerchant::Billing::IdealGateway.private_key_file = File.join(CERTIFICATE_ROOT, 'private_key.pem')
+ActiveMerchant::Billing::IdealGateway.private_certificate_file = File.join(CERTIFICATE_ROOT, 'private_certificate.cer')
+ActiveMerchant::Billing::IdealGateway.ideal_certificate_file = File.join(CERTIFICATE_ROOT, 'ideal.cer')
 </pre>
 
 h3. View
@@ -185,7 +195,7 @@ In 2007 this code was refactored as a patch for the ActiveMerchant library, this
 
 In 2009 Fingertips forked the ActiveMerchant library and added an iDEAL gateway (presumable based on the first ActiveMerchant patch) to a new ideal branch. 
 
-In 2010 this code was extracted and converted into a separate gem, so it can be more easily used in combination with the latest version of ActiveMerchant. This library is just an extraction, nothing more and nothing less. There are no fundamental changes between the code from the ideal branch and the code of this gem. Later that year "Sernin van de Krol":http://github/companeidos added support for ABN AMRO. 
+In 2010 this code was extracted and converted into a separate gem, so it can be more easily used in combination with the latest version of ActiveMerchant. This library is just an extraction, nothing more and nothing less. There are no fundamental changes between the code from the ideal branch and the code of this gem. Later that year "Sernin van de Krol":http://github.com/paneidos added support for ABN AMRO. 
 
 h2. Maintainer
 

data/Rakefile

@@ -1,23 +1,4 @@
-require 'rubygems'
-require 'rake'
-
-begin
-  require 'jeweler'
-  Jeweler::Tasks.new do |gem|
-    gem.name = "active_merchant_ideal"
-    gem.summary = %Q{iDEAL gateway for ActiveMerchant}
-    gem.description = %Q{iDEAL payment gateway for ActiveMerchant (see http://www.ideal.nl and http://www.activemerchant.org/)}
-    gem.email = "frank.oxener@gmail.com"
-    gem.homepage = "http://github.com/dovadi/active_merchant_ideal"
-    gem.authors = ["Soemirno Kartosoewito, Matthijs Kadijk, Aloy Duran, Frank Oxener"]
-    gem.add_dependency('activemerchant', '>= 1.5.1')
-    gem.add_development_dependency "mocha", ">= 0.9.7"
-    # gem is a Gem::Specification... see http://www.rubygems.org/read/chapter/20 for additional settings
-  end
-  Jeweler::GemcutterTasks.new
-rescue LoadError
-  puts "Jeweler (or a dependency) not available. Install it with: gem install jeweler"
-end
+require "bundler/gem_tasks"
 
 require 'rake/testtask'
 Rake::TestTask.new(:test) do |test|
@@ -30,21 +11,9 @@ namespace :test do
   desc "Run the remote tests for iDEAL gateway"
   Rake::TestTask.new(:remote) do |t|
     t.libs << "test"
-    t.test_files = FileList['remote_ideal_test.rb']
+    t.test_files = FileList['test/remote_ideal_test.rb']
     t.verbose = true
   end
 end
 
-task :test => :check_dependencies
-
 task :default => :test
-
-require 'rake/rdoctask'
-Rake::RDocTask.new do |rdoc|
-  version = File.exist?('VERSION') ? File.read('VERSION') : ""
-
-  rdoc.rdoc_dir = 'rdoc'
-  rdoc.title = "active_merchant_ideal #{version}"
-  rdoc.rdoc_files.include('README*')
-  rdoc.rdoc_files.include('lib/**/*.rb')
-end

data/active_merchant_ideal.gemspec

@@ -1,62 +1,28 @@
-# Generated by jeweler
-# DO NOT EDIT THIS FILE DIRECTLY
-# Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
+$:.push File.expand_path("../lib", __FILE__)
+require "active_merchant_ideal/version"
 
 Gem::Specification.new do |s|
   s.name = %q{active_merchant_ideal}
-  s.version = "0.1.6"
+  s.version      = ActiveMerchantIdeal::VERSION
+  s.authors      = ["Soemirno Kartosoewito, Matthijs Kadijk, Aloy Duran, Frank Oxener and many others"]
+  s.description  = %q{iDEAL payment gateway for ActiveMerchant (see http://www.ideal.nl and http://www.activemerchant.org/)}
+  s.summary      = %q{iDEAL gateway for ActiveMerchant}
+  s.email        = %q{frank.oxener@gmail.com}
+
+  s.homepage     = %q{http://github.com/dovadi/active_merchant_ideal}
 
-  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.authors = ["Soemirno Kartosoewito, Matthijs Kadijk, Aloy Duran, Frank Oxener"]
-  s.date = %q{2010-12-08}
-  s.description = %q{iDEAL payment gateway for ActiveMerchant (see http://www.ideal.nl and http://www.activemerchant.org/)}
-  s.email = %q{frank.oxener@gmail.com}
   s.extra_rdoc_files = [
-    "LICENSE",
-    "README.textile"
-  ]
-  s.files = [
-    ".document",
-    "LICENSE",
-    "README.textile",
-    "Rakefile",
-    "VERSION",
-    "active_merchant_ideal.gemspec",
-    "init.rb",
-    "lib/active_merchant_ideal.rb",
-    "lib/active_merchant_ideal/acquirers.yml",
-    "lib/active_merchant_ideal/ideal.rb",
-    "lib/active_merchant_ideal/ideal_response.rb",
-    "test/fixtures.yml",
-    "test/helper.rb",
-    "test/remote_ideal_test.rb",
-    "test/test_active_merchant_ideal.rb"
-  ]
-  s.homepage = %q{http://github.com/dovadi/active_merchant_ideal}
-  s.require_paths = ["lib"]
-  s.rubygems_version = %q{1.3.7}
-  s.summary = %q{iDEAL gateway for ActiveMerchant}
-  s.test_files = [
-    "test/helper.rb",
-    "test/remote_ideal_test.rb",
-    "test/test_active_merchant_ideal.rb"
-  ]
+     "LICENSE",
+     "README.textile"
+   ]
 
-  if s.respond_to? :specification_version then
-    current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
-    s.specification_version = 3
+  s.rubyforge_project = "active_merchant_ideal"
 
-    if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<activemerchant>, [">= 1.5.1"])
-      s.add_development_dependency(%q<mocha>, [">= 0.9.7"])
-    else
-      s.add_dependency(%q<activemerchant>, [">= 1.5.1"])
-      s.add_dependency(%q<mocha>, [">= 0.9.7"])
-    end
-  else
-    s.add_dependency(%q<activemerchant>, [">= 1.5.1"])
-    s.add_dependency(%q<mocha>, [">= 0.9.7"])
-  end
-end
+  s.files         = `git ls-files`.split("\n")
+  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
+  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
+  s.require_paths = ["lib"]
 
+  s.add_development_dependency "mocha"
+end

data/lib/active_merchant_ideal/ideal_response.rb

@@ -178,7 +178,8 @@ module ActiveMerchant #:nodoc:
       # <tt>:cancelled</tt>, <tt>:expired</tt>, <tt>:open</tt>, or
       # <tt>:failure</tt>.
       def status
-        text('//status').downcase.to_sym
+        status = text('//status')
+        status.downcase.to_sym unless status.blank?
       end
 
       # Returns whether or not the authenticity of the message could be
@@ -188,6 +189,23 @@ module ActiveMerchant #:nodoc:
                         verify(OpenSSL::Digest::SHA1.new, signature, message)
       end
 
+      # Returns the bankaccount number when the transaction was successful.
+      def consumer_account_number
+        text('//consumerAccountNumber')
+      end
+
+      # Returns the name on the bankaccount of the customer when the 
+      # transaction was successful.
+      def consumer_name
+        text('//consumerName')
+      end
+
+      # Returns the city on the bankaccount of the customer when the
+      # transaction was successful.
+      def consumer_city
+        text('//consumerCity')
+      end
+
       private
 
       # Checks if no errors occured _and_ if the message was authentic.

data/lib/active_merchant_ideal/version.rb

@@ -0,0 +1,3 @@
+module ActiveMerchantIdeal
+  VERSION = '0.1.7'
+end

data/test/remote_ideal_test.rb

@@ -65,6 +65,7 @@ class IdealTest < Test::Unit::TestCase
   end
 
   def test_successful_transaction
+    p capture_transaction(:success)
     assert_success capture_transaction(:success)
   end
 

data/test/test_active_merchant_ideal.rb

@@ -514,6 +514,15 @@ module IdealTestCases
 
       assert !capture_response.success?
     end
+    
+    def test_capture_of_consumer_fields
+      expects_request_and_returns ACQUIRER_SUCCEEDED_STATUS_RESPONSE
+      capture_response = @gateway.capture('0001023456789112')
+      
+      assert_equal '0949298989', capture_response.consumer_account_number
+      assert_equal 'Onderheuvel', capture_response.consumer_name
+      assert_equal 'DEN HAAG', capture_response.consumer_city
+    end
 
     def test_returns_status
       response = IdealStatusResponse.new(ACQUIRER_SUCCEEDED_STATUS_RESPONSE)

metadata

@@ -1,52 +1,36 @@
 --- !ruby/object:Gem::Specification 
 name: active_merchant_ideal
 version: !ruby/object:Gem::Version 
-  prerelease: false
+  hash: 21
+  prerelease: 
   segments: 
   - 0
   - 1
-  - 6
-  version: 0.1.6
+  - 7
+  version: 0.1.7
 platform: ruby
 authors: 
-- Soemirno Kartosoewito, Matthijs Kadijk, Aloy Duran, Frank Oxener
+- Soemirno Kartosoewito, Matthijs Kadijk, Aloy Duran, Frank Oxener and many others
 autorequire: 
 bindir: bin
 cert_chain: []
 
-date: 2010-12-08 00:00:00 +01:00
-default_executable: 
+date: 2011-12-14 00:00:00 Z
 dependencies: 
-- !ruby/object:Gem::Dependency 
-  name: activemerchant
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 1
-        - 5
-        - 1
-        version: 1.5.1
-  type: :runtime
-  version_requirements: *id001
 - !ruby/object:Gem::Dependency 
   name: mocha
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
-        - 9
-        - 7
-        version: 0.9.7
+        version: "0"
   type: :development
-  version_requirements: *id002
+  version_requirements: *id001
 description: iDEAL payment gateway for ActiveMerchant (see http://www.ideal.nl and http://www.activemerchant.org/)
 email: frank.oxener@gmail.com
 executables: []
@@ -58,21 +42,23 @@ extra_rdoc_files:
 - README.textile
 files: 
 - .document
+- .gitignore
+- Gemfile
+- Gemfile.lock
 - LICENSE
 - README.textile
 - Rakefile
-- VERSION
 - active_merchant_ideal.gemspec
 - init.rb
 - lib/active_merchant_ideal.rb
 - lib/active_merchant_ideal/acquirers.yml
 - lib/active_merchant_ideal/ideal.rb
 - lib/active_merchant_ideal/ideal_response.rb
+- lib/active_merchant_ideal/version.rb
 - test/fixtures.yml
 - test/helper.rb
 - test/remote_ideal_test.rb
 - test/test_active_merchant_ideal.rb
-has_rdoc: true
 homepage: http://github.com/dovadi/active_merchant_ideal
 licenses: []
 
@@ -86,6 +72,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
@@ -94,17 +81,19 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
 requirements: []
 
-rubyforge_project: 
-rubygems_version: 1.3.7
+rubyforge_project: active_merchant_ideal
+rubygems_version: 1.8.6
 signing_key: 
 specification_version: 3
 summary: iDEAL gateway for ActiveMerchant
 test_files: 
+- test/fixtures.yml
 - test/helper.rb
 - test/remote_ideal_test.rb
 - test/test_active_merchant_ideal.rb

data/VERSION

@@ -1 +0,0 @@
-0.1.6