active_merchant_allpay 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d467a9624b0f4d42c7dd14cb9b8ebf8db9c056df
-  data.tar.gz: 45a5dc9ed7b03596169a6c2df036ac34e71024f8
+  metadata.gz: f30de7a7d49b868d7b0b7a0523ff14a284973508
+  data.tar.gz: 79018eb6d538f59ff2e050d8608a11fc6f70c520
 SHA512:
-  metadata.gz: 337c0e216545c9cba715c918af82c82867ecd6a1bd9e85d93f05a04d6fc7e0cdb8014399c729afcb520f46f6a5a1e46fcdac158515c71e9d6720023e746e81fd
-  data.tar.gz: 75436bce4417065d222d079fc58fa89e9f033e4136b378261e29738b676b324ce1c19bc3c009bef1e8644035fcc981bd498f07f095a70511238a688b30bed97b
+  metadata.gz: eeced86fd5b1092c30d92de9695030cd381658734b55fb1036a4d96ed0ee51889bd669b5a7018f045059075ab7ef499e81495e0bc69789c359607da8e9df115d
+  data.tar.gz: a50767cbae566dfe7c0e42735bd197ef55baf796954a3266fe0ff306df91869d4b13b73ffb079d3f8f7ac7d30f4049945187e76bcce676dd78141b7c208e1653

data/README.md

@@ -1,13 +1,15 @@
 # ActiveMerchantAllpay
 
 This plugin is an active_merchant patch forAllpay(歐付寶) online payment in Taiwan.
-Now it supports Credit card(信用卡), ATM(虛擬ATM) and CVS(超商繳費).
+Now it supports Credit card(信用卡), ATM(虛擬ATM), Alipay(支付寶), CVS(超商繳費) and BARCODE(超商條碼).
+
+It has been tested on Rails 4.1.6 successfully.
 
 ## Installation
 
 Add this line to your application's Gemfile:
 
-    gem 'activemerchant'
+    gem 'activemerchant', "~> 1.43.3"
     gem 'active_merchant_allpay', '>=0.1.2'
 
 And then execute:
@@ -21,7 +23,7 @@ Or install it yourself as:
 
 ## Usage
 
-You can get Payment API and SPEC in [Allpay API](http://www.allpay.com.tw/Service/API).
+You can get Payment API and SPEC in [Allpay API](https://www.allpay.com.tw/Service/API_Help).
 Then create an initializer, like initializers/allpay.rb. Add the following configurations depends on your settings.
 
 ``` ruby
@@ -39,12 +41,16 @@ end
 ```
 
 ``` ruby
+
+# initializers/allpay.rb
 ActiveMerchant::Billing::Integrations::Allpay.setup do |allpay|
   if Rails.env.development?
-    allpay.merchant_id = '5566183'
-    allpay.hash_key    = '56cantdieohyeah'
-    allpay.hash_iv     = '183club'
+    # default setting for stage test
+    allpay.merchant_id = '2000132'
+    allpay.hash_key    = '5294y06JbISpM5x9'
+    allpay.hash_iv     = 'v77hoKGq4kWxNNIS'
   else
+    # change to yours
     allpay.merchant_id = '7788520'
     allpay.hash_key    = 'adfas123412343j'
     allpay.hash_iv     = '123ddewqerasdfas'
@@ -65,6 +71,12 @@ Now support three payment methods:
 
   # 3. CVS (convenience store)
   ActiveMerchant::Billing::Integrations::Allpay::PAYMENT_CVS
+  
+  # 4. Alipay
+  ActiveMerchant::Billing::Integrations::Allpay::PAYMENT_ALIPAY
+
+  # 5. BARCODE
+  ActiveMerchant::Billing::Integrations::Allpay::PAYMENT_BARCODE
 ```
 
 Once you’ve configured ActiveMerchantAllpay, you need a checkout form; it looks like:
@@ -77,11 +89,11 @@ Once you’ve configured ActiveMerchantAllpay, you need a checkout form; it look
     <% service.merchant_trade_no @order.payments.last.identifier %>
     <% service.merchant_trade_date @order.created_at %>
     <% service.total_amount @order.total.to_i %>
-    <% service.trade_desc @order.number %>
+    <% service.description @order.number %>
     <% service.item_name @order.number %>
     <% service.choose_payment ActiveMerchant::Billing::Integrations::Allpay::PAYMENT_ATM %>
-    <% service.client_back_url spree.orders_account_url %>
-    <% service.return_url allpay_atm_return_url %>
+    <% service.return_url spree.orders_account_url %>
+    <% service.notify_url allpay_atm_return_url %>
     <% service.encrypted_data %>
     <%= submit_tag 'Buy!' %>
   <% end %>
@@ -91,7 +103,7 @@ Also need a notification action when Allpay service notifies your server; it loo
 
 ``` ruby
   def notify
-    notification = ActiveMerchant::Billing::Integrations::Allpay::Notification.new(params)
+    notification = ActiveMerchant::Billing::Integrations::Allpay::Notification.new(request.raw_post)
 
     order = Order.find_by_number(notification.merchant_trade_no)
 
@@ -105,6 +117,30 @@ Also need a notification action when Allpay service notifies your server; it loo
   end
 ```
 
+## Troublechooting
+If you get a error "undefined method \`payment\_service\_for\`", you can add following configurations to initializers/allpay.rb. 
+```
+require "active_merchant/billing/integrations/action_view_helper"
+ActionView::Base.send(:include, ActiveMerchant::Billing::Integrations::ActionViewHelper)
+```
+
+Some allpay error due to CSRF token ("authenticity_token is not in spec"), you can add following scripts to remove them manually.
+```
+<script>
+$("input[name=utf8]").remove();
+$("input[name=authenticity_token]").remove();
+</script>
+```
+It's caused from payment\_service\_for helper function when generating by [offsite_payments](https://github.com/Shopify/offsite_payments) gem (offsite\_payments/lib/offsite\_payments/action\_view\_helper.rb)
+  
+
+## Upgrade Notes
+
+When upgrading from 0.1.3 and below to any higher versions, you need to make the following changes:
+
+- the notification initialize with raw post string (instead of a hash of params)
+- `return_url()` should be renamed to `notify_url()` (server-side callback url).
+
 ## Contributing
 
 1. Fork it

data/Rakefile

@@ -1 +1,19 @@
 require "bundler/gem_tasks"
+
+require 'rake/testtask'
+
+desc "Run the unit test suite"
+task :default => 'test:units'
+
+task :test => 'test:units'
+
+namespace :test do
+
+  Rake::TestTask.new(:units) do |t|
+    t.pattern = 'test/unit/**/*_test.rb'
+    t.ruby_opts << '-rubygems'
+    t.libs << 'test'
+    t.verbose = true
+  end
+
+end

data/active_merchant_allpay.gemspec

@@ -18,7 +18,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency 'activemerchant', '>= 1.9.4'
+  spec.add_dependency 'activemerchant', '~> 1.43.3'
+  spec.add_development_dependency('test-unit', '~> 2.5.5')
 
   spec.add_development_dependency('rake')
   spec.add_development_dependency('mocha', '~> 0.13.0')

data/lib/active_merchant/billing/integrations/allpay.rb

@@ -11,6 +11,22 @@ module ActiveMerchant #:nodoc:
         PAYMENT_CREDIT_CARD = 'Credit'
         PAYMENT_ATM         = 'ATM'
         PAYMENT_CVS         = 'CVS'
+        PAYMENT_ALIPAY      = 'Alipay'
+        PAYMENT_BARCODE     = 'BARCODE'
+
+        SUBPAYMENT_ATM_TAISHIN      = 'TAISHIN'
+        SUBPAYMENT_ATM_ESUN         = 'ESUN'
+        SUBPAYMENT_ATM_HUANAN       = 'HUANAN'
+        SUBPAYMENT_ATM_BOT          = 'BOT'
+        SUBPAYMENT_ATM_FUBON        = 'FUBON'
+        SUBPAYMENT_ATM_CHINATRUST   = 'CHINATRUST'
+        SUBPAYMENT_ATM_FIRST        = 'FIRST'
+
+        SUBPAYMENT_CVS_CVS    = 'CVS'
+        SUBPAYMENT_CVS_OK     = 'OK'
+        SUBPAYMENT_CVS_FAMILY = 'FAMILY'
+        SUBPAYMENT_CVS_HILIFE = 'HILIFE'
+        SUBPAYMENT_CVS_IBON   = 'IBON'
 
         PAYMENT_TYPE        = 'aio'
 
@@ -18,6 +34,7 @@ module ActiveMerchant #:nodoc:
         mattr_accessor :merchant_id
         mattr_accessor :hash_key
         mattr_accessor :hash_iv
+        mattr_accessor :debug
 
         def self.service_url
           mode = ActiveMerchant::Billing::Base.integration_mode

data/lib/active_merchant/billing/integrations/allpay/helper.rb

@@ -9,65 +9,126 @@ module ActiveMerchant #:nodoc:
       module Allpay
         class Helper < ActiveMerchant::Billing::Integrations::Helper
 
+          ### 常見介面
+
+          # 廠商編號
           mapping :merchant_id, 'MerchantID'
+          mapping :account, 'MerchantID' # AM common
+          # 廠商交易編號
           mapping :merchant_trade_no, 'MerchantTradeNo'
-          mapping :payment_type, 'PaymentType'
+          mapping :order, 'MerchantTradeNo' # AM common
+          # 交易金額
           mapping :total_amount, 'TotalAmount'
-          mapping :return_url, 'ReturnURL'
-          mapping :client_back_url, 'ClientBackURL'
+          mapping :amount, 'TotalAmount' # AM common
+          # 付款完成通知回傳網址
+          mapping :notify_url, 'ReturnURL' # AM common
+          # Client 端返回廠商網址
+          # mapping :client_back_url, 'ClientBackURL'
+          mapping :return_url, 'ClientBackURL' # AM common
+          # 付款完成 redirect 的網址
+          mapping :redirect_url, 'OrderResultURL'
+          # 交易描述
+          mapping :description, 'TradeDesc'
+          # 商品銷售網址
+          mapping :item_url, 'ItemURL'
+          # 是否需要額外的付款資訊, defalut: N
+          mapping :need_extra_paid_info, 'NeedExtraPaidInfo'
+          # 裝置來源, defalut: P
+          mapping :devise_source, 'DeviceSource'
+          # 忽略的付款方式
+          mapping :ignore_payment, 'IgnorePayment'
+          # 特約合作平台商代號(由allpay提供)
+          mapping :platform_id, 'PlatformID'
+          # 電子發票開註記
+          mapping :invoice_mark, 'InvoiceMark'
+          # 是否延遲撥款, defalut: 0
+          mapping :hold_trade_amt, 'HoldTradeAMT'
+          # allpay 的會員編號
+          mapping :allpay_id, 'AllPayID'
+          # allpay 的會員識別碼
+          mapping :account_id, 'AccountID'
+          # CheckMacValue 加密類型, defalut: 0
+          mapping :encrypt_type, 'EncryptType'
+          # ATM 允許繳費有效天數
+          mapping :expire_date, 'ExpireDate'
+          # ATM, CVS 序號回傳網址 (Server Side)
+          mapping :payment_info_url, 'PaymentInfoURL'
+          # ATM, CVS 序號頁面回傳網址 (Client Side)
+          mapping :payment_redirect_url, 'ClientRedirectURL'
+          # BARCODE, CVS 超商繳費截止時間
+          mapping :store_expire_date, 'StoreExpireDate'
+          # BARCODE, CVS 交易描述1
+          mapping :desc_1, 'Desc_1'
+          # BARCODE, CVS 交易描述2
+          mapping :desc_2, 'Desc_2'
+          # BARCODE, CVS 交易描述3
+          mapping :desc_3, 'Desc_3'
+          # BARCODE, CVS 交易描述4
+          mapping :desc_4, 'Desc_4'
+
+          ### Allpay 專屬介面
+
+          # 交易類型
+          mapping :payment_type, 'PaymentType'
+
+          # 選擇預設付款方式
+          #   Credit:信用卡
+          #   WebATM:網路 ATM
+          #   ATM:自動櫃員機
+          #   CVS:超商代碼
+          #   BARCODE:超商條碼
+          #   Alipay:支付寶
+          #   Tenpay:財付通
+          #   TopUpUsed:儲值消費
+          #   ALL:不指定付款方式, 由歐付寶顯示付款方式 選擇頁面
           mapping :choose_payment, 'ChoosePayment'
 
+          mapping :choose_sub_payment, 'ChooseSubPayment'
+
+          # 商品名稱
+          # 多筆請以井號分隔 (#)
+          mapping :item_name, 'ItemName'
+
           def initialize(order, account, options = {})
             super
             add_field 'MerchantID', ActiveMerchant::Billing::Integrations::Allpay.merchant_id
             add_field 'PaymentType', ActiveMerchant::Billing::Integrations::Allpay::PAYMENT_TYPE
           end
 
-          def merchant_trade_no(trade_number)
-            add_field 'MerchantTradeNo', trade_number
-          end
-
           def merchant_trade_date(date)
             add_field 'MerchantTradeDate', date.strftime('%Y/%m/%d %H:%M:%S')
           end
 
-          def total_amount(amount)
-            add_field 'TotalAmount', amount
-          end
-
-          def trade_desc(description)
-            add_field 'TradeDesc', description
-          end
-
-          def item_name(item)
-            add_field 'ItemName', item
-          end
-
-          def choose_payment(payment)
-            add_field 'ChoosePayment', payment
-          end
-
-          def return_url(url)
-            add_field 'ReturnURL', url
-          end
-
-          def client_back_url(url)
-            add_field 'ClientBackURL', url
-          end
-
           def encrypted_data
 
             raw_data = @fields.sort.map{|field, value|
-              "#{field}=#{value}"
+              # utf8, authenticity_token, commit are generated from form helper, needed to skip
+              "#{field}=#{value}" if field!='utf8' && field!='authenticity_token' && field!='commit'
             }.join('&')
 
             hash_raw_data = "HashKey=#{ActiveMerchant::Billing::Integrations::Allpay.hash_key}&#{raw_data}&HashIV=#{ActiveMerchant::Billing::Integrations::Allpay.hash_iv}"
+            url_encode_data = self.class.url_encode(hash_raw_data)
+            url_encode_data.downcase!
 
-            url_endcode_data = (CGI::escape(hash_raw_data)).downcase
+            binding.pry if ActiveMerchant::Billing::Integrations::Allpay.debug
 
-            add_field 'CheckMacValue', Digest::MD5.hexdigest(url_endcode_data)
+            add_field 'CheckMacValue', Digest::MD5.hexdigest(url_encode_data).upcase
           end
 
+          # Allpay .NET url encoding
+          # Code based from CGI.escape()
+          # Some special characters (e.g. "()*!") are not escaped on Allpay server when they generate their check sum value, causing CheckMacValue Error.
+          #
+          # TODO: The following characters still cause CheckMacValue error:
+          #       '<', "\n", "\r", '&'
+          def self.url_encode(text)
+            text = text.dup
+            text.gsub!(/([^ a-zA-Z0-9\(\)\!\*_.-]+)/) do
+              '%' + $1.unpack('H2' * $1.bytesize).join('%')
+            end
+            text.tr!(' ', '+')
+            text
+          end
         end
       end
     end

data/lib/active_merchant/billing/integrations/allpay/notification.rb

@@ -14,14 +14,36 @@ module ActiveMerchant #:nodoc:
             end
           end
 
+          # TODO 使用查詢功能實作 acknowledge
+          # Allpay 沒有遠端驗證功能，
+          # 而以 checksum_ok? 代替
+          def acknowledge
+            checksum_ok?
+          end
+
+          def complete?
+            case @params['RtnCode']
+            when '1' #付款成功
+              true
+            when '2' # ATM 取號成功
+              true
+            when '10100073' # CVS 或 BARCODE 取號成功
+              true
+            when '800' #貨到付款訂單建立成功
+              true
+            else
+              false
+            end
+          end
+
           def checksum_ok?
-            checksum = @params.delete('CheckMacValue')
+            params_copy = @params.clone
 
-            @params.delete('controller')
-            @params.delete('action')
+            checksum = params_copy.delete('CheckMacValue')
 
             # 把 params 轉成 query string 前必須先依照 hash key 做 sort
-            raw_data = Hash[@params.sort].map do |x, y|
+            # 依照英文字母排序，由 A 到 Z 且大小寫不敏感
+            raw_data = params_copy.sort_by{ |k,v| k.downcase }.map do |x, y|
               "#{x}=#{y}"
             end.join('&')
 
@@ -32,16 +54,6 @@ module ActiveMerchant #:nodoc:
             (Digest::MD5.hexdigest(url_endcode_data) == checksum.to_s.downcase)
           end
 
-          def initialize(params)
-            self.params = params
-          end
-
-          def params=(params)
-            @params = params.inject({}) do |buffer, (name, value)|
-              buffer.merge(name.to_s => value)
-            end
-          end
-
           def rtn_code
             @params['RtnCode']
           end
@@ -50,21 +62,28 @@ module ActiveMerchant #:nodoc:
             @params['MerchantID']
           end
 
+          # 廠商交易編號
           def merchant_trade_no
             @params['MerchantTradeNo']
           end
+          alias :item_id :merchant_trade_no
 
           def rtn_msg
             @params['RtnMsg']
           end
 
+          # AllPay 的交易編號
           def trade_no
             @params['TradeNo']
           end
+          alias :transaction_id :trade_no
 
           def trade_amt
             @params['TradeAmt']
           end
+          def gross
+            ::Money.new(@params['TradeAmt'].to_i * 100, currency)
+          end
 
           def payment_date
             @params['PaymentDate']
@@ -90,17 +109,40 @@ module ActiveMerchant #:nodoc:
             @params['CheckMacValue']
           end
 
-          private
+          # for ATM
+          def bank_code
+            @params['BankCode']
+          end
 
-          # Take the posted data and move the relevant data into a hash
-          def parse(post)
-            @raw = post.to_s
-            for line in @raw.split('&')
-              key, value  = *line.scan(%r{^([A-Za-z0-9_.]+)\=(.*)$}).flatten
-              params[key] = CGI.unescape(value)
-            end
+          def v_account
+            @params['vAccount']
+          end
+
+          def expire_date
+            @params['ExpireDate']
+          end
+
+          # for CVS
+          def payment_no
+            @params['PaymentNo']
           end
 
+          def currency
+            'TWD'
+          end
+
+          # for BARCODE
+          def barcode1
+            @params['Barcode1']
+          end
+
+          def barcode2
+            @params['Barcode2']
+          end
+
+          def barcode3
+            @params['Barcode3']
+          end
         end
       end
     end

data/lib/active_merchant_allpay/version.rb

@@ -1,3 +1,3 @@
 module ActiveMerchantAllpay
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

data/test/test_helper.rb

@@ -0,0 +1,105 @@
+#!/usr/bin/env ruby
+$:.unshift File.expand_path('../../lib', __FILE__)
+
+begin
+  require 'rubygems'
+  require 'bundler'
+  Bundler.setup
+rescue LoadError => e
+  puts "Error loading bundler (#{e.message}): \"gem install bundler\" for bundler support."
+end
+
+require 'active_merchant_allpay'
+
+require 'test/unit'
+require 'money'
+
+ActiveMerchant::Billing::Base.mode = :test
+
+module ActiveMerchant
+  module Assertions
+    AssertionClass = Test::Unit::AssertionFailedError
+
+    def assert_field(field, value)
+      clean_backtrace do
+        assert_equal value, @helper.fields[field]
+      end
+    end
+
+    # Allows the testing of you to check for negative assertions:
+    #
+    #   # Instead of
+    #   assert !something_that_is_false
+    #
+    #   # Do this
+    #   assert_false something_that_should_be_false
+    #
+    # An optional +msg+ parameter is available to help you debug.
+    def assert_false(boolean, message = nil)
+      message = build_message message, '<?> is not false or nil.', boolean
+
+      clean_backtrace do
+        assert_block message do
+          not boolean
+        end
+      end
+    end
+
+    # A handy little assertion to check for a successful response:
+    #
+    #   # Instead of
+    #   assert_success response
+    #
+    #   # DRY that up with
+    #   assert_success response
+    #
+    # A message will automatically show the inspection of the response
+    # object if things go afoul.
+    def assert_success(response)
+      clean_backtrace do
+        assert response.success?, "Response failed: #{response.inspect}"
+      end
+    end
+
+    # The negative of +assert_success+
+    def assert_failure(response)
+      clean_backtrace do
+        assert_false response.success?, "Response expected to fail: #{response.inspect}"
+      end
+    end
+
+    def assert_valid(validateable)
+      clean_backtrace do
+        assert validateable.valid?, "Expected to be valid"
+      end
+    end
+
+    def assert_not_valid(validateable)
+      clean_backtrace do
+        assert_false validateable.valid?, "Expected to not be valid"
+      end
+    end
+
+    def assert_deprecation_warning(message, target)
+      target.expects(:deprecated).with(message)
+      yield
+    end
+
+    def assert_no_deprecation_warning(target)
+      target.expects(:deprecated).never
+      yield
+    end
+
+    private
+    def clean_backtrace(&block)
+      yield
+    rescue AssertionClass => e
+      path = File.expand_path(__FILE__)
+      raise AssertionClass, e.message, e.backtrace.reject { |line| File.expand_path(line) =~ /#{path}/ }
+    end
+  end
+end
+
+Test::Unit::TestCase.class_eval do
+  include ActiveMerchant::Assertions
+end

data/test/unit/integrations/helpers/allpay_helper_test.rb

@@ -6,4 +6,47 @@ class AllpayHelperTest < Test::Unit::TestCase
   def setup
   end
 
+  def test_check_mac_value
+    @helper = Allpay::Helper.new 'sdfasdfa', '12345678'
+    @helper.add_field 'ItemName', 'sdfasdfa'
+    @helper.add_field 'MerchantID', '12345678'
+    @helper.add_field 'MerchantTradeDate', '2013/03/12 15:30:23'
+    @helper.add_field 'MerchantTradeNo','allpay_1234'
+    @helper.add_field 'PaymentType', 'allpay'
+    @helper.add_field 'ReturnURL', 'http:sdfasdfa'
+    @helper.add_field 'TotalAmount', '500'
+    @helper.add_field 'TradeDesc', 'dafsdfaff'
+
+    ActiveMerchant::Billing::Integrations::Allpay.hash_key = 'xdfaefasdfasdfa32d'
+    ActiveMerchant::Billing::Integrations::Allpay.hash_iv = 'sdfxfafaeafwexfe'
+
+    @helper.encrypted_data
+
+    assert_equal '40D9A6C00A4A78A300ED458237071BDA', @helper.fields['CheckMacValue']
+  end
+
+  def test_check_mac_value_with_special_characters
+    @helper = Allpay::Helper.new 'R435729525344', '2000132'
+    @helper.add_field 'ItemName', 'Guava'
+    @helper.add_field 'MerchantID', '2000132'
+    @helper.add_field 'MerchantTradeDate', '2014/08/07 17:17:33'
+    @helper.add_field 'MerchantTradeNo','R435729525344'
+    @helper.add_field 'PaymentType', 'aio'
+    @helper.add_field 'ReturnURL', 'http://example.com/notify'
+    @helper.add_field 'TotalAmount', '1000'
+    @helper.add_field 'TradeDesc', ( '~`@#$%*^()_-+={}[]|\\"\'>,.?/:;' + "\t" )
+    @helper.add_field 'ChoosePayment', 'Credit'
+
+    ActiveMerchant::Billing::Integrations::Allpay.hash_key = '5294y06JbISpM5x9'
+    ActiveMerchant::Billing::Integrations::Allpay.hash_iv = 'v77hoKGq4kWxNNIS'
+
+    @helper.encrypted_data
+
+    assert_equal 'DF1186B7B8651F44380BEF8AB8A5727B', @helper.fields['CheckMacValue']
+  end
+
+  def test_url_encoding
+    encoded = Allpay::Helper.url_encode('-_.!~*() @#$%^&=+;?/\\><`[]{}:\'",|')
+    assert_equal encoded, '-_.!%7e*()+%40%23%24%25%5e%26%3d%2b%3b%3f%2f%5c%3e%3c%60%5b%5d%7b%7d%3a%27%22%2c%7c'
+  end
 end

data/test/unit/integrations/notifications/allpay_notification_test.rb

@@ -4,8 +4,35 @@ class AllpayNotificationTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations
 
   def setup
+    ActiveMerchant::Billing::Integrations::Allpay.hash_key = '5294y06JbISpM5x9'
+    ActiveMerchant::Billing::Integrations::Allpay.hash_iv = 'v77hoKGq4kWxNNIS'
     @allpay = Allpay::Notification.new(http_raw_data)
   end
 
+  def test_params
+    p = @allpay.params
 
+    assert_equal 12, p.size
+    assert_equal 'Credit_CreditCard', p['PaymentType']
+    assert_equal 'BC586977559ED305BEC4C334DFDC881D', p['CheckMacValue']
+    assert_equal '2014/04/15 15:39:38', p['PaymentDate']
+  end
+
+  def test_complete?
+    assert @allpay.complete?
+  end
+
+  def test_checksum_ok?
+    assert @allpay.checksum_ok?
+
+    # Should preserve mac value
+    assert @allpay.params['CheckMacValue'].present?
+  end
+
+  private
+
+  def http_raw_data
+    # Sample notification from test environment
+    "TradeAmt=2760&RtnMsg=付款成功&MerchantTradeNo=81397545579&PaymentType=Credit_CreditCard&TradeNo=1404151506342901&SimulatePaid=1&MerchantID=2000132&TradeDate=2014-04-15 15:06:34&PaymentDate=2014/04/15 15:39:38&PaymentTypeChargeFee=0&CheckMacValue=BC586977559ED305BEC4C334DFDC881D&RtnCode=1"
+  end
 end

metadata

@@ -1,29 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: active_merchant_allpay
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - xwaynec
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-14 00:00:00.000000000 Z
+date: 2015-09-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemerchant
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.9.4
+        version: 1.43.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.43.3
+- !ruby/object:Gem::Dependency
+  name: test-unit
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.5.5
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.9.4
+        version: 2.5.5
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -98,10 +112,10 @@ files:
 - lib/active_merchant/billing/integrations/allpay/notification.rb
 - lib/active_merchant_allpay.rb
 - lib/active_merchant_allpay/version.rb
+- test/test_helper.rb
 - test/unit/integrations/allpay_module_test.rb
 - test/unit/integrations/helpers/allpay_helper_test.rb
 - test/unit/integrations/notifications/allpay_notification_test.rb
-- test/unit/test_helper.rb
 homepage: https://github.com/xwaynec/active_merchant_allpay
 licenses:
 - MIT
@@ -122,12 +136,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: A rails plugin to add active_merchant patch for Taiwan payment
 test_files:
+- test/test_helper.rb
 - test/unit/integrations/allpay_module_test.rb
 - test/unit/integrations/helpers/allpay_helper_test.rb
 - test/unit/integrations/notifications/allpay_notification_test.rb
-- test/unit/test_helper.rb
+has_rdoc: 

data/test/unit/test_helper.rb

@@ -1,261 +0,0 @@
-#!/usr/bin/env ruby
-$:.unshift File.expand_path('../../lib', __FILE__)
-
-begin
-  require 'rubygems'
-  require 'bundler'
-  Bundler.setup
-rescue LoadError => e
-  puts "Error loading bundler (#{e.message}): \"gem install bundler\" for bundler support."
-end
-
-require 'test/unit'
-require 'money'
-require 'mocha/version'
-if(Mocha::VERSION.split(".")[1].to_i < 12)
-  require 'mocha'
-else
-  require 'mocha/setup'
-end
-require 'yaml'
-require 'json'
-require 'active_merchant'
-require 'comm_stub'
-
-require 'active_support/core_ext/integer/time'
-require 'active_support/core_ext/numeric/time'
-
-begin
-  require 'active_support/core_ext/time/acts_like'
-rescue LoadError
-end
-
-begin
-  gem 'actionpack'
-rescue LoadError
-  raise StandardError, "The view tests need ActionPack installed as gem to run"
-end
-
-require 'action_controller'
-require "action_view/template"
-begin
-  require 'active_support/core_ext/module/deprecation'
-  require 'action_dispatch/testing/test_process'
-rescue LoadError
-  require 'action_controller/test_process'
-end
-require 'active_merchant/billing/integrations/action_view_helper'
-
-ActiveMerchant::Billing::Base.mode = :test
-
-if ENV['DEBUG_ACTIVE_MERCHANT'] == 'true'
-  require 'logger'
-  ActiveMerchant::Billing::Gateway.logger = Logger.new(STDOUT)
-  ActiveMerchant::Billing::Gateway.wiredump_device = STDOUT
-end
-
-# Test gateways
-class SimpleTestGateway < ActiveMerchant::Billing::Gateway
-end
-
-class SubclassGateway < SimpleTestGateway
-end
-
-
-module ActiveMerchant
-  module Assertions
-    AssertionClass = RUBY_VERSION > '1.9' ? MiniTest::Assertion : Test::Unit::AssertionFailedError
-
-    def assert_field(field, value)
-      clean_backtrace do
-        assert_equal value, @helper.fields[field]
-      end
-    end
-
-    # Allows the testing of you to check for negative assertions:
-    #
-    #   # Instead of
-    #   assert !something_that_is_false
-    #
-    #   # Do this
-    #   assert_false something_that_should_be_false
-    #
-    # An optional +msg+ parameter is available to help you debug.
-    def assert_false(boolean, message = nil)
-      message = build_message message, '<?> is not false or nil.', boolean
-
-      clean_backtrace do
-        assert_block message do
-          not boolean
-        end
-      end
-    end
-
-    # A handy little assertion to check for a successful response:
-    #
-    #   # Instead of
-    #   assert response.success?
-    #
-    #   # DRY that up with
-    #   assert_success response
-    #
-    # A message will automatically show the inspection of the response
-    # object if things go afoul.
-    def assert_success(response, message=nil)
-      clean_backtrace do
-        assert response.success?, build_message(nil, "#{message + "\n" if message}Response expected to succeed: <?>", response)
-      end
-    end
-
-    # The negative of +assert_success+
-    def assert_failure(response, message=nil)
-      clean_backtrace do
-        assert !response.success?, build_message(nil, "#{message + "\n" if message}Response expected to fail: <?>", response)
-      end
-    end
-
-    def assert_valid(validateable)
-      clean_backtrace do
-        assert validateable.valid?, "Expected to be valid"
-      end
-    end
-
-    def assert_not_valid(validateable)
-      clean_backtrace do
-        assert_false validateable.valid?, "Expected to not be valid"
-      end
-    end
-
-    def assert_deprecation_warning(message, target)
-      target.expects(:deprecated).with(message)
-      yield
-    end
-
-    def assert_no_deprecation_warning(target)
-      target.expects(:deprecated).never
-      yield
-    end
-
-    private
-    def clean_backtrace(&block)
-      yield
-    rescue AssertionClass => e
-      path = File.expand_path(__FILE__)
-      raise AssertionClass, e.message, e.backtrace.reject { |line| File.expand_path(line) =~ /#{path}/ }
-    end
-  end
-
-  module Fixtures
-    HOME_DIR = RUBY_PLATFORM =~ /mswin32/ ? ENV['HOMEPATH'] : ENV['HOME'] unless defined?(HOME_DIR)
-    LOCAL_CREDENTIALS = File.join(HOME_DIR.to_s, '.active_merchant/fixtures.yml') unless defined?(LOCAL_CREDENTIALS)
-    DEFAULT_CREDENTIALS = File.join(File.dirname(__FILE__), 'fixtures.yml') unless defined?(DEFAULT_CREDENTIALS)
-
-    private
-    def credit_card(number = '4242424242424242', options = {})
-      defaults = {
-        :number => number,
-        :month => 9,
-        :year => Time.now.year + 1,
-        :first_name => 'Longbob',
-        :last_name => 'Longsen',
-        :verification_value => '123',
-        :brand => 'visa'
-      }.update(options)
-
-      Billing::CreditCard.new(defaults)
-    end
-
-    def check(options = {})
-      defaults = {
-        :name => 'Jim Smith',
-        :bank_name => 'Bank of Elbonia',
-        :routing_number => '244183602',
-        :account_number => '15378535',
-        :account_holder_type => 'personal',
-        :account_type => 'checking',
-        :number => '1'
-      }.update(options)
-
-      Billing::Check.new(defaults)
-    end
-
-    def address(options = {})
-      {
-        :name     => 'Jim Smith',
-        :address1 => '1234 My Street',
-        :address2 => 'Apt 1',
-        :company  => 'Widgets Inc',
-        :city     => 'Ottawa',
-        :state    => 'ON',
-        :zip      => 'K1C2N6',
-        :country  => 'CA',
-        :phone    => '(555)555-5555',
-        :fax      => '(555)555-6666'
-      }.update(options)
-    end
-
-    def all_fixtures
-      @@fixtures ||= load_fixtures
-    end
-
-    def fixtures(key)
-      data = all_fixtures[key] || raise(StandardError, "No fixture data was found for '#{key}'")
-
-      data.dup
-    end
-
-    def load_fixtures
-      [DEFAULT_CREDENTIALS, LOCAL_CREDENTIALS].inject({}) do |credentials, file_name|
-        if File.exists?(file_name)
-          yaml_data = YAML.load(File.read(file_name))
-          credentials.merge!(symbolize_keys(yaml_data))
-        end
-        credentials
-      end
-    end
-
-    def symbolize_keys(hash)
-      return unless hash.is_a?(Hash)
-
-      hash.symbolize_keys!
-      hash.each{|k,v| symbolize_keys(v)}
-    end
-  end
-end
-
-Test::Unit::TestCase.class_eval do
-  include ActiveMerchant::Billing
-  include ActiveMerchant::Assertions
-  include ActiveMerchant::Utils
-  include ActiveMerchant::Fixtures
-end
-
-module ActionViewHelperTestHelper
-
-  def self.included(base)
-    base.send(:include, ActiveMerchant::Billing::Integrations::ActionViewHelper)
-    base.send(:include, ActionView::Helpers::FormHelper)
-    base.send(:include, ActionView::Helpers::FormTagHelper)
-    base.send(:include, ActionView::Helpers::UrlHelper)
-    base.send(:include, ActionView::Helpers::TagHelper)
-    base.send(:include, ActionView::Helpers::CaptureHelper)
-    base.send(:include, ActionView::Helpers::TextHelper)
-    base.send(:attr_accessor, :output_buffer)
-  end
-
-  def setup
-    @controller = Class.new do
-      attr_reader :url_for_options
-      def url_for(options, *parameters_for_method_reference)
-        @url_for_options = options
-      end
-    end
-    @controller = @controller.new
-    @output_buffer = ''
-  end
-
-  protected
-  def protect_against_forgery?
-    false
-  end
-end