active_job_resque_solo 0.3.1.pre → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: '0779530df7b0ff6322789944e545c217f6f3f992'
-  data.tar.gz: 417d3d7404a04ad4ef5554ab9c1e7297f81eb1f5
+  metadata.gz: 3389e5a4e6baa27ff036950fe7d33481f11e2e4e
+  data.tar.gz: 6a35295a25a4dec30449fdfb37233b3e1eabd2df
 SHA512:
-  metadata.gz: 65aa07c7b0b884f4c8c5567f5fc55858b91b3cae21dc3177eb1d8f0278274496dcee8e435cbf71f24145a517af1593cebad43c1c8f25ab341c7403405795dd5c
-  data.tar.gz: '0608260af69a597c885e61137a4361a261b5a92d19a12977575b1302d3f93a92390e00a0244d92156ccaf4fcac00c016f82a504ed6bb9fc58d08dfd7ad352bcc'
+  metadata.gz: 21adde8385e257074f4fe58088ea3ea99eadecd6b48591445feece329c7a6edb06288c60076c2b04970956436df3a74f62abfcc9cd5602acb99861473ab92633
+  data.tar.gz: 1cb85b9a297521eec7360dc423fd64e2d6f2768a23605b6bd3a35158f84f9bd7dd5b6449d36bf1ef7b271cfa052857153d22f45abc88b7c8371b34ecbfdb95ba

data/.travis.yml

@@ -1,6 +1,8 @@
 sudo: false
 language: ruby
 rvm:
-  - 2.3.4
-  - 2.4.1
+  - 2.2.0
+  - 2.3.0
+  - 2.4.0
+  - ruby-head
 before_install: gem install bundler -v 1.15.4

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 0.3.2
+
+* Simplifies lock acquisition and tightens its restrictions, reducing chances of duplicate enqueues.
+
 # 0.3.1.pre
 
 * Improves Lock efficiency by removing one call to Redis during #extend.

data/active_job_resque_solo.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.email         = ["kinkadep@gmail.com"]
 
   spec.summary       = %q{Prevents duplicate ActiveJob+Resque jobs from being enqueued.}
-  spec.description   = %q{If you are using ActiveJob with the Resque Adapter, this gem will help prevent duplicate jobs, based on arguments, from being enqueued to Resque.}
+  spec.description   = %q{If you are using ActiveJob with the Resque Adapter, this gem will prevent a jobs, based on arguments, from being enqueued to Resque as long as a duplicate is already in queue or executing on a worker.}
   spec.license       = "MIT"
   spec.homepage      = "https://github.com/kinkade/active_job_resque_solo"
 
@@ -22,6 +22,8 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
+  spec.required_ruby_version = ">= 2.2.0"
+
   spec.add_dependency "rails", ">= 4.2.0", "< 6"
 
   spec.add_development_dependency "byebug"

data/lib/active_job/plugins/resque/solo/lock.rb

@@ -42,17 +42,9 @@ module ActiveJob
 
             if @redis.set(@key, @uuid, px: px, nx: true)
               @acquired = @uuid
-            else
-              extend_at = Time.now.utc
-              @acquired = @redis.get(@key)
             end
 
-            # Consider the lock not acquired if it is proven
-            # that another process has acquired the lock.
-            #
-            # It is unlikely that acquired will be nil, but
-            # it is possible if Redis is slow due to extreme load.
-            (@acquired.nil? || @acquired == @uuid) ? extend_at : nil
+            @acquired == @uuid ? extend_at : nil
           end
 
           def extend

data/lib/active_job_resque_solo/version.rb

@@ -1,3 +1,3 @@
 module ActiveJobResqueSolo
-  VERSION = "0.3.1.pre"
+  VERSION = "0.3.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_job_resque_solo
 version: !ruby/object:Gem::Version
-  version: 0.3.1.pre
+  version: 0.3.2
 platform: ruby
 authors:
 - Phillip Kinkade
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-09-08 00:00:00.000000000 Z
+date: 2017-09-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -86,8 +86,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: If you are using ActiveJob with the Resque Adapter, this gem will help
-  prevent duplicate jobs, based on arguments, from being enqueued to Resque.
+description: If you are using ActiveJob with the Resque Adapter, this gem will prevent
+  a jobs, based on arguments, from being enqueued to Resque as long as a duplicate
+  is already in queue or executing on a worker.
 email:
 - kinkadep@gmail.com
 executables: []
@@ -123,12 +124,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.6.6