active_job_log 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 885892cec8f03e18212d7007f1c68a7e0d4afa88138d2b43b022108e7c21d362
-  data.tar.gz: a636f27b11735eb31fcbff1646179fdc3ffa7e800bdfead02d1901b4f87e5bc1
+  metadata.gz: 5def13eb7b203c3386c901d816f013bcd862adc49c3bfa0cf29771fc57b2e676
+  data.tar.gz: 0cdf2baf1a11a9e1df69f69a785f0268a28c1db42b633d6f30e4043502847a93
 SHA512:
-  metadata.gz: daa6aa8c8ac55e37a0d598f271e33e21d942b13d2cdebb0565f73e3d7f4a97be27deb8edd077152480835e5c75b565c98d04f2b650631479510865ee7637a52a
-  data.tar.gz: 24dea753b7fce617c926fd3ea208d10ca3236a8ae2d14816cf210aeb737ccd332d214f28efab5f2b2c83de1334814a1742a0217667a4a474d94a23f503cfd010
+  metadata.gz: 7238509212fcc3cb8c972e5bd4979556ba942474dfa7ec0fe99f943e195ff7301cfc73e8965ae670c5b0ae719be99069ce1e2ddd07b201bc2f85703b1ddd757d
+  data.tar.gz: 07893eee397c648fc81b6db4bed16a9cfa7ab9bc8fa631d9438525c465ce2a645404a9852bac510785d9bc9224a424dbb25ae99153855ab8b9b9a2dcd10ed487

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+### v0.2.0
+
+#### Added
+
+* New Job instance by retry.
+
 ### v0.1.0
 
 * Initial release.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_job_log (0.1.0)
+    active_job_log (0.2.0)
       enumerize (>= 1.0)
       rails (>= 4.2.0)
 

data/README.md

@@ -1,5 +1,9 @@
 # Active Job Log
 
+[![Gem Version](https://badge.fury.io/rb/active_job_log.svg)](https://badge.fury.io/rb/active_job_log)
+[![Build Status](https://travis-ci.org/platanus/active_job_log.svg?branch=master)](https://travis-ci.org/platanus/active_job_log)
+[![Coverage Status](https://coveralls.io/repos/github/platanus/active_job_log/badge.svg?branch=master)](https://coveralls.io/github/platanus/active_job_log?branch=master)
+
 Rails engine to register jobs history, adding: job state, error feedback, duration, etc.
 
 ## Installation

data/app/models/active_job_log/job.rb

@@ -17,7 +17,7 @@ module ActiveJobLog
 
     def self.update_job!(job_id, status, params = {})
       params.merge!(status_to_params(status))
-      job = Job.find_or_create_by(job_id: job_id)
+      job = find_or_create_job(job_id)
       job.update_attributes!(params)
       job
     end
@@ -25,6 +25,10 @@ module ActiveJobLog
     class << self
       private
 
+      def find_or_create_job(job_id)
+        Job.where(job_id: job_id).where.not(status: :failed).last || Job.create(job_id: job_id)
+      end
+
       def status_to_params(status)
         time_attr = infer_duration_attr_from_status(status)
         {

data/lib/active_job_log/version.rb

@@ -1,3 +1,3 @@
 module ActiveJobLog
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 end

data/spec/models/active_job_log/job_spec.rb

@@ -117,71 +117,62 @@ RSpec.describe ActiveJobLog::Job, type: :model do
 
   describe "#update_job!" do
     let(:job_id) { "x" }
-    let(:status) { :queued }
-    let(:perform) { described_class.update_job!(job_id, status, params) }
+    let(:params) { {} }
 
-    let(:params) do
-      {
-        params: [1],
-        stack_trace: [2],
-        error: "error",
-        job_class: "MyJob"
-      }
+    def perform(status)
+      described_class.update_job!(job_id, status, params)
     end
 
-    it { expect { perform }.to change(ActiveJobLog::Job, :count).from(0).to(1) }
+    context "with params" do
+      let(:params) do
+        {
+          params: [1],
+          stack_trace: [2],
+          error: "error",
+          job_class: "MyJob"
+        }
+      end
 
-    context "with existent job" do
-      let!(:job) { create(:active_job_log_job, job_id: job_id) }
-
-      it { expect { perform }.not_to change(ActiveJobLog::Job, :count) }
-    end
-
-    context "with queued status" do
-      before { @job = perform }
+      before { @job = perform(:queued) }
 
       it { expect(@job.job_id).to eq(job_id) }
       it { expect(@job.error).to eq("error") }
       it { expect(@job.params).to eq([1]) }
       it { expect(@job.stack_trace).to eq([2]) }
       it { expect(@job.job_class).to eq("MyJob") }
+    end
+
+    context "with queued status" do
+      before { @job = perform(:queued) }
+
       it { expect(@job.status).to eq(:queued) }
       it { expect(@job.queued_at).not_to be_nil }
-      it { expect(@job.started_at).to be_nil }
-      it { expect(@job.ended_at).to be_nil }
+      it { expect { perform(:pending) }.not_to change(described_class, :count) }
     end
 
     context "with pending status" do
-      let(:status) { :pending }
-
-      before { @job = perform }
+      before { @job = perform(:pending) }
 
       it { expect(@job.status).to eq(:pending) }
-      it { expect(@job.queued_at).to be_nil }
       it { expect(@job.started_at).not_to be_nil }
-      it { expect(@job.ended_at).to be_nil }
+      it { expect { perform(:failed) }.not_to change(described_class, :count) }
+      it { expect { perform(:finished) }.not_to change(described_class, :count) }
     end
 
     context "with finished status" do
-      let(:status) { :finished }
-
-      before { @job = perform }
+      before { @job = perform(:finished) }
 
       it { expect(@job.status).to eq(:finished) }
-      it { expect(@job.queued_at).to be_nil }
-      it { expect(@job.started_at).to be_nil }
       it { expect(@job.ended_at).not_to be_nil }
     end
 
     context "with failed status" do
-      let(:status) { :failed }
-
-      before { @job = perform }
+      before { @job = perform(:failed) }
 
       it { expect(@job.status).to eq(:failed) }
-      it { expect(@job.queued_at).to be_nil }
-      it { expect(@job.started_at).to be_nil }
       it { expect(@job.ended_at).not_to be_nil }
+      it { expect { perform(:queued) }.to change(described_class, :count).from(1).to(2) }
+      it { expect { perform(:pending) }.to change(described_class, :count).from(1).to(2) }
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_job_log
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Platanus
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-05-18 00:00:00.000000000 Z
+date: 2018-06-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails