active_interaction 5.1.0 → 5.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c740eef14e1c0bca42f4bbb5b3718c879bc3af038f40953a60a53007611916e5
-  data.tar.gz: b0a3738aa38869c7be559d72f23e958d0f9e66c0f490652bd8a92e1ef449e48e
+  metadata.gz: 1205bfc3c95589bd74fdb6395e09573c01210a95bf5d6644b70fef11cacea914
+  data.tar.gz: 2494a61529d645f6dcfaef940e4d54e404bda94eb78eabbac605dcc14221e422
 SHA512:
-  metadata.gz: f998483eb21ec13a43dcf3c7b6805f7865b3dd7b4d8fbc9846263338d676c41c7991a602dd3a82e13a9b93a027cbeccd5648a87fef688964124935d38d9ef6c4
-  data.tar.gz: 4669a1e76a427af4a62415f242bfdc3fa45f7a63c5a43de704b7849639841f365e83168b5c1db68ab067ca2104f8f7ec580baa487e5caa6035196607033c79f8
+  metadata.gz: 6037171bd7f2ddc2af0204e2af5fdf0140725678698e7c4fa27875f16446c7c8be0b69aa83da30626bf9fe96ae00a5f76ffc92274cfd9654abad355e611df7ed
+  data.tar.gz: fac17df5266c5a72809fbc32ab3e84d840b35fe59cb2d483511b27c46beaec197b5a5e669d740ef023bf064df82a8ac8d5cbcd94bba60b3c5e0ba72969b385c2

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+# [5.1.1][] (2022-09-01)
+
+## Fixed
+
+- [#539][] - Fixed a caching error in default values.
+
 # [5.1.0][] (2022-07-28)
 
 ## Added
@@ -1112,6 +1118,7 @@ Example.run
 
 - Initial release.
 
+  [5.1.1]: https://github.com/AaronLasseigne/active_interaction/compare/v5.1.0...v5.1.1
   [5.1.0]: https://github.com/AaronLasseigne/active_interaction/compare/v5.0.0...v5.1.0
   [5.0.0]: https://github.com/AaronLasseigne/active_interaction/compare/v4.1.0...v5.0.0
   [4.1.0]: https://github.com/AaronLasseigne/active_interaction/compare/v4.0.6...v4.1.0
@@ -1339,3 +1346,4 @@ Example.run
   [#503]: https://github.com/AaronLasseigne/active_interaction/issues/503
   [#536]: https://github.com/AaronLasseigne/active_interaction/issues/536
   [#537]: https://github.com/AaronLasseigne/active_interaction/issues/537
+  [#539]: https://github.com/AaronLasseigne/active_interaction/issues/539

data/lib/active_interaction/filter.rb

@@ -112,24 +112,21 @@ module ActiveInteraction
     # @raise [NoDefaultError] If the default is missing.
     # @raise [InvalidDefaultError] If the default is invalid.
     def default(context = nil)
-      return @default if defined?(@default)
-
       raise NoDefaultError, name unless default?
 
       value = raw_default(context)
       raise InvalidDefaultError, "#{name}: #{value.inspect}" if value.is_a?(GroupedInput)
 
-      @default =
-        if value.nil?
-          nil
-        else
-          default = process(value, context)
-          if default.errors.any? && default.errors.first.is_a?(Filter::Error)
-            raise InvalidDefaultError, "#{name}: #{value.inspect}"
-          end
-
-          default.value
+      if value.nil?
+        nil
+      else
+        default = process(value, context)
+        if default.errors.any? && default.errors.first.is_a?(Filter::Error)
+          raise InvalidDefaultError, "#{name}: #{value.inspect}"
         end
+
+        default.value
+      end
     end
 
     # Get the description.

data/lib/active_interaction/version.rb

@@ -4,5 +4,5 @@ module ActiveInteraction
   # The version number.
   #
   # @return [Gem::Version]
-  VERSION = Gem::Version.new('5.1.0')
+  VERSION = Gem::Version.new('5.1.1')
 end

data/spec/active_interaction/filter_spec.rb

@@ -36,4 +36,25 @@ describe ActiveInteraction::Filter, :filter do
       end
     end
   end
+
+  describe '#default' do
+    subject(:filter) { ActiveInteraction::IntegerFilter.new(:test, default: default) }
+
+    context 'when it is a value' do
+      let(:default) { 1 }
+
+      it 'returns the default' do
+        expect(filter.default).to be 1
+      end
+    end
+
+    context 'when it is a proc' do
+      let(:default) { -> { i + 1 } }
+
+      it 'returns the default' do
+        expect(filter.default(double(i: 0))).to be 1 # rubocop:disable RSpec/VerifiedDoubles
+        expect(filter.default(double(i: 1))).to be 2 # rubocop:disable RSpec/VerifiedDoubles
+      end
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_interaction
 version: !ruby/object:Gem::Version
-  version: 5.1.0
+  version: 5.1.1
 platform: ruby
 authors:
 - Aaron Lasseigne
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-07-28 00:00:00.000000000 Z
+date: 2022-09-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel