active_interaction 3.8.2 → 3.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ab5fbe89ea464ba3cbd680d4b444aff591500d843602bd0f94059de42c680739
-  data.tar.gz: cb6f3f963b5614a6eab29e611369917d9a4252948aa42e6ab9107d730745fda7
+  metadata.gz: 883e2c22dbe4db00730bd2d917d7812e6f79898f41cfdcde16bc685b1ae1de29
+  data.tar.gz: 4c1af0be75d96c6801b288b450d260580b3d12f330ebeb69b1f6b20d88da5241
 SHA512:
-  metadata.gz: 34b4222d51134f6a704d21a79d1c44e71d6edb4471156188564973a89fdfef68d156575dc0ec777d6b18ef6420e775ca61e9034fd44427c7cc4a66afb6bbad1a
-  data.tar.gz: 912a034a88b9c0fa10a78b83a5c8b0ceae6b3040a7c81e7550c11af16bbe60e639251e67df58c41b19b297eefcafe9a6101ae92dacaee382fec2ff1ac0fa7827
+  metadata.gz: d2426683e3249c63760a59a25c0a7e8d21780bedf31218676ffca3d75903db0f4b73c18d80b78bbc568997ca67106490bac774bf43f68dacbe5ba00541e08e78
+  data.tar.gz: 412ae553643fd1449c9063058f5d4b8f39ea0bb97f4f166db73bee7ae6bf70a5f01b4ca8ee08a867417b8f7d83d57845d5168383c5ac69d2a931df7490527056

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+# [3.8.3][] (2020-04-22)
+
+## Fixed
+
+- [486][] `valid?` returns true if block not called and error added in execute around callback.
+
 # [3.8.2][] (2020-04-22)
 
 ## Fixed
@@ -771,6 +777,7 @@ Example.run
 
 - Initial release.
 
+  [3.8.3]: https://github.com/AaronLasseigne/active_interaction/compare/v3.8.2...v3.8.3
   [3.8.2]: https://github.com/AaronLasseigne/active_interaction/compare/v3.8.1...v3.8.2
   [3.8.1]: https://github.com/AaronLasseigne/active_interaction/compare/v3.8.0...v3.8.1
   [3.8.0]: https://github.com/AaronLasseigne/active_interaction/compare/v3.7.1...v3.8.0
@@ -971,3 +978,4 @@ Example.run
   [#477]: https://github.com/AaronLasseigne/active_interaction/issues/477
   [#476]: https://github.com/AaronLasseigne/active_interaction/issues/476
   [#479]: https://github.com/AaronLasseigne/active_interaction/issues/479
+  [#486]: https://github.com/AaronLasseigne/active_interaction/issues/486

data/lib/active_interaction/concerns/runnable.rb

@@ -74,14 +74,13 @@ module ActiveInteraction
     def run
       return self.result = nil unless valid?
 
-      run_callbacks(:execute) do
-        self.result =
-          begin
-            execute
-          rescue Interrupt => interrupt
-            errors.backtrace = interrupt.errors.backtrace || interrupt.backtrace
-            errors.merge!(interrupt.errors)
-          end
+      self.result = run_callbacks(:execute) do
+        begin
+          execute
+        rescue Interrupt => interrupt
+          errors.backtrace = interrupt.errors.backtrace || interrupt.backtrace
+          errors.merge!(interrupt.errors)
+        end
       end
     end
 

data/lib/active_interaction/version.rb

@@ -6,5 +6,5 @@ module ActiveInteraction
   # The version number.
   #
   # @return [Gem::Version]
-  VERSION = Gem::Version.new('3.8.2')
+  VERSION = Gem::Version.new('3.8.3')
 end

data/spec/active_interaction/concerns/runnable_spec.rb

@@ -345,6 +345,24 @@ describe ActiveInteraction::Runnable do
         expect(outcome.caught_error).to be true
       end
     end
+
+    context 'with block not called and error in execute around callback' do
+      class CheckExecuteAroundCallbackForFailure
+        include ActiveInteraction::ActiveModelable
+        include ActiveInteraction::Runnable
+
+        set_callback :execute, :around, -> { errors.add(:base, 'invalid') }
+
+        def execute
+          true
+        end
+      end
+
+      it 'is invalid' do
+        outcome = CheckExecuteAroundCallbackForFailure.run
+        expect(outcome).to_not be_valid
+      end
+    end
   end
 
   describe '.run!' do

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: active_interaction
 version: !ruby/object:Gem::Version
-  version: 3.8.2
+  version: 3.8.3
 platform: ruby
 authors:
 - Aaron Lasseigne
 - Taylor Fausak
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-04-22 00:00:00.000000000 Z
+date: 2020-08-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -271,14 +271,14 @@ files:
 - spec/support/concerns.rb
 - spec/support/filters.rb
 - spec/support/interactions.rb
-homepage: 
+homepage:
 licenses:
 - MIT
 metadata:
   homepage_uri: https://github.com/AaronLasseigne/active_interaction
   source_code_uri: https://github.com/AaronLasseigne/active_interaction
   changelog_uri: https://github.com/AaronLasseigne/active_interaction/blob/master/CHANGELOG.md
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -294,7 +294,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.2
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Manage application specific business logic.
 test_files: