active_interaction 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eac224974be5bdaafca02a1266a62b5a7d18e835
-  data.tar.gz: f6224fbee6808c51696a42af86a4138d20d6bd56
+  metadata.gz: 6f1a6360b50ccffdcd40231df37ef50ba71e0513
+  data.tar.gz: 053934f4e4c53b81cf72e4843d3c00a4023890e3
 SHA512:
-  metadata.gz: b816a2a4b4c463e5cc208862950d5b789c4d20c70df9a2cb98c7a8013b78a734426709d5e08587d2daea14034860521fb6286893e45c05418fab08331e3076be
-  data.tar.gz: fa0ec07a406a4c4d8c0d22270abaf05e2eb17bb3bd64a1590112fcca26649817a08aa48ad25f6785fc7caefd1e835eed14e4b4a8d613587cc4bb9f841c173e95
+  metadata.gz: 17b08e4252eaed06870d0fb1c7f3993830a9a939e10f69357d0fcda7f02d0965e52e3fae6e99632077217176475c90d04526caa196d489c5618b5df4c33899f0
+  data.tar.gz: 21ba7fdaa0139290a77a85e4617cbeccd1194b25fa6fec02574a185866c8a93b5758953bee8db769216818f7987afd42fea34d3a264a6aa01a25f45e8bfc1c03

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+# [2.1.1][] (2015-08-04)
+
+## Fixed
+
+- [#296][]: Fixed a bug that silently converted invalid lazy default values to
+  `nil` instead of raising an `InvalidDefaultError`.
+
 # [2.1.0][] (2015-07-30)
 
 ## Added
@@ -430,6 +437,7 @@ For help upgrading to version 2, please read [the announcement post][].
 
 - Initial release.
 
+  [2.1.1]: https://github.com/orgsync/active_interaction/compare/v2.1.0...v2.1.1
   [2.1.0]: https://github.com/orgsync/active_interaction/compare/v2.0.1...v2.1.0
   [2.0.1]: https://github.com/orgsync/active_interaction/compare/v2.0.0...v2.0.1
   [2.0.0]: https://github.com/orgsync/active_interaction/compare/v1.6.0...v2.0.0
@@ -565,5 +573,6 @@ For help upgrading to version 2, please read [the announcement post][].
   [#286]: https://github.com/orgsync/active_interaction/issues/286
   [#289]: https://github.com/orgsync/active_interaction/issues/289
   [#295]: https://github.com/orgsync/active_interaction/issues/295
+  [#296]: https://github.com/orgsync/active_interaction/issues/296
 
   [the announcement post]: http://devblog.orgsync.com/2015/05/06/announcing-active-interaction-2/

data/lib/active_interaction.rb

@@ -9,7 +9,7 @@ require 'active_model'
 #
 # @since 1.0.0
 #
-# @version 2.1.0
+# @version 2.1.1
 module ActiveInteraction
 end
 

data/lib/active_interaction/base.rb

@@ -248,7 +248,7 @@ module ActiveInteraction
       self.class.filters.each do |name, filter|
         begin
           public_send("#{name}=", filter.clean(inputs[name]))
-        rescue Error
+        rescue InvalidValueError, MissingValueError, NoDefaultError
           # #type_check will add errors if appropriate.
         end
       end

data/lib/active_interaction/version.rb

@@ -5,5 +5,5 @@ module ActiveInteraction
   # The version number.
   #
   # @return [Gem::Version]
-  VERSION = Gem::Version.new('2.1.0')
+  VERSION = Gem::Version.new('2.1.1')
 end

data/spec/active_interaction/base_spec.rb

@@ -2,15 +2,15 @@
 
 require 'spec_helper'
 
-class InteractionWithFilter < TestInteraction
+InteractionWithFilter = Class.new(TestInteraction) do
   float :thing
 end
 
-class InteractionWithDateFilter < TestInteraction
+InteractionWithDateFilter = Class.new(TestInteraction) do
   date :thing
 end
 
-class AddInteraction < TestInteraction
+AddInteraction = Class.new(TestInteraction) do
   float :x, :y
 
   def execute
@@ -18,7 +18,7 @@ class AddInteraction < TestInteraction
   end
 end
 
-class InterruptInteraction < TestInteraction
+InterruptInteraction = Class.new(TestInteraction) do
   object :x, :y,
     class: Object,
     default: nil

data/spec/active_interaction/concerns/active_recordable_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-class InteractionWithFloatFilter < TestInteraction
+InteractionWithFloatFilter = Class.new(TestInteraction) do
   float :thing
 end
 

data/spec/active_interaction/i18n_spec.rb

@@ -12,7 +12,7 @@ describe ActiveInteraction do
   end
 end
 
-class I18nInteraction < TestInteraction
+I18nInteraction = Class.new(TestInteraction) do
   hash :a do
     hash :x
   end

data/spec/active_interaction/integration/array_interaction_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-class ArrayInteraction < TestInteraction
+ArrayInteraction = Class.new(TestInteraction) do
   array :a do
     array
   end

data/spec/active_interaction/integration/file_interaction_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 require 'action_dispatch'
 
-class FileInteraction < TestInteraction
+FileInteraction = Class.new(TestInteraction) do
   file :a
 end
 

data/spec/active_interaction/integration/hash_interaction_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-class HashInteraction < TestInteraction
+HashInteraction = Class.new(TestInteraction) do
   hash :a do
     hash :x
   end

data/spec/active_interaction/integration/interface_interaction_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helper'
 require 'json'
 require 'yaml'
 
-class InterfaceInteraction < TestInteraction
+InterfaceInteraction = Class.new(TestInteraction) do
   interface :anything
 end
 

data/spec/active_interaction/integration/object_interaction_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-class ObjectInteraction < TestInteraction
+ObjectInteraction = Class.new(TestInteraction) do
   object :object
 end
 

data/spec/active_interaction/integration/time_interaction_spec.rb

@@ -25,7 +25,7 @@ TimeWithZone = Class.new do
   end
 end
 
-class TimeInteraction < TestInteraction
+TimeInteraction = Class.new(TestInteraction) do
   time :a
 end
 

data/spec/support/interactions.rb

@@ -30,6 +30,19 @@ shared_examples_for 'an interaction' do |type, generator, filter_options = {}|
     end
   end
 
+  context 'with an invalid lazy default' do
+    let(:described_class) do
+      Class.new(TestInteraction) do
+        public_send(type, :default,
+          filter_options.merge(default: -> { Object.new }))
+      end
+    end
+
+    it 'raises an error' do
+      expect { outcome }.to raise_error ActiveInteraction::InvalidDefaultError
+    end
+  end
+
   context 'without required inputs' do
     it 'is invalid' do
       expect(outcome).to be_invalid

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_interaction
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Aaron Lasseigne
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-30 00:00:00.000000000 Z
+date: 2015-08-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel