active_interaction 1.2.3 → 1.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6ba88eafd8b605090eafd610e1b9b4e41638e5b8
-  data.tar.gz: 44de977111bd36c6348864c0024ff886d71022c5
+  metadata.gz: 8eae8e946fb9ec93d0abfa2e2264a7a35b9e8d56
+  data.tar.gz: 7c976feedfef904516036479d67a789f147d8e4a
 SHA512:
-  metadata.gz: 1befd803a782dfe60b5c058f49b3e670e2f4b8d4d5434b15e81acdb7564ab803812dcce8172c615fe0bc04f7a8be7576615f02b9183d8d3a9c8776f77f2c6a92
-  data.tar.gz: ced6bb16015b351c6d4555feb91d84f82ed4e62f3cb9ca650c9ac7c3be9d2f7edcf29f94a84aef6e24fe58572b41de52565bf4c436d3db534e48758cfc39f286
+  metadata.gz: 79162f4100cf2618ec44bddee98714af4d0b5b01d13cc8188f57a847031ece8c1657223d098912bdaa4b3ba89996cc233955d57cbd9ed44f5910cf44afb03164
+  data.tar.gz: 30f668bd7172e2f5d45df36b38d4ecda7b00d0d5aa1ca1667c4b7fa13eb21c810d8260cd269763debc738614828a0314a941cbb6ad69b86950ac53e3ec3f008c

data/CHANGELOG.md

@@ -1,216 +1,335 @@
 # [Master][]
 
+# [1.2.4][] (2014-08-07)
+
+## Fixed
+
+- [#203][]: Fix a bug that prevented transaction options from being passed to
+  subclasses.
+
 # [1.2.3][] (2014-05-12)
 
-- Fix a bug that raised `ActiveRecord::Rollback` when composing even when not
-  in a transaction.
+## Fixed
+
+- [#192][]: Fix a bug that raised `ActiveRecord::Rollback` when composing even
+  when not in a transaction.
 
 # [1.2.2][] (2014-05-07)
 
+## Fixed
+
 - Fix a bug that raised `NameError`s when there were invalid nested hash
   errors.
 - Add missing translation for symbol filters.
 
 # [1.2.1][] (2014-05-02)
 
-- Fix a bug that marked model inputs as invalid even if they returned true for
-  `object.is_a?(klass)`.
+## Fixed
+
+- [#179][]: Fix a bug that marked model inputs as invalid even if they returned true
+  for `object.is_a?(klass)`.
 
 # [1.2.0][] (2014-04-30)
 
-- Add support for Rails-style date and time parameters like `date(1i)`.
-- Add a decimal filter.
-- Add support for disabling and modifying transactions through the
+## Added
+
+- [#175][]: Add support for Rails-style date and time parameters like `date(1i)`.
+- [#173][]: Add a decimal filter.
+- [#155][]: Add support for disabling and modifying transactions through the
   `transaction` helper method.
-- Add support for `column_for_attribute` which provides better interoperability with gems like Formtastic and Simple Form.
+- [#140][]: Add support for `column_for_attribute` which provides better
+  interoperability with gems like Formtastic and Simple Form.
 
 # [1.1.7][] (2014-04-30)
 
-- Fix a bug that leaked validators among all child classes.
+## Fixed
+
+- [#174][]: Fix a bug that leaked validators among all child classes.
 
 # [1.1.6][] (2014-04-29)
 
-- Fix a bug that caused nested hash error messages to be misleading.
+## Fixed
+
+- [#36][]: Fix a bug that caused nested hash error messages to be misleading.
 
 # [1.1.5][] (2014-03-31)
 
-- The `transform_keys` method broke backwards compatibility because it's not available until Rails 4.0.2.
+## Fixed
+
+- The `transform_keys` method broke backwards compatibility because it's not
+  available until Rails 4.0.2.
 
 # [1.1.4][] (2014-03-31)
 
+## Fixed
+
 - Fix an issue where non-stripped hash keys would be incorrectly converted to strings.
 
 # [1.1.3][] (2014-03-31)
 
-- Fix Rubocop errors and pin the version to avoid future issues with new cops
+## Fixed
+
+- [#165][]: Fix Rubocop errors and pin the version to avoid future issues with new cops
   breaking the build.
-- Fix some denial of service attacks via hash symbolization. (See [#163][] for details)
+
+## Security
+
+- [#163][]: Fix some denial of service attacks via hash symbolization.
 
 # [1.1.2][] (2014-03-05)
 
-- Don't constantize classes for model filters on initialization. This fixes a
+## Fixed
+
+- [#156][]: Don't constantize classes for model filters on initialization. This fixes a
   bug that made those filters dependent on load order.
 
 # [1.1.1][] (2014-03-04)
 
-- Allow merging ActiveModel errors into ActiveInteraction errors with
+## Fixed
+
+- [#153][]: Allow merging ActiveModel errors into ActiveInteraction errors with
   `ActiveInteraction::Errors#merge!`.
 
 # [1.1.0][] (2014-02-28)
 
-- Only set instance variables for attributes with readers defined.
-- Support `:only` and `:except` options simultaneously with `import_filters`.
+## Added
+
+- [#116][], [#119][], [#122][]: Speed up many filters by caching class constants.
+- [#115][]: Add support for callbacks around `execute`.
+- [#136][]: Allow callable defaults.
+
+## Changed
+
+- [#114][]: Support `:only` and `:except` options simultaneously with `import_filters`.
   Previously this raised an `ArgumentError`.
-- Support passing a single symbol to `:only` and `:except`. Previously an Array
+- [#114][]: Support passing a single symbol to `:only` and `:except`. Previously an Array
   was required.
-- Speed up many filters by caching class constants.
-- Add support for callbacks around `execute`.
-- Allow callable defaults.
+
+## Security
+
+- [#138][]: Only set instance variables for attributes with readers defined.
+
 
 # [1.0.5][] (2014-02-25)
 
-- Rollback database changes when `compose` fails.
+## Fixed
+
+- [#143][]: Rollback database changes when `compose` fails.
 
 # [1.0.4][] (2014-02-11)
 
+## Fixed
+
 - Add translations to the gem specification.
 
 # ~~[1.0.3][] (2014-02-11)~~
 
-- Fix a bug that caused invalid strings to be parsed as `nil` instead of
+## Fixed
+
+- [#135][]: Fix a bug that caused invalid strings to be parsed as `nil` instead of
   raising an error when `Time.zone` was set.
-- Fix bug that prevented loading I18n translations.
+- [#134][]: Fix bug that prevented loading I18n translations.
 
 # [1.0.2][] (2014-02-07)
 
-- Stop creating duplicate errors on subsequent calls to `valid?`.
+## Fixed
+
+- [#130][]: Stop creating duplicate errors on subsequent calls to `valid?`.
 
 # [1.0.1][] (2014-02-04)
 
-- Short circuit `valid?` after successfully running an interaction.
-- Fix a bug that prevented merging interpolated symbolic errors.
-- Use `:invalid_type` instead of `:invalid` as I18n key for type errors.
-- Fix a bug that skipped setting up accessors for imported filters.
+## Fixed
+
+- [#125][]: Short circuit `valid?` after successfully running an interaction.
+- [#129][]: Fix a bug that prevented merging interpolated symbolic errors.
+- [#128][]: Use `:invalid_type` instead of `:invalid` as I18n key for type errors.
+- [#127][]: Fix a bug that skipped setting up accessors for imported filters.
 
 # [1.0.0][] (2014-01-21)
 
-- **Replace `Filters` with a hash.** To iterate over `Filter` objects, use
+## Added
+
+- [#102][]: Add predicate methods for checking if an input was passed.
+- [#103][]: Allow fetching filters by name.
+- [#104][]: Allow import filters from another interaction with `import_filters`.
+
+## Changed
+
+- [#111][]: Replace `Filters` with a hash. To iterate over `Filter` objects, use
   `Interaction.filters.values`.
 - Rename `Filter#has_default?` to `Filter#default?`.
-- Add `respond_to_missing?` to complement `method_missing` calls.
-- Add predicate methods for checking if an input was passed.
-- When adding a filter that shares a name with an existing filter, it will now
+
+## Fixed
+
+- [#98][]: Add `respond_to_missing?` to complement `method_missing` calls.
+- [#106][]: When adding a filter that shares a name with an existing filter, it will now
   replace the existing one instead of adding a duplicate.
-- Allow fetching filters by name.
-- Allow import filters from another interaction with `import_filters`.
 
 # [0.10.2][] (2014-01-02)
 
-- Fix a bug that marked Time instances as invalid if Time.zone was set.
+## Fixed
+
+- [#94][]: Fix a bug that marked Time instances as invalid if Time.zone was set.
 
 # [0.10.1][] (2013-12-20)
 
-- Fix bug that prevented parsing strings as times when ActiveSupport was
+## Fixed
+
+- [#90][]: Fix bug that prevented parsing strings as times when ActiveSupport was
   available.
 
 # [0.10.0][] (2013-12-19)
 
+## Added
+
 - Support casting "true" and "false" as booleans.
-- Fix bug that allowed subclasses to mutate the filters on their superclasses.
+
+## Fixed
+
+- [#89][]: Fix bug that allowed subclasses to mutate the filters on their superclasses.
 
 # [0.9.1][] (2013-12-17)
 
-- Fix I18n deprecation warning.
-- Raise `ArgumentError` when running an interaction with non-hash inputs.
-- For compatibility with `ActiveRecord::Errors`, support indifferent access of
+## Fixed
+
+- [#84][]: Fix I18n deprecation warning.
+- [#82][]: Raise `ArgumentError` when running an interaction with non-hash inputs.
+- [#77][]: For compatibility with `ActiveRecord::Errors`, support indifferent access of
   `ActiveInteraction::Errors`.
-- Fix losing filters when using inheritance.
+- [#88][]: Fix losing filters when using inheritance.
 
 # [0.9.0][] (2013-12-02)
 
-- Add experimental composition implementation
-  (`ActiveInteraction::Base#compose`).
+## Added
+
+- Add experimental composition implementation (`ActiveInteraction::Base#compose`).
+
+## Removed
+
 - Remove `ActiveInteraction::Pipeline`.
 
 # [0.8.0][] (2013-11-14)
 
-- Add ability to document interactions and filters.
+## Added
+
+- [#44][], [#45][]: Add ability to document interactions and filters.
 
 # [0.7.0][] (2013-11-14)
 
-- Add ability to chain a series of interactions together with
+## Added
+
+- [#41][]: Add ability to chain a series of interactions together with
   `ActiveInteraction::Pipeline`.
 
 # [0.6.1][] (2013-11-14)
 
+## Fixed
+
 - Re-release. Forgot to merge into master.
 
 # ~~[0.6.0][] (2013-11-14)~~
 
-- **Error class now end with `Error`.**
-- **By default, strip unlisted keys from hashes. To retain the old behavior,
-  set `strip: false` on a hash filter.**
-- **Prevent specifying defaults (other than `nil` or `{}`) on hash filters. Set
-  defaults on the nested filters instead.**
+## Added
+
 - Add ability to introspect interactions with `filters`.
-- Fix bug that prevented listing multiple attributes in a hash filter.
-- Allow getting all of the user-supplied inputs in an interaction with
+- [#57][]: Allow getting all of the user-supplied inputs in an interaction with
   `inputs`.
-- Fix bug that prevented hash filters from being nested in array filters.
-- Replace `allow_nil: true` with `default: nil`.
-- Add a symbol filter.
-- Allow adding symbolic errors with `errors.add_sym` and retrieving them with
+- [#61][]: Add a symbol filter.
+- [#58][]: Allow adding symbolic errors with `errors.add_sym` and retrieving them with
   `errors.symbolic`.
 
+## Changed
+
+- Error class now end with `Error`.
+- By default, strip unlisted keys from hashes. To retain the old behavior,
+  set `strip: false` on a hash filter.
+- [#49][]: Prevent specifying defaults (other than `nil` or `{}`) on hash filters. Set
+  defaults on the nested filters instead.
+- [#66][]: Replace `allow_nil: true` with `default: nil`.
+
+## Fixed
+
+- Fix bug that prevented listing multiple attributes in a hash filter.
+- Fix bug that prevented hash filters from being nested in array filters.
+
 # [0.5.0][] (2013-10-16)
 
-- Allow adding errors in `execute` method with `errors.add`.
-- Prevent manually setting the outcome's result.
+## Added
+
+- [#34][]: Allow adding errors in `execute` method with `errors.add`.
+
+## Fixed
+
+- [#56][]: Prevent manually setting the outcome's result.
 
 # [0.4.0][] (2013-08-15)
 
+## Added
+
 - Support i18n translations.
 
 # [0.3.0][] (2013-08-07)
 
-- Give better error messages for nested attributes.
-- Use default value when given an explicit `nil`.
-- Allow nested default values.
+## Added
+
+- [#30][]: Allow nested default values.
+
+## Changed
+
+- [#36][]: Give better error messages for nested attributes.
+- [#39][]: Add a more useful invalid interaction error message.
+- [#38][]: Use default value when given an explicit `nil`.
 
 # [0.2.2][] (2013-08-07)
 
-- Fix support for `ActiveSupport::TimeWithZone`.
+## Fixed
+
+- [#40][]: Fix support for `ActiveSupport::TimeWithZone`.
 
 # [0.2.1][] (2013-08-06)
 
-- Fix setting a default value on more than one attribute at a time.
+## Fixed
+
+- [#37][]: Fix setting a default value on more than one attribute at a time.
 
 # [0.2.0][] (2013-07-16)
 
-- Wrap interactions in ActiveRecord transactions if they're available.
-- Add option to strip string values, which is enabled by default.
-- Add support for strptime format strings on Date, DateTime, and Time filters.
+## Added
+
+- [#23][]: Add support for strptime format strings on Date, DateTime, and Time filters.
+
+## Changed
+
+- [#20][]: Wrap interactions in ActiveRecord transactions if they're available.
+- [#24][]: Add option to strip string values, which is enabled by default.
 
 # [0.1.3][] (2013-07-16)
 
+## Fixed
+
 - Fix bug that prevented `attr_accessor`s from working.
 - Handle unconfigured timezones.
-- Use RDoc as YARD's Markdown provider instead of kramdown.
+- [#27][]: Use RDoc as YARD's Markdown provider instead of kramdown.
 
 # [0.1.2][] (2013-07-14)
 
-- `execute` will now have the filtered version of the values passed
+## Fixed
+
+- [#29][]: `execute` will now have the filtered version of the values passed
   to `run` or `run!` as was intended.
 
 # [0.1.1][] (2013-07-13)
 
-- Correct gemspec dependencies on activemodel.
+## Fixed
+
+- [#28][]: Correct gemspec dependencies on activemodel.
 
 # ~~[0.1.0][] (2013-07-12)~~
 
 - Initial release.
 
-  [master]: https://github.com/orgsync/active_interaction/compare/v1.2.3...master
+  [master]: https://github.com/orgsync/active_interaction/compare/v1.2.4...master
+  [1.2.4]: https://github.com/orgsync/active_interaction/compare/v1.2.3...v1.2.4
   [1.2.3]: https://github.com/orgsync/active_interaction/compare/v1.2.2...v1.2.3
   [1.2.2]: https://github.com/orgsync/active_interaction/compare/v1.2.1...v1.2.2
   [1.2.1]: https://github.com/orgsync/active_interaction/compare/v1.2.0...v1.2.1
@@ -249,4 +368,65 @@
   [0.1.1]: https://github.com/orgsync/active_interaction/compare/v0.1.0...v0.1.1
   [0.1.0]: https://github.com/orgsync/active_interaction/compare/62f999b...v0.1.0
 
-  [#163]: https://github.com/orgsync/active_interaction/pull/163
+  [#20]: https://github.com/orgsync/active_interaction/issues/20
+  [#23]: https://github.com/orgsync/active_interaction/issues/23
+  [#24]: https://github.com/orgsync/active_interaction/issues/24
+  [#27]: https://github.com/orgsync/active_interaction/issues/27
+  [#28]: https://github.com/orgsync/active_interaction/issues/28
+  [#29]: https://github.com/orgsync/active_interaction/issues/29
+  [#30]: https://github.com/orgsync/active_interaction/issues/30
+  [#34]: https://github.com/orgsync/active_interaction/issues/34
+  [#36]: https://github.com/orgsync/active_interaction/issues/36
+  [#37]: https://github.com/orgsync/active_interaction/issues/37
+  [#38]: https://github.com/orgsync/active_interaction/issues/38
+  [#39]: https://github.com/orgsync/active_interaction/issues/39
+  [#40]: https://github.com/orgsync/active_interaction/issues/40
+  [#41]: https://github.com/orgsync/active_interaction/issues/41
+  [#44]: https://github.com/orgsync/active_interaction/issues/44
+  [#45]: https://github.com/orgsync/active_interaction/issues/45
+  [#49]: https://github.com/orgsync/active_interaction/issues/49
+  [#56]: https://github.com/orgsync/active_interaction/issues/56
+  [#57]: https://github.com/orgsync/active_interaction/issues/57
+  [#58]: https://github.com/orgsync/active_interaction/issues/58
+  [#61]: https://github.com/orgsync/active_interaction/issues/61
+  [#66]: https://github.com/orgsync/active_interaction/issues/66
+  [#77]: https://github.com/orgsync/active_interaction/issues/77
+  [#82]: https://github.com/orgsync/active_interaction/issues/82
+  [#84]: https://github.com/orgsync/active_interaction/issues/84
+  [#88]: https://github.com/orgsync/active_interaction/issues/88
+  [#89]: https://github.com/orgsync/active_interaction/issues/89
+  [#90]: https://github.com/orgsync/active_interaction/issues/90
+  [#94]: https://github.com/orgsync/active_interaction/issues/94
+  [#98]: https://github.com/orgsync/active_interaction/issues/98
+  [#102]: https://github.com/orgsync/active_interaction/issues/102
+  [#103]: https://github.com/orgsync/active_interaction/issues/103
+  [#104]: https://github.com/orgsync/active_interaction/issues/104
+  [#106]: https://github.com/orgsync/active_interaction/issues/106
+  [#111]: https://github.com/orgsync/active_interaction/issues/111
+  [#114]: https://github.com/orgsync/active_interaction/issues/114
+  [#115]: https://github.com/orgsync/active_interaction/issues/115
+  [#116]: https://github.com/orgsync/active_interaction/issues/116
+  [#119]: https://github.com/orgsync/active_interaction/issues/119
+  [#122]: https://github.com/orgsync/active_interaction/issues/122
+  [#125]: https://github.com/orgsync/active_interaction/issues/125
+  [#127]: https://github.com/orgsync/active_interaction/issues/127
+  [#128]: https://github.com/orgsync/active_interaction/issues/128
+  [#129]: https://github.com/orgsync/active_interaction/issues/129
+  [#130]: https://github.com/orgsync/active_interaction/issues/130
+  [#134]: https://github.com/orgsync/active_interaction/issues/134
+  [#135]: https://github.com/orgsync/active_interaction/issues/135
+  [#136]: https://github.com/orgsync/active_interaction/issues/136
+  [#138]: https://github.com/orgsync/active_interaction/issues/138
+  [#140]: https://github.com/orgsync/active_interaction/issues/140
+  [#143]: https://github.com/orgsync/active_interaction/issues/143
+  [#153]: https://github.com/orgsync/active_interaction/issues/153
+  [#155]: https://github.com/orgsync/active_interaction/issues/155
+  [#156]: https://github.com/orgsync/active_interaction/issues/156
+  [#163]: https://github.com/orgsync/active_interaction/issues/163
+  [#165]: https://github.com/orgsync/active_interaction/issues/165
+  [#173]: https://github.com/orgsync/active_interaction/issues/173
+  [#174]: https://github.com/orgsync/active_interaction/issues/174
+  [#175]: https://github.com/orgsync/active_interaction/issues/175
+  [#179]: https://github.com/orgsync/active_interaction/issues/179
+  [#192]: https://github.com/orgsync/active_interaction/issues/192
+  [#203]: https://github.com/orgsync/active_interaction/issues/203

data/README.md

@@ -282,12 +282,12 @@ work done in [Mutations][17].
 
   [0]: https://github.com/orgsync/active_interaction
   [1]: https://badge.fury.io/rb/active_interaction.svg
-  [2]: https://badge.fury.io/rb/active_interaction "Gem Version"
+  [2]: http://rubygems.org/gems/active_interaction "Gem Version"
   [3]: https://travis-ci.org/orgsync/active_interaction.svg?branch=master
   [4]: https://travis-ci.org/orgsync/active_interaction "Build Status"
-  [5]: https://coveralls.io/repos/orgsync/active_interaction/badge.png?branch=master
+  [5]: https://img.shields.io/coveralls/orgsync/active_interaction/master.svg
   [6]: https://coveralls.io/r/orgsync/active_interaction?branch=master "Coverage Status"
-  [7]: https://codeclimate.com/github/orgsync/active_interaction.png
+  [7]: https://codeclimate.com/github/orgsync/active_interaction/badges/gpa.svg
   [8]: https://codeclimate.com/github/orgsync/active_interaction "Code Climate"
   [9]: https://gemnasium.com/orgsync/active_interaction.svg
   [10]: https://gemnasium.com/orgsync/active_interaction "Dependency Status"

data/lib/active_interaction.rb

@@ -50,5 +50,5 @@ I18n.default_locale = :en
 #
 # @since 1.0.0
 #
-# @version 1.2.3
+# @version 1.2.4
 module ActiveInteraction end

data/lib/active_interaction/backports.rb

@@ -13,11 +13,16 @@ module ActiveInteraction
       send("#{name}=", value)
     end unless method_defined?(:[]=)
   end
+
+  class Errors
+    # Required for Rails < 3.2.13.
+    protected :initialize_dup
+  end
 end
 
 # @private
 class Hash
-  # Required for Rails <= 4.0.2.
+  # Required for Rails < 4.0.0.
   def transform_keys
     result = {}
     each_key do |key|

data/lib/active_interaction/concerns/transactable.rb

@@ -39,6 +39,13 @@ module ActiveInteraction
     end
 
     module ClassMethods # rubocop:disable Documentation
+      # @param klass [Class]
+      def inherited(klass)
+        klass.transaction(transaction?, transaction_options.dup)
+
+        super
+      end
+
       # @param enable [Boolean]
       # @param options [Hash]
       #

data/lib/active_interaction/errors.rb

@@ -171,9 +171,9 @@ module ActiveInteraction
     def merge_symbolic!(other)
       other.symbolic.each do |attribute, symbols|
         symbols.each do |symbol|
-          unless symbolic[attribute].include?(symbol)
-            symbolic[attribute] += [symbol]
-          end
+          next if symbolic[attribute].include?(symbol)
+
+          symbolic[attribute] += [symbol]
         end
       end
     end

data/lib/active_interaction/filters/abstract_filter.rb

@@ -12,7 +12,7 @@ module ActiveInteraction
 
     # @return [Class]
     def klass
-      @klass ||= self.class.slug.to_s.camelize.constantize
+      @klass ||= Object.const_get(self.class.slug.to_s.camelize, false)
     end
   end
 end

data/lib/active_interaction/filters/array_filter.rb

@@ -64,9 +64,11 @@ module ActiveInteraction
         fail InvalidFilterError, 'attribute names in array block'
       end
 
+      # rubocop:disable GuardClause
       if filter.default?
         fail InvalidDefaultError, 'default values in array block'
       end
+      # rubocop:enable GuardClause
     end
   end
 end

data/lib/active_interaction/filters/decimal_filter.rb

@@ -1,5 +1,7 @@
 # coding: utf-8
 
+require 'bigdecimal'
+
 module ActiveInteraction
   class Base
     # @!method self.decimal(*attributes, options = {})
@@ -46,7 +48,7 @@ module ActiveInteraction
       Float(value)
       BigDecimal.new(value, digits)
     rescue ArgumentError
-       raise InvalidValueError, "Given value: #{value.inspect}"
+      raise InvalidValueError, "Given value: #{value.inspect}"
     end
 
     def klass

data/lib/active_interaction/filters/model_filter.rb

@@ -40,7 +40,7 @@ module ActiveInteraction
     # @raise [InvalidClassError]
     def klass
       klass_name = options.fetch(:class, name).to_s.classify
-      klass_name.constantize
+      Object.const_get(klass_name)
     rescue NameError
       raise InvalidClassError, klass_name.inspect
     end

data/lib/active_interaction/version.rb

@@ -5,5 +5,5 @@ module ActiveInteraction
   # The version number.
   #
   # @return [Gem::Version]
-  VERSION = Gem::Version.new('1.2.3')
+  VERSION = Gem::Version.new('1.2.4')
 end

data/spec/active_interaction/base_spec.rb

@@ -439,12 +439,12 @@ describe ActiveInteraction::Base do
     let(:described_class) { InteractionWithFilter }
 
     it 'responds to the predicate' do
-      expect(interaction.respond_to?(:thing?)).to be_true
+      expect(interaction.respond_to?(:thing?)).to be_truthy
     end
 
     context 'without a value' do
       it 'returns false' do
-        expect(interaction.thing?).to be_false
+        expect(interaction.thing?).to be_falsey
       end
     end
 
@@ -456,16 +456,14 @@ describe ActiveInteraction::Base do
       end
 
       it 'returns true' do
-        expect(interaction.thing?).to be_true
+        expect(interaction.thing?).to be_truthy
       end
     end
   end
 
   describe '.import_filters' do
-    shared_context 'import_filters context' do
+    shared_context 'import_filters context' do |only, except|
       let(:klass) { AddInteraction }
-      let(:only) { nil }
-      let(:except) { nil }
 
       let(:described_class) do
         interaction = klass
@@ -477,8 +475,8 @@ describe ActiveInteraction::Base do
       end
     end
 
-    shared_examples 'import_filters examples' do
-      include_context 'import_filters context'
+    shared_examples 'import_filters examples' do |only, except|
+      include_context 'import_filters context', only, except
 
       it 'imports the filters' do
         expect(described_class.filters).to eql klass.filters
@@ -504,42 +502,31 @@ describe ActiveInteraction::Base do
     end
 
     context 'with neither :only nor :except' do
-      include_examples 'import_filters examples'
+      include_examples 'import_filters examples', nil, nil
     end
 
     context 'with :only' do
       context 'as an Array' do
-        include_examples 'import_filters examples'
-
-        let(:only) { [:x] }
+        include_examples 'import_filters examples', [:x], nil
       end
 
       context 'as an Symbol' do
-        include_examples 'import_filters examples'
-
-        let(:only) { :x }
+        include_examples 'import_filters examples', :x, nil
       end
     end
 
     context 'with :except' do
       context 'as an Array' do
-        include_examples 'import_filters examples'
-
-        let(:except) { [:x] }
+        include_examples 'import_filters examples', nil, [:x]
       end
 
       context 'as an Symbol' do
-        include_examples 'import_filters examples'
-
-        let(:except) { :x }
+        include_examples 'import_filters examples', nil, :x
       end
     end
 
     context 'with :only & :except' do
-      include_examples 'import_filters examples'
-
-      let(:only) { [:x] }
-      let(:except) { [:x] }
+      include_examples 'import_filters examples', [:x], [:x]
     end
   end
 end

data/spec/active_interaction/concerns/missable_spec.rb

@@ -10,7 +10,7 @@ describe ActiveInteraction::Missable do
       let(:slug) { :slug }
 
       it 'returns false' do
-        expect(instance.respond_to?(slug)).to be_false
+        expect(instance.respond_to?(slug)).to be_falsey
       end
     end
 
@@ -18,7 +18,7 @@ describe ActiveInteraction::Missable do
       let(:slug) { :boolean }
 
       it 'returns true' do
-        expect(instance.respond_to?(slug)).to be_true
+        expect(instance.respond_to?(slug)).to be_truthy
       end
     end
   end

data/spec/active_interaction/concerns/runnable_spec.rb

@@ -57,7 +57,7 @@ describe ActiveInteraction::Runnable do
               }
 
               klass.run
-              expect(has_run).to be_true
+              expect(has_run).to be_truthy
             end
           end
         end
@@ -141,7 +141,10 @@ describe ActiveInteraction::Runnable do
 
       it 'does not duplicate errors on subsequent calls' do
         instance.valid?
-        expect { instance.valid? }.to_not change { instance.errors.count }.by 1
+        count = instance.errors.count
+        instance.valid?
+
+        expect(instance.errors.count).to eql count
       end
     end
   end

data/spec/active_interaction/concerns/transactable_spec.rb

@@ -47,25 +47,46 @@ describe ActiveInteraction::Transactable do
 
   describe '.transaction?' do
     it 'defaults to true' do
-      expect(klass.transaction?).to be_true
+      expect(klass.transaction?).to be_truthy
     end
 
     it 'returns the stored value' do
       klass.transaction(false)
-      expect(klass.transaction?).to be_false
+      expect(klass.transaction?).to be_falsey
+    end
+
+    context 'with a subclass' do
+      before { klass.transaction(false) }
+
+      let(:subclass) { Class.new(klass) }
+
+      it 'inherits from the superclass' do
+        expect(subclass.transaction?).to be_falsey
+      end
     end
   end
 
   describe '.transaction_options' do
+    let(:h) { { rand => rand } }
+
     it 'defaults to an empty hash' do
       expect(klass.transaction_options).to eql({})
     end
 
     it 'returns the stored value' do
-      h = { rand => rand }
       klass.transaction(klass.transaction?, h)
       expect(klass.transaction_options).to eql h
     end
+
+    context 'with a subclass' do
+      before { klass.transaction(klass.transaction?, h) }
+
+      let(:subclass) { Class.new(klass) }
+
+      it 'inherits from the superclass' do
+        expect(subclass.transaction_options).to eql h
+      end
+    end
   end
 
   describe '#transaction' do

data/spec/active_interaction/errors_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe ActiveInteraction::Errors do
   let(:klass) do
     Class.new do
-      include ActiveModel::Model
+      include ActiveInteraction::ActiveModelable
 
       attr_reader :attribute
 

data/spec/active_interaction/filter_column_spec.rb

@@ -42,7 +42,7 @@ describe ActiveInteraction::FilterColumn do
         let(:type) { :integer }
 
         it 'returns true' do
-          expect(number?).to be_true
+          expect(number?).to be_truthy
         end
       end
 
@@ -50,7 +50,7 @@ describe ActiveInteraction::FilterColumn do
         let(:type) { :float }
 
         it 'returns true' do
-          expect(number?).to be_true
+          expect(number?).to be_truthy
         end
       end
 
@@ -58,7 +58,7 @@ describe ActiveInteraction::FilterColumn do
         let(:type) { :string }
 
         it 'returns false' do
-          expect(number?).to be_false
+          expect(number?).to be_falsey
         end
       end
     end
@@ -72,7 +72,7 @@ describe ActiveInteraction::FilterColumn do
         let(:type) { :string }
 
         it 'returns true' do
-          expect(text?).to be_true
+          expect(text?).to be_truthy
         end
       end
 
@@ -80,7 +80,7 @@ describe ActiveInteraction::FilterColumn do
         let(:type) { :float }
 
         it 'returns false' do
-          expect(text?).to be_false
+          expect(text?).to be_falsey
         end
       end
     end

data/spec/active_interaction/filters/boolean_filter_spec.rb

@@ -10,7 +10,7 @@ describe ActiveInteraction::BooleanFilter, :filter do
     context 'falsey' do
       [false, '0', 'false', 'FALSE'].each do |value|
         it "returns false for #{value.inspect}" do
-          expect(filter.cast(value)).to be_false
+          expect(filter.cast(value)).to be_falsey
         end
       end
     end
@@ -18,7 +18,7 @@ describe ActiveInteraction::BooleanFilter, :filter do
     context 'truthy' do
       [true, '1', 'true', 'TRUE'].each do |value|
         it "returns true for #{value.inspect}" do
-          expect(filter.cast(value)).to be_true
+          expect(filter.cast(value)).to be_truthy
         end
       end
     end

data/spec/active_interaction/integration/model_interaction_spec.rb

@@ -3,5 +3,5 @@
 require 'spec_helper'
 
 describe 'ModelInteraction' do
-  it_behaves_like 'an interaction', :model, -> { Object }, class: Class
+  it_behaves_like 'an interaction', :model, -> { // }, class: Regexp
 end

data/spec/active_interaction/modules/input_processor_spec.rb

@@ -5,11 +5,11 @@ require 'spec_helper'
 describe ActiveInteraction::InputProcessor do
   describe '.reserved?(name)' do
     it 'returns true for anything starting with "_interaction_"' do
-      expect(described_class.reserved?('_interaction_')).to be_true
+      expect(described_class.reserved?('_interaction_')).to be_truthy
     end
 
     it 'returns false for anything else' do
-      expect(described_class.reserved?(SecureRandom.hex)).to be_false
+      expect(described_class.reserved?(SecureRandom.hex)).to be_falsey
     end
   end
 

data/spec/active_interaction/modules/validation_spec.rb

@@ -21,7 +21,7 @@ describe ActiveInteraction::Validation do
       let(:inputs) { { name: 1 } }
 
       before do
-        filter.stub(:cast).and_return(1)
+        allow(filter).to receive(:cast).and_return(1)
       end
 
       it 'returns no errors' do
@@ -31,7 +31,7 @@ describe ActiveInteraction::Validation do
 
     context 'filter throws' do
       before do
-        filter.stub(:cast).and_raise(exception)
+        allow(filter).to receive(:cast).and_raise(exception)
       end
 
       context 'InvalidValueError' do

data/spec/spec_helper.rb

@@ -3,14 +3,17 @@
 require 'coveralls'
 Coveralls.wear!
 
+require 'i18n'
+if I18n.config.respond_to?(:enforce_available_locales)
+  I18n.config.enforce_available_locales = true
+  I18n.config.available_locales = %w[en hsilgne]
+end
+
 require 'active_interaction'
 
 Dir['./spec/support/**/*.rb'].each { |f| require f }
 
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
   config.filter_run_including :focus
 end
-
-I18n.config.enforce_available_locales = true

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_interaction
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.2.4
 platform: ruby
 authors:
 - Aaron Lasseigne
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-12 00:00:00.000000000 Z
+date: 2014-08-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -17,7 +17,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '3.2'
     - - "<"
       - !ruby/object:Gem::Version
         version: '5'
@@ -27,7 +27,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '3.2'
     - - "<"
       - !ruby/object:Gem::Version
         version: '5'
@@ -121,14 +121,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.21.0
+        version: 0.24.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.21.0
+        version: 0.24.1
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -143,6 +143,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.8'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.0.0
 description: Manage application specific business logic.
 email:
 - aaron.lasseigne@gmail.com
@@ -251,7 +265,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.1
 signing_key: 
 specification_version: 4
 summary: Manage application specific business logic.