active_interaction 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 152f0300bf27243acb0d7f0068b44a8b7c66fa8c
-  data.tar.gz: d2741f24682a5ede49215e0ddb7191625f27e189
+  metadata.gz: 07e6b7eb1027d9cb220bccdd4ad1e97d23d85dc2
+  data.tar.gz: 07dfb947aafeea6442164d08ed03b37c2738f446
 SHA512:
-  metadata.gz: b2976e0ff9e7b3ad09181672922fad54b821b46f8e4380afa1eb6579121f4b7cc6fc854cd59bdbf983c5ab0047dc56744ebb010585016511cd8ea193a13b733c
-  data.tar.gz: a2f08efa2b55ebb4ebbc86f1ea51cce4d5adc465fe6d5cc8d2c6667a4aebeac40e87041d8690fd94b36a6f753b541ee58e70662c1836a56269fe71c932413a8d
+  metadata.gz: 1fac720546402daaed4ca81cb48266d394acef2133da63029d9288e5bc5055467766a290ea952a3716bb298f17e112bbd819d434593c173bfe2708f3b7fabb21
+  data.tar.gz: 2b1263e75189e213d1c1ac289b51eb374b8bb3cde3846ee1944954a1b0ff41d889f99e77d604de3eb8dbfe54229b76d39486b38622f28880247df486c0288e6c

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # [Master][]
 
+# [1.0.2][] (2014-02-07)
+
+- Stop creating duplicate errors on subsequent calls to `valid?`.
+
 # [1.0.1][] (2014-02-04)
 
 - Short circuit `valid?` after successfully running an interaction.
@@ -125,8 +129,9 @@
 
 - Initial release.
 
-  [master]: https://github.com/orgsync/active_interaction/compare/v1.0.1...master
-  [1.0.0]: https://github.com/orgsync/active_interaction/compare/v1.0.0...v1.0.1
+  [master]: https://github.com/orgsync/active_interaction/compare/v1.0.2...master
+  [1.0.2]: https://github.com/orgsync/active_interaction/compare/v1.0.1...v1.0.2
+  [1.0.1]: https://github.com/orgsync/active_interaction/compare/v1.0.0...v1.0.1
   [1.0.0]: https://github.com/orgsync/active_interaction/compare/v0.10.2...v1.0.0
   [0.10.2]: https://github.com/orgsync/active_interaction/compare/v0.10.1...v0.10.2
   [0.10.1]: https://github.com/orgsync/active_interaction/compare/v0.10.0...v0.10.1

data/lib/active_interaction.rb

@@ -42,5 +42,5 @@ I18n.backend.load_translations(
 #
 # @since 1.0.0
 #
-# @version 1.0.1
+# @version 1.0.2
 module ActiveInteraction end

data/lib/active_interaction/concerns/runnable.rb

@@ -27,10 +27,6 @@ module ActiveInteraction
     extend ActiveSupport::Concern
     include ActiveModel::Validations
 
-    included do
-      validate :runtime_errors
-    end
-
     # @return [Errors]
     def errors
       @_interaction_errors
@@ -55,22 +51,20 @@ module ActiveInteraction
     def result=(result)
       if errors.empty?
         @_interaction_result = result
-        @_interaction_runtime_errors = nil
         @_interaction_valid = true
       else
         @_interaction_result = nil
-        @_interaction_runtime_errors = errors.dup
         @_interaction_valid = false
       end
     end
 
     # @return [Boolean]
     def valid?(*)
-      unless instance_variable_defined?(:@_interaction_valid)
-        @_interaction_valid = false
+      if instance_variable_defined?(:@_interaction_valid)
+        return @_interaction_valid
       end
 
-      @_interaction_valid || super || (self.result = nil)
+      super
     end
 
     private
@@ -120,22 +114,13 @@ module ActiveInteraction
       end
     end
 
-    # @!group Validations
-
-    def runtime_errors
-      if @_interaction_runtime_errors
-        errors.merge!(@_interaction_runtime_errors)
-      end
-    end
-
     #
     module ClassMethods
       def new(*)
         super.tap do |instance|
           {
             :@_interaction_errors => Errors.new(instance),
-            :@_interaction_result => nil,
-            :@_interaction_runtime_errors => nil
+            :@_interaction_result => nil
           }.each do |symbol, obj|
             instance.instance_variable_set(symbol, obj)
           end

data/lib/active_interaction/version.rb

@@ -5,5 +5,5 @@ module ActiveInteraction
   # The version number.
   #
   # @return [Gem::Version]
-  VERSION = Gem::Version.new('1.0.1')
+  VERSION = Gem::Version.new('1.0.2')
 end

data/spec/active_interaction/base_spec.rb

@@ -192,24 +192,6 @@ describe ActiveInteraction::Base do
         expect(outcome).to be_a described_class
       end
 
-      context 'setting the result' do
-        let(:described_class) do
-          Class.new(TestInteraction) do
-            boolean :attribute
-
-            validate do
-              @_interaction_result = SecureRandom.hex
-              errors.add(:attribute, SecureRandom.hex)
-            end
-          end
-        end
-
-        it 'sets the result to nil' do
-          expect(outcome).to be_invalid
-          expect(result).to be_nil
-        end
-      end
-
       context 'failing validations' do
         it 'returns an invalid outcome' do
           expect(outcome).to_not be_valid

data/spec/active_interaction/concerns/runnable_spec.rb

@@ -123,6 +123,11 @@ describe ActiveInteraction::Runnable do
       it 'returns false' do
         expect(instance).to_not be_valid
       end
+
+      it 'does not duplicate errors on subsequent calls' do
+        instance.valid?
+        expect { instance.valid? }.to_not change { instance.errors.count }.by 1
+      end
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_interaction
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Aaron Lasseigne
@@ -9,124 +9,124 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-04 00:00:00.000000000 Z
+date: 2014-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3'
-    - - "<"
+    - - <
       - !ruby/object:Gem::Version
         version: '5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3'
-    - - "<"
+    - - <
       - !ruby/object:Gem::Version
         version: '5'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.5'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.7'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '4.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '4.2'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.1'
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '4.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '4.1'
 - !ruby/object:Gem::Dependency
   name: guard-rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.8'
 description: Manage application specific business logic.
@@ -137,6 +137,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- CHANGELOG.md
+- LICENSE.txt
+- README.md
+- lib/active_interaction.rb
 - lib/active_interaction/base.rb
 - lib/active_interaction/concerns/active_modelable.rb
 - lib/active_interaction/concerns/hashable.rb
@@ -161,7 +165,6 @@ files:
 - lib/active_interaction/filters/time_filter.rb
 - lib/active_interaction/modules/validation.rb
 - lib/active_interaction/version.rb
-- lib/active_interaction.rb
 - spec/active_interaction/base_spec.rb
 - spec/active_interaction/concerns/active_modelable_spec.rb
 - spec/active_interaction/concerns/hashable_spec.rb
@@ -202,9 +205,6 @@ files:
 - spec/support/concerns.rb
 - spec/support/filters.rb
 - spec/support/interactions.rb
-- CHANGELOG.md
-- LICENSE.txt
-- README.md
 homepage: http://orgsync.github.io/active_interaction/
 licenses:
 - MIT
@@ -215,17 +215,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.11
+rubygems_version: 2.2.0
 signing_key: 
 specification_version: 4
 summary: Manage application specific business logic.