active_hash 0.9.0 → 0.9.1

data/CHANGELOG

@@ -1,11 +1,14 @@
+2010-12-08
+  - ruby 1.9.2 compatibility
+
 2010-12-06
- - added dependency on ActiveModel
- - add persisted? method to ActiveHash::Base
- - ActiveHash::Base#save takes *args to be compatible with ActiveModel
- - ActiveHash::Base#to_param returns nil if the object hasn't been saved
+  - added dependency on ActiveModel
+  - add persisted? method to ActiveHash::Base
+  - ActiveHash::Base#save takes *args to be compatible with ActiveModel
+  - ActiveHash::Base#to_param returns nil if the object hasn't been saved
 
 2010-11-09
- - Use Ruby's definition of "word character" (numbers, underscores) when forming ActiveHash::Enum constants (tstuart)
+  - Use Ruby's definition of "word character" (numbers, underscores) when forming ActiveHash::Enum constants (tstuart)
 
 2010-11-07
   - Get ActiveHash::Associations to return a scope for has_many active record relationships (mocoso)
@@ -14,23 +17,23 @@
   - Allow find_by_* methods to accept an options hash, so rails associations don't blow up
 
 2010-10-07
- - Add conditions to ActiveHash#all (Ryan Garver)
- - Add #cache_key to ActiveHash::Base (Tom Stuart)
- - Add banged dynamic finder support to ActiveHash::Base (Tom Stuart)
+  - Add conditions to ActiveHash#all (Ryan Garver)
+  - Add #cache_key to ActiveHash::Base (Tom Stuart)
+  - Add banged dynamic finder support to ActiveHash::Base (Tom Stuart)
 
 2010-09-16
- - Enum format now uses underscores instead of removing all characters
- - Removed test dependency on acts_as_fu
+  - Enum format now uses underscores instead of removing all characters
+  - Removed test dependency on acts_as_fu
 
 2010-05-26
- - Silence metaclass deprecation warnings in active support 2.3.8
+  - Silence metaclass deprecation warnings in active support 2.3.8
 
 2010-05-04
- - When calling ActiveFile::Base.reload do not actually perform the reload if nothing has been modified unless you call reload(true) to force (Michael Schubert)
+  - When calling ActiveFile::Base.reload do not actually perform the reload if nothing has been modified unless you call reload(true) to force (Michael Schubert)
 
 2010-04-25
- - When ActiveRecord model belongs_to an ActiveHash and the associated id is nil, returns nil instead of raising RecordNotFound (Jeremy Weiskotten)
- - Merged Nakajima's "add" alias for "create" - gotta save those ASCII characters :)
+  - When ActiveRecord model belongs_to an ActiveHash and the associated id is nil, returns nil instead of raising RecordNotFound (Jeremy Weiskotten)
+  - Merged Nakajima's "add" alias for "create" - gotta save those ASCII characters :)
 
 2010-03-01
   - Removed "extend"-related deprecations - they didn't play well with rails class loading
@@ -45,8 +48,7 @@
   - Calling #belongs_to now creates the underlying field if it's not already there (belongs_to :city will create the :city_id field)
 
 2009-12-10
-  - Fixed a bug where belongs_to associations would raise an error instead of returning
-    nil when the parent object didn't exist.
+  - Fixed a bug where belongs_to associations would raise an error instead of returning nil when the parent object didn't exist.
   - Added #[] and #[]= accessors for more ActiveRecord-esque-ness. (Pat Nakajima & Dave Yeu)
 
 2009-12-01

data/active_hash.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{active_hash}
-  s.version = "0.9.0"
+  s.version = "0.9.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = [
@@ -18,9 +18,10 @@ Gem::Specification.new do |s|
     "Jeremy Weiskotten",
     "Ryan Garver",
     "Tom Stuart",
-    "Joel Chippindale"
+    "Joel Chippindale",
+    "Kevin Olsen"
   ]
-  s.date = %q{2010-12-06}
+  s.date = %q{2010-12-08}
   s.email = %q{jeff@zilkey.com}
   s.extra_rdoc_files = [
     "LICENSE",

data/lib/active_hash/base.rb

@@ -173,7 +173,7 @@ module ActiveHash
       private :configuration_for_custom_finder
 
       def define_getter_method(field, default_value)
-        unless instance_methods.include?(field.to_s)
+        unless has_instance_method?(field)
           define_method(field) do
             attributes[field].nil? ? default_value : attributes[field]
           end
@@ -184,7 +184,7 @@ module ActiveHash
 
       def define_setter_method(field)
         method_name = "#{field}="
-        unless instance_methods.include?(method_name)
+        unless has_instance_method?(method_name)
           define_method(method_name) do |new_val|
             attributes[field] = new_val
           end
@@ -194,8 +194,8 @@ module ActiveHash
       private :define_setter_method
 
       def define_interrogator_method(field)
-        method_name = "#{field}?"
-        unless instance_methods.include?(method_name)
+        method_name = :"#{field}?"
+        unless has_instance_method?(method_name)
           define_method(method_name) do
             send(field).present?
           end
@@ -205,8 +205,8 @@ module ActiveHash
       private :define_interrogator_method
 
       def define_custom_find_method(field_name)
-        method_name = "find_by_#{field_name}"
-        unless singleton_methods.include?(method_name)
+        method_name = :"find_by_#{field_name}"
+        unless has_singleton_method?(method_name)
           the_meta_class.instance_eval do
             define_method(method_name) do |*args|
               options = args.extract_options!
@@ -220,8 +220,8 @@ module ActiveHash
       private :define_custom_find_method
 
       def define_custom_find_all_method(field_name)
-        method_name = "find_all_by_#{field_name}"
-        unless singleton_methods.include?(method_name)
+        method_name = :"find_all_by_#{field_name}"
+        unless has_singleton_method?(method_name)
           the_meta_class.instance_eval do
             unless singleton_methods.include?(method_name)
               define_method(method_name) do |*args|
@@ -276,14 +276,26 @@ module ActiveHash
 
       private :mark_clean
 
+      def has_instance_method?(name)
+        instance_methods.map{|method| method.to_sym}.include?(name)
+      end
+
+      private :has_instance_method?
+
+      def has_singleton_method?(name)
+        singleton_methods.map{|method| method.to_sym}.include?(name)
+      end
+
+      private :has_singleton_method?
+
     end
 
     attr_reader :attributes
 
-    def initialize(options = {})
-      options.symbolize_keys!
-      @attributes = options
-      options.each do |key, value|
+    def initialize(attributes = {})
+      attributes.symbolize_keys!
+      @attributes = attributes
+      attributes.dup.each do |key, value|
         send "#{key}=", value
       end
     end

data/spec/active_hash/base_spec.rb

@@ -692,6 +692,11 @@ describe ActiveHash, "Base" do
         end
       end
 
+      Country.find_by_name("foo").should == "find_by_name defined manually"
+      Country.find_all_by_name("foo").should == "find_all_by_name defined manually"
+      Country.new.name.should == "name defined manually"
+      Country.new.name?.should == "name? defined manually"
+
       Country.data = [
         {:name => "foo"}
       ]

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: active_hash
 version: !ruby/object:Gem::Version 
-  hash: 59
+  hash: 57
   prerelease: false
   segments: 
   - 0
   - 9
-  - 0
-  version: 0.9.0
+  - 1
+  version: 0.9.1
 platform: ruby
 authors: 
 - Jeff Dean
@@ -23,11 +23,12 @@ authors:
 - Ryan Garver
 - Tom Stuart
 - Joel Chippindale
+- Kevin Olsen
 autorequire: 
 bindir: bin
 cert_chain: []
 
-date: 2010-12-06 00:00:00 -07:00
+date: 2010-12-08 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency