active_force 0.22.0 → 0.22.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c581e80e87411581ea34984582fae46fb088791e5d35a2227b31c983d4331b5f
-  data.tar.gz: 66b5a50080eafd5d2aecfdd0cd5262b0a1142c96f9cf324840242816f7dd9c71
+  metadata.gz: c57b4dd00099e8df4236eeba3f7b917f0cef63f1cbe94a43a9f781633273d00e
+  data.tar.gz: ad72dce393fc4d40c869269eefe1c485cd5dcee7e556d9cf70c86036d775bcd9
 SHA512:
-  metadata.gz: 55c1344f425f080433b1f00e2c2227c15b1990b20395406ef8d9fb2c8aa2817d2b0f4aac2d173380f93b7e646cc6f30436946915f4b706d237373816b6b0e412
-  data.tar.gz: 1ec278a796ecdb97c4b8629f671331e49fd21301e06bc6a3b29207ca77498d1e3b2ac8c2cd65ad458f7e250955fe3ace931840a20e7d60738622266a74dd1fe6
+  metadata.gz: 0dc1dca5294187220f3998b0216854f8b793dd9f43669607f446136d0a375991dbd708eaacc192b5002c119530f5e4d492dd7e9fef6993b8aa0ca8f63e89efb0
+  data.tar.gz: 92c5ca6b3b5d99a0e1eccdc1c1b961e8dacad3b2d133f467ed17b3fce55211172b7a1402127d653054f824f54f596ada534ff3d0fd144c7b22a8ca68183d510d

data/CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Not released
 
+## 0.22.1
+- Fixes #94. Moved query logic and corrected ActiveQuery `ids` method (https://github.com/Beyond-Finance/active_force/pull/97)
 
 ## 0.22.0
 - Add `ids` method to ActiveQuery interface (https://github.com/Beyond-Finance/active_force/pull/94)

data/lib/active_force/active_query.rb

@@ -84,7 +84,7 @@ module ActiveForce
     end
 
     def ids
-      clone_and_set_instance_variables(query_fields: ["Id"])
+      super.pluck(:id)
     end
 
     def find!(id)

data/lib/active_force/query.rb

@@ -107,6 +107,10 @@ module ActiveForce
       clone_and_set_instance_variables(query_fields: ["sum(#{field})"])
     end
 
+    def ids
+      clone_and_set_instance_variables(query_fields: ["Id"])
+    end
+
     protected
       def and_conditions
         "(#{@conditions.join(') AND (')})" unless @conditions.empty?

data/lib/active_force/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveForce
-  VERSION = '0.22.0'
+  VERSION = '0.22.1'
 end

data/spec/active_force/active_query_spec.rb

@@ -117,12 +117,6 @@ describe ActiveForce::ActiveQuery do
     end
   end
 
-  describe '#ids' do
-    it 'returns a query that selects only the Id field' do
-      expect(active_query.where(field: 123).ids.to_s).to eq "SELECT Id FROM table_name WHERE (Field__c = 123)"
-    end
-  end
-
   describe "condition mapping" do
     it "maps conditions for a .where" do
       new_query = active_query.where(field: 123)
@@ -577,4 +571,18 @@ describe ActiveForce::ActiveQuery do
       expect(active_query.first.id).to eq("0000000000AAAAABBB")
     end
   end
+
+  describe "#ids" do
+    before do
+      allow(client).to receive(:query).and_return(api_result)
+      api_result.each do |instance|
+        allow(active_query).to receive(:build).with(instance, {}).and_return(build_restforce_sobject(id: instance['Id']))
+      end
+    end
+
+    it "should return an array of id strings" do
+      expect(active_query.ids).to be_a Array
+      expect(active_query.ids).to eq api_result.map { |r| r['Id'] }
+    end
+  end
 end

data/spec/active_force/query_spec.rb

@@ -236,4 +236,14 @@ describe ActiveForce::Query do
       expect(query.where("name = 'cool'").sum(:field1).to_s).to eq "SELECT sum(field1) FROM table_name WHERE (name = 'cool')"
     end
   end
+
+  describe ".ids" do
+    it "should return the query for selecting Id" do
+      expect(query.ids.to_s).to eq 'SELECT Id FROM table_name'
+    end
+
+    it "should work with a condition" do
+      expect(query.where("name = 'cool'").ids.to_s).to eq "SELECT Id FROM table_name WHERE (name = 'cool')"
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_force
 version: !ruby/object:Gem::Version
-  version: 0.22.0
+  version: 0.22.1
 platform: ruby
 authors:
 - Eloy Espinaco
@@ -11,7 +11,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-07-09 00:00:00.000000000 Z
+date: 2024-07-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel