active_fedora-registered_attributes 0.0.11 → 0.1.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b887a80c42a23d768044efdc1789e8488905d664
-  data.tar.gz: 2369e72e5eb8aa5bde961ad20bedf1878ce7ce3a
+  metadata.gz: 39fd41d2d9a1e02425935d9a80efd48a89998811
+  data.tar.gz: 4b2a655a5ee7958d9ab3c1b459b1db399197fd6b
 SHA512:
-  metadata.gz: 6e13df7082a1c40b7f61aa83a3b0e8860e22201f8243c6f660a19f8c69c860afa257d6b8660436c0a47676426f50ae81e2a0714ed7f92cfc7ca8cb7b07ef315f
-  data.tar.gz: adf51f7d99800c41569f7adf6253e2edda40ea5a7a4a986fcb610e0fe4a0643be3132c50cebaf6a5b5969fa725fc927425546aac8bd9fb95966ef4047e58e470
+  metadata.gz: 32bb47650c883eb375a07270639116d10ff5f91e749bc620bbbf8b42757ef340e998bc8e787f7e89e7a7fee43fe2ac30e7b28e16e2eeb983fddff88d779ecd17
+  data.tar.gz: 526177b9fd9cb8b43fadf5990c2d86bd5db9122edb05bf17e16ca767df8b6db5d6d251b7a705f1d31483e7e9d99659dc78f25be244d1807b97b69c4450dc49fc

data/CONTRIBUTING.md

@@ -0,0 +1,113 @@
+# How to Contribute
+
+We want your help to make Project Hydra great.
+There are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.
+
+## Hydra Project Intellectual Property Licensing and Ownership
+
+All code contributors must have an Individual Contributor License Agreement (iCLA) on file with the Hydra Project Steering Group.
+If the contributor works for an institution, the institution must have a Corporate Contributor License Agreement (cCLA) on file.
+
+https://wiki.duraspace.org/display/hydra/Hydra+Project+Intellectual+Property+Licensing+and+Ownership
+
+You should also add yourself to the `CONTRIBUTORS.md` file in the root of the project.
+
+## Contribution Tasks
+
+* Reporting Issues
+* Making Changes
+* Submitting Changes
+* Merging Changes
+
+### Reporting Issues
+
+* Make sure you have a [GitHub account](https://github.com/signup/free)
+* Submit a [Github issue](./issues) by:
+  * Clearly describing the issue
+    * Provide a descriptive summary
+    * Explain the expected behavior
+    * Explain the actual behavior
+    * Provide steps to reproduce the actual behavior
+
+### Making Changes
+
+* Fork the repository on GitHub
+* Create a topic branch from where you want to base your work.
+  * This is usually the master branch.
+  * To quickly create a topic branch based on master; `git branch fix/master/my_contribution master`
+  * Then checkout the new branch with `git checkout fix/master/my_contribution`.
+  * Please avoid working directly on the `master` branch.
+  * You may find the [hub suite of commands](https://github.com/defunkt/hub) helpful
+* Make commits of logical units.
+  * Your commit should include a high level description of your work in HISTORY.textile 
+* Check for unnecessary whitespace with `git diff --check` before committing.
+* Make sure your commit messages are [well formed](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).
+* If you created an issue, you can close it by including "Closes #issue" in your commit message. See [Github's blog post for more details](https://github.com/blog/1386-closing-issues-via-commit-messages)
+
+```
+    Present tense short summary (50 characters or less)
+
+    More detailed description, if necessary. It should be wrapped to 72
+    characters. Try to be as descriptive as you can, even if you think that
+    the commit content is obvious, it may not be obvious to others. You
+    should add such description also if it's already present in bug tracker,
+    it should not be necessary to visit a webpage to check the history.
+
+    Include Closes #<issue-number> when relavent.
+
+    Description can have multiple paragraphs and you can use code examples
+    inside, just indent it with 4 spaces:
+
+        class PostsController
+          def index
+            respond_with Post.limit(10)
+          end
+        end
+
+    You can also add bullet points:
+
+    - you can use dashes or asterisks
+
+    - also, try to indent next line of a point for readability, if it's too
+      long to fit in 72 characters
+```
+
+* Make sure you have added the necessary tests for your changes.
+* Run _all_ the tests to assure nothing else was accidentally broken.
+* When you are ready to submit a pull request
+
+### Submitting Changes
+
+[Detailed Walkthrough of One Pull Request per Commit](http://ndlib.github.io/practices/one-commit-per-pull-request/)
+
+* Read the article ["Using Pull Requests"](https://help.github.com/articles/using-pull-requests) on GitHub.
+* Make sure your branch is up to date with its parent branch (i.e. master)
+  * `git checkout master`
+  * `git pull --rebase`
+  * `git checkout <your-branch>`
+  * `git rebase master`
+  * It is likely a good idea to run your tests again.
+* Squash the commits for your branch into one commit
+  * `git rebase --interactive HEAD~<number-of-commits>` ([See Github help](https://help.github.com/articles/interactive-rebase))
+  * To determine the number of commits on your branch: `git log master..<your-branch> --oneline | wc -l`
+  * Squashing your branch's changes into one commit is "good form" and helps the person merging your request to see everything that is going on.
+* Push your changes to a topic branch in your fork of the repository.
+* Submit a pull request from your fork to the project.
+
+### Merging Changes
+
+* It is considered "poor from" to merge your own request.
+* Please take the time to review the changes and get a sense of what is being changed. Things to consider:
+  * Does the commit message explain what is going on?
+  * Does the code changes have tests? _Not all changes need new tests, some changes are refactorings_
+  * Does the commit contain more than it should? Are two separate concerns being addressed in one commit?
+  * Did the Travis tests complete successfully?
+* If you are uncertain, bring other contributors into the conversation by creating a comment that includes their @username.
+* If you like the pull request, but want others to chime in, create a +1 comment and tag a user.
+
+# Additional Resources
+
+* [General GitHub documentation](http://help.github.com/)
+* [GitHub pull request documentation](http://help.github.com/send-pull-requests/)
+* [Pro Git](http://git-scm.com/book) is both a free and excellent book about Git.
+* [A Git Config for Contributing](http://ndlib.github.io/practices/my-typical-per-project-git-config/)

data/Changelog.md

@@ -0,0 +1,3 @@
+# Changes
+## 0.1.0.rc1
+* Don't use deprecated options in ActiveFedora 6.6.0 [Justin Coyne]

data/active_fedora-registered_attributes.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "active-fedora", ">= 6.4"
+  spec.add_dependency "active-fedora", ">= 6.6.0.rc2"
   spec.add_dependency "active_attr", "~> 0.8.2"
 
   spec.add_development_dependency "bundler", "~> 1.3"

data/lib/active_fedora/registered_attributes/attribute.rb

@@ -133,11 +133,11 @@ module ActiveFedora
 
         def options_for_delegation
           if datastream.is_a?(Hash)
-            datastream.merge(unique: !multiple?)
+            datastream.merge(multiple: multiple?)
           else
             {
               to: datastream,
-              unique: !multiple?
+              multiple: multiple?
             }
           end
         end

data/lib/active_fedora/registered_attributes/version.rb

@@ -1,5 +1,5 @@
 module ActiveFedora
   module RegisteredAttributes
-    VERSION = "0.0.11"
+    VERSION = "0.1.0.rc1"
   end
 end

data/spec/active_fedora/registered_attributes/attribute_spec.rb

@@ -60,7 +60,7 @@ describe ActiveFedora::RegisteredAttributes::Attribute do
           subject.with_delegation_options {|name,opts|
             @yielded = true
             expect(name).to eq(field_name)
-            expect(opts).to eq(to: datastream, unique: false)
+            expect(opts).to eq(to: datastream, multiple: true)
           }
           expect(@yielded).to eq(true)
         end
@@ -70,7 +70,7 @@ describe ActiveFedora::RegisteredAttributes::Attribute do
         let(:options) {
           {
             multiple: true,
-            datastream: {to: datastream, at: at_value, unique: true }
+            datastream: {to: datastream, at: at_value, multiple: false }
           }
         }
         it 'yields name and options' do
@@ -78,7 +78,7 @@ describe ActiveFedora::RegisteredAttributes::Attribute do
           subject.with_delegation_options {|name,opts|
             @yielded = true
             expect(name).to eq(field_name)
-            expect(opts).to eq(to: datastream, unique: !options.fetch(:multiple), at: at_value)
+            expect(opts).to eq(to: datastream, multiple: options.fetch(:multiple), at: at_value)
           }
           expect(@yielded).to eq(true)
         end
@@ -149,7 +149,6 @@ describe ActiveFedora::RegisteredAttributes::Attribute do
       let(:options) { {datastream: nil, skip_accessor: true} }
       it 'does not yield accession options_for_input' do
         @yielded = false
-        puts subject.send(:options)
         subject.with_accession_options {|name,opts|
           @yielded = true
         }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_fedora-registered_attributes
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.1.0.rc1
 platform: ruby
 authors:
 - Jeremy Friesen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-14 00:00:00.000000000 Z
+date: 2013-10-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active-fedora
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: '6.4'
+        version: 6.6.0.rc2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: '6.4'
+        version: 6.6.0.rc2
 - !ruby/object:Gem::Dependency
   name: active_attr
   requirement: !ruby/object:Gem::Requirement
@@ -90,6 +90,8 @@ files:
 - .gitignore
 - .rspec
 - .travis.yml
+- CONTRIBUTING.md
+- Changelog.md
 - Gemfile
 - Guardfile
 - LICENSE.txt
@@ -120,12 +122,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - '>'
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.0.5
 signing_key: 
 specification_version: 4
 summary: An ActiveFedora extension for registring attributes
@@ -135,3 +137,4 @@ test_files:
 - spec/active_fedora/registered_attributes_spec.rb
 - spec/spec_helper.rb
 - spec/support/book.rb
+has_rdoc: