active_entity 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7f64f30d78308e4f5887107685f1c7801485138f
-  data.tar.gz: 477079a529608f27cc99ed5be0e6da67edfddd65
+  metadata.gz: bd1c5302faff6d06968065b3820c637038699312
+  data.tar.gz: 9336f00f6d3caae67a630abae2e0ab55a43278f4
 SHA512:
-  metadata.gz: cd7a1b494c16cd2c2fcc0717f1eebe40310abfed70e340e2ecccd650ee3fadcd1ec8fc1d65d04c7f45feecce50f0d7d3c1ac94a6fcbd1ba11f3e8cc07b938f16
-  data.tar.gz: 8f6cadc7b710a9de8a3c4d839fdd123b754ef85c77dccb32765eb58b4cf24899f8177c4d5571fd8911721d3b1eaa2e4e765cc7642c085ed1d32b7cf3d461b581
+  metadata.gz: a4b2f78cd9da664dc20eb33d442ddac11161fa52b7734bf0f125215d6a75d150edc502fcd4cd74da587f6c5e2f7e8931b7687914d5fddc3c2956f6e573a7638d
+  data.tar.gz: 56426464b9187f3d43cc2164e27e58f818a45e6ee598149b5c46626065c981cf5c084ef8342ba3c35d427261c744535c042e946d73bd8494d04bab8687289ddb

data/CHANGELOG.md

@@ -1,2 +1,5 @@
+## 0.2.1
+* Make 100% compatible with Active Model API.
+
 ## 0.2.0
 * Introduce explicit type conversion and implicit coercion extension.

data/README.md

@@ -1,6 +1,8 @@
 # ActiveEntity
 
 An extension for Active Model to encourage implementing entity.
+It's like [Virtus gem](https://github.com/solnic/virtus) but more simple and
+on Active Model way.
 
 [![Build Status](https://travis-ci.org/taiki45/active_entity.svg?branch=master)](https://travis-ci.org/taiki45/active_entity) [![Coverage Status](https://coveralls.io/repos/taiki45/active_entity/badge.svg)](https://coveralls.io/r/taiki45/active_entity) [![Code Climate](https://codeclimate.com/github/taiki45/active_entity/badges/gpa.svg)](https://codeclimate.com/github/taiki45/active_entity) [![Gem Version](https://badge.fury.io/rb/active_entity.svg)](http://badge.fury.io/rb/active_entity)
 
@@ -84,6 +86,13 @@ expect(waffle.steps).to eq('12')  #=> rollbacks casted value on error
 expect(waffle.likes).to eq('abc')
 ```
 
+## TODOs
+- `to_param` helper.
+- Default value support.
+- Custom coercion with object.
+- Value object.
+- Docs for typecasting custom procedures.
+
 ## Contributing
 
 1. Fork it ( https://github.com/taiki45/active_entity/fork )

data/Rakefile

@@ -4,5 +4,9 @@ require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new(:spec) do |task|
   task.rspec_opts = ['-c', '-fd']
 end
-task :default => :spec
 
+task :test do
+  require File.expand_path('../test/active_mdoel_lint_test.rb', __FILE__)
+end
+
+task default: %i(spec test)

data/active_entity.gemspec

@@ -21,10 +21,10 @@ Gem::Specification.new do |spec|
   spec.add_dependency "activemodel", ">= 4.0"
   spec.add_dependency "activesupport", ">= 4.0"
   spec.add_development_dependency "bundler", "~> 1.7"
-  spec.add_development_dependency "coveralls"
-  spec.add_development_dependency "pry"
-  spec.add_development_dependency "pry-doc"
+  spec.add_development_dependency "coveralls", "~> 0.7"
+  spec.add_development_dependency "pry", "~> 0.10"
+  spec.add_development_dependency "pry-doc", "~> 0.6"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.1"
-  spec.add_development_dependency "simplecov"
+  spec.add_development_dependency "simplecov", "~> 0.9"
 end

data/lib/active_entity/coercion.rb

@@ -1,4 +1,6 @@
 module ActiveEntity
+  # Offers implicit type conversion on initializing.
+  # This depends `ActiveEntity::Accessor#defined_attributes`.
   module Coercion
     include Typecasting
 

data/lib/active_entity/default_definitions.rb

@@ -1,3 +1,5 @@
+# Define default type conversion procedures.
+
 ActiveEntity::ConversionDefinitions.set(:Boolean) do |value|
   case value
   when 'true'

data/lib/active_entity/identity.rb

@@ -20,7 +20,11 @@ module ActiveEntity
 
     # For ActiveModel::Conversion
     def to_key
-      identity_attributes.empty? ? nil : identity_attributes.map {|name| public_send(name) }
+      if respond_to?(:persisted?) && persisted?
+        identity_attributes.empty? ? nil : identity_attributes.map {|name| public_send(name) }
+      else
+        nil
+      end
     end
   end
 end

data/lib/active_entity/typecasting.rb

@@ -1,4 +1,6 @@
 module ActiveEntity
+  # Offers explicit type conversion.
+  # This depends `ActiveEntity::Accessor#defined_attributes`.
   module Typecasting
     # Try to cast attribute values. When fails to cast, raises the error and
     # rollbacks all values.

data/lib/active_entity/version.rb

@@ -1,3 +1,3 @@
 module ActiveEntity
-  VERSION = '0.2.0'
+  VERSION = '0.2.1'
 end

data/lib/active_entity.rb

@@ -10,7 +10,5 @@ require 'active_entity/typecasting'
 require 'active_entity/coercion'
 require 'active_entity/identity'
 
-# TODO: to_param
-
 require 'active_entity/conversion_definitions'
 require 'active_entity/default_definitions'

data/spec/active_entity/identity_spec.rb

@@ -45,8 +45,22 @@ RSpec.describe ActiveEntity::Identity do
   describe '#to_key' do
     let(:person) { test_class.new('Alice', 1) }
 
-    it 'returns values of key' do
-      expect(person.to_key).to eq(['Alice', 1])
+    context 'when persisted?' do
+      before do
+        def person.persisted?
+          true
+        end
+      end
+
+      it 'returns values of key' do
+        expect(person.to_key).to eq(['Alice', 1])
+      end
+    end
+
+    context 'when not persisted?' do
+      it 'returns nil' do
+        expect(person.to_key).to be_nil
+      end
     end
   end
 end

data/test/active_mdoel_lint_test.rb

@@ -0,0 +1,26 @@
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'active_entity'
+
+require 'minitest'
+require 'minitest/autorun'
+
+class TestForActiveModelLint < Minitest::Test
+  include ActiveModel::Lint::Tests
+
+  class Person
+    include ActiveModel::Model
+    include ActiveEntity::Accessor
+    include ActiveEntity::Coercion
+    include ActiveEntity::Identity
+
+    attribute :name, type: String
+    attribute :email, type: String
+
+    identity_attribute :email
+  end
+
+  def setup
+    @model = Person.new(name: 'Alice', email: 'alice@example.com')
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_entity
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Taiki Ono
@@ -56,44 +56,44 @@ dependencies:
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.7'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.10'
 - !ruby/object:Gem::Dependency
   name: pry-doc
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -126,16 +126,16 @@ dependencies:
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
 description: An extension for Active Model to encourage implementing entity.
 email:
 - taiks.4559@gmail.com
@@ -172,6 +172,7 @@ files:
 - spec/active_entity/typecasting_spec.rb
 - spec/readme_spec.rb
 - spec/spec_helper.rb
+- test/active_mdoel_lint_test.rb
 homepage: https://github.com/taiki45/active_entity
 licenses:
 - MIT
@@ -206,4 +207,5 @@ test_files:
 - spec/active_entity/typecasting_spec.rb
 - spec/readme_spec.rb
 - spec/spec_helper.rb
+- test/active_mdoel_lint_test.rb
 has_rdoc: