active_elastic_job 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d19d4e4ef144ceabffd14c20daae3b285df14616
-  data.tar.gz: 70be0d9706ef4ae1f7a91d14380522e5263a2c31
+  metadata.gz: c9ced62a0162f40de919760ea5563c6bf6e6417e
+  data.tar.gz: 182d2fc41d98ee5fce356190e7ece9aa6d85e449
 SHA512:
-  metadata.gz: 829d4cd3713427e6b85ed76a0a9e212b63ad5ab1232c901d30f2ad5360db90af1e242ef0fe8f37c0d01475911ad3d88e8d5dfdb22c41e17fcc3d9f04c32f5486
-  data.tar.gz: 7cea59eaaa8091a0cfa95c103ef373874f31225223e60d87e5ce9c41b5135a9ab4db6099a66f5f6d0c384174372a838c947624e71e1a3b099b74cc905983b17d
+  metadata.gz: 4f7f9614d11eac062792ff694ca57a2d598f9abd882d42cdfab6fdbd538c171783a14b7f9467de56745c29c6c8688440e08c48b7cd87e19e54ca34c7a8c7b204
+  data.tar.gz: 9871d65f4264d52d4f13d1858093ce2e7de4929f76925f22dfb014be2a5c33370e9c1259486a645ea86bed660f0707ca60b98ac483d9bb820eccc25b943d7ef6

data/lib/active_elastic_job/rack/sqs_message_consumer.rb

@@ -13,13 +13,15 @@ module ActiveElasticJob
     # environment, which verifies the digest, have to use the *same*
     # +secrets.secret_key_base+ setting.
     class SqsMessageConsumer
+      USER_AGENT_PREFIX = 'aws-sqsd'
+
       def initialize(app) #:nodoc:
         @app = app
       end
 
       def call(env) #:nodoc:
         request = ActionDispatch::Request.new env
-        if request.headers['User-Agent'] =~ /aws-sqsd/
+        if aws_sqsd?(request)
           begin
             verify(request)
             job = JSON.load(request.body)
@@ -38,9 +40,21 @@ module ActiveElasticJob
 
       def verify(request)
         secret_key_base = Rails.application.secrets[:secret_key_base]
-        verifier = ActiveElasticJob::MessageVerifier.new(secret_key_base)
+        @verifier ||= ActiveElasticJob::MessageVerifier.new(secret_key_base)
         digest = request.headers['HTTP_X_AWS_SQSD_ATTR_MESSAGE_DIGEST']
-        verifier.verify(request.body.string, digest)
+        @verifier.verify(request.body.string, digest)
+      end
+
+      def aws_sqsd?(request)
+        # we do not match against a Regexp
+        # in order to avoid performance penalties.
+        # Instead we make a simple string comparison.
+        # Benchmark runs showed an performance increase of
+        # up to 40%
+        current_user_agent = request.headers['User-Agent']
+        return (current_user_agent.present? &&
+          current_user_agent.size >= USER_AGENT_PREFIX.size &&
+          current_user_agent[0..(USER_AGENT_PREFIX.size - 1)] == USER_AGENT_PREFIX)
       end
     end
   end

data/lib/active_elastic_job/version.rb

@@ -1,3 +1,3 @@
 module ActiveElasticJob
-  VERSION = '1.0.0'
+  VERSION = '1.1.0'
 end

data/lib/active_job/queue_adapters/active_elastic_job_adapter.rb

@@ -29,7 +29,7 @@ module ActiveJob
              See http://docs.aws.amazon.com/AWSSimpleQueueService/latest/APIReference/API_SendMessage.html
              for further details!
             MSG
-            raise RangeError, 'The maximum allowed delay is 15 minutes' if delay > 15.minutes
+            raise RangeError, msg if delay > 15.minutes
           end
 
           aws_sqs_client.send_message(

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_elastic_job
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Tawan Sierek
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-03 00:00:00.000000000 Z
+date: 2016-01-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler