active_currency 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 75b316711129b3a675bad41c3531bd43f3921323
-  data.tar.gz: 00e65292dbe3783ab0d760c54fc4932a8bde18a2
+  metadata.gz: 0d368ebfd81510032ab25fce067b42c55823cf23
+  data.tar.gz: 1bb534e253f5b4b480936ea3a1f7a194632f9d24
 SHA512:
-  metadata.gz: '043295dcad9a8bc822bc29a30cc9cdc1348fc3f1fb9a21b244a55bccb7b2efda4ec66c18ab5afeeb10dec13f70e29f6f1347095e4fb9c1e6133c996ec615fb8e'
-  data.tar.gz: d74ea8f17afe55780d610918895efe3c8b59d6abab49c75c16b292f7635f9cab2d5bc8e369ece2c53f35c2537e201468d33e46f864bb61e525147b53f6bff41d
+  metadata.gz: 2f5cb10a9550211a5b590b85d181829a9cf72353364dfd3b63359acda79d9535d1c829c4ddb96669c76124f082bf3298d26286a17d0e181747ec19db670490bb
+  data.tar.gz: 9b404f2d1ce3313ecc733635f6cf0b499bcfc2cf802622aae4f9ba2bf2ac1c8d3d84f6b92e33dfb41c8eef8c1d31ce56e0035d52e91c67275720688335560738

data/README.md

@@ -26,7 +26,7 @@ Store the current rate regularly by calling in a scheduled job (using something
 like `sidekiq-scheduler` or `whenever`):
 
 ```rb
-ActiveCurrency::AddRates.new.call
+ActiveCurrency::AddRates.new(%w[EUR USD]).call
 ```
 
 You can then exchange money by using the Money gem:
@@ -57,8 +57,8 @@ And in `config/initializers/money.rb`:
 
 ```rb
 MoneyRails.configure do |config|
-  rate_store = ActiveCurrency::RateStore.new(%w[EUR USD])
-  config.default_bank = Money::Bank::VariableExchange.new(rate_store)
+  config.default_bank =
+    Money::Bank::VariableExchange.new(ActiveCurrency::RateStore.new)
 end
 ```
 

data/app/models/active_currency/rate.rb

@@ -4,7 +4,6 @@ module ActiveCurrency
   class Rate < ActiveRecord::Base
     validates :from,
               :to,
-              inclusion: { in: ->(_v) { Money.default_bank.store.currencies } },
               presence: true
     validates :value, numericality: { greater_than: 0 }
 
@@ -20,11 +19,6 @@ module ActiveCurrency
         &.value
     end
 
-    # DEPRECATED
-    def self.current_value_for(from, to, date = nil)
-      value_for(from, to, date)
-    end
-
     # Scope retrocompatibility for Rails 3.2.
     def self.all_scope
       respond_to?(:scoped) ? scoped : all

data/lib/active_currency/add_rates.rb

@@ -3,20 +3,28 @@
 module ActiveCurrency
   # Store the latest currency rates.
   class AddRates
-    def call
-      currencies = Money.default_bank.store.currencies.map(&:to_s) - ['EUR']
-      return if currencies.blank?
+    def initialize(currencies)
+      @currencies = currencies
+    end
 
+    def call
       bank = EuCentralBank.new
       bank.update_rates
 
       from = 'EUR'
-      currencies.each do |to|
-        rate = bank.get_rate(from, to)
+      currencies.map(&:to_s).each do |to|
+        next if to == from
 
+        rate = bank.get_rate(from, to)
         Money.add_rate(from, to, rate)
         Money.add_rate(to, from, 1 / rate)
       end
     end
+
+    private
+
+    def currencies
+      @currencies.map(&:to_s).map(&:upcase)
+    end
   end
 end

data/lib/active_currency/rate_store.rb

@@ -3,11 +3,5 @@
 module ActiveCurrency
   class RateStore < DatabaseStore
     include CacheableStore
-
-    attr_reader :currencies
-
-    def initialize(currencies)
-      @currencies = currencies
-    end
   end
 end

data/lib/active_currency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveCurrency
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_currency
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Sunny Ripert
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.3.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.3.1
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement