active_call 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d67030b5b5cf7b405b842c1295c33912ebaa2b6ad1aeaefa0807e1a0f4fef105
-  data.tar.gz: 6b19ccf7e464102efe1e70ab0501ea6bb3aa8a781880f1492cca1bfeee9de576
+  metadata.gz: 31e782b9a67b967ad37abe80818b43aa445517aa99a4830e2ec158c67404922e
+  data.tar.gz: 587d98f44af3c0a36198ffb76367bf30f0b8eb22b342d0d3d361c452452faf7a
 SHA512:
-  metadata.gz: 5b0aea3b486558cd5d81ead4cbc1e75c1ae97f1edef31b3d9ed796b04cdb78e24e6aeda57227ade6c927f7a90599dfe16c06dc8065b98dcbb340db8a27f279e4
-  data.tar.gz: 46f8fa215650ff0373ada16c79a7bd3f2f5a73ff8aaea30081a6e59ade1a869ac3aff735c132d87bc3774708ef13c2dc7829d802774b238f6acd74a061589063
+  metadata.gz: 4354d1137d8dfc1dae8570ccc6fb1324f2999d9b099c3f2a0e1da1fe4b93aa99b39692029d6169263736772e8eadce59376f0cd25d9812da38080f7309d06502
+  data.tar.gz: a2875e4fd4b26027584f4c830befb94ea9dc799fbc70aacbe791d44a39fa679ff56817a22c25fa5816bb715a1d6555f9717332026410a6e1af3c66f7ae1282da

data/.rubocop.yml

@@ -18,10 +18,17 @@ AllCops:
 Layout/LineEndStringConcatenationIndentation:
   EnforcedStyle: indented
 
+Layout/LineLength:
+  AllowedPatterns:
+    - '#'
+
 Lint/MissingSuper:
   AllowedParentClasses:
     - ActiveCall::Base
 
+Metrics/AbcSize:
+  Enabled: false
+
 Metrics/BlockLength:
   Exclude:
     - spec/*/**.rb

data/CHANGELOG.md

@@ -1,4 +1,6 @@
-## [Unreleased]
+## [0.3.0] - 2025-03-31
+
+- Added `validate on: :request` which runs after `before_call` and before invoking `call`'.
 
 ## [0.2.1] - 2025-03-25
 

data/README.md

@@ -30,17 +30,19 @@ Each service object must define only one public method named `call`.
 
 1. **Before** invoking `call`.
 
-  - Validate the request with `validates`.
+  - Validate the service with `validates`.
 
   - Use the `before_call` hook to set up anything **after validation** passes.
 
+  - Validate the request with `validate on: :request`.
+
 2. **During** `call` invocation.
 
   - A `response` attribute gets set with the result of the `call` method.
 
 3. **After** invoking `call`.
 
-  - Validate the response with `validate, on: :response`.
+  - Validate the response with `validate on: :response`.
 
   - Use the `after_call` hook to set up anything **after response validation** passes.
 
@@ -52,15 +54,19 @@ Define a service object with optional validations and callbacks.
 require 'active_call'
 
 class YourGem::SomeResource::CreateService < ActiveCall::Base
-  attr_reader :message
+  attr_reader :message, :another_service
 
   validates :message, presence: true
 
+  validate on: :request do
+    errors.merge!(another_service.errors) unless another_service.success?
+  end
+
   validate on: :response do
     errors.add(:message, :invalid, message: 'cannot be baz') if response[:foo] == 'baz'
   end
 
-  before_call :strip_message
+  before_call :call_another_service, :strip_message
 
   after_call :log_response
 
@@ -74,6 +80,10 @@ class YourGem::SomeResource::CreateService < ActiveCall::Base
 
   private
 
+  def call_another_service
+    @another_service = YourGem::SomeResource::GetService.call(id: '1')
+  end
+
   def strip_message
     @message.strip!
   end
@@ -201,10 +211,14 @@ spec.add_dependency 'active_call'
 
 Now start adding your service objects in the `lib` directory and make sure they inherit from `ActiveCall::Base`.
 
+## Active Call Extensions
+
+- [Active Call - API](https://rubygems.org/gems/active_call-api)
+
 ## Gems Using Active Call
 
-- [nCino KYC DocFox](https://github.com/kobusjoubert/doc_fox)
-- [Zoho Sign](https://github.com/kobusjoubert/zoho_sign)
+- [Active Call - nCino KYC DocFox](https://rubygems.org/gems/active_call-doc_fox)
+- [Active Call - Zoho Sign](https://rubygems.org/gems/active_call-zoho_sign)
 
 ## Development
 

data/lib/active_call/base.rb

@@ -32,7 +32,7 @@ class ActiveCall::Base
       @abstract_class == true
     end
 
-    # TODO: Refactor `call` and `call!`. The only differences are the two lines raising exceptions.
+    # TODO: Refactor `call` and `call!`. The only differences are the lines raising exceptions.
 
     # Using `call`
     #
@@ -63,14 +63,16 @@ class ActiveCall::Base
     def call(...)
       service_object = new(...)
       service_object.instance_variable_set(:@bang, false)
-      return service_object if service_object.invalid?(except_on: :response)
+      return service_object if service_object.invalid?(except_on: [:request, :response])
 
       service_object.run_callbacks(:call) do
         next if service_object.is_a?(Enumerable)
 
+        service_object.validate(:request)
+        return service_object unless service_object.success?
+
         service_object.instance_variable_set(:@response, service_object.call)
         service_object.validate(:response)
-
         return service_object unless service_object.success?
       end
 
@@ -110,11 +112,17 @@ class ActiveCall::Base
     def call!(...)
       service_object = new(...)
       service_object.instance_variable_set(:@bang, true)
-      raise ActiveCall::ValidationError, service_object.errors if service_object.invalid?(except_on: :response)
+
+      if service_object.invalid?(except_on: [:request, :response])
+        raise ActiveCall::ValidationError, service_object.errors
+      end
 
       service_object.run_callbacks(:call) do
         next if service_object.is_a?(Enumerable)
 
+        service_object.validate(:request)
+        raise ActiveCall::RequestError.new(nil, service_object.errors) unless service_object.success?
+
         service_object.instance_variable_set(:@response, service_object.call)
         service_object.validate(:response)
 

data/lib/active_call/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveCall
-  VERSION = '0.2.1'
+  VERSION = '0.3.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_call
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
 - Kobus Joubert
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-03-25 00:00:00.000000000 Z
+date: 2025-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel