active_attr 0.11.0 → 0.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f072a053dc7854c420523d4dcea77f3c06181021
-  data.tar.gz: 5ea51b5d4fd81a140484c1d725a12c16ed8adbd8
+  metadata.gz: 02c6c69fe8a87196740e45c3e827e832b09a8eca
+  data.tar.gz: ce44bea22a9b8d2dbc753bc9a81cee7f51b4c6da
 SHA512:
-  metadata.gz: 19f0b7b8289d633be65d8f7f6a519d3769d34b6812f6483de5d485274496dae7b1f27aed5199829d9113b44fd11fbbc3a8030d2e884f28b2ea4d795a0f287455
-  data.tar.gz: 526b81fa479ee21f79d5df4e4bb9fafec8413aef334a75daa3c2ea4baee4dce732eaeecb4d03355c2dadae9b7166e1258a5ae30e4ddcc9b9bb78d3f9954f57f9
+  metadata.gz: 9a13a61893450f32efa41744f7187e0cf4988359db4cf556de5175098fa9e357dd6744319e8fd43b786bcf4c9b156ea92aff74f9d26ccb1100c1821272e8a9b2
+  data.tar.gz: 605675def174c8cd4d83d2b2b7bc9c99a57c625409cc6124f3bf163d234441c96f93cd71d78e542d4eccc52824dec4c3fae94e0d154573c088623af147797ce1

data/.travis.yml

@@ -6,10 +6,10 @@ rvm:
   - 1.9.3
   - 2.0.0
   - 2.1.10
-  - 2.2.9
-  - 2.3.6
-  - 2.4.3
-  - 2.5.0
+  - 2.2.10
+  - 2.3.7
+  - 2.4.4
+  - 2.5.1
 before_install: gem install bundler
 bundler_args: --without development
 gemfile:
@@ -27,7 +27,7 @@ matrix:
   allow_failures:
     - gemfile: gemfiles/rails_head.gemfile
   exclude:
-    - rvm: 2.5.0
+    - rvm: 2.5.1
       gemfile: gemfiles/rails_3_0.gemfile
     - rvm: ree
       gemfile: gemfiles/rails_4_0.gemfile

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+# ActiveAttr 0.12.0 (August 6, 2018) #
+
+* #167 Changed Typecasting::BooleanTypecaster to cast strings starting
+  with a zero character to cast to true (Artin Boghosian)
+* Changed Typecasting::BooleanTypecaster to cast more numeric strings
+  to true
+
 # ActiveAttr 0.11.0 (May 29, 2018) #
 
 * #166 Changed Typecasting::DateTimeTypecaster to not raise on invalid

data/lib/active_attr/typecasting/boolean_typecaster.rb

@@ -34,7 +34,7 @@ module ActiveAttr
       def call(value)
         case value
         when *FALSE_VALUES then false
-        when Numeric, /^\-?[0-9]/ then !value.to_f.zero?
+        when Numeric, /\A[-+]?(0+\.?0*|0*\.?0+)\z/ then !value.to_f.zero?
         else value.present?
         end
       end

data/lib/active_attr/version.rb

@@ -1,5 +1,5 @@
 module ActiveAttr
   # Complete version string
   # @since 0.1.0
-  VERSION = "0.11.0"
+  VERSION = "0.12.0"
 end

data/spec/unit/active_attr/typecasting/boolean_typecaster_spec.rb

@@ -33,6 +33,14 @@ module ActiveAttr
             typecaster.call("abc").should equal true
           end
 
+          it "casts a non-empty String starting with number 0 to true" do
+            typecaster.call("0c2").should equal true
+          end
+
+          it "casts a non-empty String starting with number > 0 to true" do
+            typecaster.call("1c2").should equal true
+          end
+
           {
             "t" => true,
             "f" => false,
@@ -119,6 +127,10 @@ module ActiveAttr
             typecaster.call("0").should equal false
           end
 
+          it "casts '0\\nx' to true" do
+            typecaster.call("0\nx").should equal true
+          end
+
           it "casts '1' to true" do
             typecaster.call("1").should equal true
           end
@@ -127,6 +139,14 @@ module ActiveAttr
             typecaster.call("0.0").should equal false
           end
 
+          it "casts '.0' to false" do
+            typecaster.call(".0").should equal false
+          end
+
+          it "casts '0.' to false" do
+            typecaster.call("0.").should equal false
+          end
+
           it "casts '0.1' to true" do
             typecaster.call("0.1").should equal true
           end
@@ -135,13 +155,25 @@ module ActiveAttr
             typecaster.call("-1").should equal true
           end
 
+          it "casts '+1' to true" do
+            typecaster.call("+1").should equal true
+          end
+
           it "casts '-0.0' to false" do
             typecaster.call("-0.0").should equal false
           end
 
+          it "casts '+0.0' to false" do
+            typecaster.call("+0.0").should equal false
+          end
+
           it "casts '-0.1' to true" do
             typecaster.call("-0.1").should equal true
           end
+
+          it "casts '+0.1' to true" do
+            typecaster.call("+0.1").should equal true
+          end
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_attr
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.12.0
 platform: ruby
 authors:
 - Chris Griego
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-29 00:00:00.000000000 Z
+date: 2018-08-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel