active_admin-subnav 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 956c5b117fae4020911254d663079fdf4c1c2162
-  data.tar.gz: edb905db6ef3a072af7ea9c96ab1a567042f7708
+  metadata.gz: 3dfe4b81008a6996309d174ac3383f0e1bade7ca
+  data.tar.gz: 9dab7380fc0e53e1792cf9325beb09025332a04c
 SHA512:
-  metadata.gz: 9945683265bcf887314715a9412300c5bd960af8b580d541e53de1021b2e115bc57328e898627e7aab68ccac2553a28e75ff0f8c59032a0e2a646b3a5c9c0917
-  data.tar.gz: daec0b8998707d5f59a634bac08f9a99b9816f982e3156e5ef551c968233ad0249409459fccfcc0e29574893a39e516ce6c27df29b7018607fd84b04f25262ac
+  metadata.gz: 76421ef162ecda5c6a54c27cd2fcbca6f593f5553eb78837a133989496881a6a826b4acc0c4fab663bef2b8214450fb40d207bc6d66c6ff704a82d090213320a
+  data.tar.gz: 7c0f7e74460a2936564d22584515b8cf52f70af7787bfe481159b65e3a72803556e6af9a92582f8761ab3e466dc686aada19d74dc72178ee9e770e3b9db7fa4f

data/Changelog.md

@@ -1,6 +1,24 @@
 # Change Log
 
-## 1.0.0
+## [1.1.0] - 2017-05-24
+
+### Added
+
+- Support for ActiveAdmin v1.0.0
+- Example image as a preview
+
+### Fixed
+
+- Overrides `ActiveAdmin::Page#belongs_to` to properly nest menus within the
+  sub navigation
+
+## [1.0.0] - 2016-09-08
+
+### Changed
 
 - Rename subnav.css.scss to subnav.scss to avoid Sprockets deprecation warning
 - No incompatible changes from v0.0.1
+
+
+[1.0.1]: https://github.com/zorab47/active_admin-subnav/compare/v1.1.0...v1.0.0
+[1.0.0]: https://github.com/zorab47/active_admin-subnav/compare/v0.0.1...v1.0.0

data/README.md

@@ -2,14 +2,16 @@
 
 [![Gem Version](https://badge.fury.io/rb/active_admin-subnav.svg)](http://badge.fury.io/rb/active_admin-subnav)
 
-## Description
-
 Enhanced sub-navigation for nested ActiveAdmin resources.
 
-Currently, the base [ActiveAdmin][] install resets the top navigation menu to
-display the nested navigation menu, but it can be confusing to lose the main
-navigation context. This project keeps the main navigation visible and displays
-a secondary navigation bar for nested resources.
+Currently, the base [ActiveAdmin][] resets the top navigation menu to display the
+nested navigation menu, but it can be confusing to lose the main navigation
+context. This project keeps the main navigation visible and displays a secondary
+navigation bar for nested resources.
+
+![ActiveAdmin::Subnav Example](docs/example.png)
+
+Supports both ActiveAdmin v1.0.0+ and older v0.6.4+ versions.
 
 **Note**: Optional belongs_to configurations are not supported!
 

data/lib/active_admin/subnav.rb

@@ -18,13 +18,10 @@ module ActiveAdmin
   end
 end
 
-
 # Register a TabbedNavigation view for the sub navigation.
 ActiveAdmin::ViewFactory.register sub_navigation: ActiveAdmin::Views::TabbedNavigation,
                                   header:         ActiveAdmin::Views::HeaderWithSubnav
 
-ActiveAdmin::Page.send :include, ActiveAdmin::Subnav::Page
-
 ActiveAdmin.after_load do
   ActiveAdmin::BaseController.send :include, ActiveAdmin::Subnav::MenuExtensions
 end

data/lib/active_admin/subnav/extensions/page.rb

@@ -1,11 +1,13 @@
 module ActiveAdmin
-  module Subnav
-    module Page
-      extend ActiveSupport::Concern
+  class Page
+    def belongs_to(target, options = {})
+      @belongs_to = Resource::BelongsTo.new(self, target, options)
+      self.sub_navigation_menu_name = target
+      controller.send :belongs_to, target, options.dup
+    end
 
-      def show_sub_menu?(*)
-        false
-      end
+    def show_sub_menu?(*)
+      false
     end
   end
 end

data/lib/active_admin/subnav/extensions/resource.rb

@@ -1,7 +1,5 @@
 module ActiveAdmin
   class Resource
-
-    # TODO: Support for optional belongs_to
     def belongs_to(target, options = {})
       @belongs_to = Resource::BelongsTo.new(self, target, options)
       self.sub_navigation_menu_name = target

data/lib/active_admin/subnav/version.rb

@@ -1,5 +1,5 @@
 module Activeadmin
   module Subnav
-    VERSION = "1.0.0"
+    VERSION = "1.1.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_admin-subnav
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Charles Maresh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-09 00:00:00.000000000 Z
+date: 2017-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeadmin
@@ -95,22 +95,18 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 description: |
-  Currently, ActiveAdmin 1.0pre resets the top navigation menu to display the sub
-  navigation menu for all resources related to that parent resource. This gem
-  provides a sub navigation menu for those resources.
+  Currently, ActiveAdmin resets the top navigation menu to display the sub
+  navigation menu for all resources related to the parent resource. This gem
+  adds a sub-navigation menu for those resources.
 email:
 - charles.maresh@orm-tech.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
 - Changelog.md
-- Gemfile
 - LICENSE.txt
 - README.md
-- Rakefile
-- active_admin-subnav.gemspec
 - app/assets/stylesheets/active_admin/subnav.scss
 - lib/active_admin/subnav.rb
 - lib/active_admin/subnav/extensions/base_controller.rb
@@ -121,7 +117,6 @@ files:
 - lib/active_admin/subnav/extensions/tabbed_navigation.rb
 - lib/active_admin/subnav/version.rb
 - lib/active_admin/subnav/views/header_with_subnav.rb
-- spec/subnav_spec.rb
 homepage: https://github.com/zorab47/active_admin-subnav
 licenses:
 - MIT
@@ -142,9 +137,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Provide sub-navigation menu for resources belonging to a parent resource.
-test_files:
-- spec/subnav_spec.rb
+test_files: []

data/.gitignore

@@ -1,22 +0,0 @@
-*.gem
-*.rbc
-.bundle
-.config
-.yardoc
-Gemfile.lock
-InstalledFiles
-_yardoc
-coverage
-doc/
-lib/bundler/man
-pkg
-rdoc
-spec/reports
-test/tmp
-test/version_tmp
-tmp
-*.bundle
-*.so
-*.o
-*.a
-mkmf.log

data/Gemfile

@@ -1,4 +0,0 @@
-source 'https://rubygems.org'
-
-# Specify your gem's dependencies in activeadmin-subnav.gemspec
-gemspec

data/Rakefile

@@ -1,2 +0,0 @@
-require "bundler/gem_tasks"
-

data/active_admin-subnav.gemspec

@@ -1,32 +0,0 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'active_admin/subnav/version'
-
-Gem::Specification.new do |spec|
-  spec.name          = "active_admin-subnav"
-  spec.version       = Activeadmin::Subnav::VERSION
-  spec.authors       = ["Charles Maresh"]
-  spec.email         = ["charles.maresh@orm-tech.com"]
-  spec.summary       = %q{Provide sub-navigation menu for resources belonging to a parent resource.}
-  spec.description   = <<DESC
-Currently, ActiveAdmin 1.0pre resets the top navigation menu to display the sub
-navigation menu for all resources related to that parent resource. This gem
-provides a sub navigation menu for those resources.
-DESC
-  spec.homepage      = "https://github.com/zorab47/active_admin-subnav"
-  spec.license       = "MIT"
-
-  spec.files         = `git ls-files -z`.split("\x0")
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
-
-  spec.add_dependency "activeadmin"
-
-  spec.add_development_dependency "bundler", "~> 1.6"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "minitest"
-  spec.add_development_dependency "minitest-spec-expect"
-  spec.add_development_dependency "sass-rails"
-end

data/spec/subnav_spec.rb

@@ -1,67 +0,0 @@
-require 'bundler/setup'
-require 'minitest/autorun'
-require 'minitest/spec/expect'
-
-require 'active_admin/subnav'
-require 'sass-rails'
-
-class Minitest::SharedExamples < Module
-  include Minitest::Spec::DSL
-end
-
-ResourceMenuSpec = Minitest::SharedExamples.new do
-  it "to have sub navigation menu name accessor" do
-    expect(resource).to_respond_to :sub_navigation_menu_name
-    expect(resource).to_respond_to :sub_navigation_menu_name=
-  end
-
-  it "is a sub menu item when sub_navigation_menu_name is set" do
-    expect(resource.sub_menu_item?).to_equal false
-    resource.sub_navigation_menu_name = "Dashboard"
-    expect(resource.sub_menu_item?).to_equal true
-  end
-end
-
-describe "activeadmin-subnav" do
-  it "registers a sub navigation view" do
-    expect(ActiveAdmin::ViewFactory.new.default_for(:sub_navigation)).to_equal ActiveAdmin::Views::TabbedNavigation
-  end
-
-  it "registers a header with subn navigation" do
-    expect(ActiveAdmin::ViewFactory.new.default_for(:header)).to_equal ActiveAdmin::Views::HeaderWithSubnav
-  end
-
-  def namespace
-    app = ActiveAdmin::Application.new
-    app.namespace(:admin)
-  end
-
-  describe "extends ActiveAdmin::Namespace" do
-    it "adds sub menus" do
-      expect(namespace).to_respond_to :sub_menus
-    end
-  end
-
-  describe "extends Page" do
-    let(:page) { ActiveAdmin::Page.new(namespace, "Dashboard", {}) }
-    alias_method :resource, :page
-
-    include ResourceMenuSpec
-
-    it "to never show sub menus" do
-      expect(page.show_sub_menu?).to_equal false
-    end
-  end
-
-  describe "extends Resource" do
-    class Post; end
-    let(:resource) { ActiveAdmin::Resource.new(namespace, Post) }
-
-    include ResourceMenuSpec
-
-    it "to assign nested resources" do
-      resource.nested_resources = "nested"
-      expect(resource.has_nested_resources?).to_equal "nested"
-    end
-  end
-end