active-triples 0.8.0 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 134e560560581d9eb910f02fb4acfe1796a49e8c
-  data.tar.gz: 06111e25af63727d289515c461f5d648bdfbf9ff
+  metadata.gz: 4928b254048d00cd2f52d050aea13407ba362425
+  data.tar.gz: 11c44cb9efe80bfc6dd09f6e33a6aee0d288666d
 SHA512:
-  metadata.gz: 12bcd4d12842619f883cc042052f53e1a89bca2b6bf78f926318ebe7a6072ee3d9116ebfc56c52deceb7401694a2d3fdaaadbea7753f5348aa5e5c44e8e469c5
-  data.tar.gz: 61a6ee297b43bd909bf89f5a91ea815fdcef3dced6a8863a4f2af7b7f989ad77bc187e5140a4ea6001876d943ea8a011a126febdfa1ae97fe499746ba94c2fc1
+  metadata.gz: 665fe27ad696dda89568310375194243760cfa22d8761bc10fc40eca9dcd39a81352c840e283e3501c4eb2504bdb1d663efa96138478660f5f9ab3454d3e874f
+  data.tar.gz: ec21704f5faf6aadf57ec45c95bfb64113ef772f3fd48c8e7e26f4ddfa9dd08dfe786cd2039743c7b742d9cf24b600141f5e7dcfd1e1579f2d57fc181e625d8b

data/CHANGES.md

@@ -1,3 +1,9 @@
+0.8.1
+-----
+
+  - Reverts changing `Relation`'s delete methods to remove all values until we
+  have a clear path forward for those depending on that functionality.
+
 0.8.0
 -----
   - Adds RDF.rb interfaces to `RDFSource`, improving interoperability 

data/lib/active_triples/relation.rb

@@ -55,13 +55,11 @@ module ActiveTriples
       parent.persist! if parent.persistence_strategy.is_a? ParentStrategy
     end
 
-    ##
-    # Deletes the values for this relation. This removes all triples matching
-    # the basic graph pattern [:rdf_subject :predicate ?object] from the parent
-    # Enumerable.
     def empty_property
       parent.query([rdf_subject, predicate, nil]).each_statement do |statement|
-        parent.delete(statement)
+        if !uri_class(statement.object) || uri_class(statement.object) == class_for_property
+          parent.delete(statement)
+        end
       end
     end
 

data/lib/active_triples/version.rb

@@ -1,3 +1,3 @@
 module ActiveTriples
-  VERSION = "0.8.0".freeze
+  VERSION = "0.8.1".freeze
 end

data/spec/active_triples/rdf_source_spec.rb

@@ -146,44 +146,6 @@ describe ActiveTriples::RDFSource do
     it 'sets a value'
   end
 
-  describe "inheritance" do
-    before do
-      class PrincipalResource
-        include ActiveTriples::RDFSource
-
-        configure type: RDF::FOAF.Agent
-        property :name, predicate: RDF::FOAF.name
-      end
-
-      class UserSource < PrincipalResource
-        configure type: RDF::FOAF.Person
-      end
-
-      class DummySource
-        include ActiveTriples::RDFSource
-
-        property :creator, predicate: RDF::DC.creator
-      end
-    end
-
-    after do
-      Object.send(:remove_const, :PrincipalResource)
-      Object.send(:remove_const, :UserSource)
-      Object.send(:remove_const, :DummySource)
-    end
-
-    let(:dummy) { DummySource.new }
-    let(:bob) { UserSource.new.tap {|u| u.name = "bob"} }
-    let(:sally) { UserSource.new.tap {|u| u.name = "sally"} }
-
-    it "should replace values" do
-      dummy.creator = bob
-      expect(dummy.creator).to eq [bob]
-      dummy.creator = sally
-      expect(dummy.creator).to eq [sally]
-    end
-  end
-
   describe 'validation' do
     it { is_expected.to be_valid }
 

data/spec/active_triples/relation_spec.rb

@@ -3,10 +3,6 @@ require 'rdf/isomorphic'
 
 describe ActiveTriples::Relation do
 
-  subject do
-    described_class.new(double("parent", reflections: []), double("value args"))
-  end
-
   describe "#rdf_subject" do
     let(:parent_resource) { double("parent resource", reflections: {}) }
 
@@ -45,51 +41,39 @@ describe ActiveTriples::Relation do
   end
 
   describe "#valid_datatype?" do
-    before do
-      allow(subject.parent).to receive(:rdf_subject) { "parent subject" } 
-    end
-
+    subject { described_class.new(double("parent", reflections: []), "value" ) }
+    before { allow(subject.parent).to receive(:rdf_subject) { "parent subject" } }
     context "the value is not a Resource" do
       it "should be true if value is a String" do
         expect(subject.send(:valid_datatype?, "foo")).to be true
       end
-
       it "should be true if value is a Symbol" do
         expect(subject.send(:valid_datatype?, :foo)).to be true
       end
-
       it "should be true if the value is a Numeric" do
         expect(subject.send(:valid_datatype?, 1)).to be true
         expect(subject.send(:valid_datatype?, 0.1)).to be true
       end
-
       it "should be true if the value is a Date" do
         expect(subject.send(:valid_datatype?, Date.today)).to be true
       end
-
       it "should be true if the value is a Time" do
         expect(subject.send(:valid_datatype?, Time.now)).to be true
       end
-
       it "should be true if the value is a boolean" do
         expect(subject.send(:valid_datatype?, false)).to be true
         expect(subject.send(:valid_datatype?, true)).to be true
       end
     end
-
     context "the value is a Resource" do
       after { Object.send(:remove_const, :DummyResource) }
-
       let(:resource) { DummyResource.new }
-
       context "and the resource class does not include RDF::Isomorphic" do
         before { class DummyResource; include ActiveTriples::RDFSource; end }
-
         it "should be false" do
           expect(subject.send(:valid_datatype?, resource)).to be false
         end
       end
-
       context "and the resource class includes RDF:Isomorphic" do
         before do
           class DummyResource
@@ -97,12 +81,10 @@ describe ActiveTriples::Relation do
             include RDF::Isomorphic
           end
         end
-
         it "should be false" do
           expect(subject.send(:valid_datatype?, resource)).to be false
         end
       end
-
       context "and the resource class includes RDF::Isomorphic and aliases :== to :isomorphic_with?" do
         before do
           class DummyResource
@@ -111,7 +93,6 @@ describe ActiveTriples::Relation do
             alias_method :==, :isomorphic_with?
           end
         end
-
         it "should be false" do
           expect(subject.send(:valid_datatype?, resource)).to be false
         end
@@ -119,32 +100,4 @@ describe ActiveTriples::Relation do
     end
   end
 
-  describe '#empty_property' do
-
-    before { resource << RDF::Statement(resource, property, 'value') }
-
-    subject { described_class.new(resource, value_args) }
-    let(:resource) { ActiveTriples::Resource.new }
-    let(:property) { RDF::URI.new('http://example.com/moomin') }
-
-    let(:value_args) do
-      double('value args', 
-             length: 1,
-             first: 'first',
-             last: property)
-    end
-
-    it 'deletes values from property' do
-      expect { subject.empty_property }.to change { subject.result }
-                                            .from(['value']).to([])
-    end
-
-    it 'deletes multiple values from property' do
-      values = [Date.today, 'value2', RDF::Node.new, true]
-      resource.set_value(property, values)
-
-      expect { subject.empty_property }.to change { subject.result }
-                                            .from(values).to([])
-    end
-  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active-triples
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.1
 platform: ruby
 authors:
 - Tom Johnson
@@ -281,7 +281,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.1
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: RDF graphs in ActiveModel wrappers.